fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-03-06 05:23:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,155 Commits 1 Branch 0 Tags
4e892129407cc2db636e30116c2f80af792fc050
Commit Graph

3155 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Philipp Wolfer
4e89212940 Support .ogv video files 2014-06-13 19:17:51 +02:00
Philipp Wolfer
0793d71e67 Support ASF video file formats (reverted from commit 7494155d0c) 2014-06-13 19:16:40 +02:00
Wieland Hoffmann
094094b1dd Add coverartproviders to the package list 2014-06-01 10:40:25 +02:00
Laurent Monin
ad2669331c Merge pull request #332 from zas/cover_art_pdf 
Improve handling of PDF cover art from CAA
 2014-05-29 10:10:01 +02:00
Laurent Monin
853e7e9bb5 images_to_be_saved_to_tags(): use can_be_saved_to_tags property 2014-05-29 09:30:18 +02:00
Laurent Monin
f544a4f44f Eventually raise CoverArtImageIOError when getting CoverArtImage.data 2014-05-29 09:13:26 +02:00
Laurent Monin
9ab5d72594 Introduce CaaThumbnailCoverArtImage and properties to handle thumbnails 
- can_be_saved_to_tags
PDFs cannot be saved to tags as today

- can_be_saved_to_disk
thumbnails shouldn't saved to disk (in audio files directory), they are only used for display

- can_be_saved_to_metadata
thumbnails aren't saved to audio files metadata
 2014-05-29 09:02:26 +02:00
Laurent Monin
54cc1e4c8d CaaCoverArtImage: describe thumbnail and is_thumbnail 2014-05-28 20:39:05 +02:00
Laurent Monin
442b41ed4a Merge pull request #336 from zas/cover_art_providers 
Split cover art providers to their own classes and files
 2014-05-28 17:30:13 +02:00
Laurent Monin
30eac04cbf Display thumbnail image for PDFs in info dialog 
It requires few changes in CaaCoverArtImage, basically one property (is_thumbnail) to indicate
the image is a thumbnail so it isn't added to metadata.
And a thumbnail property to link main image to its thumbnail.
 2014-05-28 17:29:41 +02:00
Laurent Monin
c7f224fe8f Move _queue_from_caa() code to _caa_json_downloaded(), simplify 2014-05-28 17:06:18 +02:00
Laurent Monin
0e6572fad3 CaaCoverArtImage: specify constructor, accept is_front 2014-05-28 16:57:19 +02:00
Laurent Monin
fdab5efa78 Download pdf cover art only if needed, download main file, not thumbnails. 
This patch solves 2 issues:
- pdf files only need to be saved if "save_images_to_files" option is set, PDFs are never embedded in tags
- ignore "caa_image_size" option which causes thumbnail of the pdf to be downloaded instead of the main file
 2014-05-28 16:57:14 +02:00
Laurent Monin
91b8a5ad20 Improve handling of PDF cover art from CAA 
- detect PDFs in imageinfo
- exclude PDFs from images to be written to tags
- display info about PDF in info dialog (need more work)
 2014-05-28 16:53:04 +02:00
Laurent Monin
0988a7db37 Describe CoverArtProvider class 2014-05-28 16:12:02 +02:00
Laurent Monin
c84173190f Fix up CoverArtProvider.match_url_relations description 2014-05-28 15:35:13 +02:00
Laurent Monin
8c651af501 Clarify queue_downloads() return values 2014-05-28 15:33:31 +02:00
Laurent Monin
e50bc12a88 Remove unneeded wrapper methods 2014-05-28 15:28:06 +02:00
Laurent Monin
778c9a0aff Drop now unused caa_front_found 2014-05-28 15:19:23 +02:00
Laurent Monin
5db4d18851 Raise NotImplementedError 2014-05-28 15:17:16 +02:00
Laurent Monin
419fa117d2 Merge pull request #337 from Sophist-UK/sophist_include_select_for_py2app 
Include select module in mac build.
 2014-05-28 15:15:25 +02:00
Sophist
dead1fd34e Include select module in mac build. 
See [Picard-607](http://tickets.musicbrainz.org/browse/PICARD-607) for
requirement.
 2014-05-28 10:29:42 +01:00
Laurent Monin
b4b1619187 Introduce CoverArtProvider.match_url_relations() to reduce code redundancy 2014-05-27 16:36:30 +02:00
Laurent Monin
14b8bd85e7 Split cover art providers to their own classes and files 
- add extension point so one can write a cover art provider plugin
- minor changes to ease the move
 2014-05-27 13:57:35 +02:00
Laurent Monin
e69499e80e Merge pull request #335 from Sophist-UK/sophist_include_socket_for_py2app 
Include socket module in py2app
 2014-05-27 12:54:47 +02:00
Sophist
37bc2596ed Include socket module in py2app 
See [Picard-607](http://tickets.musicbrainz.org/browse/PICARD-607) for
requirement.
 2014-05-27 08:38:44 +01:00
Laurent Monin
8814b9ff95 Merge pull request #333 from zas/fix_front_image_only 
Fix regression, save only ONE front image when "save_only_front_images_t...
 2014-05-26 17:07:57 +02:00
Laurent Monin
7a06b67261 Only download one front image if no more is needed according to options 2014-05-26 15:58:48 +02:00
Laurent Monin
9a6ca46341 Fix regression, save only ONE front image when "save_only_front_images_to_tags" is set 
This regression was introduced during code rewrite, option name is misleading.

See https://github.com/musicbrainz/picard/pull/116
See PICARD-350 (which wasn't closed)
 2014-05-26 15:17:27 +02:00
Laurent Monin
25b5d7b9b7 Update translations 2014-05-24 18:42:53 +02:00
Laurent Monin
4d4b762514 Merge pull request #329 from zas/cover_image_simplify 
Merge Image() and CoverArtImage()
 2014-05-24 16:30:27 +02:00
Laurent Monin
2d1a1005d9 Code cleanup, ease debugging 2014-05-22 18:03:40 +02:00
Laurent Monin
016cb3e009 Simplify image data/hash code 2014-05-21 17:36:05 +02:00
Laurent Monin
2c52ecf13e store_data_for_hash(): always return filename + add debug 2014-05-21 16:22:49 +02:00
Laurent Monin
f3cfd55fb4 Drop index/enumerate(), unused now 2014-05-21 16:04:35 +02:00
Laurent Monin
fb4088addd Move test for save_images_to_tags option to metadata.images_to_be_saved_to_tags 2014-05-21 16:04:35 +02:00
Laurent Monin
c0de7d95c9 PEP8 fixes 2014-05-21 16:04:35 +02:00
Laurent Monin
7e1902fdec Output more infos about downloaded image in debug mode 2014-05-21 16:04:35 +02:00
Laurent Monin
2e7caa5a2c Fix up set_data() 2014-05-21 16:04:34 +02:00
Laurent Monin
a07825fd85 Improve debugging messages 2014-05-21 16:04:34 +02:00
Laurent Monin
9e2a91d203 Re-add dummy load to ensure test images are > 64kb 
As said in comment, size was increased to catch a bug in mutagen, so better
to keep it.
 2014-05-21 16:04:34 +02:00
Laurent Monin
c7ce593941 Introduce exceptions CoverArtImageIOError and CoverArtImageIdentificationError 
- hide imageinfo exceptions
- hide io/filesystem exceptions
- those may change in future, callers don't need to know details
 2014-05-21 16:04:34 +02:00
Laurent Monin
9e764cb73e Indentation fixes. 2014-05-20 15:01:39 +02:00
Laurent Monin
aaf1cc5469 Merge pull request #330 from Sophist-UK/sophist_fix_PICARD_607 
Add ntpath to include list for py2app ...
 2014-05-19 19:54:54 +02:00
Sophist
7e96801c93 Add ntpath to include list for py2app 
in the hope (since I don;t have a Mac and cannot test this) that this
fixes the error reported in
(PICARD-607)[http://tickets.musicbrainz.org/browse/PICARD-607].
 2014-05-19 18:50:22 +01:00
Laurent Monin
03ff7f9501 Cleanup debug messages 2014-05-19 17:09:15 +02:00
Laurent Monin
1ed5af2bc7 Reduce code redundancy, introduce _next_filename() and _is_write_needed() 2014-05-19 17:03:19 +02:00
Laurent Monin
f13574bb98 Remove unused CoverArtImage.filename and associated code 2014-05-19 16:28:32 +02:00
Laurent Monin
83e45ec77d Minor change in test. 2014-05-16 23:06:42 +02:00
Laurent Monin
c14e8339c2 Add few comments 2014-05-16 23:01:11 +02:00