Sophist
5cc8fea2c4
Add explanatory comment and disregard hidden status to address review comments
2017-10-23 15:32:21 +01:00
Sophist
09195d5a91
PICARD-1143: Prevent loading .smbdelete* files
...
.smbdelete files are temporary versions of files that should have been
deleted but cannot be due to samba bug(?). We should not load these
files even if we have ignore-hidden-files unchecked.
2017-10-04 22:42:17 +01:00
Sambhav Kothari
1b5d849b69
Merge pull request #782 from vishichoudhary/picard-1138-attribute-error
...
PICARD-1138: Fix attribute error due to wrong value in string
2017-09-21 01:23:15 +05:30
vishichoudhary
ccdb1cd6b8
Fix attribute error due to wrong value in string
2017-09-20 22:20:56 +05:30
Laurent Monin
d0f54bb0c8
Merge pull request #781 from samj1912/v2manifest
...
Add v2 plugin manifest compatibility
2017-08-19 19:11:36 +02:00
Sambhav Kothari
9260201071
Add v2 plugin manifest compatibility
2017-08-17 14:42:14 +05:30
Laurent Monin
ece0e5f98b
Merge pull request #780 from samj1912/picard1126
...
PICARD-1126: Add meaningful error log during lookup requests
2017-08-10 00:03:52 +02:00
Sambhav Kothari
f24263c189
PICARD-1126: Add meaningful error log during lookup requests
2017-08-10 01:55:57 +05:30
Laurent Monin
3a86873998
Merge pull request #777 from samj1912/variable
...
Fix undefined variable
2017-07-30 10:01:02 +02:00
Sambhav Kothari
69d3180804
Merge pull request #778 from samj1912/fix-ratings
...
PICARD-1114: Fix ratings submission
2017-07-29 00:52:55 +05:30
Sambhav Kothari
738a1dd5f6
Fix track id while loading
2017-07-29 00:15:37 +05:30
Sambhav Kothari
156ba39ec1
Add response parser arg to API Helper and fix submit rating parser
2017-07-29 00:15:26 +05:30
Sambhav Kothari
b7b25f5725
Fix undefined variable
2017-07-27 18:25:10 +05:30
Laurent Monin
a9665f632d
Merge pull request #776 from samj1912/null
...
Fix null type errors while parsing API response
2017-07-26 14:04:08 +02:00
Sambhav Kothari
e3992302e5
Fix logical errors in code
2017-07-26 16:30:40 +05:30
Sambhav Kothari
b0d412169c
Add null type tests
2017-07-26 16:12:12 +05:30
Sambhav Kothari
844eca9eaa
Fix null type errors and add test data for null types
2017-07-26 16:09:34 +05:30
Sambhav Kothari
3ea07cb91a
Fix more null type errors
2017-07-26 16:09:34 +05:30
Sambhav Kothari
9d5c6b05ab
Fix null type errors
2017-07-26 16:09:34 +05:30
Laurent Monin
bdf2579966
Merge pull request #774 from samj1912/moretests
...
Add OSX tests
2017-07-25 23:05:10 +02:00
Sambhav Kothari
5b2e7c59d2
Allow fast finishing to not wait up on OSX builds
2017-07-26 00:03:52 +05:30
Sambhav Kothari
589f5e8e96
Add OSX tests
2017-07-26 00:03:52 +05:30
Laurent Monin
85cdb6f72f
Merge pull request #775 from metabrainz/samj1912-patch-1
...
Use flat style badges
2017-07-25 20:30:09 +02:00
Sambhav Kothari
9efa91a6bf
Use flat style badges
2017-07-25 23:16:01 +05:30
Laurent Monin
37bc535be5
Use shields.io for badges
2017-07-25 16:29:07 +02:00
Laurent Monin
9c701da4a7
Add AppVeyor Badge
2017-07-25 16:03:24 +02:00
Sambhav Kothari
3671664adb
Merge pull request #773 from zas/fix_catnums_null
...
Fix null catalog-number and/or label cases, add tests
2017-07-25 19:25:09 +05:30
Laurent Monin
4f328dba79
LabelInfoTest: reduce code redundancy
2017-07-25 15:48:47 +02:00
Laurent Monin
5aa025619e
Fix null catalog-number and/or label cases, add matching tests
2017-07-25 15:41:03 +02:00
Laurent Monin
57e1617b60
Merge pull request #772 from samj1912/moretests
...
Add windows testing
2017-07-24 21:17:15 +02:00
Sambhav Kothari
d7223f81a7
Add appveyor config for windows tests
2017-07-25 00:12:39 +05:30
Sambhav Kothari
98ae6f777d
Fix windows tests
2017-07-24 23:51:00 +05:30
Laurent Monin
eac91cab92
Merge pull request #771 from samj1912/moretests
...
Fix error while fetching collections in a release group
2017-07-24 18:03:44 +02:00
Sambhav Kothari
14eba29184
Fix error while fetching collections in a release group
...
JSON API returns format as a None object and it is always present,
as opposed to the logic while handling XML.
This logic therefor requires changes.
2017-07-24 20:56:17 +05:30
Laurent Monin
099f79bb71
Merge pull request #770 from samj1912/moretests
...
Add API helper tests
2017-07-23 14:04:42 +02:00
Laurent Monin
1d22eb2df6
Merge pull request #769 from samj1912/wsfix
...
Update code style to match contribution guide
2017-07-23 14:01:43 +02:00
Sambhav Kothari
0f7c066211
Add API helper tests
2017-07-23 17:17:21 +05:30
Sambhav Kothari
24655448bb
Update code style to match contribution guide
2017-07-23 15:15:51 +05:30
Laurent Monin
8a35bf3733
Merge pull request #768 from samj1912/picard1119
...
PICARD-1119: Fix wrong metadata parsing
2017-07-21 22:45:34 +02:00
Sambhav Kothari
506d59e5c6
PICARD-1119: Fix wrong metadata parsing
...
Fixes https://tickets.metabrainz.org/browse/PICARD-1119
2017-07-22 01:46:53 +05:30
Laurent Monin
e36c711357
Merge pull request #767 from metabrainz/samj1912-patch-1
...
Bump picard version for a new pip release
2017-07-21 21:41:52 +02:00
Sambhav Kothari
89f8f16f12
Bump picard version for a new pip release
2017-07-21 19:43:36 +05:30
Laurent Monin
c4946d907d
Merge pull request #766 from samj1912/ws++
...
PICARD-807: Add advanced rate limiting to WS
2017-07-21 15:30:37 +02:00
Sambhav Kothari
f48c78aab7
Add advanced rate limiting to WS
...
Based on code by @rbeasley and PR #473
2017-07-21 18:46:54 +05:30
Laurent Monin
bef4ad0425
Merge pull request #765 from samj1912/ws+
...
Add WSRequest class to simplify WS code and add retries on temp failures
2017-07-21 15:13:22 +02:00
Sambhav Kothari
09c8b9ad7c
Add comment explaining the qt error code
2017-07-21 18:37:31 +05:30
Sambhav Kothari
49fb9bcd00
Switch to a better method to detect 503s
2017-07-21 15:53:20 +05:30
Sambhav Kothari
f2ad0ba5ef
Fix spelling mistake
2017-07-20 22:16:08 +05:30
Sambhav Kothari
83e423f0a2
Fix tests with new POST refactoring
2017-07-20 21:34:31 +05:30
Sambhav Kothari
d239b865af
Refactor WSRequest into method specific classes and change user string header setter
2017-07-20 21:34:07 +05:30