Michael Wiencek
5d0ea9ce99
Merge pull request #156 from zas/pep8_plugins
...
Improve conformance to PEP8, tidy up.
2013-09-02 15:40:34 -07:00
Laurent Monin
8194168f5d
Unify comment style
2013-08-18 20:05:08 +02:00
Laurent Monin
c272099bd9
Improve conformance to PEP8, tidy up.
2013-08-15 15:01:41 +02:00
Wieland Hoffmann
de8c27134f
Adjust the replaygain plugin to the changes in threading
2013-08-14 18:22:51 +02:00
Michael Wiencek
e772e9093e
Merge pull request #151 from zas/tracknum
...
Use a smarter method to extract track number from filename.
2013-08-12 19:55:24 -07:00
Laurent Monin
54ef078dc0
Move constant regexps outside the tracknum_from_filename() function
2013-08-12 16:52:03 +02:00
Michael Wiencek
cf91b1a285
Merge pull request #154 from zas/browser_options
...
Browser options
2013-08-08 13:13:07 -07:00
Laurent Monin
00c09b389f
Remove now unused FileLookup._encode().
2013-08-06 19:09:57 +02:00
Laurent Monin
ff0bd54153
Add a real life test for track number case extraction
2013-08-06 14:48:49 +02:00
Laurent Monin
a6c8b1b1cd
Move Browser Integration options to Advanced > Network option page
2013-08-05 22:02:18 +02:00
Laurent Monin
7ec5bb25de
Rename "Web Proxy" option page to "Network"
...
Settings for web proxy are still there, but we'll add browser integration
options to this option page too.
2013-08-05 21:51:42 +02:00
Laurent Monin
c165fd862f
Add options to control browser integration (enabled/disabled and listening port)
2013-08-05 15:41:25 +02:00
Laurent Monin
77cdedbd9f
Use an url builder to simplify code.
...
_url() will ensure correct query building, encoding, query parameters are passed
as a dictionary
2013-08-05 12:05:10 +02:00
Laurent Monin
2ec0631217
Use a smarter method to extract track number from filename.
...
When file has no metadata field indicating the track number, Picard
is trying to guess it from filename, but the simple regex wasn't very efficient.
tracknum_from_filename() does a much better job.
A test case was added.
2013-08-05 00:40:11 +02:00
Michael Wiencek
fcc0be4ea9
Merge pull request #149 from zas/PEP8_shoot_again
...
PEP8 conformance fixes.
2013-08-04 15:11:21 -07:00
Michael Wiencek
12850d038b
Merge pull request #152 from zas/replace_words
...
Remove unused dict since ac9989fd
2013-08-04 10:10:05 -07:00
Laurent Monin
03254d1f12
Remove unused dict since ac9989fd
2013-08-04 14:00:36 +02:00
Laurent Monin
3cd397b9fa
PEP8 conformance fixes.
2013-08-04 10:19:05 +02:00
Michael Wiencek
9940bcef88
Merge pull request #150 from sebastinas/except-shadows-builtin
...
Correctly catch IOError
2013-08-03 11:50:48 -07:00
Sebastian Ramacher
305b694225
Correctly catch IOError
...
except OSError, IOError does not catch IOError but will overwrite IOError with
catched exception. See [1] for detauls.
[1] http://docs.python.org/2/whatsnew/2.6.html#pep-3110-exception-handling-changes
Signed-off-by: Sebastian Ramacher <sramacher@debian.org >
2013-08-03 20:47:00 +02:00
Michael Wiencek
a61887392c
Merge pull request #147 from zas/statushistory
...
Store and display status messages in a window similar to the Log window
2013-08-01 11:27:37 -07:00
Laurent Monin
6a3fd98530
formatted_log_line(): drop useless append parameter
2013-07-28 01:18:08 +02:00
Wieland Hoffmann
84354dcc68
Remove a superfluous import of picard.util.queue
...
It has been removed, so this import made picard unstartable on clean
checkout (old ones most likely has a .pyc file of the queue module lying
around).
2013-07-27 10:14:54 +02:00
Laurent Monin
5281349e24
Do not display level prefix for history (always LOG_INFO)
2013-07-24 22:17:47 +02:00
Laurent Monin
a5f533e0cb
Use formatted_log_line() in _stderr_receiver()
2013-07-24 22:04:26 +02:00
Laurent Monin
c395ca4978
Use log.formatted_log_line() in LogViewCommon
2013-07-24 22:04:08 +02:00
Laurent Monin
44952bb3f9
Add a function to format a log line in human-readable form
2013-07-24 22:02:49 +02:00
Laurent Monin
9f2abe1c02
Add a window for status history display.
...
Launch from Help menu for now
2013-07-24 22:02:49 +02:00
Laurent Monin
d381e810a0
Add a logger for status history
2013-07-24 22:02:49 +02:00
Laurent Monin
8fa19acf97
show_log(): minor tidy up
2013-07-24 21:43:38 +02:00
Laurent Monin
885006a73d
Move log and logview code to classes, to ease re-use.
2013-07-24 21:43:38 +02:00
Laurent Monin
678d472d6f
_message(): do not convert unicode strings
...
Receivers have to take care of conversion instead, if needed.
2013-07-24 21:39:31 +02:00
Laurent Monin
06ac040bf9
_stderr_receiver(): improve reporting of UnicodeDecodeError
2013-07-24 21:39:31 +02:00
Michael Wiencek
ca12a56825
Merge pull request #146 from mwiencek/new-threadpool
...
Use QThreadPool for threading
2013-07-24 10:51:50 -07:00
Michael Wiencek
14c2db23f7
Merge branch 'master' into new-threadpool
...
Conflicts:
picard/ui/mainwindow.py
2013-07-23 13:24:44 -05:00
Michael Wiencek
135648d862
Use separate thread pool for file saving
...
With a thread count of 1, to avoid race conditions in File._save_and_rename.
2013-07-23 13:23:05 -05:00
Michael Wiencek
cc5c51a170
Merge pull request #148 from ianmcorvidae/patch-1
...
Add '/' to _escape_lucune_query in webservice.py
2013-07-16 20:09:12 -07:00
Ian McEwen
3e266c1eb1
Add '/' to _escape_lucune_query in webservice.py
...
Due to Lucene 4 updates, this is necessary.
2013-07-15 07:18:50 -07:00
Wieland Hoffmann
fc7239de2c
_save_images: continue after deciding a file doesn't need to be saved
...
The previous code was `return`ing from the function, so images after the
first already existing one were not even considered for saving.
2013-07-09 14:21:44 +02:00
Wieland Hoffmann
0c15a5d284
Regenerate picard.pot
2013-07-08 19:10:26 +02:00
Wieland Hoffmann
9dc6f16422
Don't throw an AttributeError if no discid module is available
...
The cd lookup button was enabled even if no discid module was available,
don't do that.
Additionally, display information about the missing discid module in the
About window.
This fixes PICARD-510
2013-07-08 19:05:37 +02:00
Michael Wiencek
e40e1f393b
Use QThreadPool for threading
2013-07-04 20:45:06 -05:00
Michael Wiencek
72dce65f09
Merge pull request #143 from zas/logview
...
Improve logging code and display
2013-07-04 12:21:07 -07:00
Laurent Monin
f10892ca72
Drop currentThreadId in stderr output
2013-07-04 21:00:23 +02:00
Laurent Monin
2fd2487373
_stderr_receiver(): include ':' in format string instead of each dict entry
2013-07-04 21:00:23 +02:00
Laurent Monin
bc0f7d74ab
Let the receiver convert time to string.
2013-07-04 21:00:23 +02:00
Laurent Monin
c31ffe12f1
logview: code cleanup
2013-07-04 21:00:23 +02:00
Laurent Monin
6e9078e188
logview: enable minimize/maximize for log dialog windows
2013-07-04 21:00:23 +02:00
Laurent Monin
f380be442e
_entries -> entries as it is used outside log module
2013-07-04 21:00:18 +02:00
Laurent Monin
be7965dd6f
log: use bitwise operators for log levels matching
2013-07-04 20:59:07 +02:00