fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-03-02 03:23:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,674 Commits 1 Branch 0 Tags
65a4d3bcbb80de4e118db76a11185860fbef7dfa
Commit Graph

3674 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rahul Raturi
65a4d3bcbb Load selection on double click 2016-08-01 19:38:13 +05:30
Rahul Raturi
05e5d8cfd8 Load album from dialog 
Other than that:
* self.selected_object isn't required. Selected track can be
looked up in self.search_results using index from selected row.
* `tracks` should be an empty list rather than None. To avoid type
mismatch/unable to iterate.
 2016-08-01 19:38:13 +05:30
Rahul Raturi
1a23f07b72 Incorrect logic for counting row 2016-08-01 19:38:13 +05:30
Rahul Raturi
ab9df85f54 obj can only be a File object. Obsolete comment. 2016-08-01 19:38:13 +05:30
Rahul Raturi
9926aef23c Parse track search results 
* Separate method to parse search results, to reduce complexity
a bit.
* Two more columns, Date and Country added in results table, to
contrast difference between two tracks.
* Secondary type included in Type column.
 2016-08-01 19:38:13 +05:30
Rahul Raturi
9d1793de5b Use existing metadata to perform search 
The `Track` object would have new metadata. The lookup results
would be different then. Rather use `orig_metadata` of linked
file.
 2016-08-01 19:38:13 +05:30
Rahul Raturi
3ce4bc0c3c Sort search results 
* Search results are sorted using similarity factor returned by
`compare_to_track` method in `Metadata` class.
* Only use track from tuple returned by `compare_to_track`. Reason
being `compare_to_track` selects only best matched release from
the release_list associated with a track. For showing more results
each of those release are needed. These are extracted from the
`tracks` later.
 2016-08-01 19:38:13 +05:30
Rahul Raturi
7b4c71d212 Make cells non editable in tracks table 2016-08-01 19:38:13 +05:30
Rahul Raturi
f584cf8282 Avoid AttributeError exception 2016-08-01 19:38:13 +05:30
Rahul Raturi
c4d6ea4796 Make search dialog able to display all results 
To view all recordings, right click on Track object and select
"Display more results". Results can't be loaded into Picard as
for now.

What's not working:
* Search dialog is throwing exceptions sometimes, specifically
AttributeError.
* Release type is left for now.
 2016-08-01 19:38:13 +05:30
Rahul Raturi
b7fb30b3f5 Wrap code 2016-08-01 19:38:13 +05:30
Rahul Raturi
f06e30682b Track search dialog primitive UI 2016-08-01 19:38:13 +05:30
Wieland Hoffmann
526777edd7 Merge pull request #482 from scop/links 
Link updates
 2016-07-31 09:17:16 +02:00
Wieland Hoffmann
9de9ac069c Merge pull request #483 from scop/spelling 
Spelling fixes
 2016-07-31 09:16:32 +02:00
Wieland Hoffmann
0267da749b Merge pull request #484 from scop/astrcmp-indent 
Make astrcmp indentation consistent
 2016-07-31 09:15:26 +02:00
Wieland Hoffmann
a9c111af7f Merge pull request #485 from scop/with 
Handle more file closing with "with"
 2016-07-31 09:13:57 +02:00
Ville Skyttä
dcf60ac700 Handle more file closing with "with" 2016-07-31 09:36:11 +03:00
Ville Skyttä
95d8d21fb5 Make astrcmp indentation consistent 2016-07-31 09:31:44 +03:00
Ville Skyttä
9ed5c65230 Link updates 2016-07-31 09:27:07 +03:00
Ville Skyttä
b1819ec37c Spelling fixes 2016-07-31 09:26:21 +03:00
Wieland Hoffmann
000b575b79 Restore IRC notifications 2016-07-27 18:17:39 +02:00
Wieland Hoffmann
accd6f777d Merge branch 'mutagen-travis' 2016-07-27 18:17:18 +02:00
Wieland Hoffmann
a5bc181e05 Pip caches by default 
See https://pip.pypa.io/en/stable/reference/pip_install/#caching
 2016-07-27 18:14:34 +02:00
Wieland Hoffmann
1b7e695dd4 Travis knows where pip caches 
See https://docs.travis-ci.com/user/caching/#pip-cache
 2016-07-27 18:14:34 +02:00
Wieland Hoffmann
c3fd992d00 Handle differences between mutagen 1.33 and 1.34 in travis 
For now, allow 1.34 build to fail, but >=1.23,<1.34 must still pass.
 2016-07-27 18:14:34 +02:00
Ville Skyttä
8fe381dbe6 Run *.png through zopflipng (#477) 2016-07-26 21:21:03 +02:00
Michael Wiencek
832ac27f51 Merge pull request #476 from rahul-raturi/bugs 
Prevent stale log and history dialogs
 2016-06-21 10:04:49 -05:00
Rahul Raturi
2fa3bbb33f Prevent stale log and history dialogs 
Need to pass mainwindow as parent to these dialogs so they quit
with the main window. This bug was introduced in -> 3f2f0f3.
 2016-06-21 20:15:04 +05:30
Philipp Wolfer
5cf0ceb0f0 Update README: Links to issue tracking and support 2016-05-09 11:31:38 +02:00
Laurent Monin
fdaac42c92 Use https by default for external links (#472) 2016-05-04 09:10:47 +02:00
Philipp Wolfer
978be5b184 Merge pull request #460 from phw/picard-777-more-detailed-icon 
Use a more detailed icon for 32x32 pixel size
 2016-05-04 09:08:04 +02:00
Laurent Monin
543bb83775 Update picard.pot file 
Signed-off-by: Laurent Monin <github@norz.org>
 2016-05-02 09:50:55 +02:00
Laurent Monin
28ea3a6cf6 Resync translations 
Signed-off-by: Laurent Monin <github@norz.org>
 2016-05-02 09:49:40 +02:00
Laurent Monin
e30179a94a Merge pull request #470 from zas/redirect_workaround 
PICARD-811: workaround https with port 80 issue
 2016-04-30 12:09:37 +02:00
Laurent Monin
64b8c0106b PICARD-811: workaround https with port 80 issue 
On redirect, https urls without specified port defaults to port 80 causing an infinite redirect loop.

There are more issues:

* redirect 301 should be cached by Picard (it is handled as a 302 for now)
* the current handling of schemes (http vs https) and ports (80 vs 443 vs user-defined port) is quite messy
* this kind of infinite loop is not detected by Picard
 2016-04-28 11:18:10 +02:00
Laurent Monin
6506ad56bc Merge pull request #471 from rahul-raturi/encode_redirect_query 
Get encoded query from redirect url
 2016-04-28 10:49:00 +02:00
Rahul Raturi
f748971b31 Get encoded query from redirect url 2016-04-28 04:07:36 +05:30
Laurent Monin
ef407252d0 Merge pull request #467 from rahul-raturi/display_old_cover 
PICARD-808: Display existing covers in File Info dialog
 2016-04-27 15:54:28 +02:00
Rahul Raturi
dadf13e484 Add tests for union_sorted_lists method 2016-04-23 18:31:57 +05:30
Rahul Raturi
8aee8ba438 Move sorted merging of two lists code into separate method 2016-04-23 18:24:22 +05:30
Rahul Raturi
c2a4666dc0 Change check for displaying existing artwork 
Displaying existing artwork is only for Track objects. Mention this
in check.
 2016-04-17 14:53:55 +05:30
Rahul Raturi
586be81a8a Fix missing spaces around operators 2016-04-17 14:19:16 +05:30
Laurent Monin
c6b8b384a2 Merge pull request #469 from rahul-raturi/add_resource_readme 
Add readme for updating resources
 2016-04-17 10:11:08 +02:00
Rahul Raturi
7d78b2a030 Add readme for updating resources 2016-04-12 23:29:31 +05:30
Rahul Raturi
32de53083f Reduce width of type column in Info Dialogs 
Type column is oversized for most types. Reduce its width.
 2016-04-06 02:59:19 +05:30
Rahul Raturi
4eae826427 Add docstring and comments in functions added in -> 7451602 2016-04-06 02:56:15 +05:30
Rahul Raturi
1e451b9954 Make side by side comparison of new and existing cover art more obvious 
Includes changes suggested in comment ->
https://github.com/metabrainz/picard/pull/467#issuecomment-204583236
 2016-04-05 22:19:31 +05:30
Rahul Raturi
8975f3e9da Fix formatting and missing check in commit -> 7451602 2016-04-03 02:35:14 +05:30
Philipp Wolfer
988d9ec029 Merge pull request #468 from rahul-raturi/mention_python_version 
Mention python2 in shebang
 2016-04-02 22:09:52 +02:00
Rahul Raturi
93e945fad3 Mention python2 in shebang 
Some distributions have switched to Python3 as default. So, /usr/bin/env
python opens up wrong interpreter.
 2016-04-03 05:54:15 +05:30