fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-04-23 21:01:27 +00:00
Code Issues Packages Projects Releases Wiki Activity
6,156 Commits 1 Branch 0 Tags
689fcdcc48a506c8faa5eb52e4f2bcee586d6b63
Commit Graph

6156 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Laurent Monin
689fcdcc48 Drop PluginManager._api_versions, use picard.api_versions_tuple instead 
- modify PluginManager._compatible_api_versions()
- add matching tests
 2019-04-18 11:14:46 +02:00
Laurent Monin
45a6b20b85 Introduce picard.api_versions_tuple 
- list of versions as tuples
- constant calculated from picard.api_versions
- add tests
- skip tests if not enough elements (previous code didn't make sense anyway)
 2019-04-18 11:14:45 +02:00
Philipp Wolfer
a1a79658bf Merge pull request #1185 from phw/use-appid-constant 
Use PICARD_APP_ID constant instead of hardcoded strings
 2019-04-09 19:00:17 +00:00
Philipp Wolfer
adec42868c Use PICARD_APP_ID also for CFBundleIdentifier 2019-04-09 11:38:21 +02:00
Philipp Wolfer
1800e3cce5 Use PICARD_APP_ID constant instead of hardcoded strings 2019-04-09 11:18:18 +02:00
Philipp Wolfer
7aa7629ae4 PICARD-1502: Call setDesktopFileName before creating QApplication 2019-04-08 15:31:00 +00:00
Laurent Monin
160c944174 Merge pull request #1183 from phw/PICARD-1502-setdesktopfilename 
PICARD-1502:  Ensure proper app-id on Wayland
 2019-04-08 16:32:47 +02:00
Laurent Monin
794b454f53 Merge pull request #1180 from zas/extensions 
Rework ExtensionPoint
 2019-04-08 16:32:30 +02:00
Laurent Monin
5c2739b923 ExtensionPoint.register(): module -> name, to be consistent with other methods 2019-04-08 09:21:51 +02:00
Philipp Wolfer
6f3e32f711 PICARD-1502: Use QApplication.setDesktopFileName to ensure proper app-id on Wayland 2019-04-08 08:38:43 +02:00
Laurent Monin
5eebc9093f Merge pull request #1182 from zas/PICARD-1503 
PICARD-1503: fix CDROM device containing ampersand (&)
 2019-04-07 22:15:55 +02:00
Laurent Monin
882a9ff418 PICARD-1503: fix CDROM device containing ampersand (&) 
Patch by Philipp Hahn
 2019-04-07 20:57:46 +02:00
Laurent Monin
434be1f155 Merge pull request #1181 from zas/isort_version 
Add requirements-dev.txt, with working isort version and various tools
 2019-04-07 16:41:05 +02:00
Laurent Monin
2a90443de4 Add --diff --quiet to isort pre-commit hook example 2019-04-07 15:45:51 +02:00
Laurent Monin
e6ae468077 Add a note about requirements-dev.txt to CONTRIBUTING.md and merge HACKING.txt 2019-04-07 15:25:02 +02:00
Laurent Monin
69b91ad5e7 Add requirements-dev.txt, with working isort version and various tools 2019-04-07 12:02:34 +02:00
Laurent Monin
59d0bdd3ca Only log plugins register 
Others aren't displayed anyway, since log.debug doesn't work yet.
A commented print() is kept to help debugging
 2019-04-06 22:42:34 +02:00
Laurent Monin
5a89099684 ExtensionPoint(): use defaultdict(list) to store items 
- it reduces number of iterations needed in __iter__()
- it simplifies unregister_module()
 2019-04-06 22:36:18 +02:00
Laurent Monin
f7318f886e Add a label to ExtensionPoint to ease debugging 
Sample output:
D: 21:57:50,448 plugin.register:128: ExtensionPoint: album_metadata_processors register <- module='discnumber' item=<function remove_discnumbers at 0x7fcefbbeb1e0>
D: 21:57:50,449 plugin.register:128: ExtensionPoint: cluster_actions register <- module='fix_tracknums' item=<picard.plugins.fix_tracknums.FixTrackNumsUsingTitles object at 0x7fcefbbe94c8>
 2019-04-06 22:08:41 +02:00
Philipp Wolfer
7cfdccf425 Merge pull request #1177 from phw/use-isort 
Run isort over all files
 2019-04-04 15:38:21 +00:00
Philipp Wolfer
bdeaa32967 CI: Run isort with --diff --quiet 2019-04-04 15:44:00 +02:00
Philipp Wolfer
af255c32a0 Run isort on Travis CI 2019-04-04 15:42:33 +02:00
Philipp Wolfer
81b9b1c59c Documented use of pre-commit hook for isort check 2019-04-04 08:43:31 +02:00
Philipp Wolfer
dc0ec84401 isort: Consistently use two blank lines after import 2019-04-04 08:35:23 +02:00
Philipp Wolfer
dd4da2aa47 Updated isort config to put test imports in separate section 2019-04-04 08:32:22 +02:00
Philipp Wolfer
05fc98c64a Run isort over all files 2019-04-03 21:19:12 +02:00
Laurent Monin
b049e98a0f Restore comma removed in 29c2f45de1 2019-04-03 21:08:03 +02:00
Antonio Larrosa
29c2f45de1 Use QDesktopServices to open cover images instead of webbrowser2 
QDesktopServices takes care of honoring the user configuration so
when opening an image, the user preferred external app is used
instead of always using a web browser.

Fixes PICARD-1501
 2019-04-03 18:47:05 +00:00
Laurent Monin
86ea3c11f7 Merge pull request #1174 from zas/config_upgrade_tests 
Add tests for config upgrade functions
 2019-04-03 18:37:44 +02:00
Laurent Monin
931ccbca00 Remove redundant code: process is already set few lines before 2019-04-03 15:35:15 +00:00
Laurent Monin
fb6807636d Add tests for config upgrade functions 2019-04-03 12:22:53 +02:00
Laurent Monin
b1f0691597 Merge pull request #1172 from zas/config2 
Rework Config / ConfigSection
 2019-04-03 11:26:41 +02:00
Laurent Monin
a63cc6bdd1 Rework config and add tests for it 
- get rid of useless ConfigSection.__config
- use name instead of full key (as section name is fixed)
- add support for qt type
- remove _convert_to_bool(), unneeded with qt type support
 2019-04-03 09:46:52 +02:00
Laurent Monin
212cd78c69 Remove unused IntListOption 2019-04-03 09:44:45 +02:00
Laurent Monin
00b13fe5c6 Merge pull request #1173 from zas/const2 
Move some constants to picard.const
 2019-04-02 18:58:36 +02:00
Laurent Monin
22d67cd977 Move DEFAULT_NUMBERED_SCRIPT_NAME and DEFAULT_SCRIPT_NAME to picard.const 2019-04-02 14:07:14 +02:00
Laurent Monin
0f1ca5379a Move to DEFAULT_FILE_NAMING_FORMAT to picard.const 2019-04-02 14:06:49 +02:00
Laurent Monin
159cea740c Merge pull request #1167 from phw/fix-running-specific-tests-only 
Fixed invoking "python setup.py test --tests=..."
 2019-03-29 14:30:47 +01:00
Philipp Wolfer
e8049a50f4 Build against PyQt 5.12.1 on Windows 2019-03-29 14:17:40 +01:00
Laurent Monin
28655af04c Merge pull request #1165 from zas/releasing_doc 
Convert obsolete do_release.sh to an actual releasing documentation
 2019-03-29 13:53:30 +01:00
Laurent Monin
46530a30e9 Merge pull request #1166 from phw/flake-ignore-W503 
Flake ignore w503
 2019-03-29 12:57:20 +01:00
Laurent Monin
4de73a6af3 Add some details, re-order a bit 2019-03-29 12:17:35 +01:00
Philipp Wolfer
d99d79e441 Fixed invoking "python setup.py test --tests=..." 2019-03-29 11:59:25 +01:00
Philipp Wolfer
6158c001bf Ignore test files for code coverage also on Codacy 2019-03-29 11:20:09 +01:00
Philipp Wolfer
fa5ae617fe PEP8: Line break before binary operator 2019-03-29 11:11:34 +01:00
Laurent Monin
53036a190d Cleanup 2019-03-29 11:08:57 +01:00
Laurent Monin
0e93231d99 Convert do_release.sh obsolete script to a release process documentation 2019-03-29 11:01:22 +01:00
Philipp Wolfer
7cf3945272 Removed unused imports 2019-03-29 10:55:28 +01:00
Philipp Wolfer
801c7f8f35 Ignore the ui_*.py files for calculating testing code coverage. 2019-03-29 09:47:20 +00:00
Philipp Wolfer
e41c683c0f Merge pull request #1160 from phw/fix-config-loading 
Fix loading BoolOption from config
 2019-03-29 09:10:20 +00:00