Laurent Monin
6fe07b45ae
Removed a bunch of unused imports
2018-10-11 14:34:26 +02:00
Philipp Wolfer
6cda26264e
Merge pull request #999 from antlarr/fix-parser-crash
...
PICARD-1374: Fix a crash when parsing an incomplete regular expresion being written
2018-10-10 16:10:30 +02:00
Antonio Larrosa
1bcc43b288
Return text instead of an empty string in func_rreplace in case of error
2018-10-10 13:27:46 +02:00
Antonio Larrosa
08ff10efd3
Fix a crash when parsing an incomplete regular expresion being written
...
If you write $rsearch(text,) in the file naming script and then move the
cursor after the comma and start writing a regular expression like
[a-z], picard crashes as soon as the '[' character is entered, since it
tries to parse the regular expression and the re module raises an exception.
This patch catches the re exceptions for $rsearch and $rreplace so
picard doesn't crash.
2018-10-10 10:41:01 +02:00
Philipp Wolfer
d6a4eda968
Merge pull request #975 from phw/PICARD-1339-fixup
...
PICARD-1339: Improve file removal performance
2018-10-09 08:50:53 +02:00
Laurent Monin
626489ed08
Merge branch 'master' into PICARD-1339-fixup
2018-10-08 22:56:14 +02:00
Philipp Wolfer
acdc31688c
Add some documentation to util.imagelist
2018-10-08 20:46:15 +02:00
Philipp Wolfer
6a33683968
Merge pull request #993 from phw/isort-fixes
...
Isort fixes
2018-10-08 18:25:28 +02:00
Laurent Monin
30191142d3
Merge branch 'master' into isort-fixes
2018-10-08 17:49:02 +02:00
Philipp Wolfer
3c29fc4a8b
PICARD-1313: Fix setting font to disabled when uninstalling a plugin
2018-10-08 12:52:34 +02:00
Wieland Hoffmann
f03537b4f4
Merge pull request #995 from mineo/picard-1369
...
PICARD-1369: Retry opening URLs
2018-10-07 20:50:40 +02:00
Laurent Monin
f71bb2bc71
Merge branch 'master' into picard-1369
2018-10-07 19:52:52 +02:00
Philipp Wolfer
c7ce9b24b0
Freeze pip dependencies for production release
2018-10-07 19:52:19 +02:00
Wieland Hoffmann
d4167ed1e2
PICARD-1369: Retry opening URLs
...
This is a workaround for https://bugs.python.org/issue31014 . The first time
webbrowser.open is called, an exception is thrown when initializing the list of
browsers on the system. Ignoring that first exception leaves the webbrowser
module in a possibly-not-optimal state regarding the list of browsers it uses,
but it does successfully open URLs. Since there's no point in fixing this in
Picard itself, just continue with a not optimal browser choice.
2018-10-07 18:52:25 +02:00
Wieland Hoffmann
b5114de19f
PICARD-1368: Correctly set log levels ( #996 )
...
Previously, despite having the option to set one of 4 log levels, it was only
possible to toggle between WARNING and DEBUG, because log.debug_mode only set
either logging.DEBUG or VERBOSITY_DEFAULT (logging.WARNING). Now we correctly
pass the selected log level to log.set_level.
2018-10-07 18:23:07 +02:00
Philipp Wolfer
985c642275
PICARD-1366: Show Python version in About ( #991 )
2018-10-07 12:58:29 +02:00
Philipp Wolfer
613e461d08
PICARD-792: Customized tiles for Windows 10 start menu
2018-10-07 12:32:42 +02:00
Philipp Wolfer
f417bc8ded
Merge pull request #988 from phw/win-pyqt-5.11
...
PICARD-1365: Working Windows builds with PyQt 5.11
2018-10-07 12:16:46 +02:00
Philipp Wolfer
7925e6567a
Code cleanup after review
2018-10-06 09:58:43 +02:00
Philipp Wolfer
a4f2cd8a89
PICARD-1339: Added add_metadata_images function
2018-10-06 09:58:43 +02:00
Philipp Wolfer
ab2778a521
PICARD-1339: Use remove_metadata_images for Album and Track
2018-10-06 09:58:43 +02:00
Philipp Wolfer
e9a8c3abee
PICARD-1339: Make conditionals more pythonic
2018-10-06 09:58:43 +02:00
Philipp Wolfer
bc9c9ba602
PICARD-1339: WIP Added optimized imagelist.remove_metadata_images
2018-10-06 09:58:43 +02:00
Philipp Wolfer
a68e76a4b7
PICARD-1339: Added unitttest for update_metadata_images
2018-10-06 09:58:43 +02:00
Philipp Wolfer
0e550c07a8
Renamed imagelist.State to imagelist.ImageListState
2018-10-06 09:58:43 +02:00
Philipp Wolfer
e4763e8651
PICARD-1339: Optimize update_metadata_images performance
...
Greatly improves the time it takes to remove a huge amount of unclustered files from the tagger.
2018-10-06 09:58:43 +02:00
Philipp Wolfer
54cd799a1d
Run isort on entire tree
2018-10-06 09:52:45 +02:00
Philipp Wolfer
c3a2fbdb6b
Fix isort config to recognize picard section
2018-10-06 09:52:27 +02:00
Philipp Wolfer
ee80a4004e
Merge pull request #992 from phw/PICARD-1367-open-search-in-browser
...
PICARD-1367: Open search in browser
2018-10-06 09:33:06 +02:00
Philipp Wolfer
78ec12c20c
Windows build: bdist_nsis is no longer used
2018-10-05 20:03:16 +02:00
Philipp Wolfer
68b361318e
Appveyor: Build against Python 3.5.6
2018-10-05 20:03:16 +02:00
Philipp Wolfer
59aed98b02
Working Windows builds with PyQt 5.11
2018-10-05 20:03:16 +02:00
Philipp Wolfer
d2dec6ca6d
PICARD-1364: Write version information to picard.exe
2018-10-05 19:53:05 +02:00
Philipp Wolfer
46815478d4
PICARD-1367: Respect "advanced query syntax" status
2018-10-05 16:59:18 +02:00
Philipp Wolfer
31dd042483
PICARD-1367: Allow opening a search in browser from search dialogs
2018-10-05 16:54:48 +02:00
Laurent Monin
bda4858391
Merge pull request #986 from zas/browser_integration
...
PICARD-1359: improve builtin server reliability and debugging output
2018-10-05 16:32:59 +02:00
Laurent Monin
faecb4cdd4
Use urlparse() and parse_qs() to process request
2018-10-04 21:48:52 +02:00
Laurent Monin
964c2c6a2f
Enclose whole parsing in try/except to catch all corner cases
2018-10-04 16:04:52 +02:00
Laurent Monin
8c87ddf77d
Internal server: improve query parsing and error handling
...
Check for valid mbid, and returns 400 response in case of bad syntax
2018-10-04 16:04:52 +02:00
Laurent Monin
cca65a2b31
Move response strings to constants
2018-10-04 16:04:52 +02:00
Laurent Monin
b58be63ca0
Returns 500 on error
2018-10-04 16:04:52 +02:00
Laurent Monin
263228eb94
PICARD-1359: improve builtin server reliability and debugging output
2018-10-04 16:04:52 +02:00
Laurent Monin
a11224258a
Merge pull request #985 from zas/ws_tidyup
...
Minor WS code tidy up
2018-10-04 15:26:47 +02:00
Laurent Monin
716be80493
bearer -> authorization
2018-10-02 14:54:01 +02:00
Laurent Monin
fae51b5b00
Log network cache infos on one line
2018-10-02 12:55:41 +02:00
Laurent Monin
fc66113efb
Reduce code redundancy, introducing high_prio_no_cache _init_headers() param
2018-10-02 12:52:08 +02:00
Laurent Monin
21e3858b9b
Shorten lines a bit, importing QNetworkRequest
2018-10-02 12:28:39 +02:00
Laurent Monin
9ad3e41bf3
Introduce add_request() and reduce code redundancy a bit
2018-10-02 12:16:01 +02:00
Laurent Monin
dad0432cd4
Use super()
2018-10-02 12:15:23 +02:00
Laurent Monin
582451916f
Simplify code
2018-10-02 12:15:07 +02:00