fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-02-09 17:23:58 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,106 Commits 1 Branch 0 Tags
7241c8b64281b2f0edb9959cd720007644c0bbe2
Commit Graph

11106 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Laurent Monin
7241c8b642 Merge pull request #2509 from zas/register_funcs 
Move last register_* methods to extension_points
 2024-06-05 12:59:03 +02:00
Laurent Monin
abed8baafc Move register_*_metadata_processor() to new extension_points/metadata.py 2024-06-05 12:32:13 +02:00
Laurent Monin
f86de5d2fe Move register_(file|album)_*()aethods to new extension_points/event_hooks 2024-06-05 12:31:18 +02:00
Philipp Wolfer
80254dd803 Merge pull request #2508 from phw/refactor-dataobj-into-item 
Refactor dataobj into item
 2024-06-03 14:02:05 +02:00
Philipp Wolfer
2369431e47 Clearer name for parent item parameter in File.move / File.remove 2024-06-03 12:52:25 +02:00
Philipp Wolfer
402f8463b6 Add getter / setter for TreeItem.obj 
The setter ensures the cross link between TreeItem.obj and obj.ui_item
always gets set.
 2024-06-03 12:48:12 +02:00
Philipp Wolfer
b2861cdeb6 Renamed File.parent to File.parent_item 
This avoids hiding QObject.parent()
 2024-06-03 08:27:14 +02:00
Philipp Wolfer
d4ba9fc989 Renamed "item" attribute to "ui_item" 2024-06-03 08:27:14 +02:00
Philipp Wolfer
321637b6d6 Merged DataObj class with MetadataItem class 2024-06-03 08:27:13 +02:00
Philipp Wolfer
d30c1c4753 FileList does not need to reimplement iterfiles inherited from FileListItem 2024-06-02 19:01:56 +02:00
Laurent Monin
0e93d921ca Merge pull request #2503 from zas/filedialog_wrappers 
Filedialog wrappers
 2024-06-02 18:35:56 +02:00
Laurent Monin
2106e5242a Merge pull request #2504 from zas/parents2 
More Q* subclasses improvements
 2024-06-02 18:35:40 +02:00
Laurent Monin
6b222834de PICARD-2918: avoid exception if hash isn't found in _datafiles on exit 
A race condition is possible.

- set _datafiles[self._hash] ASAP
- log errors
- revamp code to limit the risk of race condition
- revamp delete_file() code to be more reliable in case of unexpected errors
 2024-06-02 18:22:06 +02:00
Anonymous
aabf26123f Translated using Weblate (Chinese (Simplified)) 
Currently translated at 47.3% (493 of 1041 strings)

Translated using Weblate (Korean)

Currently translated at 17.1% (179 of 1041 strings)

Co-authored-by: Anonymous <noreply@weblate.org>
Translate-URL: https://translations.metabrainz.org/projects/picard/3/constants/ko/
Translate-URL: https://translations.metabrainz.org/projects/picard/3/constants/zh_Hans/
Translation: Picard/Constants
 2024-06-02 02:42:41 +00:00
Vaclovas Intas
aad6470c60 Translated using Weblate (Lithuanian) 
Currently translated at 11.3% (118 of 1041 strings)

Translated using Weblate (Lithuanian)

Currently translated at 69.3% (838 of 1208 strings)

Co-authored-by: Vaclovas Intas <gateway_31@protonmail.com>
Translate-URL: https://translations.metabrainz.org/projects/picard/3/app/lt/
Translate-URL: https://translations.metabrainz.org/projects/picard/3/constants/lt/
Translation: Picard/App
Translation: Picard/Constants
 2024-06-02 02:42:41 +00:00
Laurent Monin
3a851d3c26 Merge pull request #2507 from zas/fix_image_dl 
PICARD-2919: fix download of GIF images (and maybe others)
 2024-06-01 19:16:08 +02:00
Laurent Monin
aad152ddf8 PICARD-2919: fix download of GIF images (and maybe others) 
Issue is the data downloaded is QtCore.QBytesArray object, and it wasn't convert to bytes.
So ensure it is converted before passing it to image detection methods.
 2024-06-01 18:02:31 +02:00
Laurent Monin
d599054e22 _picardize_caption(): use PICARD_DISPLAY_NAME and display it at the end 2024-05-31 16:08:44 +02:00
Laurent Monin
1a853363b5 UpdateCheckManager: no need to inherit from QtCore.QObject and pass tagger object from caller 
- _parent is actually the main window, so derive it from tagger
 2024-05-31 14:10:36 +02:00
Laurent Monin
1adc2f4786 Prefix helper methods with _, those are meant to use locally 2024-05-30 19:23:31 +02:00
Laurent Monin
7e3a5d9c58 Declare class ImageListState at module level 2024-05-30 19:17:01 +02:00
Laurent Monin
c3a815dba6 Add a tagger property to MetadataItem 
It also adds a setter for it to detect duplicated setting of this property
 2024-05-30 14:29:40 +02:00
Laurent Monin
6a633dcd10 Album: it inherits from MetadataItem, but never calls MetadataItem.__init__() 
- this doesn't seem to cause any issue, but that's bad practice
 2024-05-30 13:24:00 +02:00
Laurent Monin
f4c1f958d9 Drop LockableObject, unused 2024-05-30 13:09:51 +02:00
Laurent Monin
04c1e6e1b7 CAATypesSelectorDialog: included/excluded -> return tuple 
- excluded can be an empty tuple, `'none'` isn't a valid type anyway
- adapt debug output (display [] instead of set())
 2024-05-30 12:02:04 +02:00
Laurent Monin
1650f29d1a CAATypesSelectorDialog: reduce number of arguments, use defaults 
- default_include, default_exclude, known_types are from defaults, unlikely to change
- so move part of the code from caller to CAATypesSelectorDialog() class
- make types_include & types_exclude sets, as they are only used using `in`
- move parent parameter at the end
 2024-05-30 11:45:43 +02:00
Laurent Monin
a0cc95fff6 TipSlider, ClickableSlider: pass parent explicitely 2024-05-30 10:54:27 +02:00
Laurent Monin
414b8d83ce LogViewCommon: explicit parameters 2024-05-30 10:45:15 +02:00
Laurent Monin
9684df3b76 display_caa_types_selector() -> CAATypesSelectorDialog.display() class method 
- make parameters explicit, rather than using **kwargs
 2024-05-30 10:40:21 +02:00
Laurent Monin
e7dff30b2d TreeItem: make arguments explicit 
- sortable becomes optional
- parent is now a keyword argument
- obj is mandatory (unchanged)
- fix up callers accordingly
- introduce a post_init() method to allow post initialization without duplicating __init__()
 2024-05-29 22:44:43 +02:00
Laurent Monin
2ec8248ea0 PicardDialog.__init__(): call parent class __init__() before anything 2024-05-29 22:12:21 +02:00
Laurent Monin
6b5d673e11 HashableItem: cache the hash() result 2024-05-29 18:39:48 +02:00
Laurent Monin
70ee6d818c HashableItem: no need to convert uuid4 to str, it can be hashed directly 
5130731c9e/Lib/uuid.py (L268)
 2024-05-29 18:38:32 +02:00
Laurent Monin
4ccb1c14f4 HashableItem: id -> __id 2024-05-29 18:33:16 +02:00
Laurent Monin
5b4ecfca79 HashableTreeWidgetItem, HashableTreeWidgetItem: inherit from HashableItem 2024-05-29 18:29:17 +02:00
Laurent Monin
aed4885e26 Introduce HashableItem class 2024-05-29 18:27:31 +02:00
Laurent Monin
8bff6a2425 BaseAction: match proto, pass parent to parent class if provided 2024-05-29 17:45:37 +02:00
Laurent Monin
ab9e7ff5d9 Move CheckboxListItem to ui/widgets 2024-05-29 17:41:03 +02:00
Laurent Monin
06b9af1511 CheckboxListItem: accept parent parameter 
- change imports to match the style we have elsewhere
 2024-05-29 17:35:20 +02:00
Laurent Monin
672c37eef6 FileDialog static methods: explicit parameters 2024-05-29 15:01:18 +02:00
Laurent Monin
13dfe589b9 Replace class MultiDirsSelectDialog with new FileDialog.getMultipleDirectories() 2024-05-29 14:14:26 +02:00
Laurent Monin
d060c3e21c Add wrappers to QFileDialog -> picard.util.ui.FileDialog 
- it will help with PySide move
- it ensures we have a useful caption, and unify them
- it shortens lines
 2024-05-29 11:14:13 +02:00
Laurent Monin
7492d608bc Merge pull request #2502 from zas/parents 
Review and pass proper arguments to parent classes (mainly Qt*)
 2024-05-29 11:13:18 +02:00
Laurent Monin
c796280a5a QFileDialog: use keyword arguments 
Note: I dropped caption="" in most places, because that's the default, though I think we should set one in most cases, this will need further work.
 2024-05-29 10:30:55 +02:00
Laurent Monin
b67b606946 Pass arguments explicitly to parent Qt classes 2024-05-29 10:30:55 +02:00
Laurent Monin
579f453a50 OptionsPage: make parent keyword argument explicit 2024-05-29 10:30:55 +02:00
Laurent Monin
1dc87518d7 SearchBox: pass parent as keyword arg 2024-05-29 10:30:55 +02:00
Laurent Monin
e488054cac TagListEditor: parent as keyword arg 
Actually callers already used a keyword argument
 2024-05-29 10:30:55 +02:00
Laurent Monin
373370bfa9 RatingWidget: pass parent as keyword arg 2024-05-29 10:30:55 +02:00
Laurent Monin
ff8b23d6cd PlaybackProgressSlider: pass parent as keyword arg to QWidget 2024-05-29 10:30:55 +02:00