Commit Graph

8223 Commits

Author SHA1 Message Date
Bob Swift
73e11bbf5c Avoid confusing reuse of variable names in the same method 2021-07-13 10:14:28 -06:00
Bob Swift
bb76532dcf Hide profile selector from options dialog if no profiles are defined 2021-07-12 14:24:35 -06:00
Bob Swift
d4d84c6ab7 Clear list to avoid creating dupes on a reload. 2021-07-12 08:18:23 -06:00
Bob Swift
332b26135c Update wording to clarify options on the page not available to profiles 2021-07-11 12:39:57 -06:00
Bob Swift
ed79cc9800 Add dialog to show which profiles are attached to options on a page
- add new dialog
- fix settings groups keys
2021-07-11 12:00:47 -06:00
Bob Swift
06961f2d70 Add "Profile Help" button. 2021-07-11 08:58:41 -06:00
Bob Swift
a921cbcc0a Set combobox width to preferred and push to the right-hand side 2021-07-11 08:34:31 -06:00
Bob Swift
377c2f3561 Allow saving options settings to specified profile 2021-07-10 14:35:39 -06:00
Bob Swift
a875a394e5 Correct link for option profiles help 2021-07-10 07:59:41 +02:00
Bob Swift
bbc2262f15 Connect to proper signals for settings tree expand / collapse updates 2021-07-06 09:59:58 +02:00
Bob Swift
dffde62876 Change title of profile manager dialog 2021-07-06 09:59:22 +02:00
Laurent Monin
a6076a6cf1 Merge pull request #1860 from rdswift/check_and_repair_profiles_and_settings
Clean up missing or invalid profile settings.
2021-07-03 00:51:43 +02:00
Laurent Monin
98bd37241d Merge pull request #1858 from rdswift/disallow_blank_profile_names
Disallow entering a blank profile title
2021-07-03 00:50:51 +02:00
Bob Swift
ed792417a1 Style. Split long line. 2021-07-02 15:42:13 -06:00
Bob Swift
2cd2b9675e Disallow entering a blank profile title. 2021-07-02 15:33:17 -06:00
Laurent Monin
e11b5b31e1 Merge pull request #1859 from rdswift/check_if_naming_script_is_used_in_profile_before_deleting
Check is naming script is used in a profile before deleting
2021-07-02 22:06:34 +02:00
Laurent Monin
5b02242d92 Merge pull request #1857 from rdswift/update_script_selection_list_after_profile_change
Update menu bar settings to reflect any changes to enabled profiles
2021-07-02 22:05:53 +02:00
Laurent Monin
42c5007da0 Merge pull request #1856 from rdswift/display_profile_option_values
Display profile setting items as tooltips
2021-07-02 22:05:29 +02:00
Bob Swift
b0de9f2cda Run check and repair only once (during startup) 2021-07-02 12:20:05 -06:00
Bob Swift
57e26d26ae Clean up missing or invalid profile settings. 2021-07-02 11:53:55 -06:00
Bob Swift
ba65f15c81 Style cleanup items
- Use `isInstance()` rather than `type()` for comparisons.
- Use temporary variable to avoid long lines and repetition.
- Use dict for templates to improve clarity.
2021-07-02 07:55:42 -06:00
Bob Swift
e3d04c51e0 Avoid using builtin function name as variable name. 2021-07-01 16:42:14 -06:00
Bob Swift
29ca7f3066 Indicate which profile controls a setting not set in a profile. 2021-07-01 12:58:47 -06:00
Bob Swift
25f0cb3e2a Show full tagging scripts and ca providers lists 2021-07-01 10:49:37 -06:00
Bob Swift
df41628798 Use class constants for templates. Don't pass unnecessary parameters. 2021-07-01 10:16:17 -06:00
Bob Swift
999feb4c7f Update menu bar settings to reflect any changes to enabled profiles 2021-07-01 09:06:47 -06:00
Bob Swift
60f1925eb1 Check is naming script is used in a profile before deleting 2021-06-30 17:16:35 -06:00
Bob Swift
1b4b04d1bf Avoid use of multiple elif statements. 2021-06-30 15:24:00 -06:00
Bob Swift
01f207d1fb Refactor code to address Codacy complexity issue 2021-06-30 13:36:54 -06:00
Bob Swift
70393d1036 Display profile setting items as tooltips. 2021-06-30 13:04:00 -06:00
Laurent Monin
c9e0bb0298 Merge pull request #1855 from rdswift/profile_settings_disappearing_issue
Force update of profile settings key
2021-06-30 20:33:40 +02:00
Bob Swift
4948f4bb65 Force update of profile settings key 2021-06-30 12:19:21 -06:00
Aleksandar Hadzhivelichkov
0ae636b484 Bulgarian translation for Windows installer 2021-06-29 12:46:10 +02:00
Philipp Wolfer
a4547ed41e Update picard.pot 2021-06-29 11:59:21 +02:00
Philipp Wolfer
75f8d9326e Merge pull request #1851 from rdswift/add_user_profiles
PICARD-9: Add support for user profiles
2021-06-28 22:12:14 +02:00
Bob Swift
673b7a7191 Fix crash when deleting the last profile from the list. 2021-06-28 11:56:21 -06:00
Bob Swift
22d91a4501 Add comment explaining why deepcopy() is required. 2021-06-28 11:20:20 -06:00
Bob Swift
85ce4b1411 Rename ProfileEditorPage to ProfileEditorDialog 2021-06-28 09:17:21 -06:00
Bob Swift
d9934ad5f6 Revise and rearrange buttons. Auto-save changes within dialog. 2021-06-28 09:17:21 -06:00
Bob Swift
8c967efc1b Add keyboard shortcut to MainWindow 2021-06-28 07:41:15 -06:00
Bob Swift
4f10a47e63 Update settings for id directly 2021-06-27 08:00:58 -06:00
Bob Swift
e01b978441 Correct the url to the help page 2021-06-26 12:35:12 -06:00
Bob Swift
c046c0ad23 Miscellaneous style cleanup items
In `picard/ui/profileeditor.py`:
- Remove unnecessary `deepcopy()`.
- Use `set.difference()` for comparing key sets.
- Add explanation for creating missing key in
`get_settings_for_profile()` method.
- Move `settings` declaration into `if` section where it is used.
- Remove unnecessary `.keys()` call when creating set of profile IDs.
- Use `set.difference()` for comparing setting sets.
- Remove unnecessary `self.loading` check.
- Add class constant for which QTreeWidgetItem column to use.

In test/test_profiles.py:
- Use keys defined in `SettingConfigSection` class.
2021-06-26 08:51:12 -06:00
Bob Swift
7c1a5087b2 Merge pull request #9 from zas/namedtuplesetting
Named tuple profile settings
2021-06-26 08:32:28 -06:00
Laurent Monin
737c7463ab Convert profile settings to named tuple 2021-06-26 10:40:27 +02:00
Bob Swift
5af502491b Fix crash after deleting the last profile in the list 2021-06-25 17:37:19 -06:00
Bob Swift
150eb403ae Save editor settings on dialog close. 2021-06-25 17:15:24 -06:00
Bob Swift
abc3f38fe3 Add selected file naming script as profile option 2021-06-25 17:06:13 -06:00
Bob Swift
f6ef7c4262 Remove unused profile switching system 2021-06-25 15:45:19 -06:00
Bob Swift
4ff13106e7 Remove unused (commented out) code 2021-06-25 15:41:01 -06:00