fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-02-21 07:04:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
5,920 Commits 1 Branch 0 Tags
841c8acbfc0b0f44e2d7bc24f76bcc9d3134fa4a
Commit Graph

5920 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Laurent Monin
841c8acbfc getWordAndCount -> get_word_and_count 2019-03-04 21:46:17 +01:00
Laurent Monin
9a5dcd83dd getClusterTitle -> get_cluster_title 2019-03-04 21:46:17 +01:00
Laurent Monin
e97cdaef00 getClusterFromId -> get_cluster_from_id 2019-03-04 21:46:17 +01:00
Laurent Monin
9980b7c5ff idClusterIndex -> index_id_cluster 2019-03-04 21:46:17 +01:00
Laurent Monin
5bb5f49935 clusterBins -> cluster_bins 2019-03-04 21:46:17 +01:00
Laurent Monin
00299aeb9e clusterCount -> cluster_count 2019-03-04 21:46:17 +01:00
Laurent Monin
d44a9b56dc clusterDict -> cluster_dict 2019-03-04 21:46:17 +01:00
Laurent Monin
ad12f57a55 Cleanup 2019-03-04 21:46:17 +01:00
Laurent Monin
836eea6f97 Make Album._match_files() a generator 2019-03-04 21:45:50 +01:00
Laurent Monin
372981f535 Move tracks cache building to its own method, code is easier to read 2019-03-04 21:45:50 +01:00
Laurent Monin
3fe73bc3ea Simplify code even more 2019-03-04 21:45:50 +01:00
Laurent Monin
799181dcb5 Rework Album.match_files() 
- use simple comparaison and last best match instead of list + sort
- drop unused use_recordingid parameter
- split the method in two, it should ease testing
- drop match_file, and use modified match_files, reducing code redundancy
 2019-03-04 21:45:50 +01:00
Laurent Monin
79eedc20e6 Add debug output for each case 2019-03-04 21:03:56 +01:00
Laurent Monin
f960dd8115 Simplify code using a bunch of return 
Those if/elif were hard to read and lead to code duplication
 2019-03-04 21:03:56 +01:00
Laurent Monin
498af86aa4 Make the code slightly easier to read 2019-03-04 21:03:56 +01:00
Laurent Monin
6e412f0835 No need of recordingid if option ignore_file_mbids is set 2019-03-04 21:03:56 +01:00
Laurent Monin
7538bb4a96 No need of recordingid if target is set 2019-03-04 21:03:56 +01:00
Laurent Monin
8a36cd5139 Drop useless code 
This shouldn't be needed since b36d88ad46
 2019-03-04 21:03:56 +01:00
Laurent Monin
8bc9cf9886 Reduce indentation level 2019-03-04 21:03:56 +01:00
Laurent Monin
beb6d94f95 Fix mbid_validate() 
- drop dependency on string.Template, the regex is very simple
- test against None, as per documentation
- fix the match when the string is starting with a valid mbid but is too long
- use case-insensitive matching flag
 2019-03-04 19:35:05 +01:00
Laurent Monin
1ca043dd90 Add tests for mbid_validate() 2019-03-04 19:35:05 +01:00
Laurent Monin
c948e01400 tagger.analyze(): immediatly return if acoustid is disabled 
- code was setting files as pending before testing if acoustid was enabled
- test can be done before anything since that's a required condition
 2019-03-04 18:26:51 +01:00
Laurent Monin
81118d0954 Set version to 2.2.0dev1 2019-03-04 17:36:11 +01:00
Laurent Monin
5b3e83120d Bump version to 2.1.3 2019-03-04 17:31:14 +01:00
Laurent Monin
1f95f05645 Resync po files 2019-03-04 17:31:14 +01:00
Laurent Monin
b66d7999d2 Merge pull request #1112 from phw/PICARD-455-flac-set-image-dimensions 
PICARD-455: Set dimensions for images saved to FLAC
 2019-02-27 14:14:20 +01:00
Philipp Wolfer
a9709f97ea PICARD-455: Set dimensions for images saved to FLAC 2019-02-27 08:29:23 +01:00
Laurent Monin
9db6d8e0d9 Update pot file 2019-02-22 22:48:35 +01:00
Philipp Wolfer
ccebf9c8b9 Refactored local cover art class 
Generalized the handling of cover art URLs to also handle file:// scheme.
 2019-02-22 14:14:00 +01:00
Laurent Monin
710f1ac8ef Merge pull request #1110 from zas/clearlineedit 
PICARD-1480: Remove unneeded ButtonLineEdit
 2019-02-22 13:27:43 +01:00
Laurent Monin
c4a63a8772 Remove unneeded ButtonLineEdit 
QLineEdit has a clearButtonEnabled property since 5.2 which is meant for this purpose.
It also fixes an issue with clear button icon size
 2019-02-22 11:46:24 +01:00
Philipp Wolfer
ecf8ad565a PICARD-1178: Support comparing cover images with only one type 
All our current tags support either no or only one type.
Fixes issues where files where shown as modified when loading again and comparing against cover art with more than one type.
 2019-02-22 11:05:08 +01:00
Philipp Wolfer
a10c7a01fc Updated POT file 2019-02-21 13:32:00 +01:00
Philipp Wolfer
b4664f6649 Merge pull request #1108 from phw/PICARD-729-nat-error-handling 
PICARD-729: NAT error handling
 2019-02-21 13:30:43 +01:00
Philipp Wolfer
1c3f1e23cc PICARD-729: Show error icon if NAT fails loading 2019-02-21 13:29:27 +01:00
Philipp Wolfer
22aa08092c Expand NATs special album by default 2019-02-21 13:29:27 +01:00
Philipp Wolfer
98769b01e0 PICARD-729: Allow removing single NATs 2019-02-21 13:29:27 +01:00
Philipp Wolfer
954fdc9f79 PICARD-729: Handle error status for NATs 2019-02-21 13:29:27 +01:00
Philipp Wolfer
ed28363250 PICARD-1478: Read MB host and port from config 
Prevents requiring a restart when changing the MB server in options.
 2019-02-21 13:27:58 +01:00
Philipp Wolfer
d9a7a82503 Merge pull request #1106 from phw/PICARD-1288-fix-artist-genre-fallback 
PICARD-1288: Fix artist genre fallback
 2019-02-20 21:28:20 +01:00
Laurent Monin
7f199e5528 Update translations 2019-02-20 16:34:36 +01:00
Philipp Wolfer
14277c18b5 PICARD-1288: Added unit tests 2019-02-20 12:55:33 +01:00
Philipp Wolfer
46275d8ce5 PICARD-1288: Code readability tweaks 2019-02-20 12:37:27 +01:00
Philipp Wolfer
dc01e2c607 Refactored reading genres from JSON for less redundancy 2019-02-20 12:31:50 +01:00
Philipp Wolfer
bf7337884b PICARD-1288: Fix artist genre fallback 2019-02-20 12:00:59 +01:00
Philipp Wolfer
02ba76b39b Merge pull request #1105 from phw/PICARD-1474-fix-win-installer-version 
PICARD-1474: Fix version information in Windows installer exe
 2019-02-18 17:30:22 +01:00
Philipp Wolfer
f1248b487f Introduce a priority thread pool 
This pool is meant to be used for threads where the user expects a response as fast as possible.
 2019-02-18 17:27:13 +01:00
Philipp Wolfer
de4bf2029a Merge pull request #1103 from phw/ci-do-not-fail-on-transfersh-upload 
CI: Do not fail the build if macOS upload to transfer.sh fails
 2019-02-18 15:11:37 +01:00
Philipp Wolfer
f93357c118 PICARD-938: Do not expand track item with single file 
Fixes the issue that one has to press the left arrow key twice to navigate from track to album.
 2019-02-18 15:07:19 +01:00
Philipp Wolfer
5b9f6ecfc4 Fix encoding issue of strings in Windows installer 
Fixes the copyright sign to be shown correctly.
 2019-02-18 15:03:10 +01:00