Commit Graph

6748 Commits

Author SHA1 Message Date
Philipp Wolfer
880682033c Introduce DISPLAY_NAME constant for use in metadata
This allows us to use the same value on multiple places where we need to specify a product display name for Picard.
2019-12-03 23:08:18 +01:00
Philipp Wolfer
f8ae841ccc PICARD-1682: Use multiline editor for lyrics and comments
This allows editing lyrics and comments in the metadatabox without loosing linebreaks.
2019-12-03 23:05:38 +01:00
Philipp Wolfer
e2e31c5fc3 Merge pull request #1389 from phw/customizable-columns
PICARD-170: Customizable main panel columns
2019-12-03 23:03:39 +01:00
Philipp Wolfer
05126bf0a4 EditableListView: Use default implementation for editor creation
Custom code now just adds the autocompleter, but otherwise this is the standard editor.
2019-12-03 16:37:10 +01:00
Philipp Wolfer
21f715dcb1 Fixed drag and drop in EditableListView 2019-12-03 11:11:25 +01:00
Philipp Wolfer
c901295df3 PICARD-170: Fille album media metadata in existing loop over media
Avoids separate looping over the media list
2019-12-03 09:37:21 +01:00
Philipp Wolfer
964a452a2d EditableListView: Mimic default QItemDelegate.createEditor behavior
This leads to consistent layout for our custom implementation and standard editors.
2019-12-03 08:45:59 +01:00
Philipp Wolfer
b59f09e9fb PICARD-170: Add a restore default columns action 2019-12-02 23:54:46 +01:00
Philipp Wolfer
f8f4740fca PICARD-170: Use QHeaderView to save / restore main panel column state
Simplifies code and also persists the column order.
2019-12-02 23:37:48 +01:00
Philipp Wolfer
1b037d6270 PICARD-170: Allow selecting displayed columns
Adds a context menu to the default pane headers to select the displayed columns. The default is unchanged, but additional columns can be selected by the user.
2019-12-02 23:37:48 +01:00
Philipp Wolfer
d9f31438a0 PICARD-1523: Compare preserved tags case-insensitive 2019-12-02 20:53:45 +01:00
Philipp Wolfer
e07c6a99c2 Github Actions: Cache libdiscid for macOS builds 2019-12-02 20:30:10 +01:00
Philipp Wolfer
fc1ed6671c Merge pull request #1385 from phw/gha-pr
Github Actions: Run on pull requests
2019-12-02 14:09:38 +01:00
Philipp Wolfer
0e052a95dd GHA: Do not run macOS packaging on changes to changelog-for-version.py 2019-12-02 14:08:40 +01:00
Philipp Wolfer
d8d612e29f Update Github release from changelog 2019-12-02 13:55:05 +01:00
Philipp Wolfer
2cc0b35cfe PICARD-1565: Consider all results returned from AcoustID lookups
Previously only the first result (which has the highest score) was used. Now all results are used, weighted by their scores.
2019-12-02 13:53:45 +01:00
Philipp Wolfer
855a850e4a Adjust releasetype matching scores.
This limits the impact of the releasetype score to ~24% of the total score for cluster and file weights (previously ~34%). This means with default settings (all releasetypes set to 0.5) a otherwise perfect match will have only ~12% reduced score.
2019-12-02 13:52:13 +01:00
Philipp Wolfer
5c2e1eaa0a PICARD-1664: Use preferred release type for cluster lookup 2019-12-02 13:52:13 +01:00
Philipp Wolfer
5ea1f884b1 Github Actions: Sign code on Windows only if secrets are available 2019-12-02 13:38:10 +01:00
Philipp Wolfer
be9c91739b Github Actions: Fixed triggering Win / Mac releases on tag push 2019-12-02 13:38:10 +01:00
Philipp Wolfer
de7aad29e3 Github Actions: Run packaging tasks on pull requests 2019-12-02 13:38:10 +01:00
Philipp Wolfer
34dfc31ad1 Github Actions: Run on pull requests 2019-12-02 13:38:10 +01:00
Philipp Wolfer
c3314ce20b Run brew update on travis 2019-12-02 13:37:21 +01:00
Philipp Wolfer
c267e17faa CI: Do not run rew update for macOS builds
If required this should be run outside the setup script.
2019-12-02 12:25:13 +01:00
Philipp Wolfer
330fe84f62 PICARD-1680: Allow slecting multiple results in cd lookup dialog 2019-12-01 12:11:06 +01:00
Philipp Wolfer
71e2214dd7 cdlookup: Added some margin between label and submit button 2019-11-30 15:59:34 +01:00
Philipp Wolfer
5e4e5ba555 Update picard.pot 2019-11-30 15:55:21 +01:00
Philipp Wolfer
04e2e304c6 PICARD-1401: On empty disc lookup show a prominent disc ID submission button 2019-11-30 10:32:02 +01:00
Philipp Wolfer
a94748fc64 PICARD-1677: Fixed exception when saving ignored tags 2019-11-30 10:31:24 +01:00
Philipp Wolfer
4dffc55ef1 Merge pull request #1379 from phw/PICARD-1677-ignore-tags
PICARD-1677: Tags can be ignored for metadata comparisson
2019-11-29 17:02:15 +01:00
Philipp Wolfer
2c21cc7898 Fixed linting issues in shell script reported by codacy. 2019-11-29 17:01:36 +01:00
Philipp Wolfer
4f684d0a48 PICARD-1678: Fix Picard crashing on non-integer search scores
If the search scores returned by the server are not integer values Picard crashed during metadata comparisson.
2019-11-29 17:00:59 +01:00
Philipp Wolfer
c82b2b6f5b Added generic AutocompleteItemDelegate for autocompletion in list views 2019-11-29 15:38:49 +01:00
Philipp Wolfer
c6fcf3f1a0 PICARD-1677: Allow ignoring tags for metadata comparisson
Files that only differ in the tags set in the ignore list will not show up as changed even if those tags have changed.
2019-11-29 15:21:10 +01:00
Philipp Wolfer
9baba44c98 Refactored top tags editor into generic TagListEditor widget 2019-11-29 15:21:10 +01:00
Philipp Wolfer
edd79a6dd0 Use QDialog.exec_ instead of .exec 2019-11-29 09:38:40 +01:00
Philipp Wolfer
1fd305c9fe Github Actions: Do not trigger builds on tag / branch create
Limiting this to specific tags / branches seems unsupported, also it seems that tag pushes still trigger the build.
2019-11-29 07:43:47 +01:00
Philipp Wolfer
4eb5b6084a macOS notarization: Print success message returned by notarization service 2019-11-28 21:12:33 +01:00
Philipp Wolfer
5ecf7b7320 macOS notarization: Faster polling, improved info output 2019-11-28 20:50:09 +01:00
Philipp Wolfer
0277467db1 Use specific event handlers instead of generic event() if possible 2019-11-28 20:39:48 +01:00
Philipp Wolfer
39511dca00 Github Actions: Fixed triggering macOS builds on packaging script changes 2019-11-28 12:43:32 +01:00
Philipp Wolfer
41ca1fe10d Merge pull request #1374 from metabrainz/github-actions
Use GitHub Actions for CI
2019-11-28 08:39:06 +01:00
Philipp Wolfer
af68e3fb29 Github Actions: Run picard -V after pip install test 2019-11-28 08:09:08 +01:00
Philipp Wolfer
c4ed6c7379 Update install restructions to use setup.py build
This is required for tagger.py getting build
2019-11-27 23:19:34 +01:00
Philipp Wolfer
629baadc03 Merge pull request #1371 from phw/PICARD-714-user-defined-top-tags
PICARD-714: User defined top tags
2019-11-27 19:05:41 +01:00
Philipp Wolfer
d4f4ac0f8f Github Actions: Run test suite on all pushes 2019-11-27 10:10:33 +01:00
Philipp Wolfer
77ca6a7bc5 Github Actions: Ensure win / mac builds are triggered for release tags 2019-11-27 10:09:52 +01:00
Philipp Wolfer
89d6097125 Github Actions: Run tests even if code style validation fails
The test suite will still fail, but we get all issues reported instead of just code style issues.
2019-11-27 08:57:14 +01:00
Philipp Wolfer
a4c123bc25 Github Actions: Limit paths for which to run tests / packaging 2019-11-27 07:58:29 +01:00
Philipp Wolfer
5f92873f65 PICARD-714: Code cleanup 2019-11-26 18:45:25 +01:00