Commit Graph

2139 Commits

Author SHA1 Message Date
Wieland Hoffmann
8ba96e4851 Unbreak moving WavPack correction files
The `settings` argument to `File._rename` has been removed in 7c4fdf76.
2013-07-03 17:48:35 +02:00
Michael Wiencek
8df21aaae2 Merge pull request #142 from zas/pep8_tests
tests: PEP8 fixes
2013-07-02 18:40:48 -07:00
Laurent Monin
7dd311697f tests: PEP8 fixes 2013-07-03 03:37:24 +02:00
Michael Wiencek
7325a73507 Update INSTALL.txt 2013-07-02 19:31:05 -05:00
Michael Wiencek
157df15443 Don't crash if python-discid is missing 2013-07-02 19:30:44 -05:00
Michael Wiencek
28b1a0a05b Use uniqify in get_files_from_objects 2013-07-02 19:03:18 -05:00
Michael Wiencek
b8234bfdf4 Merge pull request #129 from zas/discid
Use python-discid instead of libdiscid
2013-07-02 16:59:39 -07:00
Michael Wiencek
6bbf7b75e5 Merge branch 'master' of github.com:musicbrainz/picard 2013-07-02 18:41:49 -05:00
Michael Wiencek
c6494fa18f Move the VA file naming upgrade to the new hook system 2013-07-02 18:40:40 -05:00
Michael Wiencek
5182c46f67 Merge pull request #141 from zas/remove_parserfilename
Unused file, only one function never called, test part broken since 2006
2013-07-02 16:31:44 -07:00
Laurent Monin
b9477ed92b Unused file, only one function never called, test part broken since 2006 2013-07-03 01:28:17 +02:00
Laurent Monin
07424f2b75 Fix duplicate CD drives in the drop-down: "D:" and "D:\", on Windows 2013-07-03 00:44:32 +02:00
Sebastian Ramacher
529cc4e495 Also try to use python-libdiscid
python-libdiscid is another libdiscid binding that also provides a python-discid
compatible interface in libdiscid.compat.discid.

Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at>
2013-07-03 00:44:32 +02:00
Laurent Monin
2fae933a6c Ensure each drive is present at most once in the list.
When Picard legacy method to list drives returns one that is already
set by python-discid (which is very likely on Windows systems).
2013-07-03 00:44:32 +02:00
Laurent Monin
b4378041e7 Add uniqify() helper function to uniqify a list
From http://www.peterbe.com/plog/uniqifiers-benchmark
2013-07-03 00:44:32 +02:00
Laurent Monin
b968b44152 Use discid/libdiscid drive auto detection, especially on first start
It will add default drive as returned by libdiscid to the list of known drives
Ie. on linux, list is : /dev/cdrom, /dev/sr0, /dev/sr1 (default link + 2 sata cd readers)

On first start it will populate the list with default drive provided by libdiscid,
which means Picard is now able to scan CD without going to Options (to set
cd reader) first, which was not the case before.
2013-07-03 00:44:32 +02:00
Laurent Monin
f742a46846 Use python-discid instead of libdiscid.
Python-discid (http://python-discid.readthedocs.org) is a Python binding of libdiscid.
It resolves http://tickets.musicbrainz.org/browse/PICARD-503
2013-07-03 00:44:32 +02:00
Michael Wiencek
9e8d494948 Merge pull request #127 from zas/album_error
Improve feedback regarding album status
2013-07-02 15:32:44 -07:00
Michael Wiencek
b3fcb04f9c Merge pull request #131 from zas/update_config_2
Handle configuration file versions
2013-07-02 15:06:58 -07:00
Laurent Monin
ebceb8aa05 Switch tab title to Errors when needed. 2013-07-02 23:38:31 +02:00
Laurent Monin
31a928966a Display cover art errors associated with album if any 2013-07-02 23:38:31 +02:00
Laurent Monin
86ed552b21 Make modified releases a bit more obvious using a specific icon. 2013-07-02 23:38:31 +02:00
Laurent Monin
258e9c2084 Use info dialog to display per-album error log.
When an error occurs during loading of a release, it will be visible
in info dialog for this release (which was unused).

New icon was added to mark visually releases with errors, and scrollbars
will appear in info dialog if needed.
2013-07-02 23:38:31 +02:00
Michael Wiencek
694b1d6c58 Merge pull request #140 from zas/pep8
PEP8 compliance fixes
2013-07-02 14:17:34 -07:00
Laurent Monin
8d40e6700d pep8 fixes 2013-07-02 23:01:13 +02:00
Michael Wiencek
cd656964f1 Merge pull request #139 from zas/deprecated_unittest_aliases
Replace deprecated unittest aliases
2013-07-02 09:39:01 -07:00
Laurent Monin
1265d5fd1c PEP8 compliance fixes 2013-07-02 10:19:34 +02:00
Laurent Monin
97f00b2d29 Handle configuration file versions.
version_info was renamed PICARD_VERSION
version_string was renamed PICARD_VERSION_STR
short version string is stored in PICARD_VERSION_STR_SHORT (for display)

Hooks can be created to handle upgrades (ie. options renaming), see config.register_upgrade_hook() and config.run_upgrade_hooks()
2013-07-02 01:45:25 +02:00
Laurent Monin
329ed8cedb Deprecated failUnlessAlmostEqual() -> assertAlmostEqual()
http://docs.python.org/2/library/unittest.html#deprecated-aliases
2013-07-01 13:34:53 +02:00
Laurent Monin
60ed243470 Deprecated failUnlessRaises() -> assertRaises()
http://docs.python.org/2/library/unittest.html#deprecated-aliases
2013-07-01 13:33:42 +02:00
Laurent Monin
6062fe404e Deprecated failIfEqual() -> assertNotEqual()
http://docs.python.org/2/library/unittest.html#deprecated-aliases
2013-07-01 13:31:41 +02:00
Laurent Monin
403bafbbaa Deprecated failUnlessEqual() -> assertEqual()
http://docs.python.org/2/library/unittest.html#deprecated-aliases
2013-07-01 13:29:57 +02:00
Michael Wiencek
fe17c2cb3c Copy value list in Metadata.update 2013-06-30 17:56:26 -05:00
Michael Wiencek
fd30cb62ee functools.partial is 2.5+ 2013-06-30 16:15:27 -05:00
Michael Wiencek
b1980e6ac8 Merge pull request #126 from mwiencek/throttle-gui
Add @throttle decorator to reduce the number of GUI updates
2013-06-30 14:02:46 -07:00
Michael Wiencek
90c43c72e1 Add @throttle decorator to reduce the number of GUI updates 2013-06-30 16:00:22 -05:00
Michael Wiencek
5568dc7c3e Merge pull request #134 from zas/status_icons
Display icons with tooltip instead of text for counters in status bar
2013-06-30 13:39:37 -07:00
Laurent Monin
1802208d69 Use a green down arrow as download icon instead of globe.
In 16x16 globe is too complex, arrow is much more legible.
2013-06-30 22:01:21 +02:00
Laurent Monin
a545c10cad Merge remote-tracking branch 'upstream/master' into status_icons 2013-06-30 21:50:39 +02:00
Laurent Monin
748502419a Remove incorrect author from header. 2013-06-30 21:49:26 +02:00
Michael Wiencek
befd8d8f57 Merge pull request #138 from zas/parse_amazon_url
Create a function to parse amazon urls and reduce code redundancy.
2013-06-30 10:45:27 -07:00
Michael Wiencek
910725ed70 Merge pull request #136 from zas/resources_tools
Improve resources tools
2013-06-30 10:39:52 -07:00
Laurent Monin
f892444998 Create a function to parse amazon urls and reduce code redundancy.
A test for amazon url parsing was added.
2013-06-30 17:25:15 +02:00
Laurent Monin
c8af60e21a Use unix eol in generated ressource file. 2013-06-30 05:04:47 +02:00
Laurent Monin
0661491f37 Use len() instead of a counter. 2013-06-30 05:02:45 +02:00
Laurent Monin
746fa31286 Use resources makeqrc and compile code, reducing code redundancy.
An empty __init__.py file was added so functions can be imported.
2013-06-28 12:39:53 +02:00
Laurent Monin
26f595a068 Mark compile.py and makeqrc.py as executables, they have python bang path. 2013-06-28 12:39:42 +02:00
Laurent Monin
b974a9cf63 Make compile.py runnable from anywhere and importable. 2013-06-28 12:39:30 +02:00
Laurent Monin
5f5afa7d02 Add script to generate picard.qrc from png images in images directory 2013-06-28 12:39:16 +02:00
Laurent Monin
22d99966dc Move source images (.psd, .svg) from images to img-src directory 2013-06-28 12:39:02 +02:00