fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-02-28 02:23:58 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,709 Commits 1 Branch 0 Tags
8bca1ecfbb7a809eb56e4bcb911f5207fa84edf1
Commit Graph

2709 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Frederik "Freso" S. Olesen
8bca1ecfbb addrelease.py: Use approximated "~length" for Recordings. 
Recordings don't support sub-second time precision, so the
track.metadata.length used for the two Add...AsRelease classes will
cause an error on /recording/create's "length" field.
track.metadata["~length"] contains the time converted to mm:ss format
and will not cause the error on /recording/create, so this commit
changes AddFileAsRecording to use that.
 2014-04-08 21:55:12 +02:00
Frederik "Freso" S. Olesen
b765452aac addrelease.py: Define form_values in __init__(). 
See https://github.com/musicbrainz/picard/pull/271/files#r11352974
 2014-04-07 23:00:54 +02:00
Frederik "Freso" S. Olesen
464aa50298 addrelease.py: Revert change to PLUGIN_NAME. 
Per nikki's comment on pull request #271:
https://github.com/musicbrainz/picard/pull/271#discussion_r11242854
 2014-04-05 13:17:01 +02:00
Frederik "Freso" S. Olesen
77af0591b0 addrelease.py: Improve PEP8 compliance (E701). 
Fixing instance of error E701: multiple statements on one line (colon).
 2014-04-02 17:57:03 +02:00
Frederik "Freso" S. Olesen
bf0fab7f3d addrelease.py: Update plugin metadata. 
- Add Freso to PLUGIN_AUTHOR
- Update PLUGIN_NAME and _DESCRIPTION to describe added file
  functionality.
- Increment PLUGIN_VERSION to 0.5.
 2014-04-02 17:50:32 +02:00
Frederik "Freso" S. Olesen
ddcf02b339 addrelease.py: Add AddFileAsRelease class. 
Allows for easily adding single files (which can't be clustered) as releases.
 2014-04-02 17:44:48 +02:00
Frederik "Freso" S. Olesen
eaa5474445 addrelease.py: Add AddFileAsRecording class. 
Allows for easily adding individual files as standalone recordings.
 2014-04-02 17:22:41 +02:00
Frederik "Freso" S. Olesen
713061b82f addrelease.py: Abstract out submission URL. 2014-04-02 17:20:24 +02:00
Frederik "Freso" S. Olesen
060f2a3812 addrelease.py: Abstract .callback() to parent class. 
Child classes now just need to define object type, NAME, and the
set_form_values() method - and reigster_*_action.
 2014-04-02 16:36:40 +02:00
Frederik "Freso" S. Olesen
fe06a50369 addrelease.py: Refactor AddClusterAsRelease. 
Abstract out some of the functionality all clumped together in
AddClusterAsRelease.callback() to methods of new parent class
AddObjectAsEntity.
 2014-04-02 16:13:13 +02:00
Laurent Monin
49ccc572dc Merge pull request #246 from m42i/highlighting_comments 
Highlighting $noop() comments differently
 2014-03-31 23:54:26 +02:00
Laurent Monin
0863b1e956 Merge pull request #261 from Sophist-UK/sophist_move_MEDIA_TAGS 
Move and rename default preserved tags
 2014-03-31 20:24:53 +02:00
Laurent Monin
fc1d24e276 Merge pull request #264 from DanMan/master 
Store ReplayGain info for MP3s in ID3v2 instead of APE tags
 2014-03-31 14:47:34 +02:00
Sophist
207e7de8b1 Switch back to PRESERVED_TAGS 2014-03-31 07:24:50 +01:00
Laurent Monin
102f03df40 Merge pull request #267 from Sophist-UK/sophist_correct_absolutetracknumber_variable 
Make code clearer (as suggested by jesus2099)
 2014-03-30 13:17:34 +02:00
Sophist
070f8939fd Make code clearer (as suggested by jesus2099) 2014-03-30 11:27:26 +01:00
Laurent Monin
61c7a340a9 self.log -> log 
Forgotten during 201cdc269c
 2014-03-29 13:44:08 +01:00
Laurent Monin
1aa619b923 Merge pull request #244 from zas/order_collections 
PICARD-561: keep collections ordered like on the website
 2014-03-29 13:29:59 +01:00
DanMan
af693808d7 Store ReplayGain info for MP3s in ID3v2 instead of APE tags (supported for years now) 2014-03-28 21:21:06 +01:00
Wieland Hoffmann
4dc1e36332 Merge branch 'sophist_hide_whatsthis_button' of github.com:Sophist-UK/picard 2014-03-28 16:17:11 +01:00
Wieland Hoffmann
c66ce78d64 Remove a commented print statement 2014-03-28 16:02:49 +01:00
Wieland Hoffmann
5552ddff38 Use None to denote a missing upper bound for script function arguments 2014-03-28 16:01:21 +01:00
Wieland Hoffmann
a299ae72dd Reorder imports 2014-03-28 15:52:52 +01:00
Wieland Hoffmann
93e80a8735 Use namedtuples for repeated access to the same elements 
The position of the elements int he tuple have a meaning, this helps
understanding it when reading the code.
 2014-03-28 15:50:59 +01:00
Wieland Hoffmann
e90ceb9ab0 Merge branch 'Sophist-UK-sophist_better_script_functions_num_args_check' 2014-03-28 15:28:35 +01:00
Laurent Monin
875c48245c Merge pull request #251 from Sophist-UK/sophist_add_trackid_variable_Picard-527 
Add %_musicbrainz_tracknumber% to fix Picard-527 ...
 2014-03-28 07:55:20 +01:00
Sophist
d65ecf4bdd Switch to ~musicbrainz_tracknumber 2014-03-27 20:23:23 +00:00
Laurent Monin
8ab5d6ae4b Merge pull request #258 from Sophist-UK/sophist_fix_minor_bugette_in_plugins 
Possible minor bugette in plugin.py
 2014-03-26 15:50:23 +01:00
Sophist
2fbde0ee13 Move and rename default preserved tags 
so that they can be used by other modules.
 2014-03-26 11:43:24 +00:00
Sophist
7233604143 Improve script check for number of args. 
Remove the need for specifying check_argcount=False if function uses
*args.

expected_args is now a 2-value tuple with lower and upper range of
argument counts.

Also, looks like a bug in calc if there were defaults.

Commented print string left in so correct range can be verified if
needed.
 2014-03-25 21:17:52 +00:00
Sophist
5c25d56b7d No known instances of this problem but ... 
... if plugin was located in picard.plugins_fake.smurf then module would
be set to "fake.smurf" rather than None.
 2014-03-25 20:19:56 +00:00
Laurent Monin
70b2c7dea1 Merge pull request #257 from Sophist-UK/sophist_fix_test_bytes2human 
Fix test bytes2human on Windows
 2014-03-24 21:32:53 +01:00
Sophist
b80091b56e Use Universal Newline Support instead. 2014-03-24 20:11:14 +00:00
Laurent Monin
b07cd3739a Merge pull request #255 from Freso/cleanup-contrib-plugins 
Clean up contrib plugins
 2014-03-24 14:14:38 +01:00
Sophist
78d2ebf9a3 Strip CR as well as LF to avoid errors on Windows 2014-03-24 07:42:40 +00:00
Frederik "Freso" S. Olesen
511cc3c24d Remove open_in_gui.py plugin. 
The functionality is included in Picard's core now, so there is no
need for a plugin to do it as well.
 2014-03-23 07:55:30 +01:00
Frederik "Freso" S. Olesen
fcc42fbb12 Remove old/* plugins. 
It's been almost 3 years since they were moved to the old/ folder, and
apparently they've not been needed enough by anyone to get an update
to current plugin API. If ever they're deemed useful again, they can
be pulled back via Git and updated.
 2014-03-23 07:23:34 +01:00
Laurent Monin
148041e794 Sort collections list in a similar way than on the website 
Not perfect, but simple enough.
 2014-03-22 12:46:41 +01:00
Sophist
173332cf71 Move common code to a new PicardDialog class... 
... and make existing dialogs sub-classes of this.
 2014-03-21 22:08:53 +00:00
Sophist
0042acb7fc Hide whatsthis button from dialog boxes 
Whatsthis button does not do anything.
 2014-03-21 22:08:51 +00:00
Sophist
d5e831b119 Add NEWS.txt 2014-03-21 22:00:39 +00:00
Sophist
8a27055020 Add %_trackindex% to fix Picard-527 ... 
... for e.g. Vinyl whose tracks are numbered A1, A2, ..., B1, B2, ...
 2014-03-21 21:58:55 +00:00
Laurent Monin
838655a2c8 Merge pull request #245 from Sophist-UK/sophist_fix_throttle_decorator 
Fix throttle decorator function so that it uses args from last call before timer triggers rather than args when timer was set.
 2014-03-21 22:36:14 +01:00
Sophist
c163afc490 Remove partial (bitmap comment) 2014-03-21 19:48:03 +00:00
Lukáš Lalinský
0f3928809d Move sip import to the picard_test command 2014-03-21 10:52:42 +01:00
Laurent Monin
fcdeb45033 Merge pull request #252 from Sophist-UK/fix_PR_225_when_locale_not_en 
Fix PR #225 when translate language is not en...
 2014-03-21 10:52:11 +01:00
Sophist
754b75f0dd Fix PR #225 when translate language is not en... 
... and there are no correct locales in the artist sort-name node.
 2014-03-21 07:38:57 +00:00
Laurent Monin
c80ea4d81c Fix Refresh action 
```
AttributeError: 'CollectionMenu' object has no attribute 'refresh_action'
```
 2014-03-20 13:43:05 +01:00
m42i
2e7e24c4f7 Rename regex variable to bracket_re 2014-03-20 12:33:13 +01:00
Laurent Monin
356909c062 Merge pull request #249 from Sophist-UK/sophist_fix_lyrics_display 
Fix lyrics tag displays with []
 2014-03-20 11:29:29 +01:00