Commit Graph

8912 Commits

Author SHA1 Message Date
Philipp Wolfer
a67d1a2bbf Use an enum for ShortenMode in util.filenaming 2022-03-02 09:33:58 +01:00
Laurent Monin
3c39156e3d Merge pull request #2072 from phw/remove-htmlescape
Remove picard.util.htmlescape
2022-03-02 09:01:40 +01:00
Philipp Wolfer
b21b553561 Remove picard.util.htmlescape
It is only a thin wrapper around html.escape only used at a single place, and it sets quote=False, which is a dangerous default. Use html.escape directly.
2022-03-01 23:34:43 +01:00
Philipp Wolfer
6a261c7fde PICARD-2430: addrelease: Use html.escape directly
Fixes issues with picard.util.htmlescape not escaping quotation marks.
2022-03-01 20:39:35 +01:00
Philipp Wolfer
3ae2bd2f59 PICARD-2425: Handle possible exceptions with os.path.realpath
E.g. on Windows this can cause exceptions if drives are mounted without mount manager.
2022-02-27 15:23:45 +01:00
Philipp Wolfer
735a4416f4 Update constants
Adds support for new medium formats and "Withdrawn" / "Cancelled" release states
2022-02-27 11:01:49 +01:00
Philipp Wolfer
a1a067a0b7 Enabled Polish translation for Windows installer
Translation by Michał Furmański
2022-02-18 08:19:04 +01:00
Laurent Monin
7fd41e7b4b Merge pull request #2068 from phw/PICARD-2423
PICARD-2423: Fix moving all files from album to unclustered
2022-02-17 19:05:43 +01:00
Philipp Wolfer
bb36965ae0 PICARD-2423: Fix moving all files from album to unclustered 2022-02-17 11:41:42 +01:00
Philipp Wolfer
170772e670 Fixed matching files to albums with no matching MBID 2022-02-17 09:25:10 +01:00
Laurent Monin
b9f81e3c91 Merge pull request #2067 from phw/refactor-similarity-utils
Refactor similarity utils
2022-02-17 09:13:03 +01:00
Philipp Wolfer
146b2da6f9 Use generator comprehension instead of inline functions 2022-02-17 08:18:26 +01:00
Philipp Wolfer
e1c6234dd7 Have find_best_match and sort_by_similarity accept any iterable 2022-02-17 08:18:26 +01:00
Philipp Wolfer
159deb299a PICARD-2421: Fixed exception on album load if file's MBID do not match any track 2022-02-17 08:17:56 +01:00
Philipp Wolfer
668ccbdcd8 Update picard.pot 2022-02-17 07:58:20 +01:00
Philipp Wolfer
c052c8e524 Merge pull request #2066 from phw/PICARD-2422-remove-acousticbrainz
PICARD-2422: Remove AcousticBrainz analysis and submission
2022-02-17 07:57:30 +01:00
Philipp Wolfer
849dcc9c12 PICARD-2421: Consider MB track ID when matching tagged files to albums
Instead of only matching by recording ID also use the track ID. In case of ambiguity consider the track duration to find the better match.
2022-02-17 07:56:42 +01:00
Philipp Wolfer
f6d3990a05 PICARD-2422: Added config upgrade for cleaning toolbar_layout 2022-02-16 18:16:47 +01:00
Philipp Wolfer
aeb1a7d5a8 PICARD-2422: Remove all AcousticBrainz extraction and submission code 2022-02-16 18:16:46 +01:00
Philipp Wolfer
5e3fa405af PICARD-2422: Removed packaging of AB streaming extractor 2022-02-16 11:46:21 +01:00
Philipp Wolfer
e9c6df2d3e Implement __bool__ and __repr__ for AcoustID Submission
Implementing __bool__ avoids checks like "if submission" to use __len__.
2022-02-14 09:55:40 +01:00
Philipp Wolfer
88e7766e5e Added test for AcoustID Submission.args without MBID 2022-02-14 08:38:43 +01:00
cybersphinx
f575a8f9f6 Fix crash on loading files with ACOUSTID_FINGERPRINT tag.
Introduced by https://github.com/metabrainz/picard/pull/2045
(PICARD-2396), specifically 62da04f831
2022-02-14 07:53:39 +01:00
Laurent Monin
e481469acb Merge pull request #2062 from phw/PICARD-2417-macos-treeview-collapse-with-left-key
PICARD-2417: Fix collapsing tree view items with LEFT key on macOS
2022-02-13 23:26:12 +01:00
Philipp Wolfer
eab689eef9 PICARD-2417: Fix collapsing tree view items with LEFT key on macOS
Force enabling the SH_ItemView_ArrowKeysNavigateIntoChildren style hint on all platforms.
2022-02-13 17:11:52 +01:00
Philipp Wolfer
3386d46770 Updated translations from transifex 2022-02-12 18:50:17 +01:00
Philipp Wolfer
628c82d8ea Merge pull request #2061 from phw/PICARD-2411-flac-fix-seektable
PICARD-2411: FLAC fix seektable changes
2022-02-11 17:16:23 +01:00
Philipp Wolfer
f20e47ae77 PICARD-2411: Remove Flac seektable if it has no seekpoints
A missing seektable is valid. Removing an otherwise empty seektable fixes the issues with software that cannot handle empty seektables.

Fully reconstructing a seek table would require decoding the Flac data.
2022-02-11 15:01:51 +01:00
Philipp Wolfer
f94c725f50 PICARD-2411: Flac seektable tests 2022-02-11 15:01:51 +01:00
Philipp Wolfer
9e632f1acb PICARD-2411: Moved FLAC seektable fix into separate function 2022-02-11 15:01:51 +01:00
Marcin Szalowicz
11c405fd17 PICARD-2411: Fix Flac SeekPoints creation with missing SeekTable
With this patch if the SeekTable is gone or empty,
we try to recreate it using SeekPoints with a step of 4096 samples
If that's not possible we remove SeekTable at all.
2022-02-11 15:01:51 +01:00
Philipp Wolfer
d34df0049c CI: Run tests on windows-2019 explicitly
Ensures that Python 3.6 is available
2022-02-11 14:59:08 +01:00
Philipp Wolfer
8b8593b546 PICARD-2414: Added some additional tests for tracknum_and_title_from_filename
Test some more real world examples and ignore cases like UB40 where a no. follows directly on alphanumeric characters.
2022-02-11 11:01:33 +01:00
Laurent Monin
76f9d44cdc Update headers 2022-02-07 09:44:34 +01:00
Laurent Monin
2f6479747d Update headers 2022-02-07 09:41:57 +01:00
Philipp Wolfer
20ec8078cf Update picard.pot 2022-02-07 07:47:00 +01:00
Laurent Monin
0c78dd3755 Merge pull request #2059 from zas/fix_flac_seektable
PICARD-2411: Add option to fix seektable for flac files
2022-02-06 16:47:41 +01:00
Laurent Monin
5b9b7fcc51 Fix missing whitespaces after comma (PEP8) 2022-02-05 17:58:37 +01:00
Marcin Szalowicz
fa2e443021 Add option to fix seektable for flac files
This is to fix problem with Kodi which is unable to load files
that have empty SeekTable, so by default a single SeekPoint is added.
An error message is logged if the file has no samples.
2022-02-05 17:51:00 +01:00
Philipp Wolfer
f331a1104c Merge pull request #2058 from zas/translate_artist_node_cleanup
Translate artist node cleanup
2022-02-03 17:04:54 +01:00
Laurent Monin
310c2baed0 _translate_artist_node(): shorten long lines a bit 2022-02-03 10:32:43 +01:00
Laurent Monin
203933ff9f Add few tests for translate_artist_names_script_exception 2022-02-03 10:31:54 +01:00
Philipp Wolfer
9e740c11a4 Omit standard ports in URLs constructed by build_qurl 2022-01-31 07:49:21 +01:00
Philipp Wolfer
14e46aba02 Update picard.pot 2022-01-30 16:16:04 +01:00
Philipp Wolfer
803055a9f9 PICARD-2410: Implement parsing Whipper ripping log files 2022-01-30 15:34:17 +01:00
Philipp Wolfer
3ae6706b05 Moved calculate_mb_toc_numbers to picard.disc.utils 2022-01-30 15:34:17 +01:00
Philipp Wolfer
89bc0cbecb Update picard.pot 2022-01-28 13:45:34 +01:00
Laurent Monin
8fa263613e Merge pull request #2055 from rdswift/clarify_script_types_in_strings
Clarify script types in strings in the UI files
2022-01-28 12:16:10 +01:00
Laurent Monin
885db0c6f5 Merge pull request #2054 from phw/cdtoc-url-lookup
PICARD-2409: Search for cdtoc URL triggers CD lookup
2022-01-28 12:15:43 +01:00
Philipp Wolfer
b815645961 FileLookup: Renamed variable mbid -> id 2022-01-28 08:16:45 +01:00