Commit Graph

2325 Commits

Author SHA1 Message Date
Laurent Monin
a7151fa4d8 PICARD-539: ensure we append preferred encoding to normalized locale
http://tickets.musicbrainz.org/browse/PICARD-539
2013-12-15 10:50:37 +01:00
Michael Wiencek
508b327a8c Merge pull request #189 from Freso/support-m4v
Support .m4v files.
2013-12-12 09:26:21 -08:00
Laurent Monin
1bd3d5cf36 Merge pull request #184 from zas/MainWindowSelectionUpdatedSignal
Emit a signal when selection is updated in the main window
2013-12-09 01:29:29 -08:00
Laurent Monin
024a68bafd Merge pull request #183 from zas/QCoreApplication
Set QApplication.applicationName and organizationName
2013-12-09 01:28:11 -08:00
Laurent Monin
a63f82ffbd Emit a signal when selection is updated in the main window
Bump plugin api version to 1.3.0
2013-12-09 10:05:27 +01:00
Laurent Monin
898ec8cb4b Set QApplication.applicationName and organizationName
Those values are used by the QSettings class when it is constructed using the empty constructor.
This saves having to repeat this information each time a QSettings object is created.
Some libs (ie. Phonon) require those to be set
2013-12-09 10:03:56 +01:00
Frederik "Freso" S. Olesen
8896ea6241 Support .m4v files.
http://chatlogs.musicbrainz.org/musicbrainz/2013/2013-12/2013-12-08.html#T12-42-40-561267
2013-12-08 14:50:38 +01:00
Laurent Monin
42d47f3113 Merge pull request #185 from zas/pluginshomepath
Open "Install plugin" dialog with user's home directory instead of '/'
2013-12-07 17:07:04 -08:00
Laurent Monin
cd8685d6a2 Open "Install plugin" dialog with user's home directory instead of '/' 2013-12-06 20:37:54 +01:00
Laurent Monin
b115d6ca0d Merge pull request #182 from zas/url_constants
Centralize Picard urls in PICARD_URLS dict, introduce webbrowser2.goto()
2013-12-05 23:51:12 -08:00
Laurent Monin
775cd512c7 Centralize Picard urls in PICARD_URLS dict.
Introduce `webbrowser2.goto()`, which open picard urls by id.
2013-12-06 08:47:40 +01:00
Laurent Monin
963c6518b5 Merge pull request #158 from zas/releases_disambiguation
Add more info to release name in other releases list if needed (improved disambiguation).
2013-12-05 23:46:28 -08:00
Laurent Monin
e9bd756144 Add more info to release name in other releases list if needed.
Context menu listing other releases is using main information from release,
often it is enough, but sometimes two or more items in the list are exactly
the same, user have to select each one to determine which is matching for him.

This patch is improving a bit the situation by adding packaging, barcode, or even
disambiguation comment if needed.
As an example, it often happens when a CD is released in jewel case and digipak,
with same label, date, country, barcode, etc..

Use more explicit '[no barcode]' instead of '[none]'.

A test case was added for this feature.
2013-12-06 08:43:23 +01:00
Laurent Monin
7251475bbe Merge pull request #166 from Sophist-UK/sophist_improve_xmls_prioritisation
Improve webservice prioritisation.
2013-12-05 23:21:07 -08:00
Sophist
b9648c332d Address Fresno comment
Put important back to True so that this is LIFO on the priority queue.
2013-12-05 17:21:51 +00:00
Sophist
7f036beef3 Space moved
As per bitmap's review comments, I have relocated the errant space from
one file to the other.

Damn pesky spaces - always sneaking off and repositioning themselves
where you don't want 'em.
2013-12-05 17:21:49 +00:00
Sophist
11ef698608 Tweak when we prioritise and don't cache 2013-12-05 17:21:04 +00:00
Sophist
c3e57a3879 Improve webservice prioritisation.
Ctrl-F5 Refresh - Priority/Important
Redirect - Priority/Important
Saves/submissions - Priority/Not-Important
Everything else - Normal
2013-12-05 17:21:03 +00:00
Laurent Monin
1ee1f68899 Merge pull request #178 from mwiencek/win32-locking
PICARD-437: Picard can have problems saving files to network shares on Windows 8(?) when embedding cover art
2013-12-05 00:27:14 -08:00
Laurent Monin
fdfeaf98a7 Merge pull request #167 from Sophist-UK/sophist_mblogin_calls_use_SSL
Use SSL for personal data, see PICARD-337.
2013-12-05 00:25:04 -08:00
Laurent Monin
892f272df7 Merge pull request #113 from Sophist-UK/sophist_prevent_duplicate_record_labels
Prevent duplicate record labels in tags.
2013-12-04 23:56:39 -08:00
Laurent Monin
e6dfe1695d Merge pull request #162 from Sophist-UK/sophist_counter_throttle_tweak
Simplify and improve active requests counting
2013-12-04 11:47:18 -08:00
Laurent Monin
fb06f7be1b Merge pull request #175 from JonnyJD/make_depends
Fix install/build instructions for Windows
2013-12-04 02:53:34 -08:00
Michael Wiencek
d6cd0cc90f Merge pull request #180 from Sophist-UK/sophist_add_missing_tag_names
Add missing originalyear name.
2013-12-03 09:44:04 -08:00
Lukas Lalinsky
8acd159528 Execute makensis.exe directly, so that bdist_nsis can be scripted 2013-12-03 15:45:22 +00:00
Sophist
680b6ff510 Avoid wait until timer gets to zero ...
... to avoid delay if we are adding a request for a new host.
2013-11-30 19:07:52 +00:00
Sophist
5ede83cefb Move decrement to end of request processing...
... to avoid counter going to zero and then up again.
2013-11-30 15:25:52 +00:00
Sophist
deaf3d3779 Add missing tag names 2013-11-30 13:58:11 +00:00
Johannes Dewender
b0e646d950 add chromaprint to optional dependencies 2013-11-27 01:39:47 +01:00
Wieland Hoffmann
7a1d071907 Regenerate picard.pot 2013-11-26 22:36:58 +01:00
Johannes Dewender
4c73ab24c6 explain sudo 2013-11-26 22:00:02 +01:00
Johannes Dewender
51711e7d53 shorter Windows build instructions 2013-11-26 21:55:51 +01:00
Michael Wiencek
04a1ca3c91 Merge pull request #125 from xlotlu/master
New approach to file renaming
2013-11-26 12:06:05 -08:00
Sophist
7c4840083c Address comments
Reduce down to one counter variable.
Eliminate decrement at unqueue/increment at start request
Update counter emit aligned with counter increment/decrement.
2013-11-26 17:50:51 +00:00
Sophist
07839f8ca9 Show total rather than max
Unsure why previous code showed max of queued and active rather than the
total of the two.
2013-11-26 17:32:50 +00:00
Sophist
a5d8317101 Address bitmap comments
Add MUSICBRAINZ_SERVERS constant and use this in options/general and to
decide SSL for mblogin webservice.
2013-11-26 17:29:01 +00:00
Sophist
5e1ab48349 Address bitmap review comment 1
This is definitely nicer code.
2013-11-26 17:27:08 +00:00
Sophist
af1b16b954 Use SSL for personal data
Currently only user name/password is encrypted using HTTP basic
encryption, but user's personal data (e.g. collections) is not
encrypted.

It is now generally accepted that all personal data should be encrypted,
and this fix applies encryption to any mblogin network requests (which
implies personal data is being loaded / saved).
2013-11-26 17:27:07 +00:00
Sophist
3b6632637f Prevent duplicate catalog numbers in tags
There are examples in MB database of two label/catalog numbers where
labels are different but catalog numbers are the same. Since these are
is stored in separate tags, this fix avoid duplicate catalog numbers.
2013-11-26 17:22:24 +00:00
Sophist
7abd37ad6b Prevent duplicate record labels in tags.
Picard receives Labels/Catalog Number pairs and separates these into
different tags. Where a two catalog numbers are from the same Label, the
label gets duplicated in the label tag, and this fix prevents that.
2013-11-26 17:22:23 +00:00
Laurent Monin
a6a667b4a5 Merge pull request #176 from zas/metadatabox_columns_resize
Fix save/restore of metadata box column sizes.
2013-11-26 02:49:35 -08:00
Laurent Monin
c7d0a2c5f6 Revert "Merge pull request #159 from Sophist-UK/sophist_fix_compilation_identification"
This reverts commit 1c2a8a5890, reversing
changes made to 76d3493066.

This merge was premature.
2013-11-26 08:18:49 +01:00
Laurent Monin
25212db0c5 Merge pull request #172 from phw/browser_integration_localhost_only
Limit browser integration to localhost by default.

It can be changed in Advanced > Network > Browser Integration options.
Browser Integration options changes are now applied only after user validation.
2013-11-25 15:13:21 -08:00
Laurent Monin
1c2a8a5890 Merge pull request #159 from Sophist-UK/sophist_fix_compilation_identification
Fix compilation flag incorrectly set by Picard, track featured artists don't indicate compilation.

Sophist explained:
Ideally the MB database would show a secondary type of Compilation accurately, but since it (presumably) doesn't, Picard tries to determine whether it is a compilation by seeing if all the tracks are by the same artist, the implication being that it is a compilation album if there are tracks with different artists.

There are a few problems with this:

1. Picard was comparing both primary and secondary track artists, so if all tracks have the same main artist but some also have featured artists (which is NOT a compilation), then Picard was flagging this (incorrectly) as a compilation.

2. Picard was not checking the release-group secondary-type field for Compilation - so e.g. a Greatest Hits album is a compilation, but since often all tracks have the same artist, Picard was flagging this (incorrectly) as NOT a compilation.
2013-11-25 14:42:22 -08:00
Michael Wiencek
21c61b4bec Perform file locking on win32
The functions _insert_bytes_no_mmap and _delete_bytes_no_mmap call
mutagen.util.lock, which in turn uses the fnctl module which isn't
available on Windows.
2013-11-25 16:29:17 -06:00
Laurent Monin
76d3493066 Move CAA_HOST and CAA_PORT to const.py 2013-11-25 21:03:45 +01:00
Laurent Monin
ab4ae93ec7 Merge pull request #171 from phw/caa_host_constant
Add constants for cover art archive host and port.
2013-11-25 11:53:26 -08:00
Wieland Hoffmann
bfa59c989b replaygain: Fix the calculation on single tracks 2013-11-25 13:55:33 +01:00
Wieland Hoffmann
3f3ccde421 replaygain: Don't calculate album gains over NATs
The album gain values are now calculated per track and still saved.
2013-11-25 13:50:56 +01:00
Wieland Hoffmann
1e513b743e replaygain: Use a defaultdict in split_files_by_type 2013-11-25 13:29:13 +01:00