Commit Graph

2444 Commits

Author SHA1 Message Date
Laurent Monin
a94c76be49 Add note to NEWS.txt about PICARD-205 being fixed. 2014-03-06 23:09:40 +01:00
Frederik "Freso" S. Olesen
c24aac4aa8 Build picard-countries.po for enabled languages. 2014-03-06 23:09:40 +01:00
Frederik "Freso" S. Olesen
24881451fb Set up Transifex to pull the country name translations. 2014-03-06 23:09:40 +01:00
Wieland Hoffmann
8fc100c40d Use getopt.gnu_getopt
If you were ever annoyed by starting Picard from the console with a
specific folder, noticing you forgot the `-d`, stopping Picard, pressing
arrow-up, adding the `-d` to the end of the line, only to notice that
this didn't help at all, this commit is for you because now the option
parsing doesn't stop after the first thing that's not an option.
2014-03-06 23:09:39 +01:00
Wieland Hoffmann
aff7b1f045 Delete cover files after running TestCoverArt 2014-01-30 17:26:49 +01:00
Wieland Hoffmann
b2caf38dcc Use a _delete method for deleting temporary image files
__del__ was not getting called reliably when the interpreter shut down.
2014-01-30 17:22:11 +01:00
Wieland Hoffmann
9a4753109e Use md5 hashes to make sure every images is only saved once
make_and_add_image will use already existing images from Tagger.images
if the hash of the image is the same as that of an image in there.
2014-01-30 17:19:24 +01:00
Wieland Hoffmann
841fe9e522 Remove a super(...).__del__ call
`object` does not actually have a __del__ method
2014-01-30 00:54:09 +01:00
Wieland Hoffmann
23634fe8ee Use tempfile.mkstemp to get a closable tempfile
This makes sure we don't run out of file descriptors if many images get
loaded into Picard.
2014-01-29 19:38:02 +01:00
Wieland Hoffmann
fd4c31c10a tis -> this 2014-01-23 11:18:38 +01:00
Wieland Hoffmann
e0b99f44e5 Fix embedding only front images
by using the images is_front_image attribute
2014-01-23 11:17:49 +01:00
Wieland Hoffmann
8930778a50 Fix a typo
Not sure how that happened.
2014-01-23 00:49:58 +01:00
Wieland Hoffmann
1caf084685 Catch IOErrors and OSErrors when creating Images
They can happen if the disk is full or the user is not allowed to access
the folder where tempfile.TemporaryFile wants to create the file.
2014-01-23 00:08:58 +01:00
Wieland Hoffmann
030fb9b00b Use the same Image objects for all tracks of an album 2014-01-22 23:28:54 +01:00
Wieland Hoffmann
b3593896a8 Use a separate class for dealing with images
This new class stores the image data in a tempfile.TemporaryFile so we
don't keep the data for all images that are used somewhere in memory
anymore.

It also deals with saving images onto disk when the corresponding tracks
are saved (this was previously done by the File class). This removes the
ability to use tagger script in the cover file name (cf. the first line
of File._make_image_filename).
2014-01-22 23:28:54 +01:00
Laurent Monin
879fd9b5c7 Merge pull request #211 from Sophist-UK/sophist_fix_nat_refresh
Fix errors on refresh of NAT track (PICARD-549)
2014-01-13 02:27:07 -08:00
Sophist
1d7ccf4461 Apply patch provided by zas 2014-01-13 10:13:53 +00:00
Laurent Monin
427a1e666f Merge pull request #210 from zas/test_exit_code
Ensure setup.py returns non-zero exit code on test failure
2014-01-12 02:18:44 -08:00
Laurent Monin
2be60fae33 Returns exit code 1 if at least one test failed.
It should make travis-ci to report test failures when they actually fail.
Ie. build 169.1 has test failures, but build was happily reported as Passed,
this patch should change this.
2014-01-12 11:08:06 +01:00
Laurent Monin
0f9b04324c Fix AttributeError: 'MetadataBox' object has no attribute 'shrink_columns'
shrink_columns() was replaced by resize_columns() in commit 4c64a277cd
2014-01-10 14:52:29 +01:00
Michael Wiencek
4a4c9960a7 Merge pull request #188 from mwiencek/artists-tag
Support the Jaikoz 'artists' tag, which stores individual artist names
2014-01-09 12:21:29 -08:00
Michael Wiencek
fbbadc8f9d Merge branch 'master' into artists-tag
Conflicts:
	NEWS.txt
2014-01-09 14:21:04 -06:00
Michael Wiencek
3c0e588bbc Update NEWS.txt 2014-01-09 14:20:10 -06:00
Laurent Monin
9747a46780 Remove extra imports 2014-01-09 15:54:03 +01:00
Laurent Monin
d779fdc8d3 Merge pull request #208 from xlotlu/filenaming
updated tests for filename shortening (which now returns relative paths)
2014-01-07 08:16:47 -08:00
Ionuț Ciocîrlan
156aeda8a0 updated tests for filename shortening (which now returns relative paths) 2014-01-07 17:59:50 +02:00
Laurent Monin
08ce08caa2 Merge pull request #187 from zas/picard528
PICARD-528: ignore file paths if hidden or excluded by regex
2014-01-06 16:34:06 -08:00
Laurent Monin
8c2628638a Merge pull request #207 from olea/patch-1
Update copyright year in About
2014-01-06 16:31:16 -08:00
Ismael Olea
0d04cbdf8a Update about.py
updated copyright dates
2014-01-06 17:11:27 +01:00
Laurent Monin
cbcbc73408 Update README.md
Typo fix
2014-01-06 11:25:27 +01:00
Laurent Monin
3e83308357 Regenerate picard.pot 2014-01-05 14:01:09 +01:00
Laurent Monin
a8fa19588d Drop useless spaces in button label
It is problematic when it comes to i18n and is useless here.
2014-01-05 13:38:03 +01:00
Laurent Monin
f942b71fe6 Merge pull request #206 from xlotlu/filenaming
PICARD-540: return relative paths for shortened filenames
2014-01-04 12:59:33 -08:00
Ionuț Ciocîrlan
0a1b97732b PICARD-540: return relative paths for shortened filenames 2014-01-04 21:43:39 +02:00
Laurent Monin
45b9619b4c Regenerate picard.pot 2014-01-02 18:11:52 +01:00
Laurent Monin
a337e70bee Merge pull request #203 from zas/upgradepath3
Drop upgrade hook autodetection
2014-01-02 08:56:34 -08:00
Laurent Monin
1de7f3fa55 Update comment 2014-01-02 17:50:31 +01:00
Laurent Monin
861ed91800 Mark messages for translation. 2014-01-02 17:47:02 +01:00
Laurent Monin
d713d1cf00 Let version_from_string() raises an exception if hook name is incorrect 2014-01-02 17:36:29 +01:00
Laurent Monin
c2d53a4d4d version_from_string(): match end of the string instead full string 2014-01-02 17:32:34 +01:00
Laurent Monin
6e889ca0a0 Use exceptions in place of assertions -> VersionError 2014-01-02 17:28:41 +01:00
Laurent Monin
22271d880c Remove useless intermediate variable 2014-01-02 17:09:28 +01:00
Laurent Monin
708faa9ba4 _upgrade_hooks is now a dict, with version as key 2014-01-02 14:23:34 +01:00
Laurent Monin
57732ce17b Un-indent upgrade functions 2014-01-02 13:00:40 +01:00
Laurent Monin
d0005ccac9 Drop autodetection of hooks, but still extract version from hook name 2014-01-02 11:52:15 +01:00
Laurent Monin
81ec25afcd Make version_from_string() more tolerant 2014-01-02 11:50:51 +01:00
Laurent Monin
69f59348c1 Add a README.md 2014-01-02 03:38:59 +01:00
Laurent Monin
1f5c150f74 Merge pull request #202 from zas/upgradepath2
Improve and fix upgrade hooks code
2014-01-01 18:24:21 -08:00
Laurent Monin
432ef5b996 Log explicit messages for config upgrades and drop now useless comments
Use log.info() instead of log.debug() as it is useful for any user to know
config options were modified.
2014-01-02 03:20:25 +01:00
Laurent Monin
ef07fc2e90 Move upgrade code to its own file, no need to be a Tagger method 2014-01-02 03:20:25 +01:00