Commit Graph

8932 Commits

Author SHA1 Message Date
Philipp Wolfer
aaee5e4f37 PICARD-993: Have different error icons for different file errors
Separate icons for file not found, access denied and anything else
2022-03-12 10:28:42 +01:00
Aerozol
903ed4b59d PICARD-993: updated error symbol
replaced 'stop' symbol with 'exclamation' symbol, new icons for
permission errors and file not found
2022-03-12 10:28:12 +01:00
Philipp Wolfer
d1539a41c7 Merge pull request #2075 from phw/PICARD-2076-win-remove-path-length-limit
PICARD-2076: Remove Windows 259 characters path length limit
2022-03-09 08:55:11 +01:00
Philipp Wolfer
a1fafdc8d9 Add Windows version check to system_supports_long_paths() 2022-03-09 00:11:48 +01:00
Philipp Wolfer
af77d269cc Handle WinPathTooLong exception in script editor file naming examples 2022-03-08 23:10:06 +01:00
Philipp Wolfer
80ae11c466 Fix picard.util.normpath sometimes returning long paths without prefix
If the input path is a shortened DOS compatible path it might be shorter than WIN_MAX_FILEPATH_LEN, but after the call to realpath it gets expanded.
2022-03-08 23:06:17 +01:00
Philipp Wolfer
0ff523db9d PICARD-2076: Added tests for picard.util.system_supports_long_paths 2022-03-08 15:21:00 +01:00
Philipp Wolfer
dd1c2a9b36 PICARD-2076: Log long path support on start 2022-03-08 14:04:44 +01:00
Philipp Wolfer
b91eefe9ca PICARD-2076: Update renaming options UI
Fix tab stops and make Windows long path option available if Windows compatibility is active but disabled.
2022-03-08 14:00:26 +01:00
Philipp Wolfer
5c84b1a288 PICARD-2076: Show a warning when enabling windows long paths 2022-03-08 14:00:25 +01:00
Philipp Wolfer
cde45dc7c1 PICARD-2076: path node length limit on Windows is 255 2022-03-08 14:00:25 +01:00
Philipp Wolfer
718875177b PICARD-2076: Use Windows long path prefix only, if long paths are unsupported 2022-03-08 14:00:24 +01:00
Philipp Wolfer
5037ce9935 PICARD-2076: Allow ignoring the Windows filepath limit when renaming files 2022-03-08 14:00:24 +01:00
Philipp Wolfer
cd493cc8af Fixed tabulator order on general and metadata options 2022-03-08 14:00:06 +01:00
Philipp Wolfer
2bcc14274a Simplified renaming options UI
Move files is a QGroupBox, the childs get automatically enabled / disabled. No need to explicitly code this.
2022-03-08 10:05:17 +01:00
Philipp Wolfer
ec5ecc25f5 picard.util.enabledSlot is no longer needed
This was a workaround for PyQt4 and does also not apply to the cases here if connecting toggled to setEnabled
2022-03-08 10:05:17 +01:00
Philipp Wolfer
c04f143274 PICARD-1570: Allow loading files with long paths on Windows 2022-03-07 11:18:49 +01:00
Philipp Wolfer
6482e63825 Fix tag name "musicbrainz_trackid" for file naming examples
The internal tag name is "musicbrainz_trackid", not "musicbrainz_releasetrackid": "musicbrainz_trackid",
". The latter is just the name written out to some formats, because "musicbrainz_trackid" has already been used for the recording ID for historic reasons
2022-03-02 15:25:04 +01:00
Laurent Monin
4c98189289 Merge pull request #2071 from phw/util-filenaming-shortenmode-enum
Use an enum for ShortenMode in util.filenaming
2022-03-02 10:05:58 +01:00
Philipp Wolfer
d3ce968363 Style override must be set before theme gets setup 2022-03-02 09:41:12 +01:00
Philipp Wolfer
a67d1a2bbf Use an enum for ShortenMode in util.filenaming 2022-03-02 09:33:58 +01:00
Laurent Monin
3c39156e3d Merge pull request #2072 from phw/remove-htmlescape
Remove picard.util.htmlescape
2022-03-02 09:01:40 +01:00
Philipp Wolfer
b21b553561 Remove picard.util.htmlescape
It is only a thin wrapper around html.escape only used at a single place, and it sets quote=False, which is a dangerous default. Use html.escape directly.
2022-03-01 23:34:43 +01:00
Philipp Wolfer
6a261c7fde PICARD-2430: addrelease: Use html.escape directly
Fixes issues with picard.util.htmlescape not escaping quotation marks.
2022-03-01 20:39:35 +01:00
Philipp Wolfer
3ae2bd2f59 PICARD-2425: Handle possible exceptions with os.path.realpath
E.g. on Windows this can cause exceptions if drives are mounted without mount manager.
2022-02-27 15:23:45 +01:00
Philipp Wolfer
735a4416f4 Update constants
Adds support for new medium formats and "Withdrawn" / "Cancelled" release states
2022-02-27 11:01:49 +01:00
Philipp Wolfer
a1a067a0b7 Enabled Polish translation for Windows installer
Translation by Michał Furmański
2022-02-18 08:19:04 +01:00
Laurent Monin
7fd41e7b4b Merge pull request #2068 from phw/PICARD-2423
PICARD-2423: Fix moving all files from album to unclustered
2022-02-17 19:05:43 +01:00
Philipp Wolfer
bb36965ae0 PICARD-2423: Fix moving all files from album to unclustered 2022-02-17 11:41:42 +01:00
Philipp Wolfer
170772e670 Fixed matching files to albums with no matching MBID 2022-02-17 09:25:10 +01:00
Laurent Monin
b9f81e3c91 Merge pull request #2067 from phw/refactor-similarity-utils
Refactor similarity utils
2022-02-17 09:13:03 +01:00
Philipp Wolfer
146b2da6f9 Use generator comprehension instead of inline functions 2022-02-17 08:18:26 +01:00
Philipp Wolfer
e1c6234dd7 Have find_best_match and sort_by_similarity accept any iterable 2022-02-17 08:18:26 +01:00
Philipp Wolfer
159deb299a PICARD-2421: Fixed exception on album load if file's MBID do not match any track 2022-02-17 08:17:56 +01:00
Philipp Wolfer
668ccbdcd8 Update picard.pot 2022-02-17 07:58:20 +01:00
Philipp Wolfer
c052c8e524 Merge pull request #2066 from phw/PICARD-2422-remove-acousticbrainz
PICARD-2422: Remove AcousticBrainz analysis and submission
2022-02-17 07:57:30 +01:00
Philipp Wolfer
849dcc9c12 PICARD-2421: Consider MB track ID when matching tagged files to albums
Instead of only matching by recording ID also use the track ID. In case of ambiguity consider the track duration to find the better match.
2022-02-17 07:56:42 +01:00
Philipp Wolfer
f6d3990a05 PICARD-2422: Added config upgrade for cleaning toolbar_layout 2022-02-16 18:16:47 +01:00
Philipp Wolfer
aeb1a7d5a8 PICARD-2422: Remove all AcousticBrainz extraction and submission code 2022-02-16 18:16:46 +01:00
Philipp Wolfer
5e3fa405af PICARD-2422: Removed packaging of AB streaming extractor 2022-02-16 11:46:21 +01:00
Philipp Wolfer
e9c6df2d3e Implement __bool__ and __repr__ for AcoustID Submission
Implementing __bool__ avoids checks like "if submission" to use __len__.
2022-02-14 09:55:40 +01:00
Philipp Wolfer
88e7766e5e Added test for AcoustID Submission.args without MBID 2022-02-14 08:38:43 +01:00
cybersphinx
f575a8f9f6 Fix crash on loading files with ACOUSTID_FINGERPRINT tag.
Introduced by https://github.com/metabrainz/picard/pull/2045
(PICARD-2396), specifically 62da04f831
2022-02-14 07:53:39 +01:00
Laurent Monin
e481469acb Merge pull request #2062 from phw/PICARD-2417-macos-treeview-collapse-with-left-key
PICARD-2417: Fix collapsing tree view items with LEFT key on macOS
2022-02-13 23:26:12 +01:00
Philipp Wolfer
eab689eef9 PICARD-2417: Fix collapsing tree view items with LEFT key on macOS
Force enabling the SH_ItemView_ArrowKeysNavigateIntoChildren style hint on all platforms.
2022-02-13 17:11:52 +01:00
Philipp Wolfer
3386d46770 Updated translations from transifex 2022-02-12 18:50:17 +01:00
Philipp Wolfer
628c82d8ea Merge pull request #2061 from phw/PICARD-2411-flac-fix-seektable
PICARD-2411: FLAC fix seektable changes
2022-02-11 17:16:23 +01:00
Philipp Wolfer
f20e47ae77 PICARD-2411: Remove Flac seektable if it has no seekpoints
A missing seektable is valid. Removing an otherwise empty seektable fixes the issues with software that cannot handle empty seektables.

Fully reconstructing a seek table would require decoding the Flac data.
2022-02-11 15:01:51 +01:00
Philipp Wolfer
f94c725f50 PICARD-2411: Flac seektable tests 2022-02-11 15:01:51 +01:00
Philipp Wolfer
9e632f1acb PICARD-2411: Moved FLAC seektable fix into separate function 2022-02-11 15:01:51 +01:00