fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-01-02 22:53:58 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,219 Commits 1 Branch 0 Tags
bbbbcbf116755fadf3ed4d6700a580bf9c39235b
Commit Graph

3219 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Laurent Monin
bbbbcbf116 Use Tango edit clear icon instead of Oxygen one 
It eases things regarding licensing stuff.

See https://github.com/musicbrainz/picard/pull/349#issuecomment-49479410
 2014-07-18 23:13:58 +02:00
Laurent Monin
7de238be99 Improve release group fallback option description 2014-07-18 22:34:26 +02:00
Laurent Monin
74e1034460 Use a more explicit description for release group image fallback feature 
Also, since option is now in CAA ui group, no need to indicate it is related to CAA.
 2014-07-18 12:10:35 +02:00
Laurent Monin
da2c976342 Resync translations 2014-07-17 11:29:50 +02:00
Laurent Monin
fcfb0a27c8 Update pot file 2014-07-17 11:28:07 +02:00
Laurent Monin
d87f5ecb9d Merge pull request #349 from zas/lineeditclear 
Add a clear button to the search line edit
 2014-07-17 11:24:19 +02:00
Laurent Monin
9c5c38ff8b Update NEWS.txt 2014-07-17 11:23:43 +02:00
Laurent Monin
f8f98cc0fe Merge remote-tracking branch 'upstream/master' into lineeditclear 2014-07-17 11:22:26 +02:00
Laurent Monin
994da0b1ac Prevent text to be drawn over the clear edit icon 2014-07-15 17:55:09 +02:00
Laurent Monin
d7622c2ffc Use QIcon.fromTheme() and use our own ressource as fallback 2014-07-15 12:56:31 +02:00
Laurent Monin
83d1c31735 Merge pull request #348 from zas/rg_coverart 
PICARD-418: fallback to using release group cover
 2014-07-15 01:19:11 +02:00
Laurent Monin
05a82917c4 Merge pull request #317 from Sophist-UK/sophist_fix_album_loading_duplicated_albumid 
PICARD-605: Make file loading more resilient
 2014-07-14 15:26:43 +02:00
Laurent Monin
2b827b4171 Add edit clear icon as resource 2014-07-14 13:11:31 +02:00
Laurent Monin
6e91f593ec Replace numeric error code by more explicit constant ContentNotFoundError 2014-07-13 23:22:10 +02:00
Laurent Monin
b67ab2fd87 Add a clear button to the search line edit 2014-07-13 20:41:46 +02:00
Laurent Monin
2c82dffc7d Inherit CaaCoverArtImage and CaaThumbnailCoverArtImage 
It eases debugging using classes named CaaCoverArtImageRg and CaaThumbnailCoverArtImageRg for release group fallback

Example of log line after this change:
D: 17:08:23 Cover art image downloaded: CaaCoverArtImageRg(url=u'http://coverartarchive.org/release/06c97185-65df-4c2b-b803-428c710bedc0/2153324479-500.jpg', types=[u'front'], is_front=True) [w=352 h=350 mime=image/jpeg ext=.jpg datalen=35765 file=/tmp/picardrdYsnE.jpg]
 2014-07-13 17:12:40 +02:00
Laurent Monin
f962617fbb Reduce code redundancy between classes 2014-07-13 16:56:02 +02:00
Laurent Monin
d57e636eb6 Update NEWS.txt 2014-07-13 16:40:26 +02:00
Laurent Monin
01e8a988d6 Ignore 404 errors for release group json 
We currently have no easy mean to know if there is cover art for the release group as we do for the release.

Not a perfect solution, ideas and patches are welcome.
We should not query the json file at all if we know there is no cover art for this release group.
 2014-07-10 12:49:29 +02:00
Laurent Monin
e46f4997b9 _caa_path() -> property 2014-07-10 12:31:05 +02:00
Laurent Monin
8f1a9b333c Do not hide exceptions from cover art providers 2014-07-10 12:29:51 +02:00
Laurent Monin
66718886de Make CoverArtProviderCaaReleaseGroup inherits from CoverArtProviderCaa 
It solved many issues, re-use json parsing code, and handling of various caa options (types, sizes, etc..)
 2014-07-10 12:05:17 +02:00
Laurent Monin
6706d57d35 Be sure to continue on next provider if no front image is found. 2014-07-09 21:23:15 +02:00
Laurent Monin
6e9fa8c5ed Remove useless line after acab1dc 2014-07-09 21:18:53 +02:00
Laurent Monin
54d3ccb8be Honour CAA image size preferences (full/250/500) 2014-07-09 21:15:43 +02:00
Laurent Monin
acab1dc985 Move fallback option to cover archive options group 2014-07-09 21:15:16 +02:00
Laurent Monin
932a3267b9 Fallback -> Fall back 2014-07-09 21:06:19 +02:00
Laurent Monin
b1c71c9686 Images can have other types (png, jpg, gif), remove '.jpg' 2014-07-09 19:50:19 +02:00
Laurent Monin
f75aa358fb PICARD-418: fallback to using release group cover 
It adds the option to use release group cover art from CAA.
It is required to enable CAA and release group fallback is disabled by default
 2014-07-09 12:22:57 +02:00
Wieland Hoffmann
84ffe3502f Fix the last commit 
because I forgot to `git add` the file again
 2014-06-28 21:14:13 +02:00
Wieland Hoffmann
50bc0755af Reset self.form_values after generating the HTML file 
Otherwise, :qa
 2014-06-28 21:12:52 +02:00
Laurent Monin
233e1403cb Merge pull request #345 from phw/fix-script-function-with-zero-arguments 
Fix evaluation of script functions with zero arguments.
 2014-06-26 11:18:15 +02:00
Philipp Wolfer
c6446626aa Better fix for script functions with zero arguments. 2014-06-25 22:08:10 +02:00
Laurent Monin
56d4d74ae0 Update translation files 2014-06-23 12:13:44 +02:00
Laurent Monin
21932662af Update picard.pot file 2014-06-23 12:08:44 +02:00
Laurent Monin
1884e4abba Merge pull request #347 from phw/fix-load-options-on-script-error 
Load the options dialog even if there is a ScriptError.
 2014-06-23 12:03:44 +02:00
Laurent Monin
d159fd6abe Merge pull request #346 from phw/plugin-fixes 
Fixed plugin precedence for the first plugin in plugin list.
 2014-06-23 12:03:22 +02:00
Philipp Wolfer
f2f8df11da Load the options dialog even if there is a ScriptError. 
Before a ScriptError, which is rasied for e.g. a missing function, the options dialog would not show up. This prevents the user from even fixing the scripting.
 2014-06-22 20:48:53 +02:00
Philipp Wolfer
aa89e5a3a3 Fixed plugin precedence for the first plugin in plugin list. 
If a plugin was in both the system wide and ther user's plugin folder and the plugin was the first in the list the plugin was loaded and listed twice.
 2014-06-22 20:25:46 +02:00
Philipp Wolfer
45984d0172 Fix evaluation of script functions with zero arguments. 2014-06-22 20:12:56 +02:00
Laurent Monin
050b81a16c Merge pull request #344 from xlotlu/master 
filename shortening needs file extension to make decisions.
 2014-06-21 20:09:42 +02:00
Ionuț Ciocîrlan
c60751559e filename shortening needs file extension to make decisions. 
closes #PICARD-613
 2014-06-21 20:26:14 +03:00
Wieland Hoffmann
d95a7221b1 Merge branch 'sophist_fix_default_naming_script' of https://github.com/Sophist-UK/picard 2014-06-20 10:31:49 +02:00
Wieland Hoffmann
9dfecd60bf Merge branch 'video' of https://github.com/phw/picard 2014-06-20 10:30:47 +02:00
Wieland Hoffmann
f41d3203fd Merge branch 'albumartist_website_fix' of https://github.com/zas/picard 2014-06-20 10:27:59 +02:00
Laurent Monin
e5953457b6 Not having 'relation_list' is not invalid, do not emit error message 
Error message is still emitted if metadata has no artist (which shouldn't happen for artist query)

E: 17:27:06 Album Artist Website: u'2451caed-5d09-456f-b640-5880b6060a64': MusicBrainz artist xml result not in correct format - {'attribs': {}, 'text': u'', 'children': {u'metadata': [{'attribs': {}, 'text': u'', 'children': {u'artist': [{'attribs': {u'type': u'Group', u'id': u'2451caed-5d09-456f-b640-5880b6060a64'}, 'text': u'', 'children': {u'name': [{'attribs': {}, 'text': u'Sir Frankie Crisp', 'children': {}}], u'sort_name': [{'attribs': {}, 'text': u'Sir Frankie Crisp', 'children': {}}]}}]}}]}}
 2014-06-20 10:10:10 +02:00
Laurent Monin
033d88362b Fix up albumartist_website plugin debug message 
Traceback (most recent call last):
  File "picard\webservice.pyo", line 285, in _process_reply
  File "C:\Program Files (x86)\MusicBrainz Picard\plugins\albumartist_website.py", line 95, in website_process
    log.debug("%s: %r: Artist Official Homepages = %s", PLUGIN_NAME, artistId, url)
NameError: global name 'url' is not defined
 2014-06-20 10:01:16 +02:00
Laurent Monin
68f88a73fe Merge pull request #339 from zas/config_path_in_debug 
Display configuration file or registry path in debug log
 2014-06-14 15:19:30 +02:00
Laurent Monin
c703d2cbb1 Merge pull request #338 from zas/cover_art_show 
Double-clicking on images in info dialog open them in external viewer
 2014-06-14 15:19:11 +02:00
Philipp Wolfer
4e89212940 Support .ogv video files 2014-06-13 19:17:51 +02:00