Antonio Larrosa
c67decd47e
Update file status after dropping images
2017-03-11 13:04:13 +01:00
Antonio Larrosa
cb07b7874e
Set the default empty cover art when there's no cover art to show
...
When there's no data, we should show the empty cover art box
2017-03-11 13:04:13 +01:00
Antonio Larrosa
0c7e2a0ecd
PEP8 fixes
2017-03-11 13:04:13 +01:00
Antonio Larrosa
d86d7f205b
Fix update of album original images
...
When the tracks of an album change their original images (for example,
because the tracks are saved and the original images change) then
them album also has to update its original images
2017-03-11 13:04:13 +01:00
Antonio Larrosa
b4bfaed65f
Update album images when an album is to be shown
...
When a user drops different images to be used as covers of
different tracks of the same album, the album's metadata.images list
didn't reflect these changes. This commit updates the list of images
so CoverArtBox always shows the correct values
2017-03-11 13:04:13 +01:00
Antonio Larrosa
14e2639e1a
Replace front images instead of appending them
...
When an image is dropped, replace the front image with the dropped one.
Appending front covers is counterintuitive
2017-03-11 13:04:13 +01:00
Antonio Larrosa
3dab58c22e
Draw stack of covers when metadata contains multiple images
...
Now CoverArtThumbnails uses all images in metadata to draw a stack
of covers so when a release contains files with different
original metadata covers that will be overwritten, the user
can intuitively see that.
2017-03-11 13:04:13 +01:00
Antonio Larrosa
876a3055b0
Add debug information
...
This will be removed later, but it's useful to see the actual metadata
arriving to CoverArtBox.
2017-03-11 13:04:13 +01:00
Antonio Larrosa
d5e91efb94
Store cover images in the cluster metadata
2017-03-11 13:04:13 +01:00
Antonio Larrosa
659c2a3a5b
Store cover images in the album original metadata
2017-03-11 13:04:13 +01:00
Lukáš Lalinský
4d698a3c6f
Merge pull request #651 from samj1912/fix-osx-builds
...
Fix OSX builds
2017-03-10 20:59:15 +01:00
Lukáš Lalinský
418b081869
Fix py2app version
2017-03-11 00:34:54 +05:30
Sambhav Kothari
d743329609
Dissolve the get_file_path method
...
It seems to be causing build errors with OSX. Moved the required LoC
to both itemviews and coverartbox
2017-03-11 00:34:53 +05:30
Sambhav Kothari
f9225f2eb8
Merge pull request #650 from metabrainz/revert-641-osx-package-env-rebuild
...
Revert "OS X package env rebuild"
2017-03-10 09:57:06 +05:30
Sambhav Kothari
8bc493fe10
Revert "OS X package env rebuild"
2017-03-10 02:50:43 +05:30
Laurent Monin
bbb46f64b0
Merge pull request #649 from samj1912/osx-test
...
Add OSX tests and a build matrix for different linux envs
2017-03-09 11:08:16 +01:00
Sambhav Kothari
43848a2c91
Add OSX tests and a build matrix for different linux envs
2017-03-09 15:12:35 +05:30
Sambhav Kothari
f228f4381f
Set sip api version
...
sip api version to be set in setup.py as it causes api conflicts in
OSX tests
2017-03-09 15:12:35 +05:30
Laurent Monin
b9ed817b94
Merge pull request #648 from metabrainz/revert-647-dndcover
...
Fix circular imports in picard.util
2017-03-08 21:17:48 +01:00
Sambhav Kothari
538cdcc22d
Move picard.log import to block level to avoid circular dependencies
2017-03-09 00:00:23 +05:30
Sambhav Kothari
779d798d9c
Merge pull request #647 from samj1912/dndcover
...
PICARD-1006: Fix Drag'n'Drops for cover art drops
2017-03-08 23:12:46 +05:30
Sambhav Kothari
4901cffb84
Use get_file_path to fetch appropriate files from URLs
2017-03-08 19:58:28 +05:30
Sambhav Kothari
b47f42d559
Add get_file_path method for OSX NSURL work around
2017-03-08 19:57:59 +05:30
Sambhav Kothari
9e021b82aa
Merge pull request #646 from samj1912/dropcluster
...
PICARD-1005: Fix drag'n'drop behaviour on blank targets
2017-03-08 16:53:10 +05:30
Sambhav Kothari
4407156310
Add debug information when aborting drop
2017-03-08 16:49:48 +05:30
Sambhav Kothari
14655187c8
PICARD-1005: Fix drag'n'drop behaviour on blank targets
...
In case a cluster is moved to the RHS of the windows, it gets moved to
unmatched files. The cluster should instead stay as is since the target is
invalid.
2017-03-08 16:38:23 +05:30
Laurent Monin
9739538d95
Merge pull request #645 from samj1912/picard223
...
PICARD-223: Allow Unmatched Files to be removable
2017-03-07 18:09:59 +01:00
Sambhav Kothari
e74af213cc
PICARD-223: Allow Unmatched Files to be removable
2017-03-07 20:05:58 +05:30
Laurent Monin
54490f7c53
Merge pull request #644 from samj1912/picard998
...
PICARD-998: Fix toolbar toggle action
2017-03-07 15:02:16 +01:00
Laurent Monin
6af139cb86
Merge pull request #643 from samj1912/picard996
...
PICARD-996: Fix cover art box show
2017-03-07 15:01:15 +01:00
Sambhav Kothari
75b9e53650
PICARD-998: Fix toolbar toggle action
2017-03-07 01:48:23 +05:30
Sambhav Kothari
98b37b5a30
PICARD-996: Fix cover art box show
2017-03-07 00:46:39 +05:30
Laurent Monin
98b39329e5
Update picard.pot
2017-03-05 09:59:32 +01:00
Sambhav Kothari
1d9aa72983
Merge pull request #641 from lalinsky/osx-package-env-rebuild
...
OS X package env rebuild
2017-03-05 10:00:40 +05:30
Lukáš Lalinský
57de4ce66d
We need gettext as well
2017-03-04 23:29:23 +01:00
Lukáš Lalinský
89002bdd16
Use the latest official Python package for the OS X build
2017-03-04 23:22:05 +01:00
Sambhav Kothari
9e82a548d7
Merge pull request #636 from Freso/add-mailmap
...
Add .mailmap file.
2017-03-04 21:54:45 +05:30
Sambhav Kothari
51551920f4
Merge branch 'master' into add-mailmap
2017-03-04 21:51:23 +05:30
Sambhav Kothari
7256c200e7
Merge pull request #640 from Sophist-UK/patch-3
...
PICARD-995: Avoid error on OSX invalid file path
2017-03-04 21:38:33 +05:30
Sophist
d28ce858b8
Avoid error on OSX invalid file path
...
If file path is invalid we need to skip the rest of the code in the for loop since filename is not set.
2017-03-03 21:06:19 +00:00
Sambhav Kothari
2727fb4b9a
Merge pull request #637 from scop/py36escseq
...
Fix Python 3.6 invalid escape sequence deprecation
2017-02-28 23:09:37 +05:30
Ville Skyttä
2070d9f008
Python 3.6 invalid escape sequence deprecation fixes
...
https://docs.python.org/3/whatsnew/3.6.html#deprecated-python-behavior
2017-02-28 15:29:23 +02:00
Frederik “Freso” S. Olesen
5e2f6b888f
Add .mailmap file.
...
Consolidate some of the mismatching author and committer name:email
pairs in the logs.
See https://git-scm.com/docs/git-shortlog#_mapping_authors
2017-02-26 12:11:44 +01:00
Sambhav Kothari
b3031a437d
Merge pull request #633 from lalinsky/master
...
Fix version number in the Windows installer
2017-02-20 00:05:47 +05:30
Sambhav Kothari
14bb213772
Merge branch 'master' into master
2017-02-20 00:02:53 +05:30
Lukáš Lalinský
7a4601f9c0
Fix version number in the Windows installer'
...
It should be the full version with current time for master builds,
short version for tags.
2017-02-19 19:30:38 +01:00
Sambhav Kothari
5b7178d471
Merge pull request #632 from lalinsky/master
...
OS X build fix
2017-02-19 23:53:18 +05:30
Lukáš Lalinský
ddc6b44d7e
Don't exclude zipfile, it's needed by pyobjc, which is needed to get access to NSURL
2017-02-19 19:15:17 +01:00
Lukáš Lalinský
562266f0d1
Note that we need pyobjc-framework-Cocoa to be installed
2017-02-19 13:11:40 +01:00
Laurent Monin
f2dfbf860f
Merge pull request #631 from samj1912/picard988
...
PICARD-988: Extract file paths from NSURL while drag'n'drop
2017-02-19 11:35:20 +01:00
