Commit Graph

9686 Commits

Author SHA1 Message Date
Philipp Wolfer
ca9854ced5 Simplified translation for release_type_scores options 2023-07-25 17:40:37 +02:00
Philipp Wolfer
e073a5b785 CI: Consistent naming of codesign environment variables
Use P12 instead of PFX in variable names
2023-07-25 15:59:45 +02:00
Philipp Wolfer
e2c44795fd Language translation fix 2023-07-25 12:59:12 +02:00
Philipp Wolfer
0be2e09ad5 Language translation fix 2023-07-25 12:55:20 +02:00
Philipp Wolfer
1c0ea0f112 Clarified option description for "interface_colors"
This is really about the light theme, not the standard theme (which might
be dark).
2023-07-25 10:02:17 +02:00
Philipp Wolfer
112e0d885e PICARD-2685: Preserve calculated AcoustID and ReplayGain tags
Preserve calculated AcoustID fingerprint and ReplayGain tags set on a file
object when that file object gets moved between tracks.
2023-07-25 00:47:31 +02:00
Philipp Wolfer
c9e728f97d Added tests for file.copy_metadata 2023-07-25 00:47:31 +02:00
Philipp Wolfer
d9e5214110 PICARD-2689: Render the actually dragged element instead of the first selected
Fixes issues with an empty rectangle being shown during dragging of items
if the first selected item is not visible.
2023-07-24 09:46:00 +02:00
Philipp Wolfer
9ca6cf9364 CI: Remove openssl install for macOS PyPI packaging
No longer needed since the code signing got removed.
This solves build issues on latest Github Actions images.
2023-07-20 08:09:37 +02:00
Philipp Wolfer
d001922d7b Avoid metaclass issues in Metadata multiple inheritance 2023-07-20 07:53:40 +02:00
Philipp Wolfer
535ac58422 PICARD-2011: Avoid ConfigSection.as_dict throwing due to Option.registry changing 2023-07-20 07:53:40 +02:00
Philipp Wolfer
accda69c12 PICARD-2011: Make Metadata class thread safe 2023-07-20 07:53:40 +02:00
Philipp Wolfer
284558507b Language string fix 2023-07-19 19:39:11 +02:00
Philipp Wolfer
8d1335cc64 Consistency fixes for the translations of language names 2023-07-19 18:40:15 +02:00
Philipp Wolfer
7875a40dcc Tweaked new translation strings for options
Attempt to be more consistent between options UI and option profile descriptons
2023-07-17 08:56:05 +02:00
Philipp Wolfer
4cb1d34494 Fixed parantheses in language translation strings 2023-07-17 08:03:45 +02:00
Bob Swift
cdbddade3c Add new options to profile settings (#2256)
Add new options to profile settings. Re-order profile settings.
2023-07-13 15:55:50 -06:00
Philipp Wolfer
9f2eb548ba Update picard.pot 2023-07-11 20:49:39 +02:00
Bob Swift
4e9e54dc32 PICARD-2681: Update text messages for new user and file save confirmation dialogs (#2255)
* Update text displayed.  Set default to `Cancel` for file save warning.
* Remove unreachable branches.
2023-07-11 10:49:39 -06:00
Philipp Wolfer
110514262c PICARD-2680: Modal first use and save confirmation dialogs 2023-07-07 08:02:57 +02:00
Philipp Wolfer
c2e7cf9ead Use Qt enums for new dialogs 2023-07-06 17:26:01 +02:00
Philipp Wolfer
e6923d3c55 Release 2.9.0b3 2023-07-06 15:39:07 +02:00
Philipp Wolfer
eefe7e35f3 Revert "PICARD-2609: Run metadata comparison on file.update in a thread"
This reverts commit 8a3a3424b9.
2023-07-06 15:30:48 +02:00
Philipp Wolfer
b41f93eed0 Updated translations from transifex 2023-07-06 15:30:18 +02:00
Philipp Wolfer
d3b60e0ccb Merge pull request #2252 from phw/pipe-reintroduce-thread-pool
Pipe refactor thread pool
2023-07-06 09:18:16 +02:00
Philipp Wolfer
5b61c2d907 Handle ThreadPool.shutdown cancel_futures argument being only available in Python 3.9 and later 2023-07-06 08:15:25 +02:00
Philipp Wolfer
8a2d0f0d53 Do not use a thread pool for read_from_pipe()
This method is already meant to run in a loop in a separate thread,
no need to spawn additional threads. Also this does not need to timeout
all the time. It is ok the thread waits until data becomes available
instead of looping all the time using CPU resources. Stopping the
pipe reader thread is done on application exit by a message.
2023-07-06 08:15:25 +02:00
Philipp Wolfer
a7c4867137 Increase timeout for reading from pipe
This keeps the thread longer waiting and avoids processing overhead.

Still timeout should be short enough to not block shutdown of the thread for too long.
2023-07-06 08:15:25 +02:00
Philipp Wolfer
36f1f255f9 Re-introduce thread pool for pipe
Creating a thread pool on each read / write for only a single thread is inefficient.
2023-07-06 08:15:24 +02:00
Philipp Wolfer
bf9ec7aa49 PICARD-2679: Fix open folder for Snap install
When running as a Snap use xdg-open instead of QDesktopServices.
Introduce picard.util.open_local_path helper to wrap this functionality.
2023-07-03 19:48:53 +02:00
Philipp Wolfer
8fd35b975d Revert "macOS 10.12: Build with PyQt 5.13.2"
This reverts commit 36b5dab2c4.
2023-07-03 12:34:34 +02:00
Philipp Wolfer
a80a186a24 PICARD-2668: Ensure application quit() runs all exit() cleanup tasks
This avoids issues like pipe handler hanging with waiting threads after
main application crashed.
2023-07-03 10:31:10 +02:00
Laurent Monin
08a40881a5 Handle exceptions better in piper sender/reader threads 2023-07-03 10:31:10 +02:00
Philipp Wolfer
a0efffb6ce PICARD-2665: Revert "PICARD-2634: Use standardized artist names by default"
This reverts commit 5a9d6b9581.
2023-07-03 08:21:10 +02:00
Philipp Wolfer
1482f9cc56 Fixed extracting translation for first run dialog 2023-07-02 12:07:29 +02:00
Philipp Wolfer
e6d2d7fb33 Update picard.pot 2023-07-02 11:52:43 +02:00
Bob Swift
104f718a31 Merge pull request #2246 from rdswift/new_user_dialogs
PICARD-2671: Add file save confirmation and first run dialogs
2023-06-30 15:38:47 -06:00
Laurent Monin
15db874b06 show_new_user -> show_new_user_dialog (#16) 2023-06-29 16:11:59 -06:00
Bob Swift
4d364fcffb Add option setting to re-enable the new user dialog 2023-06-29 15:48:30 -06:00
Bob Swift
8ee05ef606 Change double spaces between sentences to single. 2023-06-29 10:28:31 -06:00
Bob Swift
f7a1ad5c53 Change the way the documentation link is displayed
Co-authored-by: Laurent Monin <github@norz.org>
2023-06-28 18:53:26 -06:00
Bob Swift
47cf43a217 Change new user messagebox icon
Co-authored-by: Laurent Monin <github@norz.org>
2023-06-28 18:50:07 -06:00
Bob Swift
9b1d1bcd62 Shorten the new user message. Add new constant for docs server. 2023-06-28 15:53:55 -06:00
Bob Swift
2d03913d33 Add number of files processed to warning. Clean up variable names. 2023-06-28 14:54:26 -06:00
Bob Swift
a19cc1f896 Another i18n fix. 2023-06-27 10:18:14 -06:00
Bob Swift
e7a22ebdb7 Update message text and message classes:
- Rename firstrundialog module and class to newuserdialog
- Rename 'first_run' persistent variable to 'show_new_user'
- Remove unused super classes.
- Add license url to PICARD_URLS constant dictionary.
- Add documentation and licence links to first run dialog.
- Strengthen warning about using backups of music files and running
small batches.
- Add note about using at your own risk.
- Refactor text for file save warning for proper translation.
2023-06-27 09:52:51 -06:00
Bob Swift
300f95763c Add file save confirmation and first run dialogs. 2023-06-26 17:24:21 -06:00
Philipp Wolfer
47fea52c3a Update picard.pot 2023-06-26 17:27:50 +02:00
Laurent Monin
fa5e24f1ec PICARD-2662: display a more explicit message on Mutagen errors (#2245)
* PICARD-2662: display a more explicit message on Mutagen errors

* MUTAGEN -> PARSER
2023-06-26 14:56:55 +02:00
Philipp Wolfer
203aa6bd4a PICARD-2659: Fix endless login loop
Attempting to do authenticated calls against HTTP on musicbrainz.org
leads to authentication errors. Enforce all calls to use HTTPS.

This is a regression introduced by recent webservice refactoring.
2023-06-16 18:46:31 +02:00