skelly37
cb993bdcff
simplified test reader
2022-06-27 10:26:22 +02:00
skelly37
7c8b1606c1
zas's suggestions
2022-06-27 10:13:54 +02:00
skelly37
6d9921b153
Pipe thoroughly documented, logging methods improved, should be the last commit
2022-06-27 09:57:13 +02:00
skelly37
f961bdc1d5
removed missed usage of 'a' instead of 'w' to pipe
2022-06-26 19:23:43 +02:00
skelly37
22a6d708bc
tests fixed, better logging, minor refactoring
...
I've simplified the code for tagger's pipe server, i've added better logging for pipe, I've replaced dicts with strings to fix python's problems with the tests. Pipe works fine, the problem seems deeper than we thought, this approach also tests the pipe correctly.
2022-06-26 19:14:02 +02:00
Kamil
edb0e730c0
Merge branch 'metabrainz:master' into single-instance-gsoc
2022-06-26 16:17:30 +02:00
Kamil
9c0e373314
timeout added to pytest ( #2122 )
...
timeout added to pytest
2022-06-26 14:14:35 +02:00
skelly37
7f57b077e4
fixed pipe illegal seeks
2022-06-26 07:33:50 +02:00
skelly37
4693adbce6
BrokenPipeError handled, logs in test cases
...
All the issues with Unix tests was caused by the BrokenPipeError which is actually hard to reproduce. I've added a basic handle procedure: re-create the pipe and log a warning.
Should work now, and if not, we at least have more verbose logging system
2022-06-25 18:08:32 +02:00
Philipp Wolfer
2c7928c4e3
Merge pull request #2120 from phw/PICARD-2504-configurable-query-limit
...
PICARD-2504: Increase default query limit and make it configurable
2022-06-25 00:14:24 +02:00
Philipp Wolfer
eb74f499d1
PICARD-2505: Sanitize cover art type before using it as filename
...
Fixes accidental folder creation for types "matrix/runout" or "raw/unedited".
2022-06-25 00:13:24 +02:00
skelly37
8099f31da3
timeout for writer in tests included
2022-06-24 13:25:57 +02:00
skelly37
9af8002b16
retry tests 20 times, maybe it will help with stucks
2022-06-24 08:05:52 +02:00
skelly37
82585445ae
windows pipe improved
2022-06-23 15:18:18 +02:00
skelly37
cb714d7cf6
timeout included
2022-06-22 19:52:59 +02:00
skelly37
1333ee33a9
minor refactor
2022-06-22 17:27:19 +02:00
skelly37
4b762168cd
minor refactor
2022-06-22 09:47:57 +02:00
skelly37
0286f3e4ad
safe 'null' as separator and ignorable message
2022-06-21 21:50:44 +02:00
skelly37
8efeda1614
suggestions + refactor
2022-06-21 19:11:12 +02:00
Kamil
93a1249d8a
Merge pull request #2 from zas/Pipes
...
Define PIPE_DIRS as abstract constant, introduce MacOSPipe
2022-06-21 16:35:53 +00:00
skelly37
fb2cb75d92
fixed commit
2022-06-21 18:14:51 +02:00
Laurent Monin
d66834a9fa
Define PIPE_DIRS as abstract constant, introduce MacOSPipe
2022-06-21 11:43:51 +02:00
skelly37
c0c5074297
my last idea
2022-06-21 10:22:25 +02:00
skelly37
6cf45bf12b
forced_path refactor
2022-06-21 09:56:24 +02:00
skelly37
bc0e581b12
codacy
2022-06-21 09:41:27 +02:00
skelly37
46c88fb567
fallback used, filename tests removed, should work fine
...
I've decided to remove the filename tests becaue they provide no useful value during the tests. Everything has to be mocked and so on... Debug-logging the pipe path should do, because during the tests we cannot be 100% sure that the specific folder will be writable, the env variable will be declared etc.
2022-06-21 08:44:28 +02:00
Philipp Wolfer
ec8c71ab63
PICARD-2504: Limit query limit choice to 25, 50, 75 and 100
2022-06-21 08:12:30 +02:00
Philipp Wolfer
680654b244
PICARD-2504: Add query_limit to option profiles
2022-06-21 08:05:04 +02:00
Philipp Wolfer
9250d01559
PICARD-2504: Increase MB web service query limit to 50
2022-06-20 21:21:29 +02:00
Philipp Wolfer
8d987ade6a
PICARD-2504: Make MB web service query limit configurable
2022-06-20 21:21:29 +02:00
skelly37
b1d61a0181
codacy
2022-06-20 17:47:20 +02:00
skelly37
8f722b99fb
exit code + abstract pipe class
...
testing still not fixed, just pushing what I've done when it comes to the abstract pipe.
I'm also still thinking about the fallback dirs handling, so it remained unchanged
2022-06-20 14:58:30 +02:00
Frazer Smith
401102d2ef
Update GitHub Actions
2022-06-18 22:58:43 +02:00
Kamil
6e5312c95e
removed pass leftover
2022-06-17 11:13:25 +02:00
skelly37
9c43a49483
picard passes absolute paths to the pipe to avoid errors
2022-06-17 11:06:55 +02:00
skelly37
e95abc2266
print leftovers removed
2022-06-17 00:14:20 +02:00
skelly37
1f22d3c555
picard single-instance-mode preview; tagger modified
2022-06-17 00:12:53 +02:00
skelly37
8b30c2e858
missed call
2022-06-16 11:31:43 +02:00
skelly37
b83ce3f2d8
NoneType guard, defaulting to /tmp
2022-06-16 11:29:15 +02:00
skelly37
5ff83bb84d
improved dir constants
2022-06-16 11:13:39 +02:00
skelly37
2de7543f31
added mocking for filename generation tests
2022-06-16 11:02:51 +02:00
skelly37
5f27781635
os-specific filename tests with decorators
2022-06-15 21:13:40 +02:00
skelly37
d029a9d824
better logger, tuple split into lines
2022-06-15 08:54:43 +02:00
skelly37
83bbdb3e18
fallback path generates warn, tests descriped where appliable, path is tested
2022-06-14 19:34:27 +02:00
skelly37
6782ddf0c5
suggestions included, minor refactor
2022-06-14 18:56:58 +02:00
skelly37
c1d708cf5b
TypeError fixed
2022-06-14 18:37:13 +02:00
skelly37
aa8233bf1d
codacy
2022-06-14 17:49:49 +02:00
skelly37
f66e47b5a0
pipe reads&sends lists now, the whole protocol is tested
2022-06-14 17:42:08 +02:00
skelly37
904824e3dc
started writing test cases, app_name and app_version in pipe are forced to be str
2022-06-13 11:19:32 +02:00
skelly37
af05a324f0
unified error messages
2022-06-10 19:31:26 +02:00
