fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-04-05 03:55:14 +00:00
Code Issues Packages Projects Releases Wiki Activity
10,651 Commits 1 Branch 0 Tags
ce5ed9dbcfe41507f19e032ad5337e7a76dff0cc
Commit Graph

10651 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Laurent Monin
ce5ed9dbcf Merge pull request #2435 from zas/comment_options 
Add header & comment to new options.py
 2024-04-26 22:38:41 +02:00
Laurent Monin
4c6cb1db29 Rephrasing 
Co-authored-by: Bob Swift <bswift@rsds.ca>
 2024-04-26 21:45:11 +02:00
Laurent Monin
219aed5b21 Add header & comment to new options.py 2024-04-26 21:11:21 +02:00
Laurent Monin
64f8d47c36 Merge pull request #2433 from zas/centralize_options 
Move option declarations to picard/options.py and introduce const.defaults
 2024-04-26 19:27:07 +02:00
Laurent Monin
e24d4f7e8a Move remaining DEFAULT_* constants to const.defaults 
Some imports are made locally to avoid circular import issues (mainly in `util` module)
 2024-04-26 18:11:51 +02:00
Laurent Monin
2af3fa6fea Move ItemViews persist options to options.py 2024-04-26 17:29:00 +02:00
Laurent Monin
7902a096e2 Remove last traces of options 2024-04-26 17:13:09 +02:00
Laurent Monin
0eb5349882 Cache known option names 
`profile_groups_all_settings()` is used mainly in `SettingConfigSection` getter & setter
so performance is important
 2024-04-26 17:07:36 +02:00
Laurent Monin
34b046fe31 Drop class UserProfileGroups, use module level methods 2024-04-26 16:54:54 +02:00
Laurent Monin
5540f2fa0e More consistent naming 2024-04-26 16:22:08 +02:00
Laurent Monin
5edad5d440 SettingDesc.fields -> SettingDesc.highlights, more consistent 2024-04-26 16:21:51 +02:00
Laurent Monin
baf516fa14 DEFAULT_THEME_NAME = str(UiTheme.DEFAULT) 2024-04-26 15:51:14 +02:00
Laurent Monin
67cebbe8ed group_from_page(): minor simplification 2024-04-26 15:36:15 +02:00
Laurent Monin
784fae9c59 Fix up and add tests for UserProfileGroups 2024-04-26 15:06:45 +02:00
Laurent Monin
f29fb65f5a Sort profile groups according to option pages order 2024-04-26 14:19:19 +02:00
Laurent Monin
7c16dadda4 Add an order to UserProfileGroups groups according to the display order 
A bit hacky...
 2024-04-26 14:18:04 +02:00
Laurent Monin
663a33cf50 UserProfileGroups: use Page.NAME as group name, and drop hardcoded titles 2024-04-26 14:11:08 +02:00
Laurent Monin
380f67093f Get rid of register_profile_highlights() 
Use UserProfileGroups.append_to_group() directly
 2024-04-26 12:36:03 +02:00
Laurent Monin
4196e097ea Merge remote-tracking branch 'upstream/master' into centralize_options 2024-04-26 12:26:46 +02:00
Dimlbur
99a6e5cdd6 Translated using Weblate (Russian) 
Currently translated at 56.2% (668 of 1188 strings)

Co-authored-by: Dimlbur <Dimlbur@users.noreply.translations.metabrainz.org>
Translate-URL: https://translations.metabrainz.org/projects/picard/3/app/ru/
Translation: Picard/App
 2024-04-26 09:42:27 +00:00
Vaclovas Intas
403ee2ae1b Translated using Weblate (Lithuanian) 
Currently translated at 66.5% (791 of 1188 strings)

Co-authored-by: Vaclovas Intas <gateway_31@protonmail.com>
Translate-URL: https://translations.metabrainz.org/projects/picard/3/app/lt/
Translation: Picard/App
 2024-04-26 09:42:27 +00:00
Laurent Monin
bfe14f11ce Directly store the option instead of just its name 2024-04-25 23:21:21 +02:00
Laurent Monin
70d2f9d1b0 Merge remote-tracking branch 'upstream/master' into centralize_options 2024-04-25 23:06:06 +02:00
Laurent Monin
1222821a2e Fix missing tagger property in TipSlider 2024-04-25 23:05:04 +02:00
Laurent Monin
9bf11ba0e0 Declare options at module level, use a dummy init_options() to make linters happy 2024-04-25 23:00:16 +02:00
Laurent Monin
6e09d52487 Introduce OptionPage.register_setting() 
- used to restore defaults on the page
- used to list widgets to highlight when using profiles (optional)

Basically it associates a setting editing page to settings it edits.
 2024-04-25 22:13:32 +02:00
Laurent Monin
5f5b4e4a18 Merge pull request #2427 from zas/fix_cover_art_cells 
PICARD-2873: Fetch Search dialog cover art images after it was resized
 2024-04-25 19:51:55 +02:00
Laurent Monin
055547bcc3 Merge pull request #2434 from rdswift/options_maint_page_update 
PICARD-2876: Update the Options > Advanced > Maintenance page
 2024-04-25 19:42:22 +02:00
Laurent Monin
b3b841d0cc Remove empty options properties 2024-04-25 19:26:39 +02:00
Laurent Monin
7a0658d72c Rework UserProfileGroups and fix tests 2024-04-25 19:26:39 +02:00
Laurent Monin
24032925ca Finally, last bits of conversion to register_profile_highlights() 2024-04-25 19:26:39 +02:00
Laurent Monin
192f813c59 Continue conversion to register_profile_highlights() 2024-04-25 19:26:39 +02:00
Laurent Monin
962126c3db Convert to registrer_profile_highlights() 2024-04-25 19:26:39 +02:00
Laurent Monin
912bfe3021 More conversions to register_profile_highlights() 2024-04-25 19:26:39 +02:00
Laurent Monin
a6fb5ef647 Fix tests 2024-04-25 19:26:39 +02:00
Laurent Monin
c4a000a0b9 Introduce register_profile_highlights() 2024-04-25 19:26:39 +02:00
Laurent Monin
2103376e60 Move option declations to picard/options.py and introduce const.defaults 2024-04-25 19:26:39 +02:00
Philipp Wolfer
92ca2d8664 Merge pull request #2432 from phw/fix-upgrade-hooks 
Fix upgrade hooks re-declaring options
 2024-04-25 18:57:25 +02:00
Philipp Wolfer
e275824044 Fix upgrade_to_v2_7_0dev2 upgrade hook 
Copy the splitter config value as is instead of attempting a conversion.
 2024-04-25 18:24:42 +02:00
Bob Swift
ba65c3f245 Update the Options > Advanced > Maintenance page: 
- update the enabling logic for the unused setting item selections and
"Remove selected options" checkbox to allow scrolling the unused
settings list without having to enable the "Remove selected options"
checkbox
- relocate the "Remove selected options" checkbox to save space
- update the wording of the instructions to clarify and save space
- update the tab order
 2024-04-25 09:47:33 -06:00
Philipp Wolfer
89a75828f2 Fix upgrade hooks re-declaring options 
Options must only be registered once. This includes upgrade hooks,
which must only access declared options or for removed options
access their raw value.
 2024-04-25 17:42:08 +02:00
Philipp Wolfer
a2be3c8483 Do not use PyQt6-Qt6 6.7 from PyPI 
The 6.7 build has binary compatibility issues on Linux.
 2024-04-25 17:41:00 +02:00
Laurent Monin
4bfbe012b3 Merge pull request #2430 from zas/save_last_backup_dir 
PICARD-2875: Let the user select the auto backup directory in Maintenance Options
 2024-04-25 11:10:16 +02:00
Laurent Monin
52462ec5cd Merge pull request #13 from rdswift/save_last_backup_dir 
Modify maintenance options page label text and layout
 2024-04-24 22:01:32 +02:00
Bob Swift
4643d18caa Modify maintenance options page label text and layout. 
- expand automatic backup directory label and add trailing colon
- move Load and Save buttons
- add line to separate config file/directory from setting removal
- change to sentence case for existing option label and buttons
- add ellipses to buttons that open new dialogs/windows
 2024-04-24 11:46:40 -06:00
Laurent Monin
f26a74f251 If the path is changed to an invalid directory, dispplay a warning and revert back to last valid path 2024-04-24 18:04:38 +02:00
Laurent Monin
2a986cd175 Revert "Update picard/ui/ui_options_maintenance.py" 
This reverts commit 686df504cb.
 2024-04-24 17:39:50 +02:00
Laurent Monin
686df504cb Update picard/ui/ui_options_maintenance.py 
Co-authored-by: Bob Swift <bswift@rsds.ca>
 2024-04-24 17:26:00 +02:00
Laurent Monin
9edd5845ad Update picard/ui/options/maintenance.py 
Co-authored-by: Bob Swift <bswift@rsds.ca>
 2024-04-24 17:25:38 +02:00
Laurent Monin
2aa55618b9 Reduce code redundancy, introduce _safe_autobackup_dir() 2024-04-24 15:49:07 +02:00