fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-05-20 01:46:07 +00:00
Code Issues Packages Projects Releases Wiki Activity
6,271 Commits 1 Branch 0 Tags
cf4ac13d9af039f85de00dfea21b29cd4ebe85f7
Commit Graph

6271 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Laurent Monin
cf4ac13d9a Add few tests for similarity2() function 2019-07-02 14:41:06 +02:00
Laurent Monin
64c3bb8795 No need to use u"" syntax anymore 2019-07-02 14:40:27 +02:00
Laurent Monin
2306244e42 Add coding magic comment 
Even though Python 3 defaults to utf8, it is still useful for editors
 2019-07-02 14:39:58 +02:00
Laurent Monin
84f253e719 Merge pull request #1207 from zas/internal_player_checks 
Internal player checks
 2019-06-26 22:48:21 +02:00
Laurent Monin
0e47869729 Only catch ImportError exception 2019-06-26 17:37:06 +02:00
Laurent Monin
938e5d4c89 Improve internal player availability detection and error handling 2019-06-26 16:55:29 +02:00
Timur Enikeev
72841404b8 QtMultimedia availability check added 2019-06-26 15:25:56 +02:00
Laurent Monin
c2a61728f4 Merge pull request #1206 from zas/assertEquals_is_deprecated 
unittest.assertEquals() is deprecated in favor of assertEqual()
 2019-06-24 21:28:23 +02:00
Laurent Monin
38f78c4069 unittest.assertEquals() is deprecated in favor of assertEqual() 2019-06-24 19:07:18 +02:00
Philipp Wolfer
4b116ac20a PICARD-1541: Hide log dialogs instead of destroying 2019-06-24 18:14:07 +02:00
Philipp Wolfer
99d872e9a5 Merge pull request #1202 from metabrainz/PICARD-1529-fix-nat-coverart 
PICARD-1529: Avoid loaded NATs getting assigned cover art from other NATs
 2019-06-24 17:56:47 +02:00
Philipp Wolfer
4db29cf190 PICARD-1533: Set Qt.AA_EnableHighDpiScaling before appication gets created 2019-06-24 17:55:43 +02:00
Philipp Wolfer
40f12e5eb2 Simplified metadata comparisson in tests 2019-06-24 14:59:22 +02:00
Philipp Wolfer
604e542d10 Check if images get copied in test for Metadata.update() 2019-06-23 11:39:38 +02:00
Philipp Wolfer
0c57969735 PICARD-1529: Allow copying metadata without images 2019-06-23 11:35:18 +02:00
Laurent Monin
694006275c Merge pull request #1194 from timur-enikeev/PICARD-1488 
PICARD-1488: Internal music player feature added
 2019-06-17 15:41:40 +02:00
Laurent Monin
9887d57a7c Merge pull request #1199 from zas/colors 
PICARD-1524: Make colours user-configurable
 2019-06-17 10:37:35 +02:00
Philipp Wolfer
884221ae61 PICARD-1529: Avoid loaded NATs getting assigned cover art from other NATs 2019-06-17 09:04:02 +02:00
Timur Enikeev
7c8972493f First implementation of an internal audio player (PICARD-1488 issue) 2019-06-16 19:49:48 +02:00
Laurent Monin
4489eedfc8 Warn user about the fact color changes may only apply after a restart 2019-06-12 10:15:15 +02:00
Laurent Monin
2f45d40017 PICARD-1524: Make colours user-configurable 2019-06-12 10:04:12 +02:00
Laurent Monin
b3eeb55995 Merge pull request #1200 from zas/logview_fix 
PICARD-1525: Only update log/history views when actually displayed
 2019-06-11 16:08:49 +02:00
Laurent Monin
3211dc3f9d Merge pull request #1201 from zas/PICARD-1522 
PICARD-1522: Fix exception caused by an attempt to remove already removed NATS album
 2019-06-11 16:07:52 +02:00
Laurent Monin
c6815c4fad Fix exception caused by an attempt to remove already removed NATS album 
When removing an album and a non-album track, remove_nat() will call remove_album().
remove() loop over objects to remove, and call remove_album() again on the same object

This causes a KeyError: 'NATS' exception on del self.albums[album.id] execution

Solution: do not call remove_album() for NAT albums, as remove_nat() will take care of NATS pseudo album removal.
 2019-06-11 13:24:18 +02:00
Laurent Monin
ee3a1c285b PICARD-1525: Only update log/history views when actually displayed 
- override hideEvent() and showEvent() to connect/disconnect log_tail.updated signal
- only update display on showEvent()
 2019-06-11 10:26:27 +02:00
Philipp Wolfer
0f1c4999fa PICARD-1506: Provide empty config for tests 
If there is no empty config file Qt seems to initialize the specified config file path with a copy of the application's config.
 2019-06-03 14:12:07 +02:00
Philipp Wolfer
3c5f1114a8 PICARD-1517: Fix running matchedtracks()/is_complete() on clusters 2019-05-31 06:05:10 +00:00
Laurent Monin
ccd80c061f Update attributes.py (medium format) 2019-05-30 15:37:56 +02:00
Laurent Monin
8291561b9d Resync picard.pot 2019-05-30 15:32:33 +02:00
Laurent Monin
6a43385d87 Merge pull request #1193 from zas/PICARD-1514 
PICARD-1514: improve genres/tags filtering
 2019-05-29 16:10:02 +02:00
Philipp Wolfer
9c709c7ee4 PICARD-1516: Fix loading / saving MP4 without tags 2019-05-29 13:34:11 +00:00
Laurent Monin
eac56b1b2b Set a duration for tool tips 
On my platform they are never hidden if not set, even when typing in text fields.
Setting this duration improves things a bit, but i suspect an Qt bug.
 2019-05-29 11:03:13 +02:00
Philipp Wolfer
d54b61bab3 Fix crash when saving after "keep original cover art. 
Fix metadata.images getting turned into regular list under some circumstances.
 2019-05-29 08:45:49 +00:00
Laurent Monin
eb260e52db Simplify code: no need to pass self.ui.test_genres_filter 2019-05-29 10:19:59 +02:00
Laurent Monin
9d0aa44487 Translate string 
Note: actual error message cannot be translated (exception string)
 2019-05-29 10:03:10 +02:00
Laurent Monin
27040dcf6d Reduce code redundancy directly using update_test_genres_filter() 2019-05-29 09:54:32 +02:00
Laurent Monin
99f99b7434 Minor code tidy up 2019-05-28 21:08:20 +02:00
Laurent Monin
1b08c55de5 Add TagGenreFilter.filter() method 
Suggested by phw
 2019-05-28 20:51:51 +02:00
Laurent Monin
1aee66ccff Pass filters directly instead of passing config.setting 
Suggested by phw
 2019-05-28 20:34:01 +02:00
Laurent Monin
cb6c2b8825 Strip whitespaces around expressions (after +/-), and tests 2019-05-28 15:25:50 +02:00
Laurent Monin
b3a25c17b0 Improve genre filter playground, clear colors on empty lines 2019-05-28 13:43:01 +02:00
Laurent Monin
26d9eb6ed1 Make tool tips translatable 2019-05-28 13:12:12 +02:00
Laurent Monin
db39685a35 Remove FIXME comment, it was done in previous commits 2019-05-28 12:35:20 +02:00
Laurent Monin
896569d9d8 Since comparison is case-insensitive, no need to convert to lowercase 2019-05-28 12:34:36 +02:00
Laurent Monin
f1bf736ec6 Add "one per line" and a note about the test zone not being saved 2019-05-28 12:33:20 +02:00
Laurent Monin
c50331abb7 Ignore case when matching strict, wildcard and regex genre filters 2019-05-28 12:30:55 +02:00
Laurent Monin
1bcad37f86 Handle upgrade, and provide a working UI for setting genres_filter 
- bump Picard version to 2.2.0dev3 and add a hook to convert ignore_genres to genres_filter
- modify Genres UI
- add a playground to test genre_filter
- improve error handling
 2019-05-27 14:53:34 +02:00
Laurent Monin
e02dc620a1 Replace ignore_genres with genres_filter 
Syntax guide:

Whitespaces at start/end of line are stripped
Lines not starting with + or - are ignored

Strict matching:
-jazz

Wildcard matching:
-jazz*

Regex matching:
-/j.zz.*$/

Whitelisting:
-*
+jazz
 2019-05-26 19:24:14 +02:00
Laurent Monin
985f19fb97 Refactor tag/genre ignore code, and add matching tests 2019-05-26 12:53:09 +02:00
Laurent Monin
54e562c8a6 Merge pull request #1192 from zas/bump_api 
PICARD-1513: Bump version to 2.2.0dev2 and api version to 2.3
 2019-05-12 21:53:08 +02:00