Commit Graph

8881 Commits

Author SHA1 Message Date
Philipp Wolfer
d34df0049c CI: Run tests on windows-2019 explicitly
Ensures that Python 3.6 is available
2022-02-11 14:59:08 +01:00
Philipp Wolfer
8b8593b546 PICARD-2414: Added some additional tests for tracknum_and_title_from_filename
Test some more real world examples and ignore cases like UB40 where a no. follows directly on alphanumeric characters.
2022-02-11 11:01:33 +01:00
Laurent Monin
76f9d44cdc Update headers 2022-02-07 09:44:34 +01:00
Laurent Monin
2f6479747d Update headers 2022-02-07 09:41:57 +01:00
Philipp Wolfer
20ec8078cf Update picard.pot 2022-02-07 07:47:00 +01:00
Laurent Monin
0c78dd3755 Merge pull request #2059 from zas/fix_flac_seektable
PICARD-2411: Add option to fix seektable for flac files
2022-02-06 16:47:41 +01:00
Laurent Monin
5b9b7fcc51 Fix missing whitespaces after comma (PEP8) 2022-02-05 17:58:37 +01:00
Marcin Szalowicz
fa2e443021 Add option to fix seektable for flac files
This is to fix problem with Kodi which is unable to load files
that have empty SeekTable, so by default a single SeekPoint is added.
An error message is logged if the file has no samples.
2022-02-05 17:51:00 +01:00
Philipp Wolfer
f331a1104c Merge pull request #2058 from zas/translate_artist_node_cleanup
Translate artist node cleanup
2022-02-03 17:04:54 +01:00
Laurent Monin
310c2baed0 _translate_artist_node(): shorten long lines a bit 2022-02-03 10:32:43 +01:00
Laurent Monin
203933ff9f Add few tests for translate_artist_names_script_exception 2022-02-03 10:31:54 +01:00
Philipp Wolfer
9e740c11a4 Omit standard ports in URLs constructed by build_qurl 2022-01-31 07:49:21 +01:00
Philipp Wolfer
14e46aba02 Update picard.pot 2022-01-30 16:16:04 +01:00
Philipp Wolfer
803055a9f9 PICARD-2410: Implement parsing Whipper ripping log files 2022-01-30 15:34:17 +01:00
Philipp Wolfer
3ae6706b05 Moved calculate_mb_toc_numbers to picard.disc.utils 2022-01-30 15:34:17 +01:00
Philipp Wolfer
89bc0cbecb Update picard.pot 2022-01-28 13:45:34 +01:00
Laurent Monin
8fa263613e Merge pull request #2055 from rdswift/clarify_script_types_in_strings
Clarify script types in strings in the UI files
2022-01-28 12:16:10 +01:00
Laurent Monin
885db0c6f5 Merge pull request #2054 from phw/cdtoc-url-lookup
PICARD-2409: Search for cdtoc URL triggers CD lookup
2022-01-28 12:15:43 +01:00
Philipp Wolfer
b815645961 FileLookup: Renamed variable mbid -> id 2022-01-28 08:16:45 +01:00
Philipp Wolfer
eeed3adb4d Test all methods in FileLookup 2022-01-28 08:16:45 +01:00
Philipp Wolfer
d89c14d3ea Support all MB entity URLs in FileLookup 2022-01-28 08:16:44 +01:00
Philipp Wolfer
97a272bd3a Added tests for FileLookup.mbid_lookup 2022-01-28 08:16:44 +01:00
Bob Swift
ad59b4281d Clarify script types in strings in the UI files 2022-01-27 11:40:48 -07:00
Philipp Wolfer
17b8c9b6ac PICARD-2409: Search for cdtoc URL triggers CD lookup 2022-01-27 09:21:26 +01:00
Philipp Wolfer
4ea72ba6ad Compile regex for file lookup by URI 2022-01-27 08:10:01 +01:00
Bob Swift
ec282fea12 Add _musicbrainz_tracknumber to scripting variables list 2022-01-27 07:57:59 +01:00
jesus2099
e08190490c Update doc broken hyperlinks to cached versions
Update HTTP hyperlinks to HTTPS when possible
2022-01-27 07:57:36 +01:00
Adam James
5e1476e2c2 Remove legacy genre tag translation
The translation mapping was originally added as part of the last.fm
plugin in commit 99dc3e54, which was later used as the basis of the
initial folksonomy genre implementation.

This change fixes a bug where a track tagged with the "electronic" and
"electronica" genres would end up with "electronic" twice.
2022-01-26 21:12:08 +01:00
Philipp Wolfer
8b42c395ef Merge pull request #2049 from jesus2099/patch-1
PICARD-2407: Send tport with Submit cluster as release
2022-01-26 13:21:21 +01:00
Philipp Wolfer
5cde585f0a mbjson: avoid repeated get_config calls 2022-01-26 13:09:17 +01:00
Philipp Wolfer
2b621c0274 mbjson: use tuple for relation attributes 2022-01-26 13:09:17 +01:00
Philipp Wolfer
27c454fb34 Update addrelease tport (#1)
* addrelease: pass tport as query parameter

* Reduce code redundancy in addrelease
2022-01-26 12:27:28 +01:00
jesus2099
74ce586b5e Send tport with Add cluster as release
When you Add cluster as release, the tport is lost on MBS and Green Tagger buttons disappear.

Thanks @phw for QCoreApplication.instance().browser_integration.port hint!

MBS does not accept tport as POST parameter (nknown field: tport).

It works when added in the action URL, even if it is ugly to mix GET query paramers and POST body parameters like this. :-/
2022-01-25 19:14:41 +01:00
Laurent Monin
17b5d7c326 Merge pull request #2048 from phw/PICARD-1455-discid-from-eac-log
PICARD-1455: Allow disc lookup from EAC / XLD log file
2022-01-25 15:43:20 +01:00
Laurent Monin
0761263c4d Use tuples instead of lists, since those aren't to be modified 2022-01-25 12:53:56 +01:00
Philipp Wolfer
6f9c70951d Moved old disc module and eaclog to disc package
Avoids name conflict and confusion of picard.discid with the discid pip package.
2022-01-25 08:38:15 +01:00
Philipp Wolfer
36bba02e2b PICARD-1455: Compile EAC log parser regex 2022-01-25 08:38:14 +01:00
Philipp Wolfer
97d01b99df PICARD-1455: Allow disc lookup from EAC / XLD log file 2022-01-25 08:38:14 +01:00
Philipp Wolfer
a111c18b1b PICARD-2405: Add support for Matrix/Runout CAA type 2022-01-24 23:10:48 +01:00
Philipp Wolfer
4e9dbc1843 Extend the README
Clarify the structure, add features and additional links
2022-01-24 21:09:54 +01:00
Laurent Monin
fec882f196 Make test more pythonic, no need of len() > 0 here 2022-01-24 18:25:22 +01:00
Laurent Monin
416f09c451 Merge pull request #2046 from phw/PICARD-2292-recording-mixed-instrumental-works
PICARD-2292:  Fix setting "no lyrics" for recording with mixed instrumental works
2022-01-24 18:21:47 +01:00
Laurent Monin
b877874858 Merge pull request #2045 from phw/PICARD-2396-acoustid-detect-length-difference
PICARD-2396: Do not link AcoustIDs to recordings if there is a large difference in length
2022-01-24 09:10:30 +01:00
Philipp Wolfer
b854c07915 PICARD-2398: Ensure recording relationships are available to album metadata processors 2022-01-24 08:37:41 +01:00
Philipp Wolfer
e119ef5d93 Convert AcoustID Submission.args to property 2022-01-23 18:13:10 +01:00
Philipp Wolfer
5831c8ff1b mbjson: Make use of m.add_unique 2022-01-23 18:05:29 +01:00
Philipp Wolfer
59ffd90f88 PICARD-2292: Fix detecting instrumnetal for multi-work recordings
A recording with multiple works should only get the language set to "no lyrics" if all performances are instrumental
2022-01-23 18:04:18 +01:00
Philipp Wolfer
62da04f831 PICARD-2396: Adjust AcoustID payload size calculation
Needs to be adjusted to accomodate the potential larger payload if metadata gets submitted
2022-01-22 17:10:12 +01:00
Philipp Wolfer
1464838fc0 PICARD-2396: Add AcoustID Submission.get_args 2022-01-22 17:10:12 +01:00
Philipp Wolfer
574e7a90c1 PICARD-2396: Submit metadata to AcoustID on duration mismatch
If a file's duration does clearly not match the MB recording duration allow AcoustID submission anyway. But instead of submitting the recording MBID submit only the metadata.

This prevents clear mismatches while still allowing fingerprint submission. The submitted metadata can give a hint on the recording.
2022-01-22 17:10:11 +01:00