Commit Graph

30 Commits

Author SHA1 Message Date
Laurent Monin
203933ff9f Add few tests for translate_artist_names_script_exception 2022-02-03 10:31:54 +01:00
Philipp Wolfer
59ffd90f88 PICARD-2292: Fix detecting instrumnetal for multi-work recordings
A recording with multiple works should only get the language set to "no lyrics" if all performances are instrumental
2022-01-23 18:04:18 +01:00
Philipp Wolfer
e32e116d5e PICARD-2368: Use totalalbumtracks for cluster matching 2021-12-18 17:26:57 +01:00
Philipp Wolfer
8ed8075cea PICARD-2368: When comparing metadata to a release consider the actual medium track count
tracktotal in a file is supposed to have the total number of tracks on the specific medium. Comparing to the total tracks of a release across all medium hence gives wrong results.
2021-12-18 17:26:56 +01:00
Laurent Monin
bd773b56a9 Reformat test json files
Fix spacing, end of lines, overall indentation
With the help of `python3.9 -m json.tool --no-ensure-ascii`
2021-11-26 15:03:14 +01:00
Philipp Wolfer
7fabde2edf PICARD-2288: Add a variable ~workcomment for the work disambiguation 2021-10-07 14:38:59 +02:00
Philipp Wolfer
192db0a729 PICARD-2233: Composer "credited as" must not overwrite composersort
If "credited as" is set on a composer relationship, the credited name gets used both for composer and composersort. This is inconsistent with how target credits get used for artist / artistsort and causes a composersort tag without proper sort name.
2021-09-12 19:40:49 +02:00
Bob Swift
8a4082fee7 Revise artist name translation logic. Add tests. 2021-09-09 12:34:34 -06:00
Philipp Wolfer
d3d596b09a PICARD-2124: Add and fill _releaseannotation variable 2021-02-22 17:34:09 +01:00
Philipp Wolfer
dee1ad5c81 PICARD-1998: Add "director" (for videos) tag
This adds a tag "director" which is filled with the "video director" AR from MB by default.
2021-01-16 15:48:53 +01:00
Philipp Wolfer
a7e0b9f999 PICARD-204: Support for recording-level original release date
Provide variables %_recordingoriginaldate% and %_releaseoriginaldate%.
2021-01-15 17:23:57 +01:00
dukeyin
cbc1bce030 Add unit test for "Use release relationships"
* Added a release-level producer to release.json because the existing release-artist relationships are not used in tagging
* Modified the existing release test to check that the producer tag is the release-level producer when "Use release relationships" is enabled
* Added a release test to check that the producer tag is empty when "Use release relationships" is disabled
2020-07-17 20:01:37 -04:00
Philipp Wolfer
3f9ad5a743 PICARD-1884: Fix tracknumber tag with value 0 not set 2020-07-14 17:03:30 +00:00
Philipp Wolfer
149e02c914 PICARD-1840: For instrumental recordings unset lyricist
Also set language to zxx ("No lyrics"), fixes PICARD-1117
2020-06-17 21:34:02 +02:00
Philipp Wolfer
ac91895629 PICARD-1803: Fixed decamelcasing relationship attributes
EWI must not become E W I
2020-04-17 22:02:10 +02:00
Philipp Wolfer
7539d8dc23 PICARD-1751: Provide a ~releasecountries variable 2020-02-19 21:55:23 +00:00
Philipp Wolfer
a9cb192f00 PICARD-1646: Consider release types for AcoustId results
Make the release primary and secondary type as provided by AcoustId available to the matching.
2020-01-29 19:25:36 +01:00
Philipp Wolfer
14277c18b5 PICARD-1288: Added unit tests 2019-02-20 12:55:33 +01:00
Michael Wiencek
f908e66a1e PICARD-1471: Artist searches do not show begin and end area
The search server outputs these property names with hyphens, not
underscores.

MBS does output them using underscores for artist lookups, but (1)
Picard doesn't appear to perform any artist lookups, and (2) MBS will be
fixing that to use hyphens as well.
2019-02-13 02:50:59 -06:00
Philipp Wolfer
5988bd66ad PICARD-1395: Load MusicBrainz genres 2018-11-25 17:08:49 +01:00
Philipp Wolfer
96c7f2f082 PICARD-1354: Allow using instruments and vocals as credited 2018-09-25 15:07:33 +02:00
Philipp Wolfer
3a380e2355 PICARD-1162: Fix solo attribute for vocals / instruments (#979) 2018-09-22 10:37:49 +02:00
Sambhav Kothari
b0d412169c Add null type tests 2017-07-26 16:12:12 +05:30
Sambhav Kothari
844eca9eaa Fix null type errors and add test data for null types 2017-07-26 16:09:34 +05:30
Laurent Monin
5aa025619e Fix null catalog-number and/or label cases, add matching tests 2017-07-25 15:41:03 +02:00
Sambhav Kothari
506d59e5c6 PICARD-1119: Fix wrong metadata parsing
Fixes https://tickets.metabrainz.org/browse/PICARD-1119
2017-07-22 01:46:53 +05:30
Sambhav Kothari
9062a69c1b Add acoustid json parser test 2017-07-18 15:24:34 +05:30
Sambhav Kothari
22586506cc Fix tests and add test data 2017-07-16 18:33:08 +05:30
Sambhav Kothari
43a33c5f03 Add more test data 2017-07-13 17:04:27 +05:30
Sambhav Kothari
ee8a56b48d Add tests for mbjson 2017-07-13 16:58:12 +05:30