Commit Graph

2008 Commits

Author SHA1 Message Date
Michael Wiencek
d5509680ab Fix tests 2013-06-09 01:45:18 -05:00
Michael Wiencek
7c4fdf765c Make config and log importable
Conflicts:

	picard/ui/mainwindow.py
2013-06-09 00:52:18 -05:00
Wieland Hoffmann
63b241e053 Merge branch 'tests_formats_fix' of https://github.com/zas/picard 2013-06-08 10:23:32 +02:00
Laurent Monin
3ea141dfe2 Fix test_mp4 failure AssertionError: 'image/jpeg' != 'image/png'
value is already a MP4Cover, calling it again just set the format to default
JPEG, causing this issue on load.
2013-06-08 01:01:27 +02:00
Laurent Monin
e03c091e57 Fix test_ape failure due to incorrect APEValue type (auto)detection.
Force APEValue type on save to mutagen.apev2.BINARY, it is needed because
mutagen is trying to detect type, and set it to TEXT, and when it is tested
on load (apev2.py _load()), it doesn't detect cover tag because it isn't of
the BINARY type as expected.
2013-06-08 00:59:33 +02:00
Laurent Monin
b246e4b709 Reduce cover art vs formats test code redundancy. 2013-06-08 00:54:09 +02:00
Laurent Monin
5bc82bfa53 Fix tests for cover art vs formats, they couldn't fail. 2013-06-08 00:45:59 +02:00
Michael Wiencek
2d620e6f1e whitespace 2013-06-05 15:02:10 -05:00
Michael Wiencek
c96475e957 Merge branch 'Sophist-UK-sophist_match_track_lengths_within_1s' 2013-06-05 15:00:50 -05:00
Sophist
20d7debd6c Change matching fuzziness to 2s 2013-06-05 20:55:13 +01:00
Michael Wiencek
3f161a2147 Merge pull request #111 from Sophist-UK/sophist_fix_qtreeitem_vertical_alignment
Fix vertical alignment with right-aligned lengths
2013-06-05 10:58:56 -07:00
Sophist
591eee0fcf Fix vertical alignment with right-aligned lengths 2013-06-05 18:18:15 +01:00
Sophist
3f6c64da87 Changed to implement bitmap's alternative approach 2013-06-05 13:54:33 +01:00
Sophist
8dc7a80a8f Make track lengths within 1s of each other match
Due to minor timing differences when ripping a CD, it is common for
tracks to differ by up to 1s in length.

This commit enhances metadatabox to show lengths +/- 1s as matching.

Note: Means of converting mmm:ss to seconds is not elegant - anyone with
a better solution please say.
2013-06-03 22:49:48 +01:00
Michael Wiencek
1703188dbd Merge pull request #104 from Sophist-UK/sophist_length_rightjustify
Set Length fields in files and collections to be right justified
2013-06-01 08:54:42 -07:00
Sophist
62b2e9621d Set Length fields in files and collections to be right justified
Sets the alignment for all length fields to be right justified in the
files and collections QTreeWidgets.
2013-06-01 07:59:18 +01:00
Michael Wiencek
dbe900b0b7 Remove py2app hacks that are no longer necessary (using 0.7.4) 2013-05-24 23:02:53 -07:00
Michael Wiencek
55b457fcfc Kill tab character
This is what I get for using an unconfigured gVim on Windows.
2013-05-24 22:43:03 -05:00
Michael Wiencek
ddc5dbebc9 Make the previous commit actually work... 2013-05-24 22:37:52 -05:00
Michael Wiencek
d9a7988052 Include Qt accessibility plugin in the windows build 2013-05-24 21:24:59 -05:00
Michael Wiencek
6585b3762c Improve accessibility descriptions for the main panels 2013-05-24 21:00:31 -05:00
Michael Wiencek
5afe42f1f9 run build_ui on ui/options_tags.ui 2013-05-24 14:59:15 -05:00
Michael Wiencek
3e6d253213 Merge branch 'master' of github.com:musicbrainz/picard into sophist_options_tags 2013-05-24 14:58:30 -05:00
Michael Wiencek
e57e70a826 Merge pull request #101 from Sophist-UK/sophist_ignore_fpcalc_discid
Add *.exe to ignore list
2013-05-24 08:04:32 -07:00
Michael Wiencek
9ef74b5273 don't call setKerning, change groupbox names 2013-05-24 09:24:03 -05:00
Michael Wiencek
734b18cdf9 Fix tab order in metadata options 2013-05-23 12:26:33 -07:00
Michael Wiencek
61f0d8876a Allow tab access to toolbar, set tab order 2013-05-22 12:25:46 -05:00
Sophist
b81ded5bc9 Switch to *.exe (with new line at end) as recommended by Lukas 2013-05-22 13:31:01 +01:00
Sophist
436ef0bd42 Switch to *.exe as recommended by Lukas 2013-05-22 13:29:23 +01:00
Sophist
a85b8db0d9 Resequence ID3v1/2 fields in Options / Options / Tags
Resequenced ID3v2 fields so that they are together with ID3v1 fields
following - previously ID3v2 fields were split with an ID3v1 field
inbetween, This is less confusing to the user.
2013-05-22 13:02:27 +01:00
Sophist
baa671916d Add fpcalc.exe and discid.dll to ignore list
fpcalc and discid.dll are put in the development directories when you
build the development environment according to the instructions on the
musicbrainz web site - and they should not form part of the repo.
2013-05-22 12:57:03 +01:00
Sophist
036a78e02d Revert "Add fpcalc.exe and discid.dll to ignore list"
This reverts commit b5d48b5f95.
2013-05-22 12:35:41 +01:00
Sophist
b5d48b5f95 Add fpcalc.exe and discid.dll to ignore list
fpcalc and discid.dll are put in the development directories when you
build the development environment according to the instructions on the
musicbrainz web site - and they should not form part of the repo.
2013-05-22 12:10:30 +01:00
Michael Wiencek
9002d1b6c4 Use QXmlStreamReader instead of (the deprecated) QtXml
QtXml isn't maintained and is removed from Qt 5.
2013-05-21 01:43:49 -05:00
Michael Wiencek
b41555f912 Save files in order (again) 2013-05-18 13:04:06 -05:00
Michael Wiencek
e16b2533c2 Fix "vocal vocals" bug in performer: tag 2013-04-25 23:30:22 -05:00
Wieland Hoffmann
49bacdebd3 Merge branch 'master' of https://github.com/brainz34/picard 2013-04-24 16:05:59 +02:00
Wieland Hoffmann
ef08815348 Update NEWS.txt 2013-04-24 10:53:46 +02:00
Wieland Hoffmann
cd84dafe1d Merge branch 'version-info' of https://github.com/phw/picard 2013-04-24 10:47:56 +02:00
Philipp Wolfer
0d8f9b6078 Fixed exception in about dialog when libdiscid is not installed at all.
Signed-off-by: Philipp Wolfer <ph.wolfer@gmail.com>
2013-04-24 08:31:53 +02:00
Philipp Wolfer
d6e83a2963 Display version information for PyQt, Mutagen and libdiscid in about dialog. 2013-04-23 21:46:11 +02:00
Wieland Hoffmann
8afb747323 PICARD-296: Cover file is saved repeatedly
If overwrite was enabled, the else suite was executed which saved the
cover file once for each track of an album even if there was only one
file. Check if the filesize is the same as that of the file we're trying
to save - if it is, don't save the file again.
2013-04-22 13:03:03 +02:00
Wieland Hoffmann
e374c6db8f Add a note about unrecommended libdiscid versions 2013-04-17 12:12:39 +02:00
Wieland Hoffmann
a53509d182 Merge branch 'sparse_read' of https://github.com/JonnyJD/picard 2013-04-17 12:12:33 +02:00
brainz34
8bbb67c62c Fix: load_cluster() does not find existing cluster.
`load_cluster()` uses "artist" for looking up existing clusters, but
Cluster does not have a meta-data item "artist".

This bug does not show up when clustering all files at once (which
will be the case most times), as in this case a single cluster will be
calculated and only looked up once. But when clustering files in two
steps, a second cluster will be generated as the first one will not be
found.

Signed-off-by: brainz34 <brainz34@musicbrainz.org>
2013-04-15 11:53:42 +02:00
Michael Wiencek
a3fa949e29 Fix a rare TypeError in the metadatabox 2013-04-14 00:08:10 -05:00
Michael Wiencek
0b8600098b Merge pull request #92 from brainz34/master
Fix: Global plugins are overwriting User-plugins.
2013-04-12 12:04:55 -07:00
Michael Wiencek
63431b152d Merge pull request #74 from mwiencek/master
Load TXXX frames that conflict with Picard tags into the ~id3:TXXX namespace
2013-04-11 14:02:56 -07:00
brainz34
cccc1a3c1a Fix: Global plugins are overwriting User-plugins.
Since the global plugins (from picard/plugins) have been read *after*
the ones in user-plugindir, plugins got overwritten if they have the same
name. Now the user-plugindir is read after the globel one, thus the
user plugins are overwriting the global plugins -- which is more
appropriate.

Signed-off-by: brainz34 <brainz34@musicbrainz.org>
2013-04-11 21:23:42 +02:00
Wieland Hoffmann
243eed13b8 addrelease: initialize discnumber_shift outside the loop 2013-04-10 10:39:51 +02:00