Commit Graph

6784 Commits

Author SHA1 Message Date
Philipp Wolfer
d92d2ea903 PICARD-1692: Use ClickableSlider for all sliders in the UI
This better reflects user expectation and slider behavior in other applications across all platforms.
2019-12-11 22:43:29 +01:00
Philipp Wolfer
ed4353e94b Show file data in track columns
If only a single file is linked to a track and the data requested for a column is not available for the track, show the file column data instead.
2019-12-11 22:43:08 +01:00
Philipp Wolfer
31ce30e544 Fixed description label for preserved tags
Tags are now compared case insensitive
2019-12-11 22:39:42 +01:00
Philipp Wolfer
0f6310b431 ElidedLabel: If text is elided set full text as a tooltip 2019-12-11 22:39:12 +01:00
Philipp Wolfer
19f76b26f0 Move generic reusable widgets into picard.ui.widgets module 2019-12-10 22:46:17 +01:00
Philipp Wolfer
993e67cba8 playertoolbar: use ElidedLabel widget for media name label 2019-12-10 22:46:17 +01:00
Philipp Wolfer
5e12761fb7 Update picard.pot 2019-12-10 21:10:26 +01:00
Philipp Wolfer
1f5bd0675a Script editor: Fixed checkboxes not getting checked 2019-12-10 20:54:06 +01:00
Philipp Wolfer
dc38e54cb4 Script editor: Minor fix for checkboxes not fully visible with some Qt themes 2019-12-10 16:31:35 +01:00
Philipp Wolfer
13d2be1c29 Fixed EditTagDialog duplicating data on save
Editing already changed tags again duplicated all tag values.
2019-12-10 16:24:13 +01:00
Philipp Wolfer
c366d05845 Script editor: Fixed not full visible script names on macOS 2019-12-10 16:23:43 +01:00
Philipp Wolfer
0751439c1b ElidedLabel: Workaround for text wrapping with Breeze theme. 2019-12-10 16:23:43 +01:00
Philipp Wolfer
c5d9291c17 Refactored AdvancedScriptItem layout
Generated QHBoxLayout based layout in Qt Designer. This layout is simpler and provides better resize behavior.
2019-12-10 16:23:43 +01:00
Philipp Wolfer
08979b22d0 PICARD-1218: Properly truncate script names in script editor 2019-12-10 16:23:43 +01:00
Zenara Daley
30fee6e38f PICARD-1521: Add TOFN to ID3 metadata (#1401)
* Add TOFN to ID3 metadata

Co-authored-by: Andrew Wiggins <xandrewwiggins@gmail.com>
Co-authored-by: Wyll Brimacombe <wyll.brimacombe@gmail.com>
Co-authored-by: Raunaq Gupta <raunaqg10@gmail.com>
Co-authored-by: Matt Ehrler <mehrler12@gmail.com>

* Add internal tag name; check for expected value in test

Co-authored-by: Andrew Wiggins <xandrewwiggins@gmail.com>
Co-authored-by: Wyll Brimacombe <wyll.brimacombe@gmail.com>
Co-authored-by: Raunaq Gupta <raunaqg10@gmail.com>
Co-authored-by: Matt Ehrler <mehrler12@gmail.com>
2019-12-09 23:38:22 +01:00
Laurent Monin
e5e8d7e31f Merge pull request #1402 from zas/tags_tidyup
Tags utils tidyup
2019-12-09 15:57:14 +01:00
Laurent Monin
4090d68c3f Simplify display_tag_name()
There is no key ending with ':' in TAG_NAMES, so TAG_NAMES.get(name + ':', something) will always return something
2019-12-09 12:50:00 +01:00
Laurent Monin
e529ee7d71 Test display_tag_name() when name contains multiple double dot separators 2019-12-09 12:48:24 +01:00
Laurent Monin
6f251adc35 Sort TAG_NAMES dict by key in source code 2019-12-09 12:26:54 +01:00
Laurent Monin
91b9734d4c Make PRESERVED_TAGS a tuple rather than a list 2019-12-09 12:24:56 +01:00
Philipp Wolfer
007fd4e201 PICARD-1665: Only enable uninstall for user installed plugins 2019-12-07 18:41:57 +01:00
Philipp Wolfer
b4e2096e4e PICARD-1686: Always keep [non-album tracks] at first position 2019-12-07 18:39:38 +01:00
Philipp Wolfer
957516213a PICARD-170: Translate entries in column chooser context menu 2019-12-07 16:59:20 +01:00
Philipp Wolfer
d11548ad70 Update picard.pot 2019-12-07 16:16:32 +01:00
Philipp Wolfer
82447dd8a2 PICARD-1684: Allow reordering tag values in tag editor 2019-12-06 14:00:07 +01:00
Philipp Wolfer
cf4e683119 PICARD-1312: Enable mnemonics for buttons and other UI elements on macOS
On macOS mnemonics are disabled by default. But this also means that many UI elements (e.g. triggering buttons in dialogs) cannot be used with keyboard only as it is possible on other platforms. Enabling this on macOS allows better keyboard navigation for all users consistent across platforms.
2019-12-06 13:58:51 +01:00
Philipp Wolfer
aa49c4499c PICARD-1349: Allow resetting a column to unsorted state 2019-12-06 11:06:43 +01:00
Philipp Wolfer
bf6ab5d45d Update picard.pot 2019-12-05 12:06:49 +01:00
Philipp Wolfer
25636b4c59 Use new move icons also in cover art type selection dialog.
This needed some changes to the layout for consistent button sizes and placement.
2019-12-05 11:53:09 +01:00
Philipp Wolfer
f4fe3bfbf9 Added move right/left icons and use them for preferred metadata UI.
These icons match the move up/down icons for a consistent look.
2019-12-05 11:53:09 +01:00
Philipp Wolfer
1b4deae3bf Added custom move up/down icons
Using default icons from the theme does not work on Windows / macOS. These are custom icons created by myself.
2019-12-05 11:53:09 +01:00
Philipp Wolfer
e1354632d2 Wait longer initially for macOS notarization
Previously it could happen that the notarization request was not yet known when checking for the status and the service would respond with "Could not find the RequestUUID". Since the notaritzation process usually takes 2-5 minutes waiting for 1 minute initially should be fine.
2019-12-04 15:34:14 +01:00
Philipp Wolfer
5f394105e1 Disable manual sorting of compare_ignore_tags
The sort order for compare_ignore_tags does not matter. Sort entries automatically, disable manual sorting.
2019-12-04 15:06:20 +01:00
Philipp Wolfer
2cce50b61e PICARD-1683: Autocompletion for releasetype, releasestatus, releasecountry and media tags 2019-12-04 15:05:38 +01:00
Philipp Wolfer
b1f9f3a9ad PICARD-115: Show YYYY-MM-DD placeholder when editing date tags 2019-12-04 15:05:38 +01:00
Philipp Wolfer
3e8a0d8e56 Ignore syntax errors for prospector pyflakes checks.
On Codacy this does not support Python 3 syntax and we have other checks in place for syntax.
2019-12-04 10:31:48 +01:00
Philipp Wolfer
880682033c Introduce DISPLAY_NAME constant for use in metadata
This allows us to use the same value on multiple places where we need to specify a product display name for Picard.
2019-12-03 23:08:18 +01:00
Philipp Wolfer
f8ae841ccc PICARD-1682: Use multiline editor for lyrics and comments
This allows editing lyrics and comments in the metadatabox without loosing linebreaks.
2019-12-03 23:05:38 +01:00
Philipp Wolfer
e2e31c5fc3 Merge pull request #1389 from phw/customizable-columns
PICARD-170: Customizable main panel columns
2019-12-03 23:03:39 +01:00
Philipp Wolfer
05126bf0a4 EditableListView: Use default implementation for editor creation
Custom code now just adds the autocompleter, but otherwise this is the standard editor.
2019-12-03 16:37:10 +01:00
Philipp Wolfer
21f715dcb1 Fixed drag and drop in EditableListView 2019-12-03 11:11:25 +01:00
Philipp Wolfer
c901295df3 PICARD-170: Fille album media metadata in existing loop over media
Avoids separate looping over the media list
2019-12-03 09:37:21 +01:00
Philipp Wolfer
964a452a2d EditableListView: Mimic default QItemDelegate.createEditor behavior
This leads to consistent layout for our custom implementation and standard editors.
2019-12-03 08:45:59 +01:00
Philipp Wolfer
b59f09e9fb PICARD-170: Add a restore default columns action 2019-12-02 23:54:46 +01:00
Philipp Wolfer
f8f4740fca PICARD-170: Use QHeaderView to save / restore main panel column state
Simplifies code and also persists the column order.
2019-12-02 23:37:48 +01:00
Philipp Wolfer
1b037d6270 PICARD-170: Allow selecting displayed columns
Adds a context menu to the default pane headers to select the displayed columns. The default is unchanged, but additional columns can be selected by the user.
2019-12-02 23:37:48 +01:00
Philipp Wolfer
d9f31438a0 PICARD-1523: Compare preserved tags case-insensitive 2019-12-02 20:53:45 +01:00
Philipp Wolfer
e07c6a99c2 Github Actions: Cache libdiscid for macOS builds 2019-12-02 20:30:10 +01:00
Philipp Wolfer
fc1ed6671c Merge pull request #1385 from phw/gha-pr
Github Actions: Run on pull requests
2019-12-02 14:09:38 +01:00
Philipp Wolfer
0e052a95dd GHA: Do not run macOS packaging on changes to changelog-for-version.py 2019-12-02 14:08:40 +01:00