fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-05-04 18:16:11 +00:00
Code Issues Packages Projects Releases Wiki Activity
4,260 Commits 1 Branch 0 Tags
da3bbf414ff7bee80daea73c9996a64af6f0b403
Commit Graph

4260 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Antonio Larrosa
da3bbf414f Use picard.util.imageinfo.py::identify to guess the mimetype of dropped image data 
Replace the hack to identify the image format of the dropped
octet-stream with a call to imageinfo.identify which is used
in other parts of picard.
 2017-02-09 19:32:40 +01:00
Antonio Larrosa
2961ed0333 Rename the imageDropped signal to image_dropped 2017-02-09 10:43:25 +01:00
Antonio Larrosa
31768cf8f9 Rename variables to use snake-case 
Also, use log.debug instead of log.warning for a message
 2017-02-09 10:40:34 +01:00
Antonio Larrosa
f2e2188ba4 Fix various cover drop issues 
This patch adds https support, so users can drag covers from amazon.

Also fixes the imgurl query handling so users can drag covers from
google images thumbnails (but large resolution images will be downloaded).

It also adds support for dropped octet-stream data, so chromium users
can drag "opened" images from google images even if the link actually
points to the url containing the image, since chromium adds the
image data to the drop event. Unfortunately, firefox doesn't do that,
so firefox users will have to drag thumbnails (but the same large
resolution image will be used in any case)
 2017-02-09 10:40:34 +01:00
Laurent Monin
0b6207a40d PICARD-947: fix typo in parenthesis causing translation to fail 
The string was correctly parsed by gettext, but not translated at runtime.
 2017-02-09 00:07:17 +01:00
Laurent Monin
40114def9a Resync translations 2017-02-08 18:19:17 +01:00
Laurent Monin
78273d1722 Merge pull request #617 from samj1912/patch-11 
Refactor add_release_to_user_collections
 2017-02-03 22:12:03 +01:00
Sambhav Kothari
67da3428a9 Refactor add_release_to_user_collections 2017-02-04 00:58:15 +05:30
Laurent Monin
fc951c4926 Move collection related code to new add_release_to_user_collections() 
- it simplifies imports
- it will ease creation of unit tests
- outputs a debug line when it happens
 2017-02-03 14:19:14 +01:00
Laurent Monin
1b5a89ba8c Insert missing blankline (PEP8) 2017-02-03 14:15:45 +01:00
Laurent Monin
3980bb0138 Add __repr__() method to Collection class 2017-02-03 14:15:20 +01:00
Laurent Monin
abf3b4621e Fix commit d3cf9e5b: s/collection_list/collection_list[0]/ 2017-02-03 13:58:18 +01:00
Laurent Monin
27acdecaa0 Merge pull request #614 from samj1912/picard798 
PICARD-798: Handle empty collection list
 2017-02-03 12:21:25 +01:00
Sambhav Kothari
d3cf9e5bf5 PICARD-798: Handle empty collection list 2017-02-03 01:35:31 +05:30
Laurent Monin
2052bd326b Merge pull request #608 from Sophist-UK/PICARD-970_Set-buffer-size-to-data-size 
PICARD-970 Read files unbuffered in guess_format
 2017-02-02 18:46:15 +01:00
Laurent Monin
5deb33f371 Merge pull request #607 from Sophist-UK/PICARD-958_Fix-stderr-encoding 
PICARD-958: Fix-stderr-unicode encoding-errors
 2017-02-02 14:09:05 +01:00
Laurent Monin
89cd44e843 Merge pull request #611 from samj1912/patch-10 
Add travis build status to README
 2017-02-01 21:49:41 +01:00
Sambhav Kothari
b2faa57dcf Add travis build status to README 2017-02-02 01:25:47 +05:30
Laurent Monin
d0e56b90e1 Merge pull request #610 from samj1912/patch-9 
Remove sockets from py2exe exclude list
 2017-02-01 20:45:33 +01:00
Sambhav Kothari
aa8d889ab2 Remove sockets from py2exe exclude list 2017-02-02 01:11:40 +05:30
Sophist
5005bc1aea Switch to unbuffered mode and add comment. 2017-02-01 15:28:21 +00:00
Sophist
5acf8c5dff PICARD-970 Set guess_format buffer size to read size 
Resolves [PICARD-970](https://tickets.metabrainz.org/browse/PICARD-970).
 2017-02-01 14:05:41 +00:00
Sophist
3f305acdf2 Remove unneeded imports 2017-02-01 12:56:24 +00:00
Sophist
0d133e225d PICARD-958_Fix-stderr-unicode encoding-errors 2017-01-31 18:58:41 +00:00
Wieland Hoffmann
7075b1935f Merge branch 'master' of github.com:musicbrainz/picard 2017-01-29 15:53:30 +01:00
Wieland Hoffmann
605e225b3e Remove an unneeded import 2017-01-29 15:52:37 +01:00
Wieland Hoffmann
2113a13d60 submit_rating: Properly pass query arguments 
Since 8ebe83b69e, query arguments should not be
added to the path, but passed as a separate argument to the HTTP method methods
on the web service object. Do so in submit_ratings.
 2017-01-29 15:49:10 +01:00
Lukáš Lalinský
ffcbbec156 Use python-discid 1.1.1 2017-01-29 13:13:50 +01:00
Laurent Monin
0180d0cf41 Drop os.path.realpath(), partly reverting PR 599 
See discussion at d5f3ca3665 (r98327865)
 2017-01-28 11:28:42 +01:00
Laurent Monin
bda972d0e7 Merge pull request #605 from Sophist-UK/patch-4 
PICARD-958: Avoid dir/file name unicode errors
 2017-01-28 09:53:37 +01:00
Sophist
fdc905b0aa PICARD-958: Avoid dir/file name unicode errors 
Resolves [PICARD-958](https://tickets.metabrainz.org/browse/PICARD-958).

When dir or file names contain unicode characters and debug logging is on, then debug.log statements which use %s placeholders cause the following error:
```
Traceback (most recent call last):
  File ".\picard\tagger.py", line 315, in event
    event.run()
  File ".\picard\util\thread.py", line 34, in run
    self.func(*self.args, **self.kwargs)
  File ".\picard\log.py", line 116, in _stderr_receiver
    sys.stderr.write(formatted_log_line(level, time, msg + os.linesep))
  File "C:\Program Files (x86)\Python2\lib\encodings\cp850.py", line 12, in encode
    return codecs.charmap_encode(input,errors,encoding_map)
UnicodeEncodeError: 'charmap' codec can't encode character u'\u2010' in position 77: character maps to <undefined>
```
 2017-01-27 20:29:18 +00:00
Laurent Monin
32e531d5a6 Merge pull request #599 from Sophist-UK/patch-2 
PICARD-950: Don't open same folder multiple times
 2017-01-27 11:39:33 +01:00
Sophist
3df8ff193d Replace code with that proposed by Zas 2017-01-27 10:06:36 +00:00
Sophist
d5f3ca3665 Use set.add not set.append 2017-01-26 20:42:23 +00:00
Sophist
0eb9b242c2 Use set instead of list 2017-01-26 20:40:42 +00:00
Sophist
0d9b9f08f0 PICARD-950: Don't open same folder multiple times 
Resolves [PICARD-950](https://tickets.metabrainz.org/browse/PICARD-950)

This will need rebasing after #598 is merged.
 2017-01-26 20:40:41 +00:00
Laurent Monin
bdeea8d6b0 Merge pull request #602 from Freso/update-jira-links 
Update links to ticket tracker.
 2017-01-26 20:26:46 +01:00
Laurent Monin
94cf35a593 Merge pull request #598 from Sophist-UK/patch-1 
PICARD-942: Fix explore/play remote folders/files
 2017-01-26 20:19:07 +01:00
Lukáš Lalinský
ad5cce79c9 Add docs for building the os x packages 2017-01-26 18:57:45 +01:00
Sophist
97d29c8ef2 Add comment to code referring to Qt bug. 2017-01-26 17:29:45 +00:00
Frederik “Freso” S. Olesen
71bf0fa1a8 Update links to ticket tracker. 
Using:
`sed -i 's|http://tickets.musicbrainz.org|https://tickets.metabrainz.org|' $(git grep -l tickets.musicbrainz -- './*' ':!*.po')`
 2017-01-26 18:19:31 +01:00
Lukáš Lalinský
b62de843ae Avoid accessing config.setting on module level 2017-01-26 15:56:19 +01:00
Sophist
a8a96a6bdf PICARD-942: Fix explore/play remote folders/files 
Resolves [PICARD-942](https://tickets.metabrainz.org/browse/PICARD-942).

Make "Open Containing Folder" and "Open in Player" work for remote files.

See [QTBUG-13359](https://bugreports.qt.io/browse/QTBUG-13359) for cause and workaround.

Tested on Windows. Needs testing on Mac / Linux.
 2017-01-26 10:44:46 +00:00
Laurent Monin
6d88f091d4 Merge pull request #597 from lalinsky/fix-osx-package 
Fix OS X package
 2017-01-26 08:54:37 +01:00
Laurent Monin
19f98ed860 Merge pull request #596 from samj1912/patch-8 
Correct the variable naming style and docstring language fix
 2017-01-26 08:46:49 +01:00
Lukáš Lalinský
f70b49f0bb Fix OS X package 
It seems that if the ini-based config was initialized before creating the app instance,
Qt would do a different initialization sequence and some configs would not be loaded.
That caused it to not look for plugins in the app bundle.
 2017-01-25 22:05:55 +01:00
Sambhav Kothari
2ad5936372 Correct the variable naming style 2017-01-26 01:22:03 +05:30
Lukáš Lalinský
979347ddca Build OS X packages in GitLab 2017-01-25 19:54:17 +01:00
Laurent Monin
2ff74bad2b Merge pull request #593 from samj1912/patch-7 
Add python style guide
 2017-01-25 18:18:15 +01:00
Sambhav Kothari
5d603c1b18 Add guideline for i18n 2017-01-25 21:37:32 +05:30