fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-02-04 06:43:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
6,847 Commits 1 Branch 0 Tags
dd6790d18cd5f39c729be2d58a4136cddf928e46
Commit Graph

6847 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Philipp Wolfer
dd6790d18c Set constant for default icon size in main table columns 2020-01-13 15:41:38 +01:00
Philipp Wolfer
63cb098006 PICARD-34: Fingerprint indicators shows submission status 
The fingerprint indicator is shown in red for unsubmitted fingerprints and gray for submitted fingerprints. The tooltip explains the status.
 2020-01-13 15:39:54 +01:00
Philipp Wolfer
7df2c2cb96 Ensure main panel columns are resizable after restore 2020-01-13 15:39:54 +01:00
Philipp Wolfer
b04649c597 PICARD-34: Use custom column widget for fingerprint indicator 
Allows for nicer icon placement without reserved space for column text.
 2020-01-13 15:39:54 +01:00
Philipp Wolfer
ce72861b07 PICARD-34: Paint fingerprint icon in fingerprint status column 2020-01-13 15:39:53 +01:00
Philipp Wolfer
7409113624 PICARD-34: Add a AcoustId column to main panel 
This column both shows the AcoustId and a fingerprint icon indicating that the fingerprint was generated for the file.
 2020-01-13 15:39:53 +01:00
Philipp Wolfer
515df3a0aa Downgrade setuptools for CI builds 
Latest setuptools 45.0 is breaking PyInstaller, see 555c5e8163/PyInstaller/hooks/hook-pkg_resources.py
 2020-01-13 14:59:04 +01:00
Philipp Wolfer
6488683d82 Fixed AcoustId lookup loading empty nat 
Fixes a regression introduced in 2cc0b35 were an AcoustId lookup loading a NAT showed an empty NAT.
 2020-01-13 14:06:28 +01:00
Philipp Wolfer
51404a9cbb Revert "Use PyInstaller 3.5 for macOS builds" 
This reverts commit c336ba778c.
 2020-01-13 09:00:04 +01:00
Philipp Wolfer
c336ba778c Use PyInstaller 3.5 for macOS builds 
PyInstaller 3.6 is causing runtime errors on start.
 2020-01-13 08:39:08 +01:00
Philipp Wolfer
172df0a831 Do not use virtualenv on macOS builds 
This fixes recent build errors and unifies the bild scripts with the Windows version.
 2020-01-13 08:24:05 +01:00
Philipp Wolfer
1636fcb310 PICARD-1703: Upgrade to PyInstaller 3.6 
Allows us to remove some Windows specific workarounds, fixes a CVE related to the portable onefile install.
 2020-01-11 15:09:01 +01:00
Philipp Wolfer
18e1932294 Removed no longer needed StartupWMClass 2020-01-10 08:28:18 +01:00
Philipp Wolfer
f1cde96ac6 PICARD-1054: Allow Qt to handle default Qt and X command line arguments 2020-01-10 08:28:18 +01:00
Philipp Wolfer
17bd114a18 Fix initialization of QApplication with argv 2020-01-10 08:28:18 +01:00
Philipp Wolfer
f40bdceb29 PICARD-1699: Fix run fingerprinting after asking user to enable it 
When fingerprinting is disabled and the user tries to use scan, Picard asks the user if they want to open the options to configure fingerprinting. After the user has enabled fingerprinting Picard is supposed to perform the action. This commit restores this functionaility which broke in f8eb755.
 2020-01-07 18:18:11 +01:00
Philipp Wolfer
ff7d3dc7e0 Removed unused CI configurations 2020-01-07 18:16:55 +01:00
Philipp Wolfer
f3b06786f1 CI: Test with PyQt 5.13.2 (in addition to current 5.14.x) 2020-01-07 15:52:09 +01:00
Philipp Wolfer
0d695dc8ce Update picard.pot 2020-01-07 15:43:03 +01:00
Philipp Wolfer
51732187c0 On Scan only run fpcalc if the fingerprint was not already calculated. 
Since there is now a dedicated "Generate fingerprints" action the user can still choose to re-generate the fingerprints if needed. Also they can first use "Generate fingerprints" and do the lookup based on those fingerprints later.
 2020-01-07 11:18:39 +01:00
Philipp Wolfer
7b0b501f8a PICARD-991: Add action to generate AcoustId fingerprints without lookup 
This just fingerprints the files, without actually searching for matches. This allow users who just want to submit fingerprints to analyze already matched files or to analyze and match files manually.
 2020-01-07 11:18:39 +01:00
Philipp Wolfer
cf08b00275 Use PyQt 5.14.1 for Windows builds 2020-01-07 11:17:32 +01:00
Philipp Wolfer
4abd360fe9 Replaced undocumented initialization of QAction with checkable=True 
Using checkable=True in QAction constructor is undocumented. It is working currently but might break in future versions similar to how QActionGroup(..., exclusive=...) broke with PyQt 5.14.
 2020-01-07 09:01:31 +01:00
Philipp Wolfer
32e05058e0 PICARD-1700: Fix crash on PyQt >= 5.14 on cover art context menu 
In PyQt 5.14 the exclusive parameter for QActionGroup is no longer available. Also QActionGroup is exclusive by default in Qt5, so there is no need to set this.
 2020-01-07 09:01:31 +01:00
Philipp Wolfer
65bc122940 Merge pull request #1422 from phw/fix-version-compare 
Implement proper version comparison for dev, alpha, beta and rc releases
 2020-01-04 14:59:04 +01:00
Philipp Wolfer
ef638cb57e picard.spec: Simplify macos version generation 
Make use of new Version class functionality.
 2020-01-03 14:42:45 +01:00
Philipp Wolfer
79e931444e Implement Version on top of namedtuple 2020-01-03 14:38:09 +01:00
Philipp Wolfer
83de668fdf Refactor Version.to_string and Version.from_string to improve readability 2020-01-03 14:26:40 +01:00
Philipp Wolfer
2f1b6d79da Implement proper version comparison for dev, alpha, beta and rc releases 
The version identifier was previously compared alphabetically, which fails for e.g. "dev" < "alpha".

Implement proper version comparison by introducing a Version class (inherited from tuple).
 2020-01-03 14:25:15 +01:00
Philipp Wolfer
53a0894e98 PICARD-1682: Fix multiline metadatabox wrapping issues 
Elided text + automated word wrap does not work properly. Qt only wraps the text properly if it fits into the given height, otherwise it switches to manual line breaks.

Hence change the rendering to only use manual line breaks. This still gives better results for lyrics and comments without breaking the display.
 2020-01-02 16:22:01 +01:00
Philipp Wolfer
95c3689a86 PICARD-1665: Refactoring for detecting user installed plugins 2019-12-31 17:17:54 +01:00
Philipp Wolfer
775db88649 PICARD-1665: Normalize plugin and const paths for better comparisson 
Without this path comparisson to check wheter a plugin is installed in the user plugin dir fails on Windows.
 2019-12-31 17:17:54 +01:00
Philipp Wolfer
7e6b74013d PICARD-1695: Move logic to add and remove scripts to ScriptListWidget 2019-12-25 09:00:07 +01:00
Philipp Wolfer
6a785eed25 PICARD-1695: Allow inline editing of script names 
Removed the separate input for the script name in the script editor and enabled inline editing in the script list. Added a context menu for the editing.
 2019-12-25 09:00:07 +01:00
Philipp Wolfer
b3d281c50c Merge pull request #1418 from phw/rework-script-editor 
PICARD-1695: Rework script editor
 2019-12-21 08:01:11 +01:00
Philipp Wolfer
2ef3d6db58 Add VS Code config giles to gitignore 2019-12-19 17:31:26 +01:00
Philipp Wolfer
19dbf005ca Fix "Other versions" context menu not being active 2019-12-18 23:59:52 +01:00
Philipp Wolfer
e5baf0046a Scripting options: Explicitly ignore only script errors in display_error 
This avoids error handling being skipped for other exceptions.
 2019-12-17 19:58:48 +01:00
Philipp Wolfer
04b1bc2cc7 PICARD-1695: Make script editor delete confirmation window modal 2019-12-17 19:44:29 +01:00
Philipp Wolfer
b1a8fbb2b5 PICARD-1695: Make scripts sortable by drag and drop 2019-12-17 19:44:29 +01:00
Philipp Wolfer
500622851e PICARD-1695: Removed buttons from script editor ist 
The functionality is now enabled by buttons outside of the list view.
 2019-12-17 18:04:08 +01:00
Philipp Wolfer
452436df0b PICARD-1695: Move script editor control elements below the list view 
This makes the UI more consistent with similar views in options.
 2019-12-17 18:04:07 +01:00
Philipp Wolfer
aac11effdc GHA: Run tests with older dependencies 2019-12-17 17:35:15 +01:00
Philipp Wolfer
fdff636448 Merge pull request #1417 from phw/unify-up-down-arrows 
Unify up down arrows in options UI
 2019-12-17 11:23:56 +01:00
Philipp Wolfer
f293223f70 Consistently place list editors in options inside of QGroupBox 2019-12-17 08:51:48 +01:00
Philipp Wolfer
3d3afa679e taglisteditor: enable move up/down only if moving is possible 2019-12-17 08:39:12 +01:00
Philipp Wolfer
39feb44230 Unify position and size of buttons for list re-ordering 
This makes the taglisteditor widget consistent with existing list re-ordering UI for cover art and toolbar buttons.
 2019-12-17 08:38:48 +01:00
Philipp Wolfer
d426520c32 Unify list up/down arrow icons 
Use custom icons for consistency.
 2019-12-17 08:10:17 +01:00
Philipp Wolfer
f45933b099 GHA: Run tests before macOS and Windows builds 2019-12-17 00:37:53 +01:00
Philipp Wolfer
2636228853 GHA: Continue preparing release even if changelog extraction fails 2019-12-16 21:12:14 +01:00