Laurent Monin
e01896ee76
PICARD-1175: save and restore CD Lookup dialog and headers states
2018-02-01 16:18:59 +01:00
Sambhav Kothari
e3002811a2
Merge pull request #825 from samj1912/discid
...
Add discid to windows builds
2018-02-01 17:35:43 +05:30
Sambhav Kothari
a8b355a901
Add discid to windows builds
2018-02-01 17:24:14 +05:30
Sambhav Kothari
48285795eb
Merge pull request #824 from samj1912/fpcalc
...
Bundle fpcalc with distributables
2018-01-31 23:32:42 +05:30
Sambhav Kothari
62efdb1c48
Move pyinstaller related env variables to utils and add documentation
2018-01-31 23:22:09 +05:30
Sambhav Kothari
9f3cb9ced8
Re-search for fpcalc path on each execution if running as a packaged distributable
2018-01-31 23:22:09 +05:30
Sambhav Kothari
f5632873e3
Use 64 bit binaries for fpcalc
2018-01-31 23:22:09 +05:30
Sambhav Kothari
bb0b04ec16
Add fpcalc to data files
2018-01-31 21:56:46 +05:30
Sambhav Kothari
060560ce18
Search for fpcalc in MEIPASS if packaged
2018-01-31 21:56:46 +05:30
Laurent Monin
470c953803
Merge pull request #823 from zas/searchdialog_minorcleanup
...
Search dialog code minor cleanup
2018-01-31 16:21:22 +01:00
Laurent Monin
c7e45a6134
Object name string shouldn't be translated, remove _()
2018-01-31 12:06:33 +01:00
Laurent Monin
9de7041597
Remove obsolete FIXME comment
2018-01-31 12:04:00 +01:00
Laurent Monin
15365a21d9
Update attributes
2018-01-30 16:14:18 +01:00
Laurent Monin
1cafd84fe4
Update picard.pot
2018-01-30 16:09:35 +01:00
Laurent Monin
d86cf1b007
Merge pull request #822 from zas/search_sort
...
Fix sorting in SearchDialog
2018-01-30 10:33:40 +01:00
Laurent Monin
9244e01a6e
SearchDialog: return the correct row (in the data array) on accept
...
There was a mix up between row in the data and in the table widget.
Without sorting, those are the same (no row re-ordering), but when sorting is enabled it breaks.
2018-01-30 00:22:55 +01:00
Laurent Monin
038eac0295
SearchDialog: Fix sorting for numbers and durations
2018-01-30 00:22:55 +01:00
Laurent Monin
ee4f4831da
Merge pull request #820 from zas/searchdialog_nosort
...
searchdialog: disable sorting as it is broken by design
2018-01-29 21:00:19 +01:00
Laurent Monin
be29f5e5e1
Merge branch 'master' into searchdialog_nosort
2018-01-29 20:39:00 +01:00
Laurent Monin
6d8b55d484
Merge pull request #814 from zas/adjust_throttle_cleanup
...
Move throttling code to its own file
2018-01-29 20:32:33 +01:00
Laurent Monin
8df1e78af4
Move throttling code to its own file
...
API is modified to use methods to get/set delays, instead of setting global variables
2018-01-29 18:24:56 +01:00
Sambhav Kothari
a8ad99b7bd
Merge pull request #819 from samj1912/newlook
...
Use Fusion style for Picard
2018-01-29 19:27:56 +05:30
Laurent Monin
4e02efeac4
Merge branch 'master' into newlook
2018-01-29 14:52:44 +01:00
Laurent Monin
0549d29705
searchdialog: disable sorting as it is broken by design
...
Current code relies on row number to identify the selected item, and therefore,
after sorting, it returns the data at the row position BEFORE sorting
Fixing it requires more work, using QTableView and models.
2018-01-29 14:23:47 +01:00
Laurent Monin
dd4fc3831a
Merge pull request #815 from zas/searchdialog_split
...
Explode searchdialog.py in a submodule with 4 files
2018-01-29 14:00:32 +01:00
Laurent Monin
2b0a918508
Explode searchdialog.py in a submodule
2018-01-29 13:46:56 +01:00
Sambhav Kothari
4dde478ac9
Use Fusion style for Picard
2018-01-29 17:23:50 +05:30
Sambhav Kothari
43900f8530
Merge pull request #818 from yagyanshbhatia/PICARD-1067
...
PICARD-1067: Visual bug after un-checking an installed plugin
2018-01-29 15:01:09 +05:30
yagyanshbhatia
81e4214d89
Fix Visual bug after un-checking an installed plugin
...
plugins if unchecked and clicked on make it so, get disabled, but
the checkbox still shows checked.
2018-01-29 14:56:31 +05:30
Sambhav Kothari
131c2d4359
Merge pull request #817 from samj1912/pyinstaller
...
Use pyinstaller to package builds
2018-01-29 14:51:52 +05:30
Sambhav Kothari
8c006e05a0
Remove unnecessary path
2018-01-29 04:13:06 +05:30
Sambhav Kothari
e82c2bc573
Fix SSL errors in Windows 7
2018-01-29 04:07:00 +05:30
Sambhav Kothari
d7acd638ca
Remove duplicate tests
2018-01-29 02:29:27 +05:30
Sambhav Kothari
38431eec15
Update appveyor config
2018-01-29 02:00:44 +05:30
Sambhav Kothari
9d000b299d
Fix windows path
2018-01-29 02:00:44 +05:30
Sambhav Kothari
6eab0559c5
Use pyinstaller to package builds
2018-01-29 02:00:44 +05:30
Laurent Monin
45aaba7880
Merge pull request #810 from zas/search_dialog_cleanup2
...
Search dialog cleanup
2018-01-27 20:49:45 +01:00
Laurent Monin
dc386ff455
Make on_show KV parameter explicit
2018-01-27 20:33:01 +01:00
Laurent Monin
9a469fe003
Enable table sort by column
...
- it is a bit tricky, prolly the reason it wasn't enabled
- it doesn't use models/proxys etc... so it is limited (for example, length field will not be sorted correctly)
- a column 'score' was added for the user to be able to sort by it (table rows were sorted by score, because order of items in the query result is sorted like this, but there was no way to restore this order without such column)
- not perfect, but still better than no sort at all
- `show_table()` is now called after rows insertion, `prepare_table()` has to be called before
2018-01-27 20:33:01 +01:00
Laurent Monin
3f0c287ed9
Reduce space around cover art images, optimize row height/column width
2018-01-27 20:33:01 +01:00
Laurent Monin
4d43a88b6e
Fix image loading when the dialog is wide enough to show cover widgets from start
...
In this case, is_visible() was called before the widget was actually drawn.
2018-01-27 20:33:01 +01:00
Laurent Monin
3419501924
Only fetch cover art if the cell containing it is visible
2018-01-27 20:33:01 +01:00
Laurent Monin
7aab7e80f8
CoverWidget: implement sizeHint()
2018-01-27 20:33:01 +01:00
Laurent Monin
1d74c2edde
AlbumSearchDialog: stop tasks when the dialog is closed
...
Asynchronous cover art download tasks are started for each row, but those aren't removed if the dialog is closed
2018-01-27 20:33:01 +01:00
Laurent Monin
6c8a3aaa01
Use colpos('cover') instead of assuming the cover column is the last one
2018-01-27 20:33:01 +01:00
Laurent Monin
065c9cf3a8
Remove unused table_item
2018-01-27 20:33:01 +01:00
Laurent Monin
304853ad80
ArtistSearchDialog: use SearchDialog.set_table_item()
2018-01-27 20:33:01 +01:00
Laurent Monin
13095caf61
TrackSearchDialog: use SearchDialog.set_table_item()
2018-01-27 20:33:01 +01:00
Laurent Monin
f32b3eb055
AlbumSearchDialog: use an helper method and shorten lines
2018-01-27 20:33:01 +01:00
Laurent Monin
e912db441a
ArtistSearchDialog: use SearchDialog.colpos() and get rid of hardcoded positions
2018-01-27 20:33:01 +01:00
