fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-03-01 19:13:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,817 Commits 1 Branch 0 Tags
e1d651db720ce47e082279cebcf65637a3f017bb
Commit Graph

3817 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
suhas2go
e1d651db72 follow pep8 and mark strings for translation 2016-12-17 18:58:20 +05:30
suhas2go
b22f3144ac make text appropriate as tooltips 2016-12-16 02:34:43 +05:30
suhas2go
82232c614b change to tooltips 2016-12-16 02:24:19 +05:30
suhas2go
75e1d286d6 Added track match quality info 2016-12-13 20:03:03 +05:30
suhas2go
2ebdcf41a2 Add missing info of different album icons 2016-12-13 18:55:42 +05:30
Wieland Hoffmann
dcc91099a2 Don't recommend nose while the test are broken when using it 
[ci skip]
 2016-12-12 18:35:51 +01:00
Wieland Hoffmann
0a65151b71 He, she, it, das 's' muss mit 
[ci skip]
 2016-12-12 18:35:46 +01:00
Wieland Hoffmann
7dfc47a7f6 PICARD-853: Don't iterate over empty tracklists 
Mediums with only data tracks (like disc 2 of
https://musicbrainz.org/release/5855689f-db31-476c-9207-1b966ed44e07) don't have
track elements in their track-list element, so make sure we don't try to access
them.
 2016-12-06 19:58:48 +01:00
Wieland Hoffmann
1e52735275 Merge branch 'setupcfg' 2016-11-20 16:06:10 +01:00
Wieland Hoffmann
db9072bcaa Add setup.cfg to ignore flake8 errors 
This ignores E501 (line too long), some indentation related errors and
configures gettext functions as known builtins, which makes the error
list for most files very short.

Messages in the generated UI files are ignored as well.

This reduces the number of warnings from ~2300 to ~200.
 2016-11-20 12:50:04 +01:00
Wieland Hoffmann
8e0118c6de PICARD-852: Use HTTPS for requests to the plugins API on picard.mbo 2016-11-05 14:32:08 +01:00
Wieland Hoffmann
46dbab97b9 Fix a missing traceback import 2016-10-24 17:30:04 +02:00
Wieland Hoffmann
03a9166799 Fix missing *Dialog class imports 2016-10-24 17:28:20 +02:00
Wieland Hoffmann
b4fa0f4a3f Fix lookups by work id 2016-10-24 17:21:27 +02:00
Wieland Hoffmann
3dabab86b4 Merge branch 'master' of github.com:musicbrainz/picard 2016-10-24 17:21:19 +02:00
Laurent Monin
5870f6db2b Merge pull request #489 from Barami/master 
PICARD-848: Cannot fetch cover art from amazon link contains https scheme.
 2016-10-22 17:18:16 +02:00
barami
8f0617c282 Add comment to amazon url scheme test 2016-10-22 23:30:06 +09:00
Wieland Hoffmann
63afd12b76 Remove an unused import 2016-10-22 13:50:57 +02:00
Wieland Hoffmann
96e79a6962 delete_from_collection: Call _get_client_queryarg instead of passing it along 2016-10-22 12:50:12 +02:00
barami
4274bc54ff Add unit test for test to parsing of https amazon url 2016-10-22 14:57:15 +09:00
barami
6959dcf6b0 make shoter regex for https amazon url parsing 2016-10-22 14:47:33 +09:00
barami
7d35cdf40a Allow extract amazon host and asin for https 2016-10-16 14:01:54 +09:00
Laurent Monin
cb9b6294e2 Merge pull request #487 from rahul-raturi/embed_search_artist 
Search for artists from dialog
 2016-09-11 14:13:58 +02:00
Rahul Raturi
fbbae01894 Skip search dialogs for mbid lookups 
If mbid is of a release, directly load it into Picard, else open web
browser for more details.
 2016-09-11 15:59:34 +05:30
Rahul Raturi
939f44ab32 Setup artist search dialog 
The dialog displays basic information in search results, like gender,
type etc.  The artist can be looked up in browser after selection.
 2016-09-10 09:36:17 +05:30
Rahul Raturi
639383f910 Change accept event according to dialog 
For example, for an artist dialog, loading into picard is not suitable.
Each child class of `SearchDialog` will provide an `accept_event` method,
which will call appropriate handler function for that event.
 2016-09-08 00:15:39 +05:30
Rahul Raturi
17d6b6d6ed Connect artist dialog to main window 2016-09-08 00:14:22 +05:30
Rahul Raturi
841c322b64 Add method to parse artist XML node 2016-09-08 00:14:22 +05:30
Laurent Monin
0998feecae Update picard.pot 2016-09-05 21:31:33 +02:00
Laurent Monin
f5b08931de Resync .po files 2016-09-05 21:30:17 +02:00
Laurent Monin
e24684aa98 Add accelerator key to button: "&Load into Picard" 2016-09-05 21:28:20 +02:00
Laurent Monin
09df7f8fb7 Merge pull request #486 from rahul-raturi/embed_search_release 
Search releases from within a Picard dialog
 2016-09-05 21:23:14 +02:00
Rahul Raturi
3f114fda2c Try capturing focus in event rather than out 
The accept button needs to be disabled to allow searching on pressing
return. If not disabled, the dialog closes on return. In commit a44c375,
focus out event of the table was used to disable the load button. This
doesn't works as the button will be disabled when user moves the mouse
towards the button (focus moves out of the table).
To avoid this, capture focus in event of `search_edit` widget.
 2016-09-05 17:05:34 +05:30
Rahul Raturi
a1d948b9b8 Get column count dynamically 2016-09-05 17:05:33 +05:30
Rahul Raturi
c8d71a9633 Define query limit as constant 
25 is the standard limit for number of results returned.
 2016-09-05 17:05:30 +05:30
Rahul Raturi
036cfd0d3d Table may not exist after reply is recieved 
If that's the case, do nothing. This may happen if user starts another
request before existing one is finished.
 2016-09-05 11:11:34 +05:30
Rahul Raturi
a44c375011 Trigger search action on pressing return 
Some noticeable points:
* Disable search action when query field (search box) is empty.
* Return also triggers accept event. To avoid this, each time focus moves
out of table, disable the accept button. This would allow searching
without the dialog getting closed.
 2016-09-05 11:11:34 +05:30
Rahul Raturi
795a42f027 Update window title to be consistent 2016-09-05 11:11:34 +05:30
Rahul Raturi
518212db8e Update comments and remove unnecessary ones 
Also add copyright information.
Signed-off-by: Rahul Raturi <rhlrtr44@gmail.com>
 2016-09-05 11:11:34 +05:30
Rahul Raturi
46b6c4e0ec Update advanced syntax setting instantly... 
... with checkbox state changes.Updating the state and reopening the dialog
for it to actually affect the query seems counter intuitive. Also, no need to
save state when dialog closes, as the setting will already be updated.
 2016-09-05 11:11:34 +05:30
Rahul Raturi
ca058262bb Check for label element's children 
In some nodes, empty `label` element may exist. In such cases, exception
is thrown when trying to access label name.
 2016-09-05 11:11:34 +05:30
Rahul Raturi
8d87e17d28 Don't use album dialog for unmatched file cluster 2016-09-05 11:11:34 +05:30
Rahul Raturi
2eb2a501d4 Rename some variables and update text 2016-09-05 11:11:34 +05:30
Rahul Raturi
7a84cf9ca3 Display query when searching cluster 
Also, update comments to be more specific and concise.
 2016-09-05 11:11:34 +05:30
Rahul Raturi
8ca51c8846 Minor fixes: Use named tuple in album dialog ... 
... and replace `len(list)` with just `list` for testing whether it's
empty or not, as it's more pythonic.
 2016-09-05 11:11:34 +05:30
Rahul Raturi
db81a7b059 Display cover arts of searched releases 2016-09-05 11:11:34 +05:30
Rahul Raturi
e52135fd83 Connect album dialog to main window 2016-09-05 11:11:34 +05:30
Rahul Raturi
89e268341a Setup album search dialog 
The dialog is somewhat analogous to track search dialog. Some noticeable
points are:

* Allow searching for albums from clusters, by right clicking.
* Move save and restore state/size logic to individual classes, from parent
class `SearchDialog`. Both dialogs have different number of columns, and
elements.
 2016-09-05 11:11:34 +05:30
Rahul Raturi
f8559fdd7c Move code to extract iso codes to separate method 2016-09-05 11:11:34 +05:30
Rahul Raturi
c5ba18392e Don't use count element... 
... for purpose of extracting label information. Reason being, `count`
element isn't present in `label_info_list` element of search xml.
Checking for length of children has same effect as with checking count
element.
 2016-09-05 11:11:34 +05:30