Commit Graph

6284 Commits

Author SHA1 Message Date
Philipp Wolfer
e404bc7c81 Merge pull request #1212 from phw/PICARD-1549-windows-pip-install
PICARD-1549: Fixed pip install on Windows
2019-07-14 17:50:26 +02:00
Laurent Monin
8ebf3645df PICARD-1552: simplify code and drop a part that makes no sense 2019-07-14 17:49:35 +02:00
Philipp Wolfer
c64cebf3f1 PICARD-1551: Consider search score when comparing files to NATs 2019-07-09 11:31:05 +02:00
Philipp Wolfer
c7e1648ad9 PICARD-1549: Removed dependency on PyQt5 from setup.py 2019-07-07 15:33:09 +02:00
Philipp Wolfer
a801c3a5d1 PICARD-1549: Include windows installer files in source distribution
Enables installing on Windows using pip.
2019-07-07 15:04:52 +02:00
Sambhav Kothari
9401ed7a21 Merge pull request #1211 from kmosiejczuk/master
Add test *.aac files to MANIFEST.in
2019-07-06 22:21:26 +01:00
Kurt Mosiejczuk
d5dcc3d09e Add test *.aac files to MANIFEST.in so that source tarball for PyPI
has all the data files for the tests
2019-07-06 16:49:55 -04:00
Philipp Wolfer
66c27b95b4 Merge pull request #1210 from kmosiejczuk/master
Switch import of install from distutils to setuptools to support --single-version-externally-managed
2019-07-06 20:58:42 +02:00
Kurt Mosiejczuk
6a190a5c60 Making setuptools install change fit requested picard style by using
isort on setup.py
2019-07-06 12:40:39 -04:00
Kurt Mosiejczuk
3f5018f423 Switching to importing install from setuptools to support
--single-version-externally-managed so I can update the OpenBSD
picard port
2019-07-06 12:37:18 -04:00
Laurent Monin
d141f019c2 Merge pull request #1208 from zas/PICARD-1546
PICARD-1546: Truncate tracks in Other Releases menu when too many media
2019-07-02 21:28:06 +02:00
Laurent Monin
713ef9bd9f Merge pull request #1209 from zas/similiraty2_test
Add tests for similarity2()
2019-07-02 21:27:24 +02:00
Laurent Monin
cf4ac13d9a Add few tests for similarity2() function 2019-07-02 14:41:06 +02:00
Laurent Monin
64c3bb8795 No need to use u"" syntax anymore 2019-07-02 14:40:27 +02:00
Laurent Monin
2306244e42 Add coding magic comment
Even though Python 3 defaults to utf8, it is still useful for editors
2019-07-02 14:39:58 +02:00
Laurent Monin
4a6b7b2175 PICARD-1546: Truncate tracks in Other Releases menu when too many media 2019-07-02 12:17:38 +02:00
Laurent Monin
84f253e719 Merge pull request #1207 from zas/internal_player_checks
Internal player checks
2019-06-26 22:48:21 +02:00
Laurent Monin
0e47869729 Only catch ImportError exception 2019-06-26 17:37:06 +02:00
Laurent Monin
938e5d4c89 Improve internal player availability detection and error handling 2019-06-26 16:55:29 +02:00
Timur Enikeev
72841404b8 QtMultimedia availability check added 2019-06-26 15:25:56 +02:00
Laurent Monin
c2a61728f4 Merge pull request #1206 from zas/assertEquals_is_deprecated
unittest.assertEquals() is deprecated in favor of assertEqual()
2019-06-24 21:28:23 +02:00
Laurent Monin
38f78c4069 unittest.assertEquals() is deprecated in favor of assertEqual() 2019-06-24 19:07:18 +02:00
Philipp Wolfer
4b116ac20a PICARD-1541: Hide log dialogs instead of destroying 2019-06-24 18:14:07 +02:00
Philipp Wolfer
99d872e9a5 Merge pull request #1202 from metabrainz/PICARD-1529-fix-nat-coverart
PICARD-1529: Avoid loaded NATs getting assigned cover art from other NATs
2019-06-24 17:56:47 +02:00
Philipp Wolfer
4db29cf190 PICARD-1533: Set Qt.AA_EnableHighDpiScaling before appication gets created 2019-06-24 17:55:43 +02:00
Philipp Wolfer
40f12e5eb2 Simplified metadata comparisson in tests 2019-06-24 14:59:22 +02:00
Philipp Wolfer
604e542d10 Check if images get copied in test for Metadata.update() 2019-06-23 11:39:38 +02:00
Philipp Wolfer
0c57969735 PICARD-1529: Allow copying metadata without images 2019-06-23 11:35:18 +02:00
Laurent Monin
694006275c Merge pull request #1194 from timur-enikeev/PICARD-1488
PICARD-1488: Internal music player feature added
2019-06-17 15:41:40 +02:00
Laurent Monin
9887d57a7c Merge pull request #1199 from zas/colors
PICARD-1524: Make colours user-configurable
2019-06-17 10:37:35 +02:00
Philipp Wolfer
884221ae61 PICARD-1529: Avoid loaded NATs getting assigned cover art from other NATs 2019-06-17 09:04:02 +02:00
Timur Enikeev
7c8972493f First implementation of an internal audio player (PICARD-1488 issue) 2019-06-16 19:49:48 +02:00
Laurent Monin
4489eedfc8 Warn user about the fact color changes may only apply after a restart 2019-06-12 10:15:15 +02:00
Laurent Monin
2f45d40017 PICARD-1524: Make colours user-configurable 2019-06-12 10:04:12 +02:00
Laurent Monin
b3eeb55995 Merge pull request #1200 from zas/logview_fix
PICARD-1525: Only update log/history views when actually displayed
2019-06-11 16:08:49 +02:00
Laurent Monin
3211dc3f9d Merge pull request #1201 from zas/PICARD-1522
PICARD-1522: Fix exception caused by an attempt to remove already removed NATS album
2019-06-11 16:07:52 +02:00
Laurent Monin
c6815c4fad Fix exception caused by an attempt to remove already removed NATS album
When removing an album and a non-album track, remove_nat() will call remove_album().
remove() loop over objects to remove, and call remove_album() again on the same object

This causes a KeyError: 'NATS' exception on del self.albums[album.id] execution

Solution: do not call remove_album() for NAT albums, as remove_nat() will take care of NATS pseudo album removal.
2019-06-11 13:24:18 +02:00
Laurent Monin
ee3a1c285b PICARD-1525: Only update log/history views when actually displayed
- override hideEvent() and showEvent() to connect/disconnect log_tail.updated signal
- only update display on showEvent()
2019-06-11 10:26:27 +02:00
Philipp Wolfer
0f1c4999fa PICARD-1506: Provide empty config for tests
If there is no empty config file Qt seems to initialize the specified config file path with a copy of the application's config.
2019-06-03 14:12:07 +02:00
Philipp Wolfer
3c5f1114a8 PICARD-1517: Fix running matchedtracks()/is_complete() on clusters 2019-05-31 06:05:10 +00:00
Laurent Monin
ccd80c061f Update attributes.py (medium format) 2019-05-30 15:37:56 +02:00
Laurent Monin
8291561b9d Resync picard.pot 2019-05-30 15:32:33 +02:00
Laurent Monin
6a43385d87 Merge pull request #1193 from zas/PICARD-1514
PICARD-1514: improve genres/tags filtering
2019-05-29 16:10:02 +02:00
Philipp Wolfer
9c709c7ee4 PICARD-1516: Fix loading / saving MP4 without tags 2019-05-29 13:34:11 +00:00
Laurent Monin
eac56b1b2b Set a duration for tool tips
On my platform they are never hidden if not set, even when typing in text fields.
Setting this duration improves things a bit, but i suspect an Qt bug.
2019-05-29 11:03:13 +02:00
Philipp Wolfer
d54b61bab3 Fix crash when saving after "keep original cover art.
Fix metadata.images getting turned into regular list under some circumstances.
2019-05-29 08:45:49 +00:00
Laurent Monin
eb260e52db Simplify code: no need to pass self.ui.test_genres_filter 2019-05-29 10:19:59 +02:00
Laurent Monin
9d0aa44487 Translate string
Note: actual error message cannot be translated (exception string)
2019-05-29 10:03:10 +02:00
Laurent Monin
27040dcf6d Reduce code redundancy directly using update_test_genres_filter() 2019-05-29 09:54:32 +02:00
Laurent Monin
99f99b7434 Minor code tidy up 2019-05-28 21:08:20 +02:00