Commit Graph

474 Commits

Author SHA1 Message Date
Laurent Monin
cf4ac13d9a Add few tests for similarity2() function 2019-07-02 14:41:06 +02:00
Laurent Monin
64c3bb8795 No need to use u"" syntax anymore 2019-07-02 14:40:27 +02:00
Laurent Monin
2306244e42 Add coding magic comment
Even though Python 3 defaults to utf8, it is still useful for editors
2019-07-02 14:39:58 +02:00
Laurent Monin
38f78c4069 unittest.assertEquals() is deprecated in favor of assertEqual() 2019-06-24 19:07:18 +02:00
Philipp Wolfer
40f12e5eb2 Simplified metadata comparisson in tests 2019-06-24 14:59:22 +02:00
Philipp Wolfer
604e542d10 Check if images get copied in test for Metadata.update() 2019-06-23 11:39:38 +02:00
Philipp Wolfer
0c57969735 PICARD-1529: Allow copying metadata without images 2019-06-23 11:35:18 +02:00
Philipp Wolfer
0f1c4999fa PICARD-1506: Provide empty config for tests
If there is no empty config file Qt seems to initialize the specified config file path with a copy of the application's config.
2019-06-03 14:12:07 +02:00
Philipp Wolfer
3c5f1114a8 PICARD-1517: Fix running matchedtracks()/is_complete() on clusters 2019-05-31 06:05:10 +00:00
Laurent Monin
99f99b7434 Minor code tidy up 2019-05-28 21:08:20 +02:00
Laurent Monin
1b08c55de5 Add TagGenreFilter.filter() method
Suggested by phw
2019-05-28 20:51:51 +02:00
Laurent Monin
1aee66ccff Pass filters directly instead of passing config.setting
Suggested by phw
2019-05-28 20:34:01 +02:00
Laurent Monin
cb6c2b8825 Strip whitespaces around expressions (after +/-), and tests 2019-05-28 15:25:50 +02:00
Laurent Monin
c50331abb7 Ignore case when matching strict, wildcard and regex genre filters 2019-05-28 12:30:55 +02:00
Laurent Monin
1bcad37f86 Handle upgrade, and provide a working UI for setting genres_filter
- bump Picard version to 2.2.0dev3 and add a hook to convert ignore_genres to genres_filter
- modify Genres UI
- add a playground to test genre_filter
- improve error handling
2019-05-27 14:53:34 +02:00
Laurent Monin
e02dc620a1 Replace ignore_genres with genres_filter
Syntax guide:

Whitespaces at start/end of line are stripped
Lines not starting with + or - are ignored

Strict matching:
-jazz

Wildcard matching:
-jazz*

Regex matching:
-/j.zz.*$/

Whitelisting:
-*
+jazz
2019-05-26 19:24:14 +02:00
Laurent Monin
985f19fb97 Refactor tag/genre ignore code, and add matching tests 2019-05-26 12:53:09 +02:00
Laurent Monin
7240889c78 Merge pull request #1188 from zas/lrucache_refactor
LRUCache: inherit from MutableMapping + tests
2019-05-09 13:04:47 +02:00
Laurent Monin
e263c80117 Merge pull request #1179 from zas/plugin_refactor_2
Plugin refactor: explode in smaller bits
2019-04-30 09:03:40 +02:00
Laurent Monin
2848b76f1c Improve script tests: use assertRaisesRegex() and remove useless self.fail()
Suggested by Mineo
2019-04-25 14:14:45 +02:00
Laurent Monin
13934fccde LRUCache: inherit from MutableMapping + tests 2019-04-19 18:40:28 +02:00
Laurent Monin
437c55ea2e Make wrong number of arguments script error message more explicit, along tests 2019-04-19 10:05:21 +02:00
Laurent Monin
c4ff226bd5 Move a big part of plugin.py to new pluginmanager.py 2019-04-18 11:30:08 +02:00
Laurent Monin
e5d1279183 Add tests for PluginManager.load_plugins_from_directory() 2019-04-18 11:14:48 +02:00
Laurent Monin
2d8a1f8136 Unload plugin before each test 2019-04-18 11:14:48 +02:00
Laurent Monin
6bacf2deb4 _get_test_plugins(): Ignore __pycache__ 2019-04-18 11:14:48 +02:00
Laurent Monin
7fceae05f7 Minor warnings fixes 2019-04-18 11:14:48 +02:00
Laurent Monin
1b1800ae75 Clean up plugin test files
- remove extra space in files
- add a MANIFEST.json to dummyplugin.picard.zip (and remove metadata from python file)
2019-04-18 11:14:48 +02:00
Laurent Monin
51e85f6883 PluginManager.install_plugin(): assert path or plugin_name, and test it 2019-04-18 11:14:47 +02:00
Laurent Monin
ae779631c1 Actually import DummyPlugin to ensure it was properly loaded 2019-04-18 11:14:47 +02:00
Laurent Monin
dd42b5e3bd Add tests for zipped plugin installed from picard plugins ws 2019-04-18 11:14:47 +02:00
Laurent Monin
f9cc6c1d81 packaged_module support is not really implemented 2019-04-18 11:14:47 +02:00
Laurent Monin
3634cbb99b TestPicardPluginsInstall: get rid of useless loop 2019-04-18 11:14:47 +02:00
Laurent Monin
f6f7b58c38 Add tests for PluginManager.install_plugin() 2019-04-18 11:14:47 +02:00
Laurent Monin
76487b0b0b Add tests for _plugin_name_from_path() 2019-04-18 11:14:47 +02:00
Laurent Monin
689fcdcc48 Drop PluginManager._api_versions, use picard.api_versions_tuple instead
- modify PluginManager._compatible_api_versions()
- add matching tests
2019-04-18 11:14:46 +02:00
Laurent Monin
45a6b20b85 Introduce picard.api_versions_tuple
- list of versions as tuples
- constant calculated from picard.api_versions
- add tests
- skip tests if not enough elements (previous code didn't make sense anyway)
2019-04-18 11:14:45 +02:00
Philipp Wolfer
dc0ec84401 isort: Consistently use two blank lines after import 2019-04-04 08:35:23 +02:00
Philipp Wolfer
dd4da2aa47 Updated isort config to put test imports in separate section 2019-04-04 08:32:22 +02:00
Philipp Wolfer
05fc98c64a Run isort over all files 2019-04-03 21:19:12 +02:00
Laurent Monin
fb6807636d Add tests for config upgrade functions 2019-04-03 12:22:53 +02:00
Laurent Monin
a63cc6bdd1 Rework config and add tests for it
- get rid of useless ConfigSection.__config
- use name instead of full key (as section name is fixed)
- add support for qt type
- remove _convert_to_bool(), unneeded with qt type support
2019-04-03 09:46:52 +02:00
Laurent Monin
0f1ca5379a Move to DEFAULT_FILE_NAMING_FORMAT to picard.const 2019-04-02 14:06:49 +02:00
Philipp Wolfer
7cf3945272 Removed unused imports 2019-03-29 10:55:28 +01:00
Philipp Wolfer
e41c683c0f Merge pull request #1160 from phw/fix-config-loading
Fix loading BoolOption from config
2019-03-29 09:10:20 +00:00
Philipp Wolfer
63cb114080 Always run tagger.run_cleanup for PicardTestCase 2019-03-29 08:59:14 +00:00
Philipp Wolfer
d0563fa5c4 Extended option test cases 2019-03-29 09:30:09 +01:00
Philipp Wolfer
0405f7acb5 Added tests for config options 2019-03-29 09:06:54 +01:00
Philipp Wolfer
ea9ad532b2 PICARD-1497: Mark invalid Apev2 keys as unsupported tags 2019-03-28 22:52:59 +01:00
Philipp Wolfer
dd12220e1e PICARD-1497: Mark invalid Vorbis keys as unsupported tags 2019-03-28 22:52:59 +01:00