Commit Graph

4921 Commits

Author SHA1 Message Date
Sambhav Kothari
ebcd87bab2 Merge pull request #792 from dseomn/picard-1123-multiple-languages
PICARD-1123: Multiple work languages are collapsed
2017-12-14 03:59:45 +05:30
David Mandelberg
429867501c PICARD-1123: Multiple work languages are collapsed
If the server provides multiple languages, use all of them. Otherwise, fall
back to the single language field.
2017-12-13 15:42:42 -05:00
Sambhav Kothari
0e430d50f0 Merge pull request #791 from paulroub/PICARD-1161-accept-chrome-images
Accept dragged images from Google Chrome
2017-12-12 22:32:36 +05:30
Sambhav Kothari
5315308100 Merge branch 'master' into PICARD-1161-accept-chrome-images 2017-12-12 22:24:18 +05:30
Sambhav Kothari
0aadf5dc53 Merge pull request #790 from mineo/picard-1159
PICARD-1159: Don't pass filenames as bytes to wave.open
2017-12-10 00:46:09 +05:30
Sambhav Kothari
35018c388f Merge branch 'master' into picard-1159 2017-12-10 00:41:16 +05:30
Paul Roub
c8104ccbc4 Accept dragged images from Google Chrome
On macOS, at least, images dragged from Chrome are rejected (there's no
octet stream data to be found).  Using the x-qt-image data instead --
only when the previously-used methods have failed.
2017-12-08 12:54:59 -05:00
Wieland Hoffmann
5dad06efe4 Merge pull request #789 from phw/handle-plugin-symlinks-on-update
Handle upgrade of plugin directories being symlinks
2017-12-06 19:31:54 +01:00
Wieland Hoffmann
8490422384 PICARD-1159: Don't pass filenames as bytes to wave.open
wave.open treats everything that's not a str as a file-like object.
encode_filename returns bytes, but they're not file-like.
2017-12-06 19:19:34 +01:00
Philipp Wolfer
949619751e Handle upgrade of plugin directories being symlinks
Fixes PICARD-1156
2017-11-27 12:57:07 +01:00
Sambhav Kothari
bcd58b513d Merge pull request #788 from metabrainz/picard1148
PICARD-1148: Fix ValueError due to change from XML to JSON
2017-11-12 22:28:41 +05:30
Sambhav Kothari
d9ed69dc6b PICARD-1148: Fix ValueError due to change from XML to JSON 2017-11-11 16:22:11 +05:30
Sambhav Kothari
c2f228269c Merge pull request #785 from Sophist-UK/picard-1143_always-hide-.smbdelete-files
PICARD-1143: Prevent loading .smbdelete* files
2017-10-23 23:39:06 +05:30
Sambhav Kothari
edd62be252 Merge branch 'master' into picard-1143_always-hide-.smbdelete-files 2017-10-23 23:13:58 +05:30
Sophist
acf0482c07 Refine comment very slightly 2017-10-23 15:33:36 +01:00
Sophist
5cc8fea2c4 Add explanatory comment and disregard hidden status to address review comments 2017-10-23 15:32:21 +01:00
Sambhav Kothari
5c9890f409 Merge pull request #786 from mineo/picard-1147
PICARD-1147: Handle media with only data tracks
2017-10-19 02:13:05 +05:30
Wieland Hoffmann
934fe93489 PICARD-1147: Handle media with only data tracks
In the JSON representation, these media do not have a 'tracks' element
containing the list of tracks.
2017-10-18 18:33:09 +02:00
Laurent Monin
9b0b3dbaa9 Merge pull request #784 from samj1912/picard1142
PICARD-1142: Fix crash on CD lookup
2017-10-05 08:59:11 +02:00
Sophist
09195d5a91 PICARD-1143: Prevent loading .smbdelete* files
.smbdelete files are temporary versions of files that should have been
deleted but cannot be due to  samba bug(?). We should not load these
files even if we have ignore-hidden-files unchecked.
2017-10-04 22:42:17 +01:00
Sambhav Kothari
fbe5f13640 PICARD-1142: Fix crash on CD lookup 2017-09-29 18:47:17 +05:30
Sambhav Kothari
1b5d849b69 Merge pull request #782 from vishichoudhary/picard-1138-attribute-error
PICARD-1138: Fix attribute error due to wrong value in string
2017-09-21 01:23:15 +05:30
vishichoudhary
ccdb1cd6b8 Fix attribute error due to wrong value in string 2017-09-20 22:20:56 +05:30
Laurent Monin
d0f54bb0c8 Merge pull request #781 from samj1912/v2manifest
Add v2 plugin manifest compatibility
2017-08-19 19:11:36 +02:00
Sambhav Kothari
9260201071 Add v2 plugin manifest compatibility 2017-08-17 14:42:14 +05:30
Laurent Monin
ece0e5f98b Merge pull request #780 from samj1912/picard1126
PICARD-1126: Add meaningful error log during lookup requests
2017-08-10 00:03:52 +02:00
Sambhav Kothari
f24263c189 PICARD-1126: Add meaningful error log during lookup requests 2017-08-10 01:55:57 +05:30
Laurent Monin
3a86873998 Merge pull request #777 from samj1912/variable
Fix undefined variable
2017-07-30 10:01:02 +02:00
Sambhav Kothari
69d3180804 Merge pull request #778 from samj1912/fix-ratings
PICARD-1114: Fix ratings submission
2017-07-29 00:52:55 +05:30
Sambhav Kothari
738a1dd5f6 Fix track id while loading 2017-07-29 00:15:37 +05:30
Sambhav Kothari
156ba39ec1 Add response parser arg to API Helper and fix submit rating parser 2017-07-29 00:15:26 +05:30
Sambhav Kothari
b7b25f5725 Fix undefined variable 2017-07-27 18:25:10 +05:30
Laurent Monin
a9665f632d Merge pull request #776 from samj1912/null
Fix null type errors while parsing API response
2017-07-26 14:04:08 +02:00
Sambhav Kothari
e3992302e5 Fix logical errors in code 2017-07-26 16:30:40 +05:30
Sambhav Kothari
b0d412169c Add null type tests 2017-07-26 16:12:12 +05:30
Sambhav Kothari
844eca9eaa Fix null type errors and add test data for null types 2017-07-26 16:09:34 +05:30
Sambhav Kothari
3ea07cb91a Fix more null type errors 2017-07-26 16:09:34 +05:30
Sambhav Kothari
9d5c6b05ab Fix null type errors 2017-07-26 16:09:34 +05:30
Laurent Monin
bdf2579966 Merge pull request #774 from samj1912/moretests
Add OSX tests
2017-07-25 23:05:10 +02:00
Sambhav Kothari
5b2e7c59d2 Allow fast finishing to not wait up on OSX builds 2017-07-26 00:03:52 +05:30
Sambhav Kothari
589f5e8e96 Add OSX tests 2017-07-26 00:03:52 +05:30
Laurent Monin
85cdb6f72f Merge pull request #775 from metabrainz/samj1912-patch-1
Use flat style badges
2017-07-25 20:30:09 +02:00
Sambhav Kothari
9efa91a6bf Use flat style badges 2017-07-25 23:16:01 +05:30
Laurent Monin
37bc535be5 Use shields.io for badges 2017-07-25 16:29:07 +02:00
Laurent Monin
9c701da4a7 Add AppVeyor Badge 2017-07-25 16:03:24 +02:00
Sambhav Kothari
3671664adb Merge pull request #773 from zas/fix_catnums_null
Fix null catalog-number and/or label cases, add tests
2017-07-25 19:25:09 +05:30
Laurent Monin
4f328dba79 LabelInfoTest: reduce code redundancy 2017-07-25 15:48:47 +02:00
Laurent Monin
5aa025619e Fix null catalog-number and/or label cases, add matching tests 2017-07-25 15:41:03 +02:00
Laurent Monin
57e1617b60 Merge pull request #772 from samj1912/moretests
Add windows testing
2017-07-24 21:17:15 +02:00
Sambhav Kothari
d7223f81a7 Add appveyor config for windows tests 2017-07-25 00:12:39 +05:30