1. Process network error instead of response
2. Error message on redirect loop
3. In both of the above call handler to avoid Loading Album message being stuck.
Received the following error when coverart was temp unavail:
D: 09:25:27 GET http://archive.org:80/download/mbid-8028cf3c-fcf5-4915-ae47-ca29b2875d64/index.json
Traceback (most recent call last):
File ".\picard\webservice.py", line 240, in _process_reply
cached
File ".\picard\log.py", line 81, in debug
main_logger.message(LOG_DEBUG, message, *args)
File ".\picard\log.py", line 58, in message
message = message % args
TypeError: %d format: a number is required, not NoneType
If you were ever annoyed by starting Picard from the console with a
specific folder, noticing you forgot the `-d`, stopping Picard, pressing
arrow-up, adding the `-d` to the end of the line, only to notice that
this didn't help at all, this commit is for you because now the option
parsing doesn't stop after the first thing that's not an option.
This new class stores the image data in a tempfile.TemporaryFile so we
don't keep the data for all images that are used somewhere in memory
anymore.
It also deals with saving images onto disk when the corresponding tracks
are saved (this was previously done by the File class). This removes the
ability to use tagger script in the cover file name (cf. the first line
of File._make_image_filename).
If two releases with same tracklist exists, we want to take digital media over CD (ie),
because most users are tagging digital files from unknown source and don't care
which exact release it is until tracklist is matching.
Worldwide is preferred by default, because if two releases exist with same tracklist
it is more likely it is the worldwide one's than a country-specific one.
Average user is expecting cover art to be shown in such application.
Set default size for CAA images to 500px.
All providers are enabled so the behavior is the same than MusicBrainz website
(which shows cover art from (ie.) Amazon by default).
For CAA, download only approved images by default.
68bf155 was overzealous in removing the conversion routines because
although sip does convert the values for us, that doesn't help if the
wrong type is already saved (hence why we're converting it in the
first place...).
This adds back that functionality. To solve the upgrade hook issue,
a `raw_value` method is added to the ConfigSection class so that
`__getitem__` isn't invoked during the upgrade (which is what wrongly
converted the value to begin with).
