fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-02-27 01:54:06 +00:00
Code Issues Packages Projects Releases Wiki Activity
7,535 Commits 1 Branch 0 Tags
edc3cfddeef6c78dcafe738b970408aa48b35fe9
Commit Graph

7535 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sophist
93907d5dfa Add NEWS 2014-03-10 07:43:05 +00:00
Sophist
3a3008eb06 Translate heading strings 2014-03-10 07:41:54 +00:00
Sophist
632efbc90a Reverting change to countries.py 2014-03-10 07:41:53 +00:00
Sophist
1ecb310e6c I18n of heading line. 2014-03-10 07:41:52 +00:00
Sophist
4b6235673e Fix indentation error 
Not sure how this crept in - but only causes an issue if no areas.
 2014-03-10 07:41:51 +00:00
Sophist
e67e49bfe4 Bug fixes 
Handle missing data correctly.

Handle unset preferred releases countries and formats

Move priority handling from releasegroup to itemviews so that if there
are two albums from same Release Group, then the list is displayed
correctly for each.
 2014-03-10 07:41:49 +00:00
Sophist
613a505835 Prioritise releases... 
... which have correct number of tracks, and match preferred release
countries and formats.
 2014-03-10 07:41:48 +00:00
Sophist
099146af4a Improve Other Releases menu 
1. Make sorting work
2. Change sequence to reflect importance of matching.
(Note: Not yet implemented, but it would be better if we matched
releases with same number of tracks as Album first.)
3. Add field heading to menu.
 2014-03-10 07:41:47 +00:00
Michael Wiencek
e9c3a5edc6 Merge pull request #234 from Sophist-UK/sophist_increase_priority_other_release_refresh 
Make other release selection more responsive
 2014-03-09 18:58:38 -05:00
Michael Wiencek
b457371252 Merge pull request #225 from Sophist-UK/sophist_add_itunes_composer_support 
Sophist add itunes composer support
 2014-03-09 18:23:54 -05:00
Sophist
e08dfc6600 Add NEWS 2014-03-09 19:43:38 +00:00
Sophist
8e23c53577 Make other release selection more responsive 2014-03-09 19:15:40 +00:00
Michael Wiencek
fb6aed78d7 Fix issue where QSettings returns QPyNullVariants in some versions of PyQt 2014-03-08 20:58:37 -06:00
Wieland Hoffmann
ccdd175059 Catch signals to perform cleanup tasks 
This currently does only quit Picard after it has regained focus (see
[0] and other answers to that question for the reason why). It also
doesn't work on windows right now because I have no way to test that.

[0] http://stackoverflow.com/a/4939113/307681
 2014-03-06 23:43:36 +01:00
Wieland Hoffmann
58f44f479a Delete cover files after running TestCoverArt 2014-03-06 23:43:02 +01:00
Wieland Hoffmann
3686fde72a Use a _delete method for deleting temporary image files 
__del__ was not getting called reliably when the interpreter shut down.
 2014-03-06 23:42:56 +01:00
Wieland Hoffmann
4aba28ad60 Use md5 hashes to make sure every images is only saved once 
make_and_add_image will use already existing images from Tagger.images
if the hash of the image is the same as that of an image in there.
 2014-03-06 23:42:49 +01:00
Wieland Hoffmann
82d83a95f0 Remove a super(...).__del__ call 
`object` does not actually have a __del__ method
 2014-03-06 23:42:31 +01:00
Wieland Hoffmann
111afc4fd9 Use tempfile.mkstemp to get a closable tempfile 
This makes sure we don't run out of file descriptors if many images get
loaded into Picard.
 2014-03-06 23:42:25 +01:00
Wieland Hoffmann
bc8b2c89f1 tis -> this 2014-03-06 23:42:06 +01:00
Wieland Hoffmann
05e844da01 Fix embedding only front images 
by using the images is_front_image attribute
 2014-03-06 23:42:01 +01:00
Wieland Hoffmann
9412d4b07e Fix a typo 
Not sure how that happened.
 2014-03-06 23:41:54 +01:00
Wieland Hoffmann
87153ed752 Catch IOErrors and OSErrors when creating Images 
They can happen if the disk is full or the user is not allowed to access
the folder where tempfile.TemporaryFile wants to create the file.
 2014-03-06 23:41:48 +01:00
Wieland Hoffmann
01cefae96e Use the same Image objects for all tracks of an album 2014-03-06 23:41:43 +01:00
Wieland Hoffmann
3b8b0e7df7 Use a separate class for dealing with images 
This new class stores the image data in a tempfile.TemporaryFile so we
don't keep the data for all images that are used somewhere in memory
anymore.

It also deals with saving images onto disk when the corresponding tracks
are saved (this was previously done by the File class). This removes the
ability to use tagger script in the cover file name (cf. the first line
of File._make_image_filename).
 2014-03-06 23:41:38 +01:00
Wieland Hoffmann
0fe492492e Revert "Merge branch 'image-class'" 
This reverts commit 6c72905c51, reversing
changes made to 005e591d80.
 2014-03-06 23:38:51 +01:00
Wieland Hoffmann
6c72905c51 Merge branch 'image-class' 
Conflicts:
	.gitignore
	NEWS.txt
	picard/ui/options/cover.py
	picard/ui/options/releases.py
	picard/webservice.py
	po/countries/et.po
	po/countries/pt_BR.po
	po/countries/zh_CN.po
	setup.py
 2014-03-06 23:33:01 +01:00
Wieland Hoffmann
f2d0ea7777 fixup! Catch signals to perform cleanup tasks 
Yikes, a that previous commit was in an in-between state and should not
have been pushed!
 2014-03-06 23:24:34 +01:00
Wieland Hoffmann
0e0c375745 Catch signals to perform cleanup tasks 
This currently does only quit Picard after it has regained focus (see
[0] and other answers to that question for the reason why). It also
doesn't work on windows right now because I have no way to test that.

[0] http://stackoverflow.com/a/4939113/307681
 2014-03-06 23:18:19 +01:00
Wieland Hoffmann
2f907bf549 Add a missing re import 
This is used by the code checking whether to ignore a to-be-loaded
directory.
 2014-03-06 23:09:43 +01:00
Laurent Monin
f977f3ada7 Set preferred releases to "Digital Media" and "[Worldwide]" by default. 
If two releases with same tracklist exists, we want to take digital media over CD (ie),
because most users are tagging digital files from unknown source and don't care
which exact release it is until tracklist is matching.

Worldwide is preferred by default, because if two releases exist with same tracklist
it is more likely it is the worldwide one's than a country-specific one.
 2014-03-06 23:09:43 +01:00
Laurent Monin
35cb0d7fb9 Download cover art by default, one front image only. 
Average user is expecting cover art to be shown in such application.
Set default size for CAA images to 500px.
All providers are enabled so the behavior is the same than MusicBrainz website
(which shows cover art from (ie.) Amazon by default).
For CAA, download only approved images by default.
 2014-03-06 23:09:43 +01:00
Laurent Monin
8c38bb58df Show cover art box by default. 
Average user is expecting cover art to be shown in such application.
 2014-03-06 23:09:43 +01:00
Laurent Monin
ab29fe22ff Remove user info from logged urls 
It is a safety measure as users may publish their logs ie. in bug reports.
 2014-03-06 23:09:43 +01:00
Laurent Monin
cc8e58b970 Add new po/countries/*.po files 2014-03-06 23:09:43 +01:00
Laurent Monin
264b438905 Regenerate picard.pot 2014-03-06 23:09:43 +01:00
Laurent Monin
253aa0d4f5 _exit() is not needed anymore, use sys.exit() 2014-03-06 23:09:43 +01:00
Laurent Monin
4ccb44c836 Use with open() as statements within generate_file() 2014-03-06 23:09:43 +01:00
Laurent Monin
a3316c5931 Call _exit() instead of raising Exception() 2014-03-06 23:09:43 +01:00
Laurent Monin
721180d8ca Use distutils.spawn.spawn() instead of subprocess.call(), simplify code 2014-03-06 23:09:42 +01:00
Laurent Monin
aa6df14701 Use distutils.spawn.find_executable to find tx (or tx.exe) 2014-03-06 23:09:42 +01:00
Laurent Monin
40d86a349c Use SystemExit() instance to set code together with message. 2014-03-06 23:09:42 +01:00
Laurent Monin
f4890ae6cb Not only maintainers can update picard.pot, everybody can. 2014-03-06 23:09:42 +01:00
Laurent Monin
f4ca571d48 Clarify the percentage thing. 2014-03-06 23:09:42 +01:00
Laurent Monin
23051a969a No need to know how countries.pot is generated. 
Keep a pointer to the project which updates it though.
 2014-03-06 23:09:42 +01:00
Laurent Monin
5ebe6419d2 Remove useless try/except 2014-03-06 23:09:42 +01:00
Laurent Monin
8a4fcc2805 Use a dict for countries instead of a list, and sort before writing to file 2014-03-06 23:09:42 +01:00
Laurent Monin
e52e93f6e1 country_list -> countries 2014-03-06 23:09:42 +01:00
Laurent Monin
608b05bdc9 Use os.path.join() to build path and define it as a variable not a parameter 
This method will hardly be called for anything else, having it as parameter
is not needed.
 2014-03-06 23:09:42 +01:00
Laurent Monin
848e489dba Only check if we can open po/countries/countries.pot and simplify code 2014-03-06 23:09:42 +01:00