Commit Graph

7535 Commits

Author SHA1 Message Date
Laurent Monin
0f0c3b0bdb Really enable lookup metadata action for cluster list.
When selecting non-empty cluster list, Lookup action was possible (button enabled, action called),
but no real action was taking place.
This patch enables it.
2013-01-22 23:02:12 +01:00
Lukáš Lalinský
5f26af39ab Merge remote-tracking branch 'zas/setup_translate' 2013-01-21 16:48:06 +01:00
Laurent Monin
c7c852caaa Set source outside the loop. 2013-01-21 16:27:47 +01:00
Laurent Monin
b8e1cc6dd7 Handle _translate() case for new pyuic versions
The code in setup.py replaces QtGui.QApplication.translate() with _(),
but it does not handle _translate(), this patch is fixing that.
2013-01-21 16:10:38 +01:00
Lukáš Lalinský
fe76da07e4 Merge pull request #84 from zas/QNetwork_cache_control
Implement QNetworkAccessManager-level caching
2013-01-21 05:44:53 -08:00
Laurent Monin
3bfe27ee41 Implement QNetworkAccessManager-level caching 2013-01-20 00:03:45 +01:00
Michael Wiencek
73877099fe small stylistic changes 2013-01-19 15:32:44 -06:00
Michael Wiencek
0b8fae4c32 Merge branch 'zas-info_dialog' 2013-01-19 15:22:13 -06:00
Michael Wiencek
a22a16adf5 Don't show other people's public collections 2013-01-18 20:39:42 -06:00
Laurent Monin
de521c31a2 Enable Informations dialog for albums, used to display metadata images.
It is using existing InfoDialog code, moved to a common class.
For now, first tab is just hidden as there is nothing to display in.
In Artwork tab, all metadata images associated with the album are shown.
Slight change in behavior is that pressing Informations button while an album is
selected was showing 1st track information, now it should album info.

Info dialog menu item is only available if album has images to display.
2013-01-18 20:19:42 +01:00
Laurent Monin
12f817c689 Move file item specific code to its own class FileInfoDialog 2013-01-18 19:06:58 +01:00
Laurent Monin
f0d90574e4 InfoDialog: hide artwork tab if empty 2013-01-18 19:05:40 +01:00
Laurent Monin
a189a753a0 InfoDialog: split display of each tab in separated methods 2013-01-18 19:05:40 +01:00
Laurent Monin
63c3af23b8 InfoDialog: add method to hide tabs 2013-01-18 19:05:06 +01:00
Lukáš Lalinský
63b17cf2af Handle error responses from AcoustID
http://tickets.musicbrainz.org/browse/PICARD-391
2013-01-14 22:06:38 +01:00
Laurent Monin
23c8271fbc CoverArtBox: preserve cover art aspect ratio on drawing
Cover is now placed correctly over the cover shadow, aspect ratio
is preserved.
2013-01-13 13:18:58 +01:00
Lukáš Lalinský
d3fcd06e32 Merge remote-tracking branch 'zas/caa_image_unknown' 2013-01-13 09:03:06 +01:00
Laurent Monin
bd45534630 CoverArtBox: fix incorrect extension matching (.png)
Code was incorrectly setting 'image/png' type for file 'img.png.jpg'
2013-01-13 00:05:43 +01:00
Laurent Monin
43cc06842c CAA downloader: fix CAA download of 'unknown' type images
When no type is set for an image, CAA is returning an empty list for types.
But Picard user has no way to specify he wants to also download images
of unknown type using the option 'Download only images of the following types'.

I added a special type named 'unknown' and modified _caa_json_downloaded() to
handle this case.
2013-01-12 21:46:21 +01:00
Wieland Hoffmann
0c8061d079 Merge branch 'optim_caa_approved' of https://github.com/zas/picard 2013-01-11 10:09:35 +01:00
Laurent Monin
ba5b275672 Remove forgotten debug print 2013-01-11 03:29:32 +01:00
Laurent Monin
a19f98cfef If option "caa_approved_only" is set, skip non-approved images asap. 2013-01-10 10:53:41 +01:00
Wieland Hoffmann
65d580c131 Merge branch 'master' of github.com:musicbrainz/picard 2013-01-08 21:53:56 +01:00
Wieland Hoffmann
7c134bbd13 fixup! Rename and preserve tags containing # so they can be used 2013-01-08 21:53:42 +01:00
Michael Wiencek
c7fa88a173 Merge branch 'master' of github.com:musicbrainz/picard 2013-01-08 13:19:29 -06:00
Michael Wiencek
994eb75c54 Add basic collections management support (PICARD-84)
Adds a "Collections" submenu to the album context menu.

The code is mostly based on my GSoC branch from a couple years ago,
but I made some heavy changes.
2013-01-08 13:16:31 -06:00
Wieland Hoffmann
ea928b4f39 Rename and preserve tags containing # so they can be used 2013-01-08 19:09:37 +01:00
Lukáš Lalinský
128931f687 Fix logical conflict (different fix from bitmap) 2012-12-30 17:16:02 +01:00
Lukáš Lalinský
bbdb11dada Merge branch 'master' of github.com:musicbrainz/picard 2012-12-30 17:14:54 +01:00
Lukáš Lalinský
be552f84ef Handle Unicode apostrophe as well
http://forums.musicbrainz.org/viewtopic.php?pid=20715
2012-12-30 17:14:07 +01:00
Lukáš Lalinský
29a79b5e54 Create a constant with the AcoustID hostname 2012-12-30 17:11:36 +01:00
Lukáš Lalinský
07b4d36e97 Fix error when there are no tags (filename is not a local variable) 2012-12-30 17:10:49 +01:00
Michael Wiencek
a29d225805 Merge branch 'master' of github.com:musicbrainz/picard into mwiencek-master 2012-12-18 23:06:03 -06:00
Michael Wiencek
c5ad7703e9 Load TXXX frames that conflict with Picard tags into the ~id3:TXXX namespace 2012-12-18 23:05:43 -06:00
Michael Wiencek
fc7e85e1cb Merge pull request #73 from mwiencek/master
PICARD-240: Save both primary and secondary release types
2012-12-18 08:39:38 -08:00
Michael Wiencek
173d425be5 Save both primary and secondary release types (PICARD-240) 2012-12-12 22:32:51 -06:00
Michael Wiencek
6fa84e2842 Allow adding custom tags in EditTagDialog (PICARD-349) 2012-12-12 21:11:34 -06:00
Wieland Hoffmann
e37a8475ed Merge branch 'master' of github.com:musicbrainz/picard 2012-12-06 23:22:07 +01:00
Wieland Hoffmann
db3d1fff46 Fix missing 'filename' variable 2012-12-06 23:18:41 +01:00
Lukáš Lalinský
1f0eadd3af Ignore non-ASCII characters in the UFID frame 2012-12-03 19:24:12 +01:00
Wieland Hoffmann
4506e46c1f Merge branch 'master' of github.com:musicbrainz/picard 2012-12-03 18:54:47 +01:00
Wieland Hoffmann
2917ea17d6 Reset dirname/filename/extension tags after saving 2012-12-03 18:54:20 +01:00
Wieland Hoffmann
b6fb613f26 Only set the ~extension tag once 2012-12-03 18:54:08 +01:00
Michael Wiencek
f68ae39d51 Make dropping files from newer iTunes work 2012-12-03 18:54:05 +01:00
Michael Wiencek
f3dd329552 'add new tag' writes to different field than specified (PICARD-348) 2012-12-03 18:54:05 +01:00
Wieland Hoffmann
1db77afa18 Merge branch 'master' of github.com:musicbrainz/picard 2012-11-29 15:38:10 +01:00
Wieland Hoffmann
5c56e01124 Accept https URLs on drop
Fixes PICARD-378
2012-11-29 15:35:54 +01:00
Wieland Hoffmann
9087e808bc Remove the jamendo cover art provider
The annotation for the jamendo label says to use the CAA and there's a
bot migrating existing cover art with only a few relationships left to
do.
2012-11-20 18:32:54 +01:00
Michael Wiencek
1da7180397 Make dropping files from newer iTunes work 2012-11-14 00:16:27 -06:00
Michael Wiencek
9dbbc42852 'add new tag' writes to different field than specified (PICARD-348) 2012-11-13 23:30:42 -06:00