Commit Graph

7535 Commits

Author SHA1 Message Date
Michael Wiencek
d5509680ab Fix tests 2013-06-09 01:45:18 -05:00
Michael Wiencek
7c4fdf765c Make config and log importable
Conflicts:

	picard/ui/mainwindow.py
2013-06-09 00:52:18 -05:00
Wieland Hoffmann
63b241e053 Merge branch 'tests_formats_fix' of https://github.com/zas/picard 2013-06-08 10:23:32 +02:00
Laurent Monin
3ea141dfe2 Fix test_mp4 failure AssertionError: 'image/jpeg' != 'image/png'
value is already a MP4Cover, calling it again just set the format to default
JPEG, causing this issue on load.
2013-06-08 01:01:27 +02:00
Laurent Monin
e03c091e57 Fix test_ape failure due to incorrect APEValue type (auto)detection.
Force APEValue type on save to mutagen.apev2.BINARY, it is needed because
mutagen is trying to detect type, and set it to TEXT, and when it is tested
on load (apev2.py _load()), it doesn't detect cover tag because it isn't of
the BINARY type as expected.
2013-06-08 00:59:33 +02:00
Laurent Monin
b246e4b709 Reduce cover art vs formats test code redundancy. 2013-06-08 00:54:09 +02:00
Laurent Monin
5bc82bfa53 Fix tests for cover art vs formats, they couldn't fail. 2013-06-08 00:45:59 +02:00
Michael Wiencek
f3015e741a Merge branch 'sophist_improve_status_counters' of git://github.com/Sophist-UK/picard into Sophist-UK-sophist_improve_status_counters 2013-06-07 01:50:57 -05:00
Sophist
6cc0b33871 Address review comments 2013-06-07 06:54:30 +01:00
Ionuț Ciocîrlan
e189a2f567 build_ui against options_renaming 2013-06-06 20:20:44 +03:00
Ionuț Ciocîrlan
b5f242dc77 new renaming setting 2013-06-06 20:19:13 +03:00
Ionuț Ciocîrlan
b8596dfb15 account for empty / non-absolute target directory; bugfix 2013-06-06 19:11:43 +03:00
Ionuț Ciocîrlan
6927824078 Merge remote-tracking branch 'upstream/master' 2013-06-06 16:41:45 +03:00
Sophist
c809968d1c Fix function and white space 2013-06-06 10:06:39 +01:00
Sophist
795ea5d1f2 Add cluster count 2013-06-06 08:07:49 +01:00
Sophist
50157734c7 Rename stuff to better reflect usage 2013-06-05 22:02:12 +01:00
Sophist
29d967e406 Remove incorrect comment. 2013-06-05 21:35:17 +01:00
Sophist
4a74a22084 Another minor terminology tweak in News.txt 2013-06-05 21:32:12 +01:00
Sophist
550b82f80e Fix terminology. 2013-06-05 21:28:57 +01:00
Sophist
ea89cd5a00 Resequence change notes. 2013-06-05 21:26:32 +01:00
Sophist
4b0c7d0a07 Remove spurious exception handler. 2013-06-05 21:23:39 +01:00
Michael Wiencek
2d620e6f1e whitespace 2013-06-05 15:02:10 -05:00
Michael Wiencek
c96475e957 Merge branch 'Sophist-UK-sophist_match_track_lengths_within_1s' 2013-06-05 15:00:50 -05:00
Sophist
20d7debd6c Change matching fuzziness to 2s 2013-06-05 20:55:13 +01:00
Michael Wiencek
3f161a2147 Merge pull request #111 from Sophist-UK/sophist_fix_qtreeitem_vertical_alignment
Fix vertical alignment with right-aligned lengths
2013-06-05 10:58:56 -07:00
Sophist
591eee0fcf Fix vertical alignment with right-aligned lengths 2013-06-05 18:18:15 +01:00
Sophist
2f637a5756 Provide more consistent status bar info and code
Still need to make "Unmatched Files" and "Clusters" FileTreeItems
consistent.
2013-06-05 18:00:21 +01:00
Ionuț Ciocîrlan
c17dbf215b setting renamed / repurposed 2013-06-05 19:39:37 +03:00
Ionuț Ciocîrlan
35780a0d98 a new approach to shortening filenames / paths 2013-06-05 18:45:43 +03:00
Sophist
3f6c64da87 Changed to implement bitmap's alternative approach 2013-06-05 13:54:33 +01:00
Sophist
9a11aded5b Address peer review comments
Improved object handling on file-save. Improved code for identification
of id3v23 true multi-value fields. etc.
2013-06-05 11:21:44 +01:00
Sophist
8dc7a80a8f Make track lengths within 1s of each other match
Due to minor timing differences when ripping a CD, it is common for
tracks to differ by up to 1s in length.

This commit enhances metadatabox to show lengths +/- 1s as matching.

Note: Means of converting mmm:ss to seconds is not elegant - anyone with
a better solution please say.
2013-06-03 22:49:48 +01:00
Sophist
399eea5016 Remove un-needed num_saves method 2013-06-03 22:09:47 +01:00
Sophist
f3e5a41492 Provide better activity stats in the status bar
Partial solution to PICARD-478
2013-06-03 21:46:01 +01:00
Sophist
9e675e4973 Handle TypeError on flattening 2013-06-03 17:34:59 +01:00
Sophist
9835cab8de Fix original values metadata class after save 2013-06-03 16:37:09 +01:00
Sophist
74121d709d Improve displayed values and comparison when saving id3v23 2013-06-03 16:11:36 +01:00
Sophist
2ad20b68a9 Add option for user to set concatenation character(s) for id3v23 multi-values 2013-06-03 16:04:46 +01:00
Sophist
738fbd94d5 Remove sorting for displayed multi-value tags and provide a sort tags plugin
Picard stores tags unsorted but displays them sorted and this is
inconsistent.

This commit removes display sorting of multi-value tags from Picard
improves consistency by displaying what will be / is actually saved.

This commit also provides a plug-in to allow user to sort tags both
displayed and stored in the file.
2013-06-03 08:17:53 +01:00
Sophist
1605adbd7b Handle Performer tags stored in ID3v2.3
Performer tags are stored as part of the IPLS tag in ID3v2.3 and this is
put into the TIPL tag when read by mutagen. This fix adds unknown TIPL
roles as Performer tags.
2013-06-02 22:21:08 +01:00
Michael Wiencek
1703188dbd Merge pull request #104 from Sophist-UK/sophist_length_rightjustify
Set Length fields in files and collections to be right justified
2013-06-01 08:54:42 -07:00
Sophist
62b2e9621d Set Length fields in files and collections to be right justified
Sets the alignment for all length fields to be right justified in the
files and collections QTreeWidgets.
2013-06-01 07:59:18 +01:00
Michael Wiencek
dbe900b0b7 Remove py2app hacks that are no longer necessary (using 0.7.4) 2013-05-24 23:02:53 -07:00
Michael Wiencek
55b457fcfc Kill tab character
This is what I get for using an unconfigured gVim on Windows.
2013-05-24 22:43:03 -05:00
Michael Wiencek
ddc5dbebc9 Make the previous commit actually work... 2013-05-24 22:37:52 -05:00
Michael Wiencek
d9a7988052 Include Qt accessibility plugin in the windows build 2013-05-24 21:24:59 -05:00
Michael Wiencek
6585b3762c Improve accessibility descriptions for the main panels 2013-05-24 21:00:31 -05:00
Michael Wiencek
5afe42f1f9 run build_ui on ui/options_tags.ui 2013-05-24 14:59:15 -05:00
Michael Wiencek
3e6d253213 Merge branch 'master' of github.com:musicbrainz/picard into sophist_options_tags 2013-05-24 14:58:30 -05:00
Michael Wiencek
e57e70a826 Merge pull request #101 from Sophist-UK/sophist_ignore_fpcalc_discid
Add *.exe to ignore list
2013-05-24 08:04:32 -07:00