Commit Graph

7535 Commits

Author SHA1 Message Date
Philipp Wolfer
06df904d9d PICARD-1974: Fix crash in Tags From Filenames
Fix crash in Tags From Filenames if same tag placeholder was used multiple times. Refactor the parsing and matching of the expression into separate class with tests.
2020-10-16 13:29:59 +02:00
Philipp Wolfer
53a2e3bb60 PICARD-1972: When matching files to tracks preserve track length (#1659)
PICARD-1972: Allow initializing Metadata with another Metadata object

If calling Metadata(other_metadata) make a full copy and don't just treat other_metadata as a dict.

Apart of making the API more intuitive this fixes issues with track metadata being not fully preserved when attaching files to tracks.
2020-10-16 13:27:10 +02:00
Philipp Wolfer
f4ebe91926 Fixed spelling of variable MuiDescriptionStartMenu in Windows installer 2020-10-15 22:06:01 +02:00
Philipp Wolfer
53f50dbd93 Release 2.5.0b1 2020-10-15 14:43:46 +02:00
Philipp Wolfer
b68b30603e Update constants 2020-10-15 14:38:59 +02:00
Philipp Wolfer
838f582154 Fixed variables in Hebrew installer translation 2020-10-15 14:32:40 +02:00
Philipp Wolfer
56fda0383e PICARD-1971: Fixed TagsFromFileNamesDialog not restoring saved window size 2020-10-15 08:49:23 +02:00
Laurent Monin
ca327f3c0e Fix missing timer parameter after changes introduced in bbcd54ea 2020-10-14 16:22:18 +02:00
Laurent Monin
fe1d9b72e4 Resync constants (mb attributes) 2020-10-14 12:29:57 +02:00
Laurent Monin
a8ae57721a Resync translations 2020-10-14 12:28:53 +02:00
Philipp Wolfer
9e6108bd21 Update translations 2020-10-11 17:33:20 +02:00
Philipp Wolfer
7a4740b621 Avoid label line break in advanced options view 2020-10-11 15:51:49 +02:00
Philipp Wolfer
b34f6fbbdf Update picard.pot 2020-10-11 15:19:39 +02:00
Philipp Wolfer
33555684ae Fixed moving files to clusters not working 2020-10-11 15:18:53 +02:00
Philipp Wolfer
bbcd54ea27 PICARD-1390: Set webservice transfer timeout on config changes
Avoid reading the config on each request
2020-10-11 11:45:45 +02:00
Philipp Wolfer
52abe10821 PICARD-1390: Allow configuring network timeout in options 2020-10-11 11:45:45 +02:00
Philipp Wolfer
a4d254dd7c PICARD-1390: Apply a timeout to network requests without data transfer
If a network request does not transfer any data for 30 seconds abort it. Prevents Picard getting stuck waiting on network requests.
2020-10-11 11:45:45 +02:00
Philipp Wolfer
6558fc6ad1 PICARD-1969: Fix browser integration port setting getting saved when canceling options 2020-10-11 11:45:45 +02:00
Philipp Wolfer
ff2c62c024 PICARD-534: Add support for SOCKS proxy 2020-10-10 17:04:40 +02:00
Philipp Wolfer
49464e95fd PICARD-1964: Support right-to-left text flow in scripting docs
Set the general text direction to right-to-left, but still render entire code blocks as left-to-right
2020-10-10 16:05:33 +02:00
Philipp Wolfer
1027dafa78 Fixed wrong indentation in script documentation 2020-10-09 13:46:35 +02:00
Philipp Wolfer
9916267fb9 Disable CodeQL for C code for now 2020-10-09 11:20:16 +02:00
Philipp Wolfer
c9bba31019 Create codeql-analysis.yml 2020-10-09 10:56:32 +02:00
Philipp Wolfer
4fd90db079 Fixed scripting documentation window not remembering size 2020-10-09 08:44:02 +02:00
Philipp Wolfer
2c83f4ecc5 PICARD-259: Have file metadata available when manually running script
Ensure that file metadata is also available to script when being run on a track manually after loading. If clear_existing_tags is present tags that would be deleted are not available. Technical variables are always available.
2020-10-09 08:13:19 +02:00
Philipp Wolfer
cedb3d7497 Update picard.pot 2020-10-08 19:51:08 +02:00
Philipp Wolfer
373908e1d1 PICARD-1965: Allow opening AcoustID options from missing API key dialog 2020-10-08 18:02:36 +02:00
Philipp Wolfer
957c921592 Merge pull request #1651 from phw/fix-clear-existing-tags
PICARD-259: Fix clear_existing_tags
2020-10-08 15:19:35 +02:00
Philipp Wolfer
e75bd0612a Merge pull request #1654 from phw/event-processing-iterator
Add process_events_iter to allow iteration while processing events
2020-10-07 20:52:45 +02:00
Philipp Wolfer
c3ccd6a392 Make MultiMetadataProxy fully compatible with Metadata
Run the same test cases against both Metadata and MultiMetadataProxy
2020-10-07 17:48:24 +02:00
Philipp Wolfer
38cfe4255d Time based approach for process_events_iter 2020-10-07 16:26:31 +02:00
Philipp Wolfer
8c16546aa9 Fixed variables in Hebrew installer translation 2020-10-07 14:28:58 +02:00
Philipp Wolfer
d0f788e6ca Added Hebrew and Portuguese (Brazil) installer translations 2020-10-07 13:32:56 +02:00
Philipp Wolfer
6816fd8b94 GHA: Migrate to using enviroment files
set-env and add-path are deprecated, see https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
2020-10-07 10:53:31 +02:00
Philipp Wolfer
0fb58520eb Fix CI builds for macOS and Windows by downgrading markdown
Building with markdown 3.3 causes some incompatibility with PyInstaller. Downgrade to 3.2.2 for macOS and Windows builds.
2020-10-07 10:38:55 +02:00
Philipp Wolfer
ce7215dd78 PICARD-1963: Avoid stack overflow when loading large amount of files
When loading a large list of files this could result in a stack overflow,
since tagger.move_files calls QCoreApplication.processEvents, which in
return might process an event to call tagger.move_files again, resulting
in a deep recursion.

Refactor the special case of moving a single file into a separate method.
2020-10-07 09:24:33 +02:00
Philipp Wolfer
96def71c6b PICARD-259: Use MultiMetadataProxy to make file metadata available to scripts 2020-10-06 20:06:49 +02:00
Philipp Wolfer
06508560f9 MultiMetadataProxy to combine multiple metadata objects 2020-10-06 20:04:52 +02:00
Philipp Wolfer
0b0eb06761 PICARD-1957: Only load files on double click in file browser
Double clicking on a folder expands it, do not also load it.
2020-10-06 17:00:44 +02:00
Philipp Wolfer
8012d54a5b Generate the process_events_iter iterator with yield 2020-10-06 15:37:33 +02:00
Philipp Wolfer
fbe16857f8 Add EventProcessingIterator to allow iteration while processing events
This acts as a wrapper around another iterable to allow running QCoreApplication.processEvents.
Instead of running processEvent on every iteration it is done in steps.
2020-10-06 15:16:31 +02:00
Philipp Wolfer
69b0d0e073 PICARD-1961: Keep instrument and other attributes spelling as is
This was introduced very eraly in d923c9a. Originally MB provided a more fixed list of instruments, with instrument names as attributes actually being camel cased.

This is no longer the case and instruments should now be used as given in the API response.
2020-10-05 10:43:52 +02:00
Philipp Wolfer
6b723d5f09 PICARD-259: Fix clear_existing_tags
This broke in 09c382f when scripting for file metadata was enabled.
2020-10-04 17:18:24 +02:00
Philipp Wolfer
adb420aeda Update picard.pot 2020-10-04 10:03:08 +02:00
Philipp Wolfer
b9cb55ec91 PICARD-1952: Show warning if user chooses to use system theme 2020-10-04 10:01:35 +02:00
Philipp Wolfer
6165693281 PICARD-1952: Allow user to force system theme on Linux 2020-10-04 10:01:35 +02:00
Philipp Wolfer
fc37b12f0f PICARD-1960: Allow adding/removing tags in EditTagDialog with Insert/Del 2020-10-04 09:55:12 +02:00
Philipp Wolfer
7f2a8bc277 PICARD-1960: Enable insert key for adding items to list widgets 2020-10-04 09:55:12 +02:00
Philipp Wolfer
7597704234 Updated pot file 2020-10-03 10:43:36 +02:00
Philipp Wolfer
304cb43eee PICARD-1959: Rename disc ID "Lookup in Browser" to "Submit disc ID" 2020-10-02 20:09:17 +02:00