Commit Graph

7535 Commits

Author SHA1 Message Date
Philipp Wolfer
af255c32a0 Run isort on Travis CI 2019-04-04 15:42:33 +02:00
Philipp Wolfer
81b9b1c59c Documented use of pre-commit hook for isort check 2019-04-04 08:43:31 +02:00
Philipp Wolfer
dc0ec84401 isort: Consistently use two blank lines after import 2019-04-04 08:35:23 +02:00
Philipp Wolfer
dd4da2aa47 Updated isort config to put test imports in separate section 2019-04-04 08:32:22 +02:00
Philipp Wolfer
05fc98c64a Run isort over all files 2019-04-03 21:19:12 +02:00
Laurent Monin
b049e98a0f Restore comma removed in 29c2f45de1 2019-04-03 21:08:03 +02:00
Antonio Larrosa
29c2f45de1 Use QDesktopServices to open cover images instead of webbrowser2
QDesktopServices takes care of honoring the user configuration so
when opening an image, the user preferred external app is used
instead of always using a web browser.

Fixes PICARD-1501
2019-04-03 18:47:05 +00:00
Laurent Monin
86ea3c11f7 Merge pull request #1174 from zas/config_upgrade_tests
Add tests for config upgrade functions
2019-04-03 18:37:44 +02:00
Laurent Monin
931ccbca00 Remove redundant code: process is already set few lines before 2019-04-03 15:35:15 +00:00
Laurent Monin
fb6807636d Add tests for config upgrade functions 2019-04-03 12:22:53 +02:00
Laurent Monin
b1f0691597 Merge pull request #1172 from zas/config2
Rework Config / ConfigSection
2019-04-03 11:26:41 +02:00
Laurent Monin
a63cc6bdd1 Rework config and add tests for it
- get rid of useless ConfigSection.__config
- use name instead of full key (as section name is fixed)
- add support for qt type
- remove _convert_to_bool(), unneeded with qt type support
2019-04-03 09:46:52 +02:00
Laurent Monin
212cd78c69 Remove unused IntListOption 2019-04-03 09:44:45 +02:00
Laurent Monin
00b13fe5c6 Merge pull request #1173 from zas/const2
Move some constants to picard.const
2019-04-02 18:58:36 +02:00
Laurent Monin
22d67cd977 Move DEFAULT_NUMBERED_SCRIPT_NAME and DEFAULT_SCRIPT_NAME to picard.const 2019-04-02 14:07:14 +02:00
Laurent Monin
0f1ca5379a Move to DEFAULT_FILE_NAMING_FORMAT to picard.const 2019-04-02 14:06:49 +02:00
Laurent Monin
159cea740c Merge pull request #1167 from phw/fix-running-specific-tests-only
Fixed invoking "python setup.py test --tests=..."
2019-03-29 14:30:47 +01:00
Philipp Wolfer
e8049a50f4 Build against PyQt 5.12.1 on Windows 2019-03-29 14:17:40 +01:00
Laurent Monin
28655af04c Merge pull request #1165 from zas/releasing_doc
Convert obsolete do_release.sh to an actual releasing documentation
2019-03-29 13:53:30 +01:00
Laurent Monin
46530a30e9 Merge pull request #1166 from phw/flake-ignore-W503
Flake ignore w503
2019-03-29 12:57:20 +01:00
Laurent Monin
4de73a6af3 Add some details, re-order a bit 2019-03-29 12:17:35 +01:00
Philipp Wolfer
d99d79e441 Fixed invoking "python setup.py test --tests=..." 2019-03-29 11:59:25 +01:00
Philipp Wolfer
6158c001bf Ignore test files for code coverage also on Codacy 2019-03-29 11:20:09 +01:00
Philipp Wolfer
fa5ae617fe PEP8: Line break before binary operator 2019-03-29 11:11:34 +01:00
Laurent Monin
53036a190d Cleanup 2019-03-29 11:08:57 +01:00
Laurent Monin
0e93231d99 Convert do_release.sh obsolete script to a release process documentation 2019-03-29 11:01:22 +01:00
Philipp Wolfer
7cf3945272 Removed unused imports 2019-03-29 10:55:28 +01:00
Philipp Wolfer
801c7f8f35 Ignore the ui_*.py files for calculating testing code coverage. 2019-03-29 09:47:20 +00:00
Philipp Wolfer
e41c683c0f Merge pull request #1160 from phw/fix-config-loading
Fix loading BoolOption from config
2019-03-29 09:10:20 +00:00
Philipp Wolfer
63cb114080 Always run tagger.run_cleanup for PicardTestCase 2019-03-29 08:59:14 +00:00
Philipp Wolfer
d0563fa5c4 Extended option test cases 2019-03-29 09:30:09 +01:00
Philipp Wolfer
0405f7acb5 Added tests for config options 2019-03-29 09:06:54 +01:00
Laurent Monin
15453524cd Merge pull request #1161 from phw/PICARD-1497-validate-tag-keys
PICARD-1497: Validate tag keys
2019-03-29 00:44:10 +01:00
Laurent Monin
769a4bea9c Remove last bits of deprecated Metadata.delete()
- a note was added to it
- not removed, some plugins might rely on it
2019-03-28 22:25:50 +00:00
Philipp Wolfer
45b4bde087 Fix reading boolean config values 2019-03-28 23:19:20 +01:00
Philipp Wolfer
ea9ad532b2 PICARD-1497: Mark invalid Apev2 keys as unsupported tags 2019-03-28 22:52:59 +01:00
Philipp Wolfer
dd12220e1e PICARD-1497: Mark invalid Vorbis keys as unsupported tags 2019-03-28 22:52:59 +01:00
Philipp Wolfer
dbeca60659 Merge pull request #1155 from phw/refactor-format-tests
Refactor format tests
2019-03-28 21:01:51 +00:00
Laurent Monin
2032b2aec6 Merge pull request #1158 from zas/tagdiff
PEP8: Capitalize TagStatus class constants
2019-03-28 19:32:52 +01:00
Philipp Wolfer
31d79ac777 Merge pull request #1156 from phw/italian-installer
Installer Italian translation
2019-03-28 14:48:44 +00:00
Laurent Monin
0724e8fb26 metadata.delete('tag') -> del metadata['tag'] 2019-03-28 13:39:51 +00:00
Philipp Wolfer
10f896d327 Formats test code cleanup
Addressed review comments
2019-03-28 14:18:14 +01:00
Laurent Monin
905d0a7062 Define CHANGED as ADDED | REMOVED, and remove comment
Suggested by samj1912
2019-03-28 14:09:48 +01:00
Philipp Wolfer
57c9b2ff4a Fixed image_type_from_id3_num not returning correct values on Python 3.5 2019-03-28 12:20:11 +01:00
Philipp Wolfer
7aa076ba2a NSIS: Changed text for required component
Also changed component selection layout to allow longer texts for components.
2019-03-28 12:13:08 +01:00
Philipp Wolfer
12548bb638 Added tests for ASF utility functions 2019-03-28 11:45:42 +01:00
Philipp Wolfer
7c7ad564d5 Added tests for ID3 utility functions 2019-03-28 11:45:42 +01:00
Philipp Wolfer
09fe255891 Renamed base test case classes for consistency 2019-03-28 11:45:42 +01:00
Philipp Wolfer
a268b13ceb Refactored cover art file tests into format specific test files 2019-03-28 11:45:42 +01:00
Philipp Wolfer
16506caf96 Fixed test run on Windows 2019-03-28 11:45:42 +01:00