Commit Graph

7535 Commits

Author SHA1 Message Date
Laurent Monin
cfa198ec49 Display no details if no plugin is selected 2018-09-27 14:47:51 +02:00
Laurent Monin
666dbf4469 Rework the plugins UI, preliminary steps 2018-09-27 14:47:51 +02:00
Laurent Monin
d0b855dc24 Remove now unused selected_plugin() 2018-09-27 14:47:51 +02:00
Laurent Monin
2a4af0f582 Fix save/restore on Reload List, simplify code 2018-09-27 14:47:51 +02:00
Laurent Monin
82175371af Drop plugins_list_selected persist option
It can be quite confusing as is
2018-09-27 14:47:51 +02:00
Laurent Monin
eb3051a34d Move few methods near they are actually used 2018-09-27 14:47:51 +02:00
Laurent Monin
c533d19fc8 Move PLUGIN_ACTION_* to plugins UI, as they are only used there 2018-09-27 14:47:51 +02:00
Laurent Monin
3c1ee72f39 Drop PLUGIN_ACTION_UPDATE in plugin and simplify code
Since there are only 2 actions possible, install & update, use a bool
2018-09-27 14:47:51 +02:00
Laurent Monin
c2329aca57 Shorten lines and simplify 2018-09-27 14:47:51 +02:00
Laurent Monin
3d89846824 Use COLUMN_NAME instead of number 2018-09-27 14:47:51 +02:00
Laurent Monin
fb92186959 Fix item states save/restore (used when reloading plugin list mainly) 2018-09-27 14:47:51 +02:00
Laurent Monin
9ba9773026 Introduce enabled_plugins() method and simplify save() 2018-09-27 14:47:51 +02:00
Laurent Monin
8ec6a8f0da Simplify items() method 2018-09-27 14:47:51 +02:00
Laurent Monin
7239ecac69 item.plugin() -> property 2018-09-27 14:47:51 +02:00
Laurent Monin
f33773d46a Shorten lines 2018-09-27 14:47:51 +02:00
Laurent Monin
2b065008df No need of loader property, used only in open_plugin_dir() 2018-09-27 14:47:51 +02:00
Laurent Monin
a9e0529690 Tidy up 2018-09-27 14:47:51 +02:00
Laurent Monin
58920cceeb Replace item_plugin() with item.plugin() 2018-09-27 14:47:51 +02:00
Laurent Monin
0de9098ffb Replaced find_by_name() by find_item_by_plugin_name() 2018-09-27 14:47:51 +02:00
Laurent Monin
330364f22a PEP8 fixes 2018-09-27 14:47:51 +02:00
Laurent Monin
ff4ea3ca2b Explode _populate() in smaller methods 2018-09-27 14:47:51 +02:00
Laurent Monin
ce48776f1d Let the user uninstall a plugin marked for update 2018-09-27 14:47:51 +02:00
Laurent Monin
4558ebaba4 Move new_version from plugin to item 2018-09-27 14:47:51 +02:00
Laurent Monin
d7c37f31b8 Get rid of PS_IS_UNINSTALLED and PluginShared states property and methods 2018-09-27 14:47:51 +02:00
Laurent Monin
af1cdac3bc Get rid of PS_MARKED_FOR_UPDATE 2018-09-27 14:47:51 +02:00
Laurent Monin
647ce766f2 Get rid of PS_CAN_BE_UPDATED 2018-09-27 14:47:51 +02:00
Laurent Monin
f2f97128f3 Get rid of PS_CAN_BE_DOWNLOADED 2018-09-27 14:47:51 +02:00
Laurent Monin
e2be2c0a42 Merge add_new_plugin_item() and update_plugin_item()
Revert this move, since i'll add more parameters it avoids extra duplication
2018-09-27 14:47:51 +02:00
Laurent Monin
5f402ae193 Get rid of PS_ENABLED 2018-09-27 14:47:51 +02:00
Laurent Monin
db6a60e42d Cache self.ui.plugins.header() and shorten lines 2018-09-27 14:47:51 +02:00
Laurent Monin
1d4c37167a Make Codacy happy 2018-09-27 14:47:51 +02:00
Laurent Monin
1bcadf1f12 Pass item to download_plugin() 2018-09-27 14:47:51 +02:00
Laurent Monin
c27bddc1e4 Get rid of useless set_current_item() calls 2018-09-27 14:47:51 +02:00
Laurent Monin
8056c19b59 Introduce refresh_details(), change_details() being a signal handler 2018-09-27 14:47:51 +02:00
Laurent Monin
33a969c075 Introduce item_plugin() that returns the plugin for the item 2018-09-27 14:47:51 +02:00
Laurent Monin
9d7f9e6ae1 Introduce set_current_item() and simplify code 2018-09-27 14:47:51 +02:00
Laurent Monin
7c79ba370e restore_state(): get rid of (now) unused restore_selection
Since it is only used on load, always restore selection
2018-09-27 14:47:51 +02:00
Laurent Monin
da92b894dc Improve preservation of states across Reload List 2018-09-27 14:47:51 +02:00
Laurent Monin
c86b89a3a4 Manage plugin states in a set(), simplify code 2018-09-27 14:47:51 +02:00
Laurent Monin
f516b4db8d in dict defaults to dict keys, remove .keys() 2018-09-27 14:47:51 +02:00
Laurent Monin
7f25d542f8 Revamp methods, introduce add_new_plugin_item() and update_plugin_item() 2018-09-27 14:47:51 +02:00
Laurent Monin
077333abb5 Simplify code 2018-09-27 14:47:51 +02:00
Laurent Monin
135de9f7c3 Shorten lines 2018-09-27 14:47:51 +02:00
Laurent Monin
da04764833 i,p -> item, plugin 2018-09-27 14:47:51 +02:00
Laurent Monin
34faf405ca Get rid of items dict, use data() and QTreeWidgetItemIterator instead 2018-09-27 14:47:51 +02:00
Laurent Monin
b569df9224 Enable plugin after first installation 2018-09-27 14:47:51 +02:00
Laurent Monin
09368513d7 Add a manager property to PluginsOptionsPage 2018-09-27 14:47:51 +02:00
Philipp Wolfer
ff177db31f PICARD-1039: Support Forward Delete as alternative to Del on macOS 2018-09-26 14:02:57 +02:00
Philipp Wolfer
b741be6402 Revert "PICARD-1339: Remove O(n^2) complexity when deleting files"
This reverts commit d034e5c6fa.
2018-09-26 08:29:10 +02:00
Philipp Wolfer
a2a34562cf Merge pull request #984 from phw/PICARD-518-fix-rendering-artifact
PICARD-518: Fixed slider tooltips causing rendering artifacts
2018-09-25 23:24:08 +02:00