Commit Graph

7535 Commits

Author SHA1 Message Date
Philipp Wolfer
390c00e6eb PICARD-518: Fixed slider tooltips causing rendering artifacts
When opening the options dialog some random looking artifacts got visible caused by the slider tooltip being displayed on initialization
2018-09-25 22:14:55 +02:00
Philipp Wolfer
f6c9dbc084 Merge pull request #981 from phw/PICARD-664-dnd-representation
PICARD-664: Render the first dragged row as drag representation
2018-09-25 20:40:08 +02:00
Philipp Wolfer
02cfbfeaf0 Merge pull request #980 from phw/PICARD-1358-macos-native-style
PICARD-1358: Use native Qt style for macOS
2018-09-25 20:38:53 +02:00
Philipp Wolfer
47247ac0ad Merge pull request #978 from phw/PICARD-1354-instrument-credits
PICARD-1354: Allow using instruments and vocals as credited
2018-09-25 20:37:28 +02:00
Philipp
2990d763c5 PICARD-1358: Do not show menu icons on macOS 2018-09-25 16:21:46 +02:00
Philipp Wolfer
3da76f97ae PICARD-1354: Adressed code review comments 2018-09-25 15:43:52 +02:00
Philipp Wolfer
96c7f2f082 PICARD-1354: Allow using instruments and vocals as credited 2018-09-25 15:07:33 +02:00
Philipp Wolfer
38e3561d6c PICARD-664: Render the first dragged row as drag representation 2018-09-25 14:28:52 +02:00
Philipp
ee7462bb00 PICARD-1358: Use native Qt style for macOS 2018-09-25 12:32:52 +02:00
Philipp Wolfer
f49fd9c89d Merge pull request #977 from phw/enable-more-languages
i18n: Enable languages with more than 40% translation
2018-09-24 10:47:19 +02:00
Laurent Monin
ae330673f8 Merge branch 'master' into enable-more-languages 2018-09-23 16:14:13 +02:00
Philipp Wolfer
3a380e2355 PICARD-1162: Fix solo attribute for vocals / instruments (#979) 2018-09-22 10:37:49 +02:00
Laurent Monin
b3f5d517b8 Merge branch 'master' into enable-more-languages 2018-09-22 10:27:53 +02:00
Philipp Wolfer
f108cc7291 i8n: Updated translations 2018-09-21 08:04:00 +02:00
Philipp Wolfer
f9bc503fa4 i18n: Enable languages with more than 40% translation 2018-09-21 07:43:37 +02:00
Laurent Monin
eb419ea146 Add a command-line option (-P) to force Picard ignoring all plugins 2018-09-20 10:31:15 +02:00
Laurent Monin
2b6b06436f Reduce code duplication
Convert a warning in debug but not essential to user, and simpler.
2018-09-20 10:14:31 +02:00
Laurent Monin
55f50cde8d Drop useless dict comprehension 2018-09-20 10:14:31 +02:00
Laurent Monin
cbd7c189de Log image identification errors to debug when d'n'd on cover art box 2018-09-20 10:14:31 +02:00
Philipp Wolfer
ea0a60ff3b Fix drag'n'drop of images from Browser
This did only work if the URL contained no query string
2018-09-20 10:14:31 +02:00
Laurent Monin
10bee8a4e2 Partially fix drag'n'drop on cover art box
It wasn't working in most cases, mainly due to QByteArray vs bytes mismatch (actually since a long time)
2018-09-20 10:14:31 +02:00
Philipp Wolfer
62d5543c53 Merge pull request #971 from phw/PICARD-1346-fix-move-files
PICARD-1346: Fix exception with move additional files
2018-09-20 08:37:06 +02:00
Philipp Wolfer
82d5c0ffe1 PICARD-1346: Added unit test 2018-09-19 21:25:26 +02:00
Philipp Wolfer
d3e4bc91ea PICARD-1346: Use sets to avoid O(n²) iteration when moving files 2018-09-19 21:25:26 +02:00
Philipp Wolfer
bdbc541ddc PICARD-1346: Fix exception with move additional files
When multiple patterns for move additional files matched the same file an exception was thrown when attempting to move the files again after it already had been moved.
2018-09-19 21:25:26 +02:00
Laurent Monin
b9bdbfe47b PICARD-1347: reduce code duplication 2018-09-19 10:03:26 +02:00
Philipp Wolfer
79ee67e382 PICARD-1344: Add $delete function 2018-09-17 08:10:45 +02:00
Laurent Monin
c1d11ca6cc PICARD-1281: Drop deprecated CFBundleGetInfoString from info.plist
https://tickets.metabrainz.org/browse/PICARD-1281
http://www.openradar.me/8600732
2018-09-16 17:37:19 +02:00
Philipp Wolfer
8a4ceded69 Refactor: More DRY formats implementations 2018-09-13 18:23:48 +02:00
Laurent Monin
b0217ee946 Simplify sortable/non-sortable __lt__() 2018-09-13 17:54:13 +02:00
Laurent Monin
16a3074be4 PEP8 fixes 2018-09-13 17:54:13 +02:00
Laurent Monin
09d1551a61 PICARD-518: Add a tip to sliders in Options > Metadata > Preferred Releases
- Display a tip with actual value
- 5 by 5 step (values from 0 to 100)
- page step (keyboard only set to 25)
2018-09-13 14:10:00 +02:00
Sambhav Kothari
660494fef2 Merge pull request #966 from zas/pyinstaller_3.4_fix
Fix pyinstaller complaining about empty DEST
2018-09-12 22:14:05 +01:00
Laurent Monin
888249de97 Fix pyinstaller complaining about empty DEST
It is enforced by pyinstaller 3.4

Empty DEST not allowed when adding binary and data files. Maybe you want to used '.'.
Caused by 'discid.dll'.

https://github.com/pyinstaller/pyinstaller/issues/3066
2018-09-12 15:45:43 +02:00
Philipp Wolfer
d034e5c6fa PICARD-1339: Remove O(n^2) complexity when deleting files
This change basically makes sure calls to update_metadata_images are done only once per cluster / track when multiple files get removed. Since update_metadata_images iterates over all files inside a cluster doing this after deletion reduces the complexity significantly.
2018-09-08 16:06:51 +02:00
Laurent Monin
c2437c412b Warn about deprecated string_() and convert_to_string() 2018-09-08 15:48:24 +02:00
Laurent Monin
63f71354b1 Improve code in _move_additional_files(), drop extra loops 2018-09-08 15:48:24 +02:00
Laurent Monin
683b934685 Drop use of string_(), deprecated 2018-09-08 15:48:24 +02:00
Laurent Monin
442f2883e5 PICARD-1340: fix display of Mono/Stereo for channels in info dialog
ch is a string
2018-09-08 15:09:42 +02:00
Philipp Wolfer
97bd392844 PICARD-1112: Clear deleted tags after saving file 2018-09-07 13:18:19 +02:00
Philipp Wolfer
8586bf95da PICARD-105: Allow loading AcoustId recording as NAT
For NAT recordings AcoustId returns incomplete results and we have only the recording ID. Allow Picard to load such results as NAT.
2018-09-07 10:55:58 +02:00
Philipp Wolfer
0791312e5c Merge pull request #962 from phw/PICARD-1268-support-concertmaster-relationship
PICARD-1268: Load concertmaster as performer:concertmaster
2018-09-06 16:51:23 +02:00
Philipp Wolfer
9bd2e9418d Merge pull request #959 from phw/PICARD-1336-mp4-set-bool-tags-supported
PICARD-1336: For MP4 integer tags were not marked as supported
2018-09-06 16:51:04 +02:00
Philipp Wolfer
28d473b630 PICARD-1268: Load concertmaster as performer:concertmaster 2018-09-06 16:11:43 +02:00
Philipp Wolfer
8a8fbc143c Syntax fix 2018-09-06 16:11:14 +02:00
Philipp Wolfer
cdcd6db7e2 Sort mapping lists in mbjson alphabetically 2018-09-06 16:07:03 +02:00
Philipp Wolfer
6d679e9e46 Merge pull request #954 from phw/PICARD-1332-restore-deleted-file-tags
PICARD-1332: When unmatching a file restore deleted tags from origina…
2018-09-06 14:16:17 +02:00
Philipp Wolfer
cb0f391c12 PICARD-1336: For MP4 integer tags were not marked as supported 2018-09-06 14:12:47 +02:00
Philipp Wolfer
72e12aba3a Merge pull request #957 from zas/fix_isort_init_py
Fix isort config to not skip __init__.py files (but few)
2018-09-05 18:09:13 +02:00
Laurent Monin
9bdc435dcb Clean-up imports with the help of isort 2018-09-05 17:39:25 +02:00