Sambhav Kothari
eca507f541
Remove un-needed guard clauses for mutagen imports
...
Since Picard 2.0 picard uses a min. mutagen version 1.39. These are not
needed anymore.
2018-03-09 19:48:45 +05:30
Sambhav Kothari
4cf430e419
Merge pull request #868 from zas/no_contrib
...
contrib/plugins is gone
2018-03-09 19:38:34 +05:30
Laurent Monin
cd687f4853
Remove references to contrib/plugins in code
2018-03-09 19:29:55 +05:30
Sambhav Kothari
4ac680ee7e
Merge pull request #866 from zas/tagging_scripts_splitter
...
PICARD-1026: set a minimum size for tagging scripts list
2018-03-09 19:21:49 +05:30
Laurent Monin
0175282a86
PICARD-1026: set a minimum size for tagging scripts list
...
- it is not possible to fully hide the left part now
- minimal width set to 80 pixels
2018-03-09 14:36:24 +01:00
Sambhav Kothari
d1edeaf386
Merge pull request #869 from zas/paths_cleanup
...
Paths cleanup
2018-03-09 19:03:51 +05:30
Laurent Monin
5a11e6e7a2
Use QStandardPaths.AppConfigLocation
2018-03-09 14:17:29 +01:00
Laurent Monin
aca9475a97
Remove old config paths handling stuff
...
This is pre-1.4.x stuff
2018-03-09 14:17:12 +01:00
Laurent Monin
eb59c84c19
Merge pull request #865 from zas/options_wrap
...
Wrap some long labels in Options
2018-03-09 12:55:49 +01:00
Laurent Monin
b3771da154
Merge branch 'master' into options_wrap
2018-03-09 12:35:08 +01:00
Laurent Monin
5fcece923f
Merge pull request #867 from yvanzo/update-po-readme
...
Update instructions to update attributes strings
2018-03-09 12:34:51 +01:00
Laurent Monin
19b820d610
Merge branch 'master' into options_wrap
2018-03-09 12:09:59 +01:00
Laurent Monin
246d742bd5
Merge branch 'master' into update-po-readme
2018-03-09 12:09:06 +01:00
yvanzo
9d8af77a5c
Update instructions to update attributes strings
2018-03-09 11:45:03 +01:00
Laurent Monin
e04b6ff02a
Merge pull request #863 from zas/cleanup_4
...
Manage preserved tags as a set, with the help of new class PreservedTags
2018-03-08 16:03:51 +01:00
Laurent Monin
9577873d16
Merge branch 'master' into cleanup_4
2018-03-08 15:48:28 +01:00
Laurent Monin
f957d302c9
Merge pull request #864 from sambhav/picard1211
...
PICARD-1211: Fix disabled close button in Windows
2018-03-08 15:17:44 +01:00
Laurent Monin
7b94c79aff
Simplify _from_config()
...
Suggested by Sambhav
2018-03-08 15:05:14 +01:00
Laurent Monin
9d0cdb1f30
Wrap some long labels in Options
...
- set a stylesheet to OptionsPage instances
- fix few spacers not playing well with wrap word
- wrap word of all QLabel in Options page
2018-03-08 14:51:39 +01:00
Sambhav Kothari
da66b864a4
PICARD-1211: Fix disabled close button in Windows
2018-03-08 18:50:20 +05:30
Laurent Monin
f6f2aa0558
Manage preserved tags as a set, with the help of new class PreservedTags
2018-03-07 16:01:12 +01:00
Laurent Monin
b201207baa
Set correct version: 2.0.0.dev4
...
beta qualifier isn't supported by code atm.
2018-03-06 20:20:12 +01:00
Laurent Monin
9e56504f63
Bump version to 2.0.0beta1
2018-03-06 19:48:30 +01:00
Laurent Monin
c89e81928b
Update .po files
2018-03-06 19:47:43 +01:00
Laurent Monin
f203915f11
Update picard.pot
2018-03-06 19:46:19 +01:00
Laurent Monin
e7c9708122
Merge pull request #862 from zas/groupbox_title_workaround
...
PICARD-1206: force style for GroupBox::title
2018-03-06 19:39:03 +01:00
Laurent Monin
9c377ec7ca
Merge branch 'master' into groupbox_title_workaround
2018-03-06 15:06:37 +01:00
Laurent Monin
ad690c4673
Merge pull request #860 from zas/infodialog_cleanup2
...
Info dialog cleanup
2018-03-06 15:06:11 +01:00
Laurent Monin
d5fec3a52f
Merge branch 'master' into infodialog_cleanup2
2018-03-06 14:52:35 +01:00
Laurent Monin
3822093687
PICARD-1206: force style for GroupBox::title
...
It is a workaround for a Qt bug, resulting on partially truncated group box titles.
2018-03-06 14:50:22 +01:00
Laurent Monin
2ca55279de
Merge pull request #861 from zas/caa_cleanup
...
Caa minor code cleanup
2018-03-06 14:47:19 +01:00
Laurent Monin
c38cf101c0
CAATypesSelectorDialog.get_selected_types(): use list comprehension and simplify
2018-03-06 12:01:40 +01:00
Laurent Monin
568906fcb7
Drop redundant connect() calls
2018-03-06 11:57:34 +01:00
Laurent Monin
d3743948fa
InfoDialog: only display Close button, as it is the sole action possible
...
Also fix translation of it, extending StandardButton
2018-03-06 11:28:03 +01:00
Laurent Monin
90122aae3f
Inline text & value in info dialog file properties
2018-03-06 10:52:11 +01:00
Laurent Monin
44db5589b2
Merge pull request #859 from kepstin/picard-259
...
Allow tagger script to access file metadata
2018-03-06 10:43:43 +01:00
Calvin Walton
12ed9ce63a
Refactor code to find enabled scripts to a function
...
The enabled_tagger_scripts_texts() function creates a list of enabled
functions which other code can use directly, abstracting away the checks
to see if tagger script is enabled, and whether each individual script
is enabled (and non-empty).
2018-03-05 20:01:11 -05:00
Calvin Walton
dd898e999e
Allow tagger script to access file metadata
...
Fixes PICARD-259 (and associated sub-tickets)
This moves the taggerscript evaluation to happen when a file is matched
(i.e. when a file is added to a track), where it has access to the both
the file metadata *and* the track metadata.
In order to ensure that the titles in the user interface are correct,
this is done by saving an extra copy of the original musicbrainz
metadata in track.orig_metadata. The taggerscript is run as per normal
on track.metadata, but the file matching will use track.orig_metadata
and re-run the taggerscript on the merged data.
2018-03-04 20:35:39 -05:00
Laurent Monin
2529019ff9
Merge pull request #858 from zas/infodialog_cleanup
...
InfoDialog: reduce code redundancy, subclassing QWidget
2018-03-04 15:03:44 +01:00
Laurent Monin
6ae154ba6c
Store image size in a class attribute
2018-03-04 13:53:35 +01:00
Laurent Monin
e766105f6b
InfoDialog: adjust row's height according to cover art widget height
...
It prevents the image to be vertically truncated
2018-03-04 13:41:48 +01:00
Laurent Monin
cd9be58044
InfoDialog: reduce code redundancy, subclassing QWidget
2018-03-04 13:26:52 +01:00
Laurent Monin
54810f497a
Merge pull request #857 from zas/saverestore
...
Generic class to save/restore dialog geometry, code simplification
2018-03-04 10:14:30 +01:00
Laurent Monin
b7d8ce91fd
Introduce and use PreserveGeometry class and drop a lot useless code
...
It also adds save/restore geometry to:
- password dialog
- info dialogs (fix PICARD-1093)
- tags from filenames dialog
- edit tags dialog
Each geometry is saved as "geometry_<class_name>" persist option (ByteArray())
2018-03-04 09:20:25 +01:00
Laurent Monin
5d4f4c82e8
Merge pull request #855 from zas/sslversion
...
Display SSL version string
2018-03-03 12:35:23 +01:00
Laurent Monin
44e6bcdf0c
Display SSL version string
...
Example: "SSL OpenSSL 1.0.2g 1 Mar 2016"
2018-03-02 10:34:00 +01:00
Laurent Monin
d918c8b52c
Fix Exception when removing last script in Options/Scripting
...
Traceback (most recent call last):
File "./picard/ui/options/scripting.py", line 258, in <lambda>
list_widget.set_remove_connection(lambda: self.remove_from_list_of_scripts(self.ui.script_list.row(item)))
File "./picard/ui/options/scripting.py", line 323, in remove_from_list_of_scripts
item.setSelected(True)
AttributeError: 'NoneType' object has no attribute 'setSelected'
2018-03-02 09:50:31 +01:00
Laurent Monin
483b8defbe
Regenerate picard.pot
2018-03-02 09:33:02 +01:00
Laurent Monin
637657fb1f
Use faster string concatenation instead of format to build key
...
Forgotten in https://github.com/metabrainz/picard/pull/854
2018-03-01 20:49:22 +01:00
Sambhav Kothari
61d55505b2
Merge pull request #854 from sambhav/picard_1204
...
PICARD-1204: Read and dump values to QSettings only when necessary
2018-03-02 00:04:48 +05:30