Sambhav Kothari
7a95fe4797
Fix variable names and optimize key building
2018-03-01 23:11:47 +05:30
Sambhav Kothari
d620c76ad1
Process modifications to QSettings immediately
2018-03-01 23:03:21 +05:30
Sambhav Kothari
32e02df631
Make sure only relevant keys are loaded
2018-03-01 19:52:58 +05:30
Sambhav Kothari
09e7542f8a
PICARD-1204: Read and dump values to QSettings only when necessary
...
Reading and dumping too often from QSettings causes picard to lock up.
This makes sure we only read on start and dump on change.
2018-03-01 19:52:54 +05:30
Laurent Monin
002b8c0105
Merge pull request #847 from vishichoudhary/two-three
...
Use python3 super function instead of calling by class name
2018-02-28 17:16:40 +01:00
vishal choudhary
983c183893
use python3 super()
2018-02-28 21:10:13 +05:30
Laurent Monin
8236dedbbd
Merge pull request #852 from zas/PICARD-1202
...
PICARD-1202: only use current item if there's actually one
2018-02-28 11:58:45 +01:00
Laurent Monin
af8af574c6
Merge branch 'master' into PICARD-1202
2018-02-28 11:35:43 +01:00
Laurent Monin
e29ec9712c
Merge pull request #851 from zas/no_restore
...
PICARD-1201: Add -N/--no-restore option to not restore persisted sizes and positions
2018-02-28 10:41:42 +01:00
Laurent Monin
12cc9635f7
PICARD-1202: only use current item if there's actually one
...
It prevents following error:
Traceback (most recent call last):
File "/usr/lib/python3.6/site-packages/picard/ui/metadatabox.py", line 292, in contextMenuEvent
column = item.column()
AttributeError: 'NoneType' object has no attribute 'column'
2018-02-28 10:38:22 +01:00
Laurent Monin
bd51da2109
Merge branch 'master' into no_restore
2018-02-28 10:29:24 +01:00
Sambhav Kothari
8478b3150a
Merge pull request #849 from sambhav/dsfui
...
PICARD-1203: Do not show un-supported tags in UI
2018-02-28 14:52:28 +05:30
Sambhav Kothari
19940ee8ef
Refactor format tests to remove unsupported tags automatically
2018-02-28 13:57:54 +05:30
Sambhav Kothari
4c6e791830
Refactor supports_tag as a class method and update unsupported tags
2018-02-28 13:57:54 +05:30
Laurent Monin
3b01e17923
Add -N/--no-restore option to not restore persisted sizes and positions
...
It is useful for:
- users having UI issues on startup (too small, too big, out of screen, etc...)
- devs for testing purposes
2018-02-28 09:16:44 +01:00
Sambhav Kothari
23ea30b1d5
Add an ext_to_format function
2018-02-28 12:05:38 +05:30
Sambhav Kothari
9c70a509f4
Do not show un-supported DSF tags in UI
2018-02-28 12:05:38 +05:30
Laurent Monin
2349388ea6
Merge pull request #850 from zas/splitter
...
PICARD-1200: fix Options tree pane resizing
2018-02-27 21:04:44 +01:00
Laurent Monin
d96080f17e
PICARD-1200: fix Options tree pane resizing
...
Size policy of both panes plus the minimum width enforced for the tree pane are responsible of the issue
Set horizontal policies to Ignored, and use QSplitter.setSizes() to set a smart default.
After this change, it is possible to move the splitter smoothly.
2018-02-27 13:42:21 +01:00
Laurent Monin
a8e416a9f4
Merge pull request #835 from zas/dsf
...
PICARD-1187: Add DSF file support
2018-02-26 15:04:36 +01:00
Laurent Monin
a678d540dc
Add DSF test
2018-02-26 14:10:24 +01:00
Laurent Monin
374849faef
PICARD-1187: Add DSF file support
2018-02-26 14:08:48 +01:00
Laurent Monin
9013dc1a23
Merge pull request #848 from zas/cleanuptests
...
Cleanup format tests
2018-02-26 13:57:24 +01:00
Laurent Monin
940b216f09
Drop useless wrapper
2018-02-26 13:33:08 +01:00
Laurent Monin
a8e2d39271
Introduce a simple decorator and reduce code redundancy
2018-02-26 12:48:38 +01:00
Laurent Monin
28bcf6535d
Reduce code redundancy: use addCleanup(), get rid of tearDown()
2018-02-26 12:31:17 +01:00
Laurent Monin
9f8ea36c95
Remove left-over debug code
2018-02-26 12:11:11 +01:00
Laurent Monin
442331cf6c
Wrap common test classes in CommonTests to prevent unittest to pick tests in those
2018-02-26 12:11:11 +01:00
Laurent Monin
6a5ef767d2
Raise SkipTest where appropriate, instead of silently returning
...
- replace `original` with more explicit `testfile`
- build the full path once
- extract extension and store it in a property
2018-02-26 00:26:12 +01:00
Laurent Monin
00ea9375ae
Do not repeat tags declaration, just modify one dict depending on format
...
Provides few methods:
- FormatsTest.setup_tags()
- FormatsTest.set_tags()
- FormatsTest.remove_tags()
2018-02-25 23:52:34 +01:00
Laurent Monin
e51d998fda
Merge pull request #846 from zas/stdpaths
...
Set default paths to standard locations
2018-02-25 15:08:31 +01:00
Laurent Monin
f8d27e8fca
Set default paths to standard locations
2018-02-23 19:38:36 +01:00
Laurent Monin
99ef1b28a2
Merge pull request #845 from vishichoudhary/use_super
...
Use python super function instead of calling by class name
2018-02-22 10:44:12 +01:00
vishal choudhary
3d2b8a6da3
use python super instead of calling with class name
2018-02-22 03:26:34 +05:30
Laurent Monin
270d832b99
Merge pull request #843 from zas/codacy_fixes
...
Codacy fixes
2018-02-20 23:05:42 +01:00
Laurent Monin
a535413264
Fix warning: Lambda may not be necessary
2018-02-20 21:14:44 +01:00
Laurent Monin
a84837dd71
Fix warning: Redefining built-in 'SyntaxError'
2018-02-20 21:08:01 +01:00
Laurent Monin
a981943157
Fix warning: Redefining built-in 'format'
2018-02-20 20:51:44 +01:00
Laurent Monin
3baaebbeaf
Fix warning: Redefining built-in 'id'
2018-02-20 20:50:03 +01:00
Laurent Monin
6981f5bad3
file -> file_
2018-02-20 20:41:22 +01:00
Laurent Monin
ac0a001415
Use super()
2018-02-20 20:39:04 +01:00
Laurent Monin
cec58efa5f
TrackInfoDialog: inherit from InfoDialog, instead of FileInfoDialog
2018-02-20 20:39:04 +01:00
Laurent Monin
096e3ef2a0
format_file_info(): move static method out of the class
2018-02-20 20:39:04 +01:00
Laurent Monin
a3503e8b7f
Fix warning: Redefining built-in 'dir'
2018-02-20 17:57:15 +01:00
Laurent Monin
5bdc36e42c
Fix warning: Access to member 'toolbar' before its definition line 616
...
Not really an issue though.
2018-02-20 17:44:00 +01:00
Laurent Monin
f73dbe1be3
Merge pull request #838 from zas/caa1200_fix
...
Handle caa_image_size option change in an upgrade hook, bump version to 2.0.0dev3
2018-02-14 15:01:21 +01:00
Laurent Monin
c35cdd0c4a
Merge pull request #840 from zas/fix_log_saveas
...
PICARD-1192: set QTextDocumentWriter format to plaintext, and allow any filename
2018-02-14 15:00:50 +01:00
Laurent Monin
f42329c646
Merge branch 'master' into fix_log_saveas
2018-02-14 14:25:12 +01:00
Laurent Monin
f02100d3c4
Merge branch 'master' into caa1200_fix
2018-02-14 14:24:49 +01:00
Laurent Monin
601d2bae74
Merge pull request #839 from samj1912/simple_logging
...
Remove unnecessary code to figure out logger name
2018-02-14 14:24:11 +01:00