Commit Graph

7535 Commits

Author SHA1 Message Date
suhas2go
aa900df63e last blank line is necessary 2016-12-17 19:16:25 +05:30
suhas2go
0a051cbfbf remove unnecessary blank lines 2016-12-17 19:12:24 +05:30
suhas2go
26e5aa6c2e remove mouse tracking for statustip 2016-12-17 19:08:53 +05:30
suhas2go
e1d651db72 follow pep8 and mark strings for translation 2016-12-17 18:58:20 +05:30
suhas2go
0155488a93 add bringtofront function to tagger 2016-12-16 22:36:11 +05:30
Sambhav Kothari
eddee11fa3 PICARD-546,287: Add support for tag removal 2016-12-16 21:46:33 +05:30
suhas2go
b22f3144ac make text appropriate as tooltips 2016-12-16 02:34:43 +05:30
suhas2go
82232c614b change to tooltips 2016-12-16 02:24:19 +05:30
Sambhav Kothari
ef6bea2fdf PICARD-857: Remove deprecated checks and add…
…support for GNOME 3 and Unity

Gnome 3 recommends using dconf to get and set values, as a result
gconftool-2 does not return a value in gnome3. Also GNOME_SESSION_ID
as a variable has been deprecated, so the detection of Gnome as a DE
has been changed accordingly.
2016-12-16 00:37:24 +05:30
Sambhav Kothari
5da9838a20 PICARD-857: Add themeing support for GNOME-3 and remove deprecated checks
Gnome 3 recommends using gsettings to get and set values, as a result
gconftool-2 does not return a value in gnome3. Also GNOME_SESSION_ID
as a variable has been deprecated, so the detection of Gnome as a DE
has been changed accordingly.
2016-12-16 00:36:15 +05:30
Wieland Hoffmann
572743fb6d Merge pull request #499 from samj1912/nosetest
Add support for nosetests
2016-12-14 21:08:10 +01:00
Sambhav Kothari
43311e4a5e Add support for nosetests 2016-12-15 01:35:30 +05:30
samj1912
d2f078da1d Remove quotes from theme name 2016-12-15 01:16:25 +05:30
Sambhav Kothari
0189b6cd8a PICARD-857: Add themeing support for GNOME-3 and remove deprecated checks
Gnome 3 recommends using gsettings to get and set values, as a result
gconftool-2 does not return a value in gnome3. Also GNOME_SESSION_ID
as a variable has been deprecated, so the detection of Gnome as a DE
has been changed accordingly.
2016-12-14 21:10:11 +05:30
suhas2go
75e1d286d6 Added track match quality info 2016-12-13 20:03:03 +05:30
suhas2go
2ebdcf41a2 Add missing info of different album icons 2016-12-13 18:55:42 +05:30
Sambhav Kothari
97c83c5777 PICARD-855: Adds errorhandler for missing meta-data
When a track with a non valid total-tracks has multiple release matches
on Picard, picard tries to apply a linear combination  of weights to
detect the best match. In the process it tried to typecast totaltracks
into and int.

This causes a ValueError when totaltracks is not castable into an int.
2016-12-13 05:39:05 +05:30
Sambhav Kothari
40d934250b PICARD-851: Correctly update parent items on save
When multiple files were linked to the same track and the changes to
the items were saved, the parent album icon didn't update to reflect
the change.

This was because of a buggy item.save() function which led to an update
call to the update() method of files. The files on update did not recu-
rsively call their parent items to be updated too.
2016-12-13 01:22:28 +05:30
Wieland Hoffmann
dcc91099a2 Don't recommend nose while the test are broken when using it
[ci skip]
2016-12-12 18:35:51 +01:00
Wieland Hoffmann
0a65151b71 He, she, it, das 's' muss mit
[ci skip]
2016-12-12 18:35:46 +01:00
Wieland Hoffmann
7dfc47a7f6 PICARD-853: Don't iterate over empty tracklists
Mediums with only data tracks (like disc 2 of
https://musicbrainz.org/release/5855689f-db31-476c-9207-1b966ed44e07) don't have
track elements in their track-list element, so make sure we don't try to access
them.
2016-12-06 19:58:48 +01:00
Wieland Hoffmann
1e52735275 Merge branch 'setupcfg' 2016-11-20 16:06:10 +01:00
Wieland Hoffmann
db9072bcaa Add setup.cfg to ignore flake8 errors
This ignores E501 (line too long), some indentation related errors and
configures gettext functions as known builtins, which makes the error
list for most files very short.

Messages in the generated UI files are ignored as well.

This reduces the number of warnings from ~2300 to ~200.
2016-11-20 12:50:04 +01:00
Wieland Hoffmann
8e0118c6de PICARD-852: Use HTTPS for requests to the plugins API on picard.mbo 2016-11-05 14:32:08 +01:00
Wieland Hoffmann
46dbab97b9 Fix a missing traceback import 2016-10-24 17:30:04 +02:00
Wieland Hoffmann
03a9166799 Fix missing *Dialog class imports 2016-10-24 17:28:20 +02:00
Wieland Hoffmann
b4fa0f4a3f Fix lookups by work id 2016-10-24 17:21:27 +02:00
Wieland Hoffmann
3dabab86b4 Merge branch 'master' of github.com:musicbrainz/picard 2016-10-24 17:21:19 +02:00
Laurent Monin
5870f6db2b Merge pull request #489 from Barami/master
PICARD-848: Cannot fetch cover art from amazon link contains https scheme.
2016-10-22 17:18:16 +02:00
barami
8f0617c282 Add comment to amazon url scheme test 2016-10-22 23:30:06 +09:00
Wieland Hoffmann
63afd12b76 Remove an unused import 2016-10-22 13:50:57 +02:00
Wieland Hoffmann
96e79a6962 delete_from_collection: Call _get_client_queryarg instead of passing it along 2016-10-22 12:50:12 +02:00
barami
4274bc54ff Add unit test for test to parsing of https amazon url 2016-10-22 14:57:15 +09:00
barami
6959dcf6b0 make shoter regex for https amazon url parsing 2016-10-22 14:47:33 +09:00
barami
7d35cdf40a Allow extract amazon host and asin for https 2016-10-16 14:01:54 +09:00
Laurent Monin
cb9b6294e2 Merge pull request #487 from rahul-raturi/embed_search_artist
Search for artists from dialog
2016-09-11 14:13:58 +02:00
Rahul Raturi
fbbae01894 Skip search dialogs for mbid lookups
If mbid is of a release, directly load it into Picard, else open web
browser for more details.
2016-09-11 15:59:34 +05:30
Rahul Raturi
939f44ab32 Setup artist search dialog
The dialog displays basic information in search results, like gender,
type etc.  The artist can be looked up in browser after selection.
2016-09-10 09:36:17 +05:30
Rahul Raturi
639383f910 Change accept event according to dialog
For example, for an artist dialog, loading into picard is not suitable.
Each child class of `SearchDialog` will provide an `accept_event` method,
which will call appropriate handler function for that event.
2016-09-08 00:15:39 +05:30
Rahul Raturi
17d6b6d6ed Connect artist dialog to main window 2016-09-08 00:14:22 +05:30
Rahul Raturi
841c322b64 Add method to parse artist XML node 2016-09-08 00:14:22 +05:30
Laurent Monin
0998feecae Update picard.pot 2016-09-05 21:31:33 +02:00
Laurent Monin
f5b08931de Resync .po files 2016-09-05 21:30:17 +02:00
Laurent Monin
e24684aa98 Add accelerator key to button: "&Load into Picard" 2016-09-05 21:28:20 +02:00
Laurent Monin
09df7f8fb7 Merge pull request #486 from rahul-raturi/embed_search_release
Search releases from within a Picard dialog
2016-09-05 21:23:14 +02:00
Rahul Raturi
3f114fda2c Try capturing focus in event rather than out
The accept button needs to be disabled to allow searching on pressing
return. If not disabled, the dialog closes on return. In commit a44c375,
focus out event of the table was used to disable the load button. This
doesn't works as the button will be disabled when user moves the mouse
towards the button (focus moves out of the table).
To avoid this, capture focus in event of `search_edit` widget.
2016-09-05 17:05:34 +05:30
Rahul Raturi
a1d948b9b8 Get column count dynamically 2016-09-05 17:05:33 +05:30
Rahul Raturi
c8d71a9633 Define query limit as constant
25 is the standard limit for number of results returned.
2016-09-05 17:05:30 +05:30
Rahul Raturi
036cfd0d3d Table may not exist after reply is recieved
If that's the case, do nothing. This may happen if user starts another
request before existing one is finished.
2016-09-05 11:11:34 +05:30
Rahul Raturi
a44c375011 Trigger search action on pressing return
Some noticeable points:
* Disable search action when query field (search box) is empty.
* Return also triggers accept event. To avoid this, each time focus moves
out of table, disable the accept button. This would allow searching
without the dialog getting closed.
2016-09-05 11:11:34 +05:30