fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-01-06 16:44:06 +00:00
Code Issues Packages Projects Releases Wiki Activity
9,526 Commits 1 Branch 0 Tags
ee76bf9e51ce1d36bb6770a9ba2debf32856617e
Commit Graph

9526 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Laurent Monin
ee76bf9e51 Improve coverage of artist_to_metadata(), checking for ended/endarea/enddate 
- drop redundant test
 2023-06-02 15:47:16 +02:00
Laurent Monin
a962f9176e Improve coverage of media_formats_from_node() and medium_to_metadata() 
- use a multi-media release (this case wasn't tested at all)
- fuse old and new tests
- drop media.json test file as it was only used there
 2023-06-02 15:26:53 +02:00
Laurent Monin
2060e3bc82 Add tests for _relations_to_metadata_target_type_url() 
- 100% coverage of this method
 2023-06-02 11:40:00 +02:00
Laurent Monin
b83567d204 Remove unused code 
- move test in _parse_attributes()
- drop _REPLACE_MAP and _transform_attribute() (only used once)
 2023-06-02 11:02:33 +02:00
Laurent Monin
2ae3b54614 Basic tests for _parse_attributes() 2023-06-02 10:59:18 +02:00
Laurent Monin
c82ef8b0f1 Extensively test _locales_from_aliases() 
- use a stripped down version of aliases (unused fields were removed)
- 100% coverage
- correctness of results has to be reviewed
 2023-06-02 00:45:40 +02:00
Laurent Monin
ca879789fd Move code from _translate_artist_node() to new _locales_from_aliases() 
- it will ease testing
 2023-06-01 19:35:21 +02:00
Laurent Monin
19b19976d2 Move definitions where they are used 2023-06-01 19:27:29 +02:00
Laurent Monin
2012a07548 Fix matching issue with alias types and use alias type id instead 
- web service returns "Legal name" not "Legal Name"
- match is dependent on text strings, but since a while the service provides an alias type id
- use the type id instead for the match
- add ALIAS_TYPE_*_ID constants to picard/const
 2023-06-01 16:48:33 +02:00
Laurent Monin
3d502c8fc8 _parse_attributes(): move prefix declaration near where it is used 2023-06-01 14:33:51 +02:00
Laurent Monin
19cf094084 _PREFIX_ATTRS: list -> set 2023-06-01 14:31:06 +02:00
Laurent Monin
c887fd8c7d _artist_rel_types -> _ARTIST_REL_TYPES as it is a constant 2023-06-01 14:28:12 +02:00
Hosted Weblate
d5f3485430 Update translation files 
Updated by "Update LINGUAS file" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://translations.metabrainz.org/projects/picard/appstream/
Translation: Picard/appstream
 2023-06-01 04:45:01 +00:00
Philipp Wolfer
4a58b13fcc Cleanup all translation files with msgmerge 2023-05-31 18:11:08 +02:00
Philipp Wolfer
8a4a437078 Removed .po files not used by Weblate 2023-05-31 18:04:01 +02:00
Philipp Wolfer
80ffc93ceb Translated using Weblate (Italian) 
Currently translated at 100.0% (14 of 14 strings)

Translated using Weblate (Hebrew)

Currently translated at 100.0% (14 of 14 strings)

Translated using Weblate (Spanish)

Currently translated at 100.0% (14 of 14 strings)

Co-authored-by: Philipp Wolfer <ph.wolfer@gmail.com>
Translate-URL: https://translations.metabrainz.org/projects/picard/installer/es/
Translate-URL: https://translations.metabrainz.org/projects/picard/installer/he/
Translate-URL: https://translations.metabrainz.org/projects/picard/installer/it/
Translation: Picard/installer
 2023-05-31 13:26:11 +00:00
Philipp Wolfer
2f76f68020 Translated using Weblate (German) 
Currently translated at 100.0% (1594 of 1594 strings)

Co-authored-by: Philipp Wolfer <ph.wolfer@gmail.com>
Translate-URL: https://translations.metabrainz.org/projects/picard/app/de/
Translation: Picard/app
 2023-05-31 13:18:16 +00:00
Philipp Wolfer
b0a6cbf352 Remove PGP code signing for PyPI release 
PyPI stopped supporting PGP code signing, see
https://blog.pypi.org/posts/2023-05-23-removing-pgp/
 2023-05-31 14:48:23 +02:00
Philipp Wolfer
88674073c3 Release 2.9.0b1 2023-05-31 09:22:22 +02:00
Philipp Wolfer
0d3365627d PICARD-2624: Use mutagen 1.46 with IFF file patch for macOS / Windows packages 
Fixes writing IFF files with truncated trailing null bytes.
 2023-05-31 09:21:24 +02:00
Philipp Wolfer
c38aad000c Updated Swedish translation 2023-05-31 08:34:51 +02:00
Laurent Monin
54a4444986 Merge pull request #2216 from zas/mbjson_tidy2 
Tidy up mbjson a tad more
 2023-05-30 13:49:35 +02:00
Laurent Monin
a972b72ca6 Change few more double quotes to single quotes 2023-05-30 12:35:41 +02:00
Laurent Monin
e80980aa82 _relations_to_metadata_target_type_artist(): valuesort -> sort_name 2023-05-30 11:39:25 +02:00
Laurent Monin
44bbb9976a _relations_to_metadata_target_type_artist(): value -> translated_name 2023-05-30 11:37:32 +02:00
Laurent Monin
7d366c0f03 artist_credit_from_node(), artist_credit_to_metadata(): improve naming consistency 2023-05-30 11:35:43 +02:00
Laurent Monin
187bf41b09 _translate_artist_node(): transl -> translated_name 
Well, it stores the translated artist name (depending on options).
 2023-05-30 11:22:50 +02:00
Laurent Monin
9185c485af _translate_artist_node(): translsort -> sort_name 
This isn't a translation at all, just the sort name.
 2023-05-30 11:21:05 +02:00
Laurent Monin
c272a8c21a Improve quotes consistency 
- use single quotes for dict keys (those are very unlikely to contain any single or double quotes)
- use double quotes for strings meant to be displayed (meaning when building error messages here)
 except when the string contains double quotes

Previously it was a mixed bag, and in practice it makes no difference, so this move is just about making code more consistent and easier to read.
 2023-05-30 11:13:27 +02:00
Laurent Monin
09ab2193a1 add_genres(), add_user_genres(): move test for empty name to dataobj add_genre() 2023-05-30 10:49:51 +02:00
Laurent Monin
16507ff4a3 Simplify _relation_attributes() (#2215) 
Use try/except as the key should be always there, and that's the fastest in such case.
Except is there to prevent any issue if the API does something weird.
 2023-05-30 10:10:02 +02:00
Philipp Wolfer
e01a43dc4b Updated translations 2023-05-30 08:58:26 +02:00
Laurent Monin
33b9f6c4aa Merge pull request #2214 from zas/mbjson_split 
_relations_to_metadata(): split in smaller bits and reduce code redundancy
 2023-05-30 08:18:37 +02:00
Laurent Monin
70a5945a9e _relations_to_metadata(): convert if/elif to dict search returning a function 2023-05-29 23:23:33 +02:00
Laurent Monin
ca561b38dd Convert context to new namedtuple TargetTypeFuncContext 2023-05-29 23:23:33 +02:00
Laurent Monin
1f72c6982b _relations_to_metadata(): merge contexts in one 2023-05-29 23:23:33 +02:00
Laurent Monin
91d943e37c _relations_to_metadata(): move bits to new _relations_to_metadata_target_type_series() 2023-05-29 23:23:33 +02:00
Laurent Monin
2a85a96bfc _relations_to_metadata(): move part of the code to new _relations_to_metadata_target_type_url() 2023-05-29 23:23:33 +02:00
Laurent Monin
1d27db520a _relations_to_metadata(): move part of the code to new _relations_to_metadata_target_type_work() 2023-05-29 23:23:33 +02:00
Laurent Monin
67092d068a _relations_to_metadata(): move code to new _relations_to_metadata_target_type_artist() 2023-05-29 23:23:33 +02:00
Philipp Wolfer
cb720416d5 Fixed docs for $min and $max scripting functions 2023-05-29 22:28:17 +02:00
Philipp Wolfer
ab1ee997ad PICARD-711: Use RG series details if release ARs are enabled 2023-05-29 21:42:42 +02:00
Philipp Wolfer
26cf9b507e PICARD-711: Add support for series variables 
Adds support for variables for release group, release, recording
and work series. The following variables are getting set:

- ~recording_series
- ~recording_series_id
- ~recording_seriescomment
- ~recording_seriesnumber
- ~release_series
- ~release_series_id
- ~release_seriescomment
- ~release_seriesnumber
- ~releasegroup_series
- ~releasegroup_series_id
- ~releasegroup_seriescomment
- ~releasegroup_seriesnumber
- ~work_series
- ~work_series_id
- ~work_seriescomment
- ~work_seriesnumber
 2023-05-29 21:42:42 +02:00
Philipp Wolfer
70eb7cc2a6 Update picard.pot 2023-05-22 21:52:46 +02:00
Philipp Wolfer
b273b116ca PICARD-2616: Add tests for releasedate tag 2023-05-22 20:46:45 +02:00
certuna
b0376184c0 PICARD-2616: Support releasedate tag (TDRL in ID3v2.4) 2023-05-22 08:13:43 +02:00
Philipp Wolfer
0309e9f08e PICARD-2645: Fix handle the quit confirmation when reveiving QUIT command 2023-05-21 18:15:08 +02:00
Philipp Wolfer
828abe875a PICARD-2627: Ensure pipe listener threads closes on quit 
It can happen that tagger.pipe_server hangs waiting getting data from the
pipe. If this happens when Picard is closing the pipe_server thread keeps
running in the background until it reveives data, which likely won't
happen. To fix this write a MESSAGE_TO_IGNORE to the pipe when closing.
 2023-05-21 18:14:51 +02:00
Philipp Wolfer
047255c7c0 Build with PyInstaller 5.11 2023-05-14 11:25:38 +02:00
Philipp Wolfer
b2991f8daf Adjust copyright year in about dialog 2023-05-14 11:22:45 +02:00