Commit Graph

5086 Commits

Author SHA1 Message Date
Laurent Monin
f02100d3c4 Merge branch 'master' into caa1200_fix 2018-02-14 14:24:49 +01:00
Laurent Monin
601d2bae74 Merge pull request #839 from samj1912/simple_logging
Remove unnecessary code to figure out logger name
2018-02-14 14:24:11 +01:00
Sambhav Kothari
9d82269342 Add comment and fix logger name behaviour 2018-02-14 00:53:06 +05:30
Sambhav Kothari
b9f38e7d1f Remove unnecessary code and use pathlib to figure out logger name 2018-02-14 00:36:55 +05:30
Laurent Monin
a638550e30 Handle caa_image_size option change in an upgrade hook, bump version to 2.0.0dev3
Suggested by sambhav in https://github.com/metabrainz/picard/pull/833/files#r167294289

It also fixes the issue reported at https://tickets.metabrainz.org/browse/PICARD-1189?focusedCommentId=45336&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-45336
2018-02-13 14:28:19 +01:00
Sambhav Kothari
6ae4ecc1c2 Merge pull request #836 from vishichoudhary/PICARD-1190
Add keyboard shortcut to enable log messages and history activity
2018-02-11 13:10:19 +05:30
vishal choudhary
d6bf508f75 Move ampersand from Log to Error 2018-02-11 12:53:06 +05:30
vishal choudhary
3590d80ab9 Add keyboard shortcut for log and history dialogs 2018-02-11 00:38:33 +05:30
Laurent Monin
8242c18483 Merge pull request #834 from zas/log_logging
Rework logging system and in-app log view
2018-02-10 17:51:21 +01:00
Laurent Monin
89c3bda7ee Let Qt manage the parenting, fixing QLayout warnings
QLayout: Attempting to add QLayout "" to LogView "", which already has a layout
2018-02-10 17:44:03 +01:00
Laurent Monin
814da6531a Get rid of _dbug() wrapper as it hides source/lineno from log 2018-02-10 17:44:03 +01:00
Laurent Monin
fdbd18d93a Improve consistency between -d command-line arg and log view verbosity
- if user set verbosity to debug in log view, keep this setting on next start
- if -d is passed on command line, set verbosity to debug only until exit, but if the user switches it in log view
- set default log level to warning
- save verbosity to config option "log_verbosity"
2018-02-10 17:44:03 +01:00
Laurent Monin
76092e61f9 Rework logging system and in-app log view
- use standard logging module as backend
- implement a circular buffer handler for in-app log view
- use default logging levels
- debug mode is now tied to verbosity
- default log format changed, adding source/lineno infos and milliseconds precision
- history log changed to logging/circular buffer handler too

- log view was changed accordingly
- Save As button added
- Clear Log (only the in-memory buffer and the view) button added, with confirmation dialog
- Highlight text and button added
- Verbosity toggling menu added
- Debug mode check box removed (replaced by verbosity = Debug)
2018-02-10 17:44:03 +01:00
Laurent Monin
6a2ccdcbd6 Merge pull request #832 from zas/lookup_callback
Improve search feature and related code
2018-02-10 11:17:17 +01:00
Laurent Monin
183db69682 Merge branch 'master' into lookup_callback 2018-02-09 22:16:58 +01:00
Laurent Monin
4968ec3901 Merge pull request #833 from zas/caa_1200
Add support for 1200 px CAA thumbnail size
2018-02-09 22:16:16 +01:00
Laurent Monin
e666d6a855 Merge branch 'master' into lookup_callback 2018-02-09 18:22:10 +01:00
Laurent Monin
30635246f6 Add support for 1200 px CAA thumbnail size
- size was stored as index in the combo box
- items were set in .ui, not dynamically built
- QtDesigner doesn't support setting user data to QComboBox items
- compatibility preserved using a trick: any value between 0 and 2 is old way, new way uses -1 and values >= 250
- safe default if value is outside range is read from config file
- fallback on smaller thumbnails if desired size isn't available
2018-02-09 11:00:40 +01:00
Laurent Monin
5035ebba3d Merge pull request #809 from vishichoudhary/PICARD-1177
PICARD-1177 : Add a option to remove plugin
2018-02-08 23:52:42 +01:00
Laurent Monin
9e139934bc Merge branch 'master' into PICARD-1177 2018-02-08 21:59:03 +01:00
Laurent Monin
4f58a45a3f Add a contextual menu to Search button as a shortcut to toggle search options 2018-02-08 14:18:25 +01:00
Laurent Monin
93c46f8ae2 When a string with a mbid is detected, rewrite the search string to show it matched
- this feature is a bit hidden
- if you paste an url with an entity + mbid, an url is build and web browser open
- rewriting it shows it matched, and the search can be repeated
2018-02-08 14:18:25 +01:00
Laurent Monin
e1108d2c4a Reduce search/lookup code redundancy
- drop filelookup.<entity>_search()
- rename filelookup._search() to filelookup.search_entity()
- use a dict to describe different possibilities in tagger.search()
- use filelookup.search_entity() instead of building a methode name to call
2018-02-08 14:18:24 +01:00
Laurent Monin
1dabaaf1ff Set builtin search dialog horizontal to pixel mode
Without this option, it may be hard to resize very wide columns.
2018-02-08 14:16:53 +01:00
Laurent Monin
cbc989d00e Prevent multiple calls to tagger.exit()
When Picard is stopped by signal (ie. CTRL-C from linux command line), exit() may be called more than once.
2018-02-08 01:04:40 +01:00
Sambhav Kothari
3e96089617 Merge pull request #831 from samj1912/macos
Fix OSX builds by adding libdiscid binaries
2018-02-07 02:22:43 +05:30
Sambhav Kothari
7843124c9e Build discid from source 2018-02-06 23:23:34 +05:30
Sambhav Kothari
2b9ef3c6bd Use an env. variable for discid version 2018-02-06 22:25:37 +05:30
Sambhav Kothari
cd5800a2e6 Add brew caching 2018-02-06 19:42:26 +05:30
Sambhav Kothari
22cb70a8cf Fix OSX builds by adding libdiscid binaries 2018-02-06 19:22:06 +05:30
Sambhav Kothari
bca576744d Only build releases on tags 2018-02-06 16:46:09 +05:30
Sambhav Kothari
d08499c3e7 Merge pull request #821 from samj1912/macos
Build OSX packages for Picard
2018-02-06 16:31:59 +05:30
Sambhav Kothari
1c3378d3a3 Use OSX 10.11 to build packages 2018-02-06 16:10:47 +05:30
Sambhav Kothari
16311cabc9 Add Picard version string to dmg and generate md5 hashes 2018-02-06 15:40:29 +05:30
Sambhav Kothari
d13d257ade Use pyinstaller to modify info.plist 2018-02-06 15:12:42 +05:30
vishichoudhary
97a03fc229 Use if instead of try block 2018-02-05 23:49:01 +05:30
vishichoudhary
5af69b291a Allow uninstallation of plugins
This PR adds an option to uninstall plugins in the Plugin Manager.
It also takes care of a few issues with the UI for plugin manager
itself. (Rapid multi-clicking of install button causing UI
discrepancies)
2018-02-05 23:49:01 +05:30
Sambhav Kothari
0d57653529 Fix artifact upload 2018-02-05 22:02:57 +05:30
Sambhav Kothari
ae6afb9e0c Update OSX scripts with shebang and execution bits 2018-02-05 22:02:57 +05:30
Sambhav Kothari
b89f70bcd1 Enable high-dpi mode while building app 2018-02-05 22:02:57 +05:30
Sambhav Kothari
0626c2e890 Build OSX packages on travis 2018-02-05 22:02:57 +05:30
Sambhav Kothari
0d3cd674fe Fix OSX builds 2018-02-05 22:02:57 +05:30
Laurent Monin
e2ed569233 Python3 doesn't need to import print_function
This is now a standard feature and no longer needs to be imported from __future__.

https://www.python.org/dev/peps/pep-3105/
2018-02-05 14:43:55 +01:00
Laurent Monin
41b49eccc2 Merge pull request #829 from vishichoudhary/PICARD-1184
PICARD-1184: Fix multi click weird issues
2018-02-02 19:41:42 +01:00
vishichoudhary
41e02c3c24 move variable to const 2018-02-02 19:39:53 +05:30
vishichoudhary
180da8965d Merge branch 'master' into PICARD-1184 2018-02-02 19:05:32 +05:30
vishichoudhary
774c239d3f Remove duplicate code 2018-02-02 19:05:03 +05:30
Laurent Monin
f6c17d89e7 Merge pull request #827 from zas/PICARD-994
PICARD-994: Show all release countries in CD lookup
2018-02-02 13:06:55 +01:00
Laurent Monin
ab56cbaf28 Merge branch 'master' into PICARD-994 2018-02-02 12:57:31 +01:00
Laurent Monin
a982bdc36e Merge pull request #826 from zas/cdlookup_states
PICARD-1175: save and restore CD Lookup dialog and headers states
2018-02-02 12:30:01 +01:00