Commit Graph

79 Commits

Author SHA1 Message Date
Laurent Monin
7a36f8c5f4 Sort dicts by key so it is easier to find something 2018-01-25 18:40:45 +01:00
Laurent Monin
136e3a9e7a Remove duplicate key 'artist' in tags dicts
This is there since 10 years, appeared with cfe5299a76
2018-01-25 18:34:04 +01:00
Laurent Monin
2f1e58c56e Remove duplicate key 'album' in tags dicts
This is there since 10 years, appeared with cfe5299a76
2018-01-25 18:31:39 +01:00
Wieland Hoffmann
8490422384 PICARD-1159: Don't pass filenames as bytes to wave.open
wave.open treats everything that's not a str as a file-like object.
encode_filename returns bytes, but they're not file-like.
2017-12-06 19:19:34 +01:00
Sambhav Kothari
51041be6a3 Fix test bytes error 2017-04-07 16:06:15 +05:30
Sambhav Kothari
8a6285e7dc Fix cover art test bytes issue 2017-04-07 16:06:15 +05:30
Sambhav Kothari
4be5ce8f5e Replace deprecated file method and rename formats.open to formats.open_ 2017-04-07 13:17:37 +05:30
Sambhav Kothari
236b1d155d Fix dictionary behaviour for py3 2017-04-07 13:17:37 +05:30
Sambhav Kothari
428e168b87 Port Picard to Qt5 2017-04-03 16:45:42 +05:30
Sambhav Kothari
427c98c862 Add tests for _fixed_splitext 2017-01-16 02:32:13 +05:30
Laurent Monin
9c033389e6 Merge pull request #528 from samj1912/picard868
PICARD-868,307: Fix TMOO,TSST frame not being saved
2017-01-10 21:51:33 +01:00
Sambhav Kothari
4dd5a66a94 Update tests to remove unsupported AIFF tags 2017-01-09 00:28:02 +05:30
Sambhav Kothari
e005d541fe Minor changes to function names 2017-01-07 03:23:14 +05:30
Sambhav Kothari
1b35b91f8c Add tests to check id3v23 compatibility 2017-01-07 02:24:18 +05:30
Sambhav Kothari
2b36896e5d Add tests to check for performer duplication 2017-01-06 22:51:08 +05:30
Laurent Monin
639a6ed531 Merge pull request #523 from samj1912/delmp3
PICARD-867: Improve id3 tag deletion
2017-01-05 18:39:04 +01:00
Sambhav Kothari
44bf38f4c5 Add id3 specific deletion tests 2017-01-05 00:24:21 +05:30
Sambhav Kothari
3452b20111 Fix test cleanup 2017-01-04 23:29:03 +05:30
Sambhav Kothari
dcb8538f02 Add cleanup of temp files 2017-01-04 17:36:36 +05:30
Sambhav Kothari
e7e830bc61 Try magic number detection even if no extension 2017-01-04 16:42:22 +05:30
Sambhav Kothari
22b6fce42a Add tests for guess_format 2017-01-04 15:45:26 +05:30
Sambhav Kothari
da5e0a29bb Rename 'save_only_front_image_to_tags' appropriately 2016-12-28 04:22:46 +05:30
Sambhav Kothari
a10bfdaf98 Add tests to check for complex tag deletion 2016-12-25 20:56:26 +05:30
Sambhav Kothari
fb64a83ae3 PEP8 Fixes 2016-12-24 01:45:24 +05:30
Sambhav Kothari
7f25a28dbc Add removable tags 2016-12-20 18:30:10 +05:30
Sophist
2d932e3bba Add support for automated tests. 2015-10-15 10:51:20 +01:00
Philipp Wolfer
8688fe49c6 Tag deletion implemented for Vorbis files 2015-09-23 21:25:41 +02:00
Philipp Wolfer
645873d544 Added unit tests for tag deletion.
Currently fails for all formats but MP4 (since its only implemented there).
2015-09-23 21:01:16 +02:00
Laurent Monin
043d37b07a Merge pull request #376 from phw/aiff
PICARD-42: Support AIFF files
2014-12-02 19:18:42 +01:00
Philipp Wolfer
ce5e4a4ff9 Do not require mutagen 1.23 but disable AIFF support for older versions. 2014-11-18 21:20:19 +01:00
Wieland Hoffmann
28482d3c2b Merge branch 'improved-wma-tags' of github.com:phw/picard 2014-11-13 11:38:08 +01:00
Philipp Wolfer
66feb95a5a Added tests for True Audio to make sure the recent ID3 changes didn't break anything. 2014-11-10 23:34:00 +01:00
Philipp Wolfer
be025002c9 Initial support for AIFF files with ID3 tags. 2014-11-10 23:31:50 +01:00
Philipp Wolfer
5cb930c150 Added tests for Musepack v7 and v8 2014-11-10 22:43:26 +01:00
Philipp Wolfer
388b429b0b Improvements to ASF tags:
* Distingiush between WM/OriginalReleaseTime and WM/OriginalReleaseYear
* Save encodersettings to WM/EncodingSettings
* Save website to WM/AuthorURL
* Support WM/PartOfSet possibly containing totaldiscs
2014-11-06 21:43:56 +01:00
Laurent Monin
bff18344c1 Move cover art related files to a "coverart" sub-directory 2014-09-29 09:48:39 +02:00
Laurent Monin
9a6ca46341 Fix regression, save only ONE front image when "save_only_front_images_to_tags" is set
This regression was introduced during code rewrite, option name is misleading.

See https://github.com/musicbrainz/picard/pull/116
See PICARD-350 (which wasn't closed)
2014-05-26 15:17:27 +02:00
Laurent Monin
c0de7d95c9 PEP8 fixes 2014-05-21 16:04:35 +02:00
Laurent Monin
9e2a91d203 Re-add dummy load to ensure test images are > 64kb
As said in comment, size was increased to catch a bug in mutagen, so better
to keep it.
2014-05-21 16:04:34 +02:00
Laurent Monin
83e45ec77d Minor change in test. 2014-05-16 23:06:42 +02:00
Laurent Monin
a5827926ac Improve tests for cover art types
- add tests according to save_only_front_images_to_tags
- some formats cannot save more than one image
- some formats have no type
2014-05-16 20:40:50 +02:00
Laurent Monin
a0213db350 Rely on imageinfo.identify to extract mimetype
- it does what mimetypes.get_from_data()
- .tiff is unused (afaik), so don't bother with it
- it is safer to analyze data for mime type (as data may not match provided mime type)
- when images are loaded from audio file tags, a check is done on valid format
2014-05-15 16:05:01 +02:00
Laurent Monin
8afcefaa6b Remove now unused LockableDefaultDict 2014-05-15 15:42:54 +02:00
Laurent Monin
a9e9a14a74 Use real image files to test formats 2014-05-15 14:36:41 +02:00
Laurent Monin
42f2048d99 Drop refcount/__del__ mess, make code much more reliable and simpler 2014-05-15 14:26:39 +02:00
Laurent Monin
d652e7307b Make exit cleanup process more generic 2014-05-14 15:55:04 +02:00
Laurent Monin
60bfd6d344 Merge Image() and CoverArtImage()
- Info dialog Artwork tab now displays types and comment for cover art images
- a tooltip gives info about the source (url, caa url, local file, tag, ...)
2014-05-14 15:55:04 +02:00
Wieland Hoffmann
5a2eee3484 Merge branch 'image-class-2'
Conflicts:
	picard/ui/infodialog.py
2014-04-08 13:13:22 +02:00
Laurent Monin
e97f404fff Update test_formats: defaultdict -> LockableDefaultDict 2014-03-31 21:33:32 +02:00
Wieland Hoffmann
58f44f479a Delete cover files after running TestCoverArt 2014-03-06 23:43:02 +01:00