fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-04-05 03:55:14 +00:00
Code Issues Packages Projects Releases Wiki Activity
8,411 Commits 1 Branch 0 Tags
f53a35eee6dfaace114dc71b2a29a4bcbbb5ab61
Commit Graph

8411 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Philipp Wolfer
f53a35eee6 PICARD-2189: Add appdirs module to fix getting proper cache location 
The cache location previously was wrong because it was created before app and org name had been set. The new module fixes this and allows more flexible replacement of the implementation.
 2021-09-26 11:43:42 +02:00
Philipp Wolfer
2422d74cb3 macOS: Handle different command line syntax for xpath on Big Sur 2021-09-25 14:52:37 +02:00
Philipp Wolfer
e44aef4330 macOS: Build with Python 3.9.7 2021-09-25 14:50:59 +02:00
Philipp Wolfer
5f0e598385 Removed Qt translations workaround no longer needed with current PyInstaller 2021-09-25 14:50:11 +02:00
Philipp Wolfer
c320377237 Build with PyInstaller 4.5.1 2021-09-25 14:50:11 +02:00
Laurent Monin
f22a36f13d Merge pull request #1905 from rdswift/more_config_path_changes 
More config path changes
 2021-09-19 10:10:07 +02:00
Bob Swift
61ca15e8be Set configuration file path QLineEdit colors to match QLabel colors 2021-09-18 12:25:16 -06:00
Bob Swift
8b8916b8ac Remove configuration path information from About dialog 2021-09-16 17:10:19 -06:00
Bob Swift
e728609e8d Change Line Edit to Label in Scroll Area 2021-09-16 16:18:37 -06:00
Bob Swift
7a3f99f258 Add config file name and link to Maintenance options page 2021-09-16 10:41:22 +02:00
Laurent Monin
a213b5e4ea Fix tests 2021-09-16 10:38:21 +02:00
Philipp Wolfer
67acdc6d76 PICARD-2279: Allow saving AcoustID fingerprint in file tags 2021-09-16 10:38:21 +02:00
Philipp Wolfer
35976665c9 Only allow AB submission for saved files 2021-09-15 20:23:06 +02:00
Laurent Monin
d673eb2fe4 Merge pull request #1901 from rdswift/show_config_file_in_about_dialog 
PICARD-2278: Show path to config file in About dialog.
 2021-09-15 09:42:01 +02:00
Bob Swift
e0e2c4e3f6 Show path to config file in About dialog. 2021-09-14 15:46:51 -06:00
Philipp Wolfer
1a65920c29 Tested Windows app with current Windows 11 build 2021-09-14 08:46:58 +02:00
Philipp Wolfer
192db0a729 PICARD-2233: Composer "credited as" must not overwrite composersort 
If "credited as" is set on a composer relationship, the credited name gets used both for composer and composersort. This is inconsistent with how target credits get used for artist / artistsort and causes a composersort tag without proper sort name.
 2021-09-12 19:40:49 +02:00
Philipp Wolfer
1f82fb46bb Update picard.pot 2021-09-12 16:23:46 +02:00
Philipp Wolfer
d38b4a3d86 Updated translations from Transifex 2021-09-12 16:23:14 +02:00
Philipp Wolfer
fe10c835f3 Merge pull request #1899 from rdswift/script_exception_dialog 
Translation exception script settings update
 2021-09-12 16:19:47 +02:00
Bob Swift
9b63b26644 Remove instructions from dialog. Leave tooltip. 2021-09-11 12:42:38 -06:00
Bob Swift
8296525f78 Add missing underscore to force translation of documentation 2021-09-11 11:14:13 -06:00
Bob Swift
ff2f76ffe6 Code style improvements: 
- Use `or` to assign default values in `config_upgrade.py`
- Get tuple values directly in `for` loops in various modules.
- Use temporary variable to reduce code redundency in `metadata.py`.
 2021-09-11 11:01:31 -06:00
Bob Swift
69d8dfdb88 Add translation exception test logging 2021-09-11 10:36:11 -06:00
Bob Swift
f55cf3167c Update script selector ui: 
- Set minimum size for the dialog.
- Add label and tooltips explaining the weighting threshold.
- Display available scripts list in alphabetical order.
- Add "..." to "Select" buttons on Metadata options page.
- Use `ScriptExceptionSelector.make_label` method in Metadata options.
 2021-09-11 09:38:54 -06:00
Bob Swift
6a69fb7291 Add script-specific weighting thresholds for translation exceptions: 
- Move exception script selection to new dialog.
- Add script-specific weighting thresholds.
 2021-09-10 14:07:10 -06:00
Philipp Wolfer
feebceb861 Merge pull request #1898 from rdswift/weighted_script_detector 
PICARD-412: Artist translation option enhancements
 2021-09-10 08:59:46 +02:00
Bob Swift
8a4082fee7 Revise artist name translation logic. Add tests. 2021-09-09 12:34:34 -06:00
Bob Swift
ee48da0b54 Add test for processing empty string (to confirm no divide-by-zero) 2021-09-09 12:28:34 -06:00
Bob Swift
1e20d8214d Fix translation of locales shown in the selector UI. 2021-09-09 09:51:04 -06:00
Bob Swift
cb84b17604 Add missing module. 2021-09-08 17:56:24 -06:00
Bob Swift
3e5b060a37 Add ability to use multiple translation locales: 
- Add new `artist_locales` setting and remove old `artist_locale`.
- Add new translation locales selector and ordering screen.
- Cycle through selected translation locales until a match is found.
- Update tests.
 2021-09-08 17:47:16 -06:00
Bob Swift
e8aa0b3cd6 Add weighted script detector and multiple translation ignore options 2021-09-08 11:58:24 -06:00
Laurent Monin
e9eec38146 Merge pull request #1897 from phw/PICARD-2274-fix-crashes 
PICARD-2274: Fix crashes when updating items without tree widget
 2021-09-07 10:25:09 +02:00
Philipp Wolfer
d942bb24b9 PICARD-2274: Fix crashes when updating items without tree widget 
In some situations items from the tree views get updated without being attached to the tree widget. Avoid exceptions in this situation.
 2021-09-07 08:12:47 +02:00
Philipp Wolfer
a78ecc142c Update picard.pot 2021-09-06 12:01:10 +02:00
Vladislav Karbovskii
7224961bc4 PICARD-157: Option to skip artist name translation for specific scripts 
Add a dropdown to select a script for which artist translation will be skipped.

Co-authored-by: Laurent Monin <github@norz.org>
Co-authored-by: Bob Swift <bswift@rsds.ca>
 2021-09-06 12:00:01 +02:00
Philipp Wolfer
44a4868353 acousticbrainz: always submit with currently matched recording ID 2021-09-06 08:08:13 +02:00
Philipp Wolfer
f48d4a2fdd acousticbrainz: Fix submission for files without saved recording ID 2021-09-06 08:08:13 +02:00
Philipp Wolfer
beaddc08c9 Option page names are lowercase 2021-09-06 08:08:13 +02:00
Philipp Wolfer
4d903f7a07 Update actions after AcousticBrainz feature changed 2021-09-06 08:08:13 +02:00
Philipp Wolfer
be868e5cb5 PICARD-2273: Always set acoustid_id, even if not linked to MB recordings 
If acoustid.org finds a matching AcoustID for a fingerprint, always set the acoustid_id tag.
 2021-09-05 17:50:07 +02:00
Philipp Wolfer
896b0c7cf7 Update picard.pot 2021-09-04 17:51:09 +02:00
Philipp Wolfer
81495419a7 Merge pull request #1894 from zas/abextract_fixes 
Simplify AcousticBrainz extractor settings
 2021-09-04 17:49:58 +02:00
Laurent Monin
59d76a332d ab_submit_features(): drop useless features_file parameter 
The file path is already stored as a file property
 2021-09-04 09:57:28 +02:00
Laurent Monin
ce3bc62ede ab_setup_extractor(): calculate sha1 only if we could get the version 2021-09-04 09:48:37 +02:00
Laurent Monin
fcd0ba1576 ab_setup_extractor(): reset _acousticbrainz_extractor* globals in any case 
If feature is disabled after it was enabled those weren't properly set to None
 2021-09-04 09:48:13 +02:00
Laurent Monin
d8266ef132 Prevent Picard crash if extractor was set, but is removed before extraction 
To reproduce:

- enable AcousticBrainz and set extractor path
- exit Options
- move the executable elsewhere
- start extraction on few files
 2021-09-04 09:21:27 +02:00
Laurent Monin
907ab18d90 Reduce indentation level and use QLineEdit.clear() instead of setText("") 2021-09-04 09:03:48 +02:00
Laurent Monin
6e6348f783 Remove unused properties 2021-09-04 09:03:08 +02:00