Commit Graph

  • 2835732962 match -> match_: match is a statement in Python 3.10+ Laurent Monin 2024-05-25 12:21:31 +02:00
  • 21e8d53d39 Use MainWindow.suspend_sorting context manager whenever possible Laurent Monin 2024-05-24 13:35:04 +02:00
  • 7ec728e9e1 MainPanel: log when sorting is enabled/disabled, and only do it when needed Laurent Monin 2024-05-24 13:34:26 +02:00
  • 8e2826e36a MainWindow: introduce suspend_sorting IgnoreUpdatesContext Laurent Monin 2024-05-24 13:33:40 +02:00
  • abfdbb3ac6 IgnoreUpdatesContext: add on_last_exit and matching tests Laurent Monin 2024-05-24 13:12:07 +02:00
  • 977c4e5602 IgnoreUpdatesContext: rename __exit__() parameters to match Python documentation Laurent Monin 2024-05-24 13:10:01 +02:00
  • ef14f46744 IgnoreUpdatesContext: add on_first_enter and matching tests Laurent Monin 2024-05-24 13:06:57 +02:00
  • 5e499e5dcd Test nested on_exit/on_enter Laurent Monin 2024-05-24 13:02:56 +02:00
  • c24c9133e9 IgnoreUpdatesContext: add on_enter and matching test Laurent Monin 2024-05-24 12:57:43 +02:00
  • b60d98febe IgnoreUpdatesContext: onexit -> on_exit Laurent Monin 2024-05-24 12:51:56 +02:00
  • b5aedad683 Merge pull request #2490 from zas/clustering Laurent Monin 2024-05-24 13:46:24 +02:00
  • cbf4adc2ba Fix and improve Clustering debug output Laurent Monin 2024-05-24 12:18:31 +02:00
  • 745767bcce cluster()/_do_clustering(): pass files as tuple instead of list Laurent Monin 2024-05-24 12:15:24 +02:00
  • d46d4bb08a remove_metadata_images() -> remove_metadata_images_from_children() Laurent Monin 2024-05-23 16:08:03 +02:00
  • 75bfb1c274 add_metadata_images() -> add_metadata_images_from_children() Laurent Monin 2024-05-23 16:05:55 +02:00
  • 8920c415ba Compare sets of keys, rather than dict_keys Laurent Monin 2024-05-23 16:02:54 +02:00
  • 8ca7f2cd21 Also test return values Laurent Monin 2024-05-23 15:58:37 +02:00
  • df00e4522d Make remove_metadata_images() returns a boolean indicating changes like similar methods Laurent Monin 2024-05-23 15:44:30 +02:00
  • 8e09dfce07 iter_children_items_metadata(): use an ignore set instead of matching class instance Laurent Monin 2024-05-23 15:24:15 +02:00
  • 5ad0640020 Make get_sources_metadata_images() a static method of MetadataItem Laurent Monin 2024-05-23 14:38:38 +02:00
  • 1fa21683d9 ImageList.insert(): no need to return anything Laurent Monin 2024-05-23 14:32:42 +02:00
  • 6d1c10b056 ImageList.__setitem__(): mark as dirty only if the value changed Laurent Monin 2024-05-23 14:20:41 +02:00
  • 86ba49aeb1 ImageList._changed -> _dirty Laurent Monin 2024-05-23 14:18:34 +02:00
  • d45dd9bf57 Drop now unused update_new_metadata/update_orig_metadata Laurent Monin 2024-05-23 13:40:23 +02:00
  • 84445b1399 Reduce code redundancy Laurent Monin 2024-05-23 13:25:16 +02:00
  • 6743b42c87 Use getattr() and rename variables to make duplicated code even more obvious Laurent Monin 2024-05-23 13:16:56 +02:00
  • 492bfea73a Introduce iter_children_items_metadata() and finally make the code deduplication possible Laurent Monin 2024-05-23 13:07:05 +02:00
  • df0f11cc9f Move ImageListState declaration where it is used (only one place) Laurent Monin 2024-05-23 12:34:19 +02:00
  • 99b8e60c2d Move variables declarations where they are used Laurent Monin 2024-05-23 12:30:03 +02:00
  • 7223de0db2 Make ImageListState more generic, and greatly simplify code Laurent Monin 2024-05-23 11:23:37 +02:00
  • 1b8294da9b ImageListState.process_images_*(): pass metadata instead of parent object Laurent Monin 2024-05-23 11:11:47 +02:00
  • bef084ffcc Split ImageListState.process_images() in two methods Laurent Monin 2024-05-23 11:08:49 +02:00
  • 3a46081366 Declare sources where it is used, and drop unused state where applicable Laurent Monin 2024-05-23 11:04:15 +02:00
  • f41e86ddfc state.sources was never used in ImageListState, drop it Laurent Monin 2024-05-23 10:59:41 +02:00
  • 543a4f4095 sources -> sources_metadata, as that's different from state.sources Laurent Monin 2024-05-23 10:57:37 +02:00
  • e5bae38e34 get_sources_metadata_images(): move at module level as it doesn't depend on ImageListState Laurent Monin 2024-05-23 10:46:59 +02:00
  • 2c6164440f Drop ImageListState.get_metadata_images(), call get_sources_metadata_images directly Laurent Monin 2024-05-23 10:05:00 +02:00
  • 77b3b51b9a ImageListState.get_metadata_images(): start to reduce code redundancy Laurent Monin 2024-05-23 09:58:52 +02:00
  • 8c22dd0733 Replace update_new/orig_metadata by a set Laurent Monin 2024-05-23 09:48:16 +02:00
  • 8a184d0ff0 metadataitem_update_metadata_images() -> update_metadata_images_from_children() Laurent Monin 2024-05-22 23:58:12 +02:00
  • 2ce5470390 Replace get_imagelist_state() by a generator and set ImageListState.sources using it Laurent Monin 2024-05-22 23:57:36 +02:00
  • ab463c6456 Define update_new/orig_metadata in MetadataItem and its subclasses Laurent Monin 2024-05-22 23:39:55 +02:00
  • 741be9595c Define new get_imagelist_state() in Album & FileListItem Laurent Monin 2024-05-22 22:35:13 +02:00
  • 84f4ca3f48 Move code from _update_imagelist_state() to metadataitem_update_metadata_images() Laurent Monin 2024-05-22 22:18:13 +02:00
  • 2aa4e12525 imagelist._remove_images() -> Metadate.remove_images() Laurent Monin 2024-05-22 22:02:58 +02:00
  • 8111f4fe75 imagelist._add_images() -> Metadata.add_images() Laurent Monin 2024-05-22 21:57:32 +02:00
  • 3ce951bd47 imagelist._process_images() -> ImageListState.process_images() Laurent Monin 2024-05-22 21:51:58 +02:00
  • 8ff5f7a92c imagelist._get_metadata_images() -> ImageListState.get_metadata_images() Laurent Monin 2024-05-22 21:46:41 +02:00
  • 24cacb9be4 imagelist._get_state() -> MetadataItem._get_imagelist_state() Laurent Monin 2024-05-22 21:41:19 +02:00
  • c6dde741a3 imagelist._update_state() -> MetadataItem._update_imagelist_state() Laurent Monin 2024-05-22 21:34:22 +02:00
  • 18e8a24810 Use proper keyword argument when calling Album.update(boolean) Laurent Monin 2024-05-22 20:10:10 +02:00
  • 1c75c82eea Move update_metadata_images() from imagelist to MetadataItem.metadataitem_update_metadata_images() Laurent Monin 2024-05-22 19:30:55 +02:00
  • df8fa5f330 Move add_metadata_images() to MetadataItem Laurent Monin 2024-05-22 19:14:41 +02:00
  • 6db8ae5382 Move remove_metadata_images() from imagelist to MetadataItem Laurent Monin 2024-05-22 19:06:20 +02:00
  • e246eaa6b9 Introduce MetadataItem as a subclass of Item Laurent Monin 2024-05-22 19:04:26 +02:00
  • ebf6bfeabd Move picard.ui.item to picard.item Laurent Monin 2024-05-22 18:29:39 +02:00
  • 17c7768a5e Add missing self.tagger initializations (#2489) Laurent Monin 2024-05-22 23:48:07 +02:00
  • c62c0cdb6f Merge pull request #2484 from zas/collection_menu_cleanup Philipp Wolfer 2024-05-22 18:24:06 +02:00
  • 633df8b53b Build with PyInstaller 6.7.0 Philipp Wolfer 2024-05-22 10:12:49 +02:00
  • 12d0641138 Merge pull request #2481 from zas/infodialog_cleanup2 Laurent Monin 2024-05-21 22:21:59 +02:00
  • 440a8cbe50 Merge pull request #2483 from zas/restore_color_default Laurent Monin 2024-05-21 22:16:54 +02:00
  • fc4bf63b50 Merge pull request #2482 from zas/configurable_colors Laurent Monin 2024-05-21 22:14:13 +02:00
  • 762e897512 Rename from generic Ui_Dialog to proper Ui_CDLookupDialog and Ui_OptionsDialog Laurent Monin 2024-05-21 16:26:37 +02:00
  • f1ba9c83b8 PICARD-2906: fix the behavior of the Pause button in internal player Laurent Monin 2024-05-21 18:23:33 +02:00
  • 632f0805d8 Properly ignore hovered signal when set to do so Laurent Monin 2024-05-21 15:12:50 +02:00
  • 5f6e64c990 CollectionCheckBox: updateText() -> _update_text() Laurent Monin 2024-05-21 15:02:55 +02:00
  • 4fb4a66d85 CollectionCheckBox: label() -> _label() Laurent Monin 2024-05-21 14:58:01 +02:00
  • 3b08914418 update_highlight() -> _on_hovered() Laurent Monin 2024-05-21 14:53:03 +02:00
  • befe6a808e refresh_list() -> _refresh_list() Laurent Monin 2024-05-21 14:51:57 +02:00
  • 8f8cfa7f91 Always pass *args, **kwargs to parent Qt objects Laurent Monin 2024-05-21 14:47:58 +02:00
  • 800a005ab4 CollectionMenu.update_collections() -> _update_collections() Laurent Monin 2024-05-21 14:39:49 +02:00
  • 10521be809 CollectionMenu.__init__(): also pass keyword arguments to parent class Laurent Monin 2024-05-21 14:37:25 +02:00
  • c5faa125a6 Use user_collections.values() as id_ isn't used, and drop numerical indexes Laurent Monin 2024-05-21 14:34:46 +02:00
  • baf73f0825 Interface colors: Let the user restore only one color to default Laurent Monin 2024-05-21 11:52:28 +02:00
  • 444d9067a2 Make color of first cover highlight configurable Laurent Monin 2024-05-21 11:16:40 +02:00
  • 41d2d013c8 Make row highlight configurable Laurent Monin 2024-05-21 11:07:42 +02:00
  • 819f89b1f4 Use hasattr() and shorten line Laurent Monin 2024-05-20 19:50:51 +02:00
  • 2fb190c08c Only setData() if there's an image to display Laurent Monin 2024-05-20 17:56:32 +02:00
  • e81a898cf0 Introduce ArtworkRow class Laurent Monin 2024-05-20 17:44:19 +02:00
  • e8fcfdac70 Make _build_artwork_rows() a generator Laurent Monin 2024-05-20 15:33:49 +02:00
  • bdbdc11985 Set artwork_rows after looking for matching new image Laurent Monin 2024-05-20 15:28:55 +02:00
  • 90bd1e39b8 Call _build_artwork_rows() from _display_artwork_rows() Laurent Monin 2024-05-20 15:28:07 +02:00
  • 40f3e14c4c _display_artwork_rows(): only iterate existing columns Laurent Monin 2024-05-20 15:19:50 +02:00
  • 7884daf810 _display_artwork_image_cell(): always create an item even if empty Laurent Monin 2024-05-20 15:05:40 +02:00
  • 398ffd0c29 Fix double-click on type cell, return if no data Laurent Monin 2024-05-20 15:04:07 +02:00
  • 7ccb3bb06a Rework artwork tooltips Laurent Monin 2024-05-20 14:25:43 +02:00
  • 3bdf5f30d2 Introduce _artwork_infos(): properly escape lines Laurent Monin 2024-05-20 14:23:30 +02:00
  • 6c9898686c Change the artwork tab content building logic totally Laurent Monin 2024-05-20 13:07:12 +02:00
  • b90d948561 Use normalized_types() as key instead of types_as_string() Laurent Monin 2024-05-20 00:10:26 +02:00
  • ad2753cacc Make CoverArtImage sortable + matching tests Laurent Monin 2024-05-20 00:06:14 +02:00
  • 6bddf8e1b4 normalized_types(): return a tuple (hashable) Laurent Monin 2024-05-20 00:05:03 +02:00
  • fd1ec5cb39 Make DataHash sortable (based on _hash, arbitrary order) Laurent Monin 2024-05-20 00:03:14 +02:00
  • d80e23d5e6 Introduce coverart.utils.translated_types_as_string() Laurent Monin 2024-05-20 00:02:37 +02:00
  • 75110e3203 If there's no image to display just hide the tab and return Laurent Monin 2024-05-19 19:18:53 +02:00
  • 54d2d60dd9 Simplify images/existing_images/artworktable_class related code Laurent Monin 2024-05-19 19:18:24 +02:00
  • 3887c8655a Reduce the size of the arrow in cover art display Laurent Monin 2024-05-19 17:37:53 +02:00
  • 6a2ad04846 Declare common pixmaps once Laurent Monin 2024-05-19 17:36:45 +02:00
  • fb4d82e2b0 _display_artwork(): make rows/image types matching more efficient and easier to understand Laurent Monin 2024-05-19 12:32:43 +02:00
  • 3737723180 Translated using Weblate (Russian) wileyfoxyx 2024-05-19 17:42:35 +00:00
  • 205037081e Translated using Weblate (Russian) wileyfoxyx 2024-05-19 17:42:30 +00:00