Workaround to fix #235 (add placeholder inside node_modules)

This commit is contained in:
SteveSandersonMS
2016-09-08 14:32:25 +01:00
parent 1f2168949d
commit 5fcce843ba
11 changed files with 63 additions and 6 deletions

9
.gitignore vendored
View File

@@ -34,6 +34,13 @@ npm-debug.log
# files with that name (https://github.com/npm/npm/issues/1862). So, each template instead has a template_gitignore
# file which gets renamed after the files are copied. And so any files that need to be excluded in the source
# repo have to be excluded here.
/templates/*/node_modules/
# Note that we need to exclude node_modules/** (i.e., subdirs, not the whole of node_modules) because we do need to
# include the _placeholder.txt files, and can't do that using gitignore exclusion because developers aren't promoted to
# commit files included that way. This is all a workaround for Workaround for https://github.com/aspnet/JavaScriptServices/issues/235
/templates/*/node_modules/**
/templates/*/wwwroot/dist/
.vscode/
# Workaround for https://github.com/aspnet/JavaScriptServices/issues/235
!/templates/*/node_modules/_placeholder.txt

7
templates/Angular2Spa/node_modules/_placeholder.txt generated vendored Normal file
View File

@@ -0,0 +1,7 @@
This file exists as a workaround for https://github.com/dotnet/cli/issues/1396
('dotnet publish' does not publish any directories that didn't exist or were
empty before the publish script started, which means it's not enough just to
run 'npm install' during publishing: you need to ensure node_modules already
existed at least).
Hopefully, this can be removed after the move to the new MSBuild.

View File

@@ -184,9 +184,12 @@ ClientBin/
*.dbproj.schemaview
*.pfx
*.publishsettings
node_modules/
orleans.codegen.cs
# Workaround for https://github.com/aspnet/JavaScriptServices/issues/235
/node_modules/**
!/node_modules/_placeholder.txt
# RIA/Silverlight projects
Generated_Code/

7
templates/KnockoutSpa/node_modules/_placeholder.txt generated vendored Normal file
View File

@@ -0,0 +1,7 @@
This file exists as a workaround for https://github.com/dotnet/cli/issues/1396
('dotnet publish' does not publish any directories that didn't exist or were
empty before the publish script started, which means it's not enough just to
run 'npm install' during publishing: you need to ensure node_modules already
existed at least).
Hopefully, this can be removed after the move to the new MSBuild.

View File

@@ -184,9 +184,12 @@ ClientBin/
*.dbproj.schemaview
*.pfx
*.publishsettings
node_modules/
orleans.codegen.cs
# Workaround for https://github.com/aspnet/JavaScriptServices/issues/235
/node_modules/**
!/node_modules/_placeholder.txt
# RIA/Silverlight projects
Generated_Code/

View File

@@ -0,0 +1,7 @@
This file exists as a workaround for https://github.com/dotnet/cli/issues/1396
('dotnet publish' does not publish any directories that didn't exist or were
empty before the publish script started, which means it's not enough just to
run 'npm install' during publishing: you need to ensure node_modules already
existed at least).
Hopefully, this can be removed after the move to the new MSBuild.

View File

@@ -184,9 +184,12 @@ ClientBin/
*.dbproj.schemaview
*.pfx
*.publishsettings
node_modules/
orleans.codegen.cs
# Workaround for https://github.com/aspnet/JavaScriptServices/issues/235
/node_modules/**
!/node_modules/_placeholder.txt
# RIA/Silverlight projects
Generated_Code/

7
templates/ReactSpa/node_modules/_placeholder.txt generated vendored Normal file
View File

@@ -0,0 +1,7 @@
This file exists as a workaround for https://github.com/dotnet/cli/issues/1396
('dotnet publish' does not publish any directories that didn't exist or were
empty before the publish script started, which means it's not enough just to
run 'npm install' during publishing: you need to ensure node_modules already
existed at least).
Hopefully, this can be removed after the move to the new MSBuild.

View File

@@ -184,9 +184,12 @@ ClientBin/
*.dbproj.schemaview
*.pfx
*.publishsettings
node_modules/
orleans.codegen.cs
# Workaround for https://github.com/aspnet/JavaScriptServices/issues/235
/node_modules/**
!/node_modules/_placeholder.txt
# RIA/Silverlight projects
Generated_Code/

View File

@@ -0,0 +1,7 @@
This file exists as a workaround for https://github.com/dotnet/cli/issues/1396
('dotnet publish' does not publish any directories that didn't exist or were
empty before the publish script started, which means it's not enough just to
run 'npm install' during publishing: you need to ensure node_modules already
existed at least).
Hopefully, this can be removed after the move to the new MSBuild.

View File

@@ -184,9 +184,12 @@ ClientBin/
*.dbproj.schemaview
*.pfx
*.publishsettings
node_modules/
orleans.codegen.cs
# Workaround for https://github.com/aspnet/JavaScriptServices/issues/235
/node_modules/**
!/node_modules/_placeholder.txt
# RIA/Silverlight projects
Generated_Code/